102315 2012-11-14 18:33:04 -0800 Allow WebCoreFullScreenWarningView to animate visibility. 2016-03-09 09:27:12 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 102300 98863 102317 1 jer.noble jer.noble benjamin oldest_to_newest 767572 0 jer.noble 2012-11-14 18:33:04 -0800 Allow WebCoreFullScreenWarningView to animate visibility. 767600 1 174317 jer.noble 2012-11-14 19:01:12 -0800 Created attachment 174317 Patch 803096 2 174317 benjamin 2013-01-08 23:57:34 -0800 Comment on attachment 174317 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174317&action=review > Source/WebCore/platform/mac/WebCoreFullScreenWarningView.h:41 > +- (void)show; > +- (void)showWithFade; > +- (void)showThenHideWithFade; > +- (void)hideWithFade; > +- (void)hide; Somethings that annoys me a bit with this is the disconnect between those and the hidden properties of NSView. It would be nice to set the completionHandler of [hideXXX] to hide the view for real, and to unhide it as the first operation of [showXXX]. You are not using all those methods in https://bugs.webkit.org/attachment.cgi?id=174319&action=review Do you need all of them? 806481 3 jer.noble 2013-01-14 11:13:25 -0800 (In reply to comment #2) > (From update of attachment 174317 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=174317&action=review > > > Source/WebCore/platform/mac/WebCoreFullScreenWarningView.h:41 > > +- (void)show; > > +- (void)showWithFade; > > +- (void)showThenHideWithFade; > > +- (void)hideWithFade; > > +- (void)hide; > > Somethings that annoys me a bit with this is the disconnect between those and the hidden properties of NSView. How about renaming these to "fadeOut" and "fadeIn"? I can then override setHidden: to cancel any existing animations. > It would be nice to set the completionHandler of [hideXXX] to hide the view for real, and to unhide it as the first operation of [showXXX]. Sure. > You are not using all those methods in https://bugs.webkit.org/attachment.cgi?id=174319&action=review > Do you need all of them? The only one not currently used is -(void)show, and with the rename above, it'll go away. 806555 4 174317 benjamin 2013-01-14 13:27:00 -0800 Comment on attachment 174317 Patch Sounds good! I r- this one in the meantime. 807455 5 182807 jer.noble 2013-01-15 10:50:34 -0800 Created attachment 182807 Patch Addressed benjamin's comments. Will update dependant patches with the new method names. 807776 6 182861 jer.noble 2013-01-15 15:51:40 -0800 Created attachment 182861 Patch Replaced the completion handler (unsupported in < 10.8) with a simple performSelectorAfterDelay:) 976931 7 182861 kling 2014-02-05 11:09:02 -0800 Comment on attachment 182861 Patch Clearing review flag on patches from before 2014. If this patch is still relevant, please reset the r? flag. 976955 8 182861 jer.noble 2014-02-05 11:13:03 -0800 Comment on attachment 182861 Patch Yep, still relevant. 174317 2012-11-14 19:01:12 -0800 2013-01-15 10:50:32 -0800 Patch bug-102315-20121114185910.patch text/plain 3980 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0NjU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDUwOWNiZDQ5ODg1MjVk OTMxOWFlMzAxZGJlYjk3OGNiMzExZTU4Yy4uZGEzYjRkODg5M2Q0NmViYjRmYTVmOGUwMmVkNWM3 YzkyMWUyMmFkMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI0IEBACiAyMDEyLTExLTE0ICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCisgICAgICAgIEFsbG93IFdlYkNvcmVGdWxs U2NyZWVuV2FybmluZ1ZpZXcgdG8gYW5pbWF0ZSB2aXNpYmlsaXR5LgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAyMzE1CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2xpZW50cyBvZiBXZWJDb3JlRnVsbFNj cmVlbldhcm5pbmdWaWV3IG5lZWQgdG8gYW5pbWF0ZSB0aGUKKyAgICAgICAgdmlldyBpbnRvIGV4 aXN0ZW5jZSBhbmQgZmFkZSB0aGUgdmlldyBhZnRlciBhIHBlcmlvZCBvZiB0aW1lLgorCisgICAg ICAgICogcGxhdGZvcm0vbWFjL1dlYkNvcmVGdWxsU2NyZWVuV2FybmluZ1ZpZXcuaDoKKyAgICAg ICAgKiBwbGF0Zm9ybS9tYWMvV2ViQ29yZUZ1bGxTY3JlZW5XYXJuaW5nVmlldy5tbToKKyAgICAg ICAgKC1bV2ViQ29yZUZ1bGxTY3JlZW5XYXJuaW5nVmlldyBkZWFsbG9jXSk6IENhbmNlbCBwcmV2 aW91cyBwZXJmb3JtIHJlcXVlc3RzLgorICAgICAgICAoLVtXZWJDb3JlRnVsbFNjcmVlbldhcm5p bmdWaWV3IHNob3ddKTogU2hvdyB3aXRob3V0IGFuaW1hdGlvbi4KKyAgICAgICAgKC1bV2ViQ29y ZUZ1bGxTY3JlZW5XYXJuaW5nVmlldyBzaG93V2l0aEZhZGVdKTogU2hvdyB3aXRoIGFuaW1hdGlv bi4KKyAgICAgICAgKC1bV2ViQ29yZUZ1bGxTY3JlZW5XYXJuaW5nVmlldyBzaG93VGhlbkhpZGVX aXRoRmFkZV0pOiBTaG93IHRoZW4gaGlkZSB3aXRoIGFuaW1hdGlvbi4KKyAgICAgICAgKC1bV2Vi Q29yZUZ1bGxTY3JlZW5XYXJuaW5nVmlldyBoaWRlXSk6IEhpZGUgd2l0aG91dCBhbmltYXRpb24u CisgICAgICAgICgtW1dlYkNvcmVGdWxsU2NyZWVuV2FybmluZ1ZpZXcgaGlkZVdpdGhGYWRlXSk6 IEhpZGUgd2l0aCBhbmltYXRpb24uCisKKzIwMTItMTEtMTQgIEplciBOb2JsZSAgPGplci5ub2Js ZUBhcHBsZS5jb20+CisKICAgICAgICAgQWRkIGEgbmV3IHNoYXJlZCBjbGFzcyBXZWJDb3JlRnVs bFNjcmVlblBsYWNlaG9sZGVyVmlldywgZm9yIHVzZSBpbiBXZWJLaXQgYW5kIFdlYktpdDIuCiAg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDIzMDAKIApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1dlYkNvcmVGdWxsU2NyZWVu V2FybmluZ1ZpZXcuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9XZWJDb3JlRnVsbFNj cmVlbldhcm5pbmdWaWV3LmgKaW5kZXggZjZlYTlhZDc4NGVhZTJkZTA5NWQxZTMwZWRkN2MwYzU0 ZmE2Y2NjZC4uODlmNThhNzQ0ODllZDhjY2ZiNDJjY2ZlZDQ1YzNmMmJjYTliODcxZSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1dlYkNvcmVGdWxsU2NyZWVuV2Fybmlu Z1ZpZXcuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvV2ViQ29yZUZ1bGxTY3Jl ZW5XYXJuaW5nVmlldy5oCkBAIC0zNCw2ICszNCwxMSBAQAogICAgIFJldGFpblB0cjxOU1RleHRG aWVsZD4gX3RleHRGaWVsZDsKIH0KIC0gKGlkKWluaXRXaXRoVGl0bGU6KE5TU3RyaW5nKil0aXRs ZTsKKy0gKHZvaWQpc2hvdzsKKy0gKHZvaWQpc2hvd1dpdGhGYWRlOworLSAodm9pZClzaG93VGhl bkhpZGVXaXRoRmFkZTsKKy0gKHZvaWQpaGlkZVdpdGhGYWRlOworLSAodm9pZCloaWRlOwogQGVu ZAogCiAjZW5kaWYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9XZWJD b3JlRnVsbFNjcmVlbldhcm5pbmdWaWV3Lm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFj L1dlYkNvcmVGdWxsU2NyZWVuV2FybmluZ1ZpZXcubW0KaW5kZXggY2VkOThjMTg5MWU2NDVjMDVm YjQxZjUyMWNlOGE2OTZjYWQ2ZGNkMy4uYTgxYTgzMjJlNTFiYTJmNmZjYzQzOGU1ZWZlODhjY2U5 M2M1NzI1ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1dlYkNvcmVG dWxsU2NyZWVuV2FybmluZ1ZpZXcubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFj L1dlYkNvcmVGdWxsU2NyZWVuV2FybmluZ1ZpZXcubW0KQEAgLTEwNCw0ICsxMDQsNTQgQEAgc3Rh dGljIGNvbnN0IE5TVGltZUludGVydmFsIFdhcm5pbmdWaWV3RmFkZUR1cmF0aW9uID0gMC41Owog CiAgICAgcmV0dXJuIHNlbGY7CiB9CisKKy0gKHZvaWQpZGVhbGxvYworeworICAgIFtOU09iamVj dCBjYW5jZWxQcmV2aW91c1BlcmZvcm1SZXF1ZXN0c1dpdGhUYXJnZXQ6c2VsZiBzZWxlY3RvcjpA c2VsZWN0b3IoaGlkZVdpdGhGYWRlKSBvYmplY3Q6bmlsXTsKKyAgICBbc3VwZXIgZGVhbGxvY107 Cit9CisKKy0gKHZvaWQpc2hvdworeworICAgIFtOU0FuaW1hdGlvbkNvbnRleHQgYmVnaW5Hcm91 cGluZ107CisgICAgW1tOU0FuaW1hdGlvbkNvbnRleHQgY3VycmVudENvbnRleHRdIHNldER1cmF0 aW9uOjBdOworICAgIFtbc2VsZiBhbmltYXRvcl0gc2V0QWxwaGFWYWx1ZToxXTsKKyAgICBbTlNB bmltYXRpb25Db250ZXh0IGVuZEdyb3VwaW5nXTsKK30KKworLSAodm9pZClzaG93V2l0aEZhZGUK K3sKKyAgICBbTlNBbmltYXRpb25Db250ZXh0IGJlZ2luR3JvdXBpbmddOworICAgIFtbTlNBbmlt YXRpb25Db250ZXh0IGN1cnJlbnRDb250ZXh0XSBzZXREdXJhdGlvbjpXYXJuaW5nVmlld0ZhZGVE dXJhdGlvbl07CisgICAgW1tzZWxmIGFuaW1hdG9yXSBzZXRBbHBoYVZhbHVlOjFdOworICAgIFtO U0FuaW1hdGlvbkNvbnRleHQgZW5kR3JvdXBpbmddOworfQorCistICh2b2lkKXNob3dUaGVuSGlk ZVdpdGhGYWRlCit7CisgICAgW05TT2JqZWN0IGNhbmNlbFByZXZpb3VzUGVyZm9ybVJlcXVlc3Rz V2l0aFRhcmdldDpzZWxmIHNlbGVjdG9yOkBzZWxlY3RvcihoaWRlV2l0aEZhZGUpIG9iamVjdDpu aWxdOworICAgIFtzZWxmIHBlcmZvcm1TZWxlY3RvcjpAc2VsZWN0b3IoaGlkZVdpdGhGYWRlKSB3 aXRoT2JqZWN0Om5pbCBhZnRlckRlbGF5Oldhcm5pbmdWaWV3SGlkZURlbGF5XTsKKyAgICBbc2Vs ZiBzaG93V2l0aEZhZGVdOworfQorCistICh2b2lkKWhpZGVXaXRoRmFkZQoreworICAgIFtOU09i amVjdCBjYW5jZWxQcmV2aW91c1BlcmZvcm1SZXF1ZXN0c1dpdGhUYXJnZXQ6c2VsZiBzZWxlY3Rv cjpAc2VsZWN0b3IoaGlkZVdpdGhGYWRlKSBvYmplY3Q6bmlsXTsKKworICAgIFtOU0FuaW1hdGlv bkNvbnRleHQgYmVnaW5Hcm91cGluZ107CisgICAgW1tOU0FuaW1hdGlvbkNvbnRleHQgY3VycmVu dENvbnRleHRdIHNldER1cmF0aW9uOldhcm5pbmdWaWV3RmFkZUR1cmF0aW9uXTsKKyAgICBbW3Nl bGYgYW5pbWF0b3JdIHNldEFscGhhVmFsdWU6MF07CisgICAgW05TQW5pbWF0aW9uQ29udGV4dCBl bmRHcm91cGluZ107Cit9CisKKy0gKHZvaWQpaGlkZQoreworICAgIFtOU09iamVjdCBjYW5jZWxQ cmV2aW91c1BlcmZvcm1SZXF1ZXN0c1dpdGhUYXJnZXQ6c2VsZiBzZWxlY3RvcjpAc2VsZWN0b3Io aGlkZVdpdGhGYWRlKSBvYmplY3Q6bmlsXTsKKworICAgIFtOU0FuaW1hdGlvbkNvbnRleHQgYmVn aW5Hcm91cGluZ107CisgICAgW1tOU0FuaW1hdGlvbkNvbnRleHQgY3VycmVudENvbnRleHRdIHNl dER1cmF0aW9uOjBdOworICAgIFtbc2VsZiBhbmltYXRvcl0gc2V0QWxwaGFWYWx1ZTowXTsKKyAg ICBbTlNBbmltYXRpb25Db250ZXh0IGVuZEdyb3VwaW5nXTsKK30KKwogQGVuZAo= 182807 2013-01-15 10:50:34 -0800 2013-01-15 15:51:38 -0800 Patch bug-102315-20130115104736.patch text/plain 3862 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5NjM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmI2MjA1OTI1ZWE4ZmFi ZDg4MjEwMWQyMTNkN2Q2ZDlhMjRjNjkyNy4uODE3OWI5MWY3NTUyMmVlYzQ3Y2VhMWIxNmQzNjM5 MTZmNWU3NjRmMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTExLTE0ICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIEFsbG93IFdlYkNvcmVGdWxs U2NyZWVuV2FybmluZ1ZpZXcgdG8gYW5pbWF0ZSB2aXNpYmlsaXR5LgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAyMzE1CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2xpZW50cyBvZiBXZWJDb3JlRnVsbFNj cmVlbldhcm5pbmdWaWV3IG5lZWQgdG8gYW5pbWF0ZSB0aGUKKyAgICAgICAgdmlldyBpbnRvIGV4 aXN0ZW5jZSBhbmQgZmFkZSB0aGUgdmlldyBhZnRlciBhIHBlcmlvZCBvZiB0aW1lLgorCisgICAg ICAgICogcGxhdGZvcm0vbWFjL1dlYkNvcmVGdWxsU2NyZWVuV2FybmluZ1ZpZXcuaDoKKyAgICAg ICAgKiBwbGF0Zm9ybS9tYWMvV2ViQ29yZUZ1bGxTY3JlZW5XYXJuaW5nVmlldy5tbToKKyAgICAg ICAgKC1bV2ViQ29yZUZ1bGxTY3JlZW5XYXJuaW5nVmlldyBkZWFsbG9jXSk6IENhbmNlbCBwcmV2 aW91cyBwZXJmb3JtIHJlcXVlc3RzLgorICAgICAgICAoLVtXZWJDb3JlRnVsbFNjcmVlbldhcm5p bmdWaWV3IHNldEhpZGRlbjpdKTogRGl0dG8uIENoYW5nZSBvcGFjaXR5IHdpdGhvdXQgYW5pbWF0 aW9uLgorICAgICAgICAoLVtXZWJDb3JlRnVsbFNjcmVlbldhcm5pbmdWaWV3IGZhZGVJbl0pOiBV bmhpZGUgdGhlbiBtYWtlIG9wYXF1ZSB3aXRoIGFuaW1hdGlvbi4KKyAgICAgICAgKC1bV2ViQ29y ZUZ1bGxTY3JlZW5XYXJuaW5nVmlldyBmYWRlSW5UaGVuT3V0XSk6IFVuaGlkZSB0aGVuIGZhZGUg aW4gdGhlbiBmYWRlIG91dC4KKyAgICAgICAgKC1bV2ViQ29yZUZ1bGxTY3JlZW5XYXJuaW5nVmll dyBmYWRlT3V0XSk6IE1ha2UgdHJhbnNwYXJlbnQgd2l0aCBhbmltYXRpb24gdGhlbiBoaWRlIGF0 IGNvbXBsZXRpb24uCisKIDIwMTMtMDEtMTQgIFl1cnkgU2VtaWtoYXRza3kgIDx5dXJ5c0BjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgW1JFR1JFU1NJT05dIERldiBUb29scyBwb3B1cCBmb3IgV29y a2VycyBmb3JnZXRzIHNpemVzL3Nob3dzIHRpbnkgaW4gdG9wIGxlZnQKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9XZWJDb3JlRnVsbFNjcmVlbldhcm5pbmdWaWV3Lmgg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvV2ViQ29yZUZ1bGxTY3JlZW5XYXJuaW5nVmll dy5oCmluZGV4IGY2ZWE5YWQ3ODRlYWUyZGUwOTVkMWUzMGVkZDdjMGM1NGZhNmNjY2QuLjM4ODBm NDdhM2RjNzU1ZGI5ZmM0NTJhMWNjYzhjYjIxOTRmNzA0M2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL21hYy9XZWJDb3JlRnVsbFNjcmVlbldhcm5pbmdWaWV3LmgKKysrIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1dlYkNvcmVGdWxsU2NyZWVuV2FybmluZ1ZpZXcu aApAQCAtMzIsOCArMzIsMTIgQEAKIAogQGludGVyZmFjZSAgV2ViQ29yZUZ1bGxTY3JlZW5XYXJu aW5nVmlldyA6IE5TQm94IHsKICAgICBSZXRhaW5QdHI8TlNUZXh0RmllbGQ+IF90ZXh0RmllbGQ7 CisgICAgQk9PTCBfc2hvdWxkSGlkZTsKIH0KIC0gKGlkKWluaXRXaXRoVGl0bGU6KE5TU3RyaW5n Kil0aXRsZTsKKy0gKHZvaWQpZmFkZUluOworLSAodm9pZClmYWRlSW5UaGVuT3V0OworLSAodm9p ZClmYWRlT3V0OwogQGVuZAogCiAjZW5kaWYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL21hYy9XZWJDb3JlRnVsbFNjcmVlbldhcm5pbmdWaWV3Lm1tIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vbWFjL1dlYkNvcmVGdWxsU2NyZWVuV2FybmluZ1ZpZXcubW0KaW5kZXggMWJh Mzg4MjM3YzQ5YmQ2NWJlNjgyYjI5YmM3MTY2ODQ4MDY0MGIzNC4uMjMyZDk2ODQzNjBiMzc0YjJl M2ZlNDkxMTc0MzFkMWY0YWE3Yjg5OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vbWFjL1dlYkNvcmVGdWxsU2NyZWVuV2FybmluZ1ZpZXcubW0KKysrIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vbWFjL1dlYkNvcmVGdWxsU2NyZWVuV2FybmluZ1ZpZXcubW0KQEAgLTEwNSw0 ICsxMDUsNTQgQEAgc3RhdGljIGNvbnN0IE5TVGltZUludGVydmFsIFdhcm5pbmdWaWV3RmFkZUR1 cmF0aW9uID0gMC41OwogCiAgICAgcmV0dXJuIHNlbGY7CiB9CisKKy0gKHZvaWQpZGVhbGxvYwor eworICAgIFtOU09iamVjdCBjYW5jZWxQcmV2aW91c1BlcmZvcm1SZXF1ZXN0c1dpdGhUYXJnZXQ6 c2VsZiBzZWxlY3RvcjpAc2VsZWN0b3IoZmFkZU91dCkgb2JqZWN0Om5pbF07CisgICAgW3N1cGVy IGRlYWxsb2NdOworfQorCistICh2b2lkKXNldEhpZGRlbjooQk9PTClmbGFnCit7CisgICAgW05T T2JqZWN0IGNhbmNlbFByZXZpb3VzUGVyZm9ybVJlcXVlc3RzV2l0aFRhcmdldDpzZWxmIHNlbGVj dG9yOkBzZWxlY3RvcihmYWRlT3V0KSBvYmplY3Q6bmlsXTsKKyAgICBbc3VwZXIgc2V0SGlkZGVu OmZsYWddOworCisgICAgW05TQW5pbWF0aW9uQ29udGV4dCBiZWdpbkdyb3VwaW5nXTsKKyAgICBb W05TQW5pbWF0aW9uQ29udGV4dCBjdXJyZW50Q29udGV4dF0gc2V0RHVyYXRpb246MF07CisgICAg W1tzZWxmIGFuaW1hdG9yXSBzZXRBbHBoYVZhbHVlOmZsYWcgPyAwIDogMV07CisgICAgW05TQW5p bWF0aW9uQ29udGV4dCBlbmRHcm91cGluZ107Cit9CisKKy0gKHZvaWQpZmFkZUluCit7CisgICAg X3Nob3VsZEhpZGUgPSBmYWxzZTsKKyAgICBbc3VwZXIgc2V0SGlkZGVuOk5PXTsKKworICAgIFtO U0FuaW1hdGlvbkNvbnRleHQgYmVnaW5Hcm91cGluZ107CisgICAgW1tOU0FuaW1hdGlvbkNvbnRl eHQgY3VycmVudENvbnRleHRdIHNldER1cmF0aW9uOldhcm5pbmdWaWV3RmFkZUR1cmF0aW9uXTsK KyAgICBbW3NlbGYgYW5pbWF0b3JdIHNldEFscGhhVmFsdWU6MV07CisgICAgW05TQW5pbWF0aW9u Q29udGV4dCBlbmRHcm91cGluZ107Cit9CisKKy0gKHZvaWQpZmFkZUluVGhlbk91dAoreworICAg IFtzZWxmIGZhZGVJbl07CisgICAgW3NlbGYgcGVyZm9ybVNlbGVjdG9yOkBzZWxlY3RvcihmYWRl T3V0KSB3aXRoT2JqZWN0Om5pbCBhZnRlckRlbGF5Oldhcm5pbmdWaWV3SGlkZURlbGF5XTsKK30K KworLSAodm9pZClmYWRlT3V0Cit7CisgICAgX3Nob3VsZEhpZGUgPSB0cnVlOworICAgIFtOU09i amVjdCBjYW5jZWxQcmV2aW91c1BlcmZvcm1SZXF1ZXN0c1dpdGhUYXJnZXQ6c2VsZiBzZWxlY3Rv cjpAc2VsZWN0b3IoZmFkZU91dCkgb2JqZWN0Om5pbF07CisKKyAgICBbTlNBbmltYXRpb25Db250 ZXh0IGJlZ2luR3JvdXBpbmddOworICAgIFtbTlNBbmltYXRpb25Db250ZXh0IGN1cnJlbnRDb250 ZXh0XSBzZXREdXJhdGlvbjpXYXJuaW5nVmlld0ZhZGVEdXJhdGlvbl07CisgICAgW1tOU0FuaW1h dGlvbkNvbnRleHQgY3VycmVudENvbnRleHRdIHNldENvbXBsZXRpb25IYW5kbGVyOl57CisgICAg ICAgIGlmIChfc2hvdWxkSGlkZSkKKyAgICAgICAgICAgIFtzdXBlciBzZXRIaWRkZW46dHJ1ZV07 CisgICAgfV07CisgICAgW1tzZWxmIGFuaW1hdG9yXSBzZXRBbHBoYVZhbHVlOjBdOworICAgIFtO U0FuaW1hdGlvbkNvbnRleHQgZW5kR3JvdXBpbmddOworfQorCiBAZW5kCg== 182861 2013-01-15 15:51:40 -0800 2016-03-09 09:27:12 -0800 Patch bug-102315-20130115154843.patch text/plain 3739 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5NjM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmI2MjA1OTI1ZWE4ZmFi ZDg4MjEwMWQyMTNkN2Q2ZDlhMjRjNjkyNy4uNjMxMmVjNTUwODM1YWU2YWFkNTk2NGY4MjRlMzg5 NWViZThmMzNjZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTExLTE0ICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIEFsbG93IFdlYkNvcmVGdWxs U2NyZWVuV2FybmluZ1ZpZXcgdG8gYW5pbWF0ZSB2aXNpYmlsaXR5LgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAyMzE1CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2xpZW50cyBvZiBXZWJDb3JlRnVsbFNj cmVlbldhcm5pbmdWaWV3IG5lZWQgdG8gYW5pbWF0ZSB0aGUKKyAgICAgICAgdmlldyBpbnRvIGV4 aXN0ZW5jZSBhbmQgZmFkZSB0aGUgdmlldyBhZnRlciBhIHBlcmlvZCBvZiB0aW1lLgorCisgICAg ICAgICogcGxhdGZvcm0vbWFjL1dlYkNvcmVGdWxsU2NyZWVuV2FybmluZ1ZpZXcuaDoKKyAgICAg ICAgKiBwbGF0Zm9ybS9tYWMvV2ViQ29yZUZ1bGxTY3JlZW5XYXJuaW5nVmlldy5tbToKKyAgICAg ICAgKC1bV2ViQ29yZUZ1bGxTY3JlZW5XYXJuaW5nVmlldyBkZWFsbG9jXSk6IENhbmNlbCBwcmV2 aW91cyBwZXJmb3JtIHJlcXVlc3RzLgorICAgICAgICAoLVtXZWJDb3JlRnVsbFNjcmVlbldhcm5p bmdWaWV3IHNldEhpZGRlbjpdKTogRGl0dG8uIENoYW5nZSBvcGFjaXR5IHdpdGhvdXQgYW5pbWF0 aW9uLgorICAgICAgICAoLVtXZWJDb3JlRnVsbFNjcmVlbldhcm5pbmdWaWV3IGZhZGVJbl0pOiBV bmhpZGUgdGhlbiBtYWtlIG9wYXF1ZSB3aXRoIGFuaW1hdGlvbi4KKyAgICAgICAgKC1bV2ViQ29y ZUZ1bGxTY3JlZW5XYXJuaW5nVmlldyBmYWRlSW5UaGVuT3V0XSk6IFVuaGlkZSB0aGVuIGZhZGUg aW4gdGhlbiBmYWRlIG91dC4KKyAgICAgICAgKC1bV2ViQ29yZUZ1bGxTY3JlZW5XYXJuaW5nVmll dyBmYWRlT3V0XSk6IE1ha2UgdHJhbnNwYXJlbnQgd2l0aCBhbmltYXRpb24gdGhlbiBoaWRlIGFm dGVyIGFuaW1hdGlvbiBkZWxheS4KKyAgICAgICAgKC1bV2ViQ29yZUZ1bGxTY3JlZW5XYXJuaW5n VmlldyBfaGlkZUFmdGVyRmFkZU91dF0pOiBUYXJnZXQgb2YgYWJvdmUuCisKIDIwMTMtMDEtMTQg IFl1cnkgU2VtaWtoYXRza3kgIDx5dXJ5c0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW1JFR1JF U1NJT05dIERldiBUb29scyBwb3B1cCBmb3IgV29ya2VycyBmb3JnZXRzIHNpemVzL3Nob3dzIHRp bnkgaW4gdG9wIGxlZnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9X ZWJDb3JlRnVsbFNjcmVlbldhcm5pbmdWaWV3LmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9t YWMvV2ViQ29yZUZ1bGxTY3JlZW5XYXJuaW5nVmlldy5oCmluZGV4IGY2ZWE5YWQ3ODRlYWUyZGUw OTVkMWUzMGVkZDdjMGM1NGZhNmNjY2QuLmQyNTYzNGQ2NjA4YmRhZWI2NWFiZjYyZGZlZTUzZjBj NDZiYzI2MGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9XZWJDb3Jl RnVsbFNjcmVlbldhcm5pbmdWaWV3LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFj L1dlYkNvcmVGdWxsU2NyZWVuV2FybmluZ1ZpZXcuaApAQCAtMzQsNiArMzQsOSBAQAogICAgIFJl dGFpblB0cjxOU1RleHRGaWVsZD4gX3RleHRGaWVsZDsKIH0KIC0gKGlkKWluaXRXaXRoVGl0bGU6 KE5TU3RyaW5nKil0aXRsZTsKKy0gKHZvaWQpZmFkZUluOworLSAodm9pZClmYWRlSW5UaGVuT3V0 OworLSAodm9pZClmYWRlT3V0OwogQGVuZAogCiAjZW5kaWYKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL21hYy9XZWJDb3JlRnVsbFNjcmVlbldhcm5pbmdWaWV3Lm1tIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1dlYkNvcmVGdWxsU2NyZWVuV2FybmluZ1ZpZXcubW0K aW5kZXggMWJhMzg4MjM3YzQ5YmQ2NWJlNjgyYjI5YmM3MTY2ODQ4MDY0MGIzNC4uNjM1NDI4Zjhk YjIwZTRmYTJhODljMjc1YmQxMTQ2ODAwZTBiZTBjMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vbWFjL1dlYkNvcmVGdWxsU2NyZWVuV2FybmluZ1ZpZXcubW0KKysrIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1dlYkNvcmVGdWxsU2NyZWVuV2FybmluZ1ZpZXcubW0K QEAgLTEwNSw0ICsxMDUsNTUgQEAgc3RhdGljIGNvbnN0IE5TVGltZUludGVydmFsIFdhcm5pbmdW aWV3RmFkZUR1cmF0aW9uID0gMC41OwogCiAgICAgcmV0dXJuIHNlbGY7CiB9CisKKy0gKHZvaWQp ZGVhbGxvYworeworICAgIFtOU09iamVjdCBjYW5jZWxQcmV2aW91c1BlcmZvcm1SZXF1ZXN0c1dp dGhUYXJnZXQ6c2VsZl07CisgICAgW3N1cGVyIGRlYWxsb2NdOworfQorCistICh2b2lkKXNldEhp ZGRlbjooQk9PTClmbGFnCit7CisgICAgW05TT2JqZWN0IGNhbmNlbFByZXZpb3VzUGVyZm9ybVJl cXVlc3RzV2l0aFRhcmdldDpzZWxmXTsKKyAgICBbc3VwZXIgc2V0SGlkZGVuOmZsYWddOworCisg ICAgW05TQW5pbWF0aW9uQ29udGV4dCBiZWdpbkdyb3VwaW5nXTsKKyAgICBbW05TQW5pbWF0aW9u Q29udGV4dCBjdXJyZW50Q29udGV4dF0gc2V0RHVyYXRpb246MF07CisgICAgW1tzZWxmIGFuaW1h dG9yXSBzZXRBbHBoYVZhbHVlOmZsYWcgPyAwIDogMV07CisgICAgW05TQW5pbWF0aW9uQ29udGV4 dCBlbmRHcm91cGluZ107Cit9CisKKy0gKHZvaWQpZmFkZUluCit7CisgICAgW3N1cGVyIHNldEhp ZGRlbjpOT107CisKKyAgICBbTlNBbmltYXRpb25Db250ZXh0IGJlZ2luR3JvdXBpbmddOworICAg IFtbTlNBbmltYXRpb25Db250ZXh0IGN1cnJlbnRDb250ZXh0XSBzZXREdXJhdGlvbjpXYXJuaW5n Vmlld0ZhZGVEdXJhdGlvbl07CisgICAgW1tzZWxmIGFuaW1hdG9yXSBzZXRBbHBoYVZhbHVlOjFd OworICAgIFtOU0FuaW1hdGlvbkNvbnRleHQgZW5kR3JvdXBpbmddOworfQorCistICh2b2lkKWZh ZGVJblRoZW5PdXQKK3sKKyAgICBbc2VsZiBmYWRlSW5dOworICAgIFtzZWxmIHBlcmZvcm1TZWxl Y3RvcjpAc2VsZWN0b3IoZmFkZU91dCkgd2l0aE9iamVjdDpuaWwgYWZ0ZXJEZWxheTpXYXJuaW5n Vmlld0hpZGVEZWxheV07Cit9CisKKy0gKHZvaWQpZmFkZU91dAoreworICAgIFtOU09iamVjdCBj YW5jZWxQcmV2aW91c1BlcmZvcm1SZXF1ZXN0c1dpdGhUYXJnZXQ6c2VsZl07CisKKyAgICBbTlNB bmltYXRpb25Db250ZXh0IGJlZ2luR3JvdXBpbmddOworICAgIFtbTlNBbmltYXRpb25Db250ZXh0 IGN1cnJlbnRDb250ZXh0XSBzZXREdXJhdGlvbjpXYXJuaW5nVmlld0ZhZGVEdXJhdGlvbl07Cisg ICAgW1tzZWxmIGFuaW1hdG9yXSBzZXRBbHBoYVZhbHVlOjBdOworICAgIFtOU0FuaW1hdGlvbkNv bnRleHQgZW5kR3JvdXBpbmddOworCisgICAgW3NlbGYgcGVyZm9ybVNlbGVjdG9yOkBzZWxlY3Rv cihfaGlkZUFmdGVyRmFkZU91dCkgd2l0aE9iamVjdDpuaWwgYWZ0ZXJEZWxheTpXYXJuaW5nVmll d0ZhZGVEdXJhdGlvbl07Cit9CisKKy0gKHZvaWQpX2hpZGVBZnRlckZhZGVPdXQKK3sKKyAgICBb c3VwZXIgc2V0SGlkZGVuOnRydWVdOworfQorCiBAZW5kCg==