<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>102306</bug_id>
          
          <creation_ts>2012-11-14 17:41:48 -0800</creation_ts>
          <short_desc>For single element arrays use the pointer into the CFDataRef instead of copying data</short_desc>
          <delta_ts>2012-11-24 12:44:12 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Platform</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Pratik Solanki">psolanki</reporter>
          <assigned_to name="Pratik Solanki">psolanki</assigned_to>
          <cc>ap</cc>
    
    <cc>beidson</cc>
    
    <cc>benjamin</cc>
    
    <cc>darin</cc>
    
    <cc>ddkilzer</cc>
    
    <cc>japhet</cc>
    
    <cc>psolanki</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>767521</commentid>
    <comment_count>0</comment_count>
    <who name="Pratik Solanki">psolanki</who>
    <bug_when>2012-11-14 17:41:48 -0800</bug_when>
    <thetext>This is an optimization when USE(NETWORK_CFDATA_ARRAY_CALLBACK) is available. Generally, WebCore copies the data returned from CFNetwork into its own buffers once the resource is done loading. However, if the resource is cached, CFNetwork will return us a CFArrayRef with exactly 1 CFDataRef in it. In such a case, it might be beneficial to not copy the data and just use the byte pointer i.e. call CFDataGetBytePtr() and use that memory directly.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>767522</commentid>
    <comment_count>1</comment_count>
    <who name="Pratik Solanki">psolanki</who>
    <bug_when>2012-11-14 17:42:10 -0800</bug_when>
    <thetext>&lt;rdar://problem/12267471&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>768295</commentid>
    <comment_count>2</comment_count>
      <attachid>174487</attachid>
    <who name="Pratik Solanki">psolanki</who>
    <bug_when>2012-11-15 10:49:13 -0800</bug_when>
    <thetext>Created attachment 174487
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>768402</commentid>
    <comment_count>3</comment_count>
      <attachid>174487</attachid>
    <who name="Pratik Solanki">psolanki</who>
    <bug_when>2012-11-15 12:55:20 -0800</bug_when>
    <thetext>Comment on attachment 174487
Patch

Retracting. This needs another tweak.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>768739</commentid>
    <comment_count>4</comment_count>
      <attachid>174569</attachid>
    <who name="Pratik Solanki">psolanki</who>
    <bug_when>2012-11-15 17:31:12 -0800</bug_when>
    <thetext>Created attachment 174569
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>768749</commentid>
    <comment_count>5</comment_count>
      <attachid>174569</attachid>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2012-11-15 17:38:02 -0800</bug_when>
    <thetext>Comment on attachment 174569
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=174569&amp;action=review

Looks reasonable to me. Brady might want to have a look too, as he&apos;s been refactoring adjacent code.

&gt; Source/WebCore/ChangeLog:22
&gt; +        (WebCore):

It is helpful to edit ChangeLogs to remove useless gunk like this. ChangeLogs are meant for human consumption, so anything you can do to make reading easier is a plus (but obviously, not hugely important for somethign trivial like this).

&gt; Source/WebCore/platform/SharedBuffer.cpp:149
&gt; +    const char *buffer = singleDataArrayBuffer();

Star goes to the left.

&gt; Source/WebCore/platform/cf/SharedBufferCF.cpp:144
&gt; +        return reinterpret_cast&lt;const char *&gt;(CFDataGetBytePtr(m_dataArray.at(0).get()));

Ditto.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>769583</commentid>
    <comment_count>6</comment_count>
    <who name="Pratik Solanki">psolanki</who>
    <bug_when>2012-11-16 12:39:45 -0800</bug_when>
    <thetext>Thanks for the review. I&apos;ll commit with the changes suggested. I also had to change a variable name since the compiler got confused about buffer being a const char * and a member function.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>769587</commentid>
    <comment_count>7</comment_count>
    <who name="Pratik Solanki">psolanki</who>
    <bug_when>2012-11-16 12:47:47 -0800</bug_when>
    <thetext>Committed r134987: &lt;http://trac.webkit.org/changeset/134987&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>769689</commentid>
    <comment_count>8</comment_count>
      <attachid>174569</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2012-11-16 14:51:15 -0800</bug_when>
    <thetext>Comment on attachment 174569
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=174569&amp;action=review

&gt; Source/WebCore/platform/SharedBuffer.cpp:151
&gt; +    const char *buffer = singleDataArrayBuffer();
&gt; +    if (buffer)
&gt; +        return buffer;

This would be slightly nicer with the variable definition inside the if.

&gt; Source/WebCore/platform/cf/SharedBufferCF.cpp:143
&gt; +    if (m_dataArray.size() == 1)

This would be slightly nicer as an early return.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>769692</commentid>
    <comment_count>9</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2012-11-16 14:52:08 -0800</bug_when>
    <thetext>(In reply to comment #6)
&gt; I also had to change a variable name since the compiler got confused about buffer being a const char * and a member function.

An alternate solution in cases like that is to use this-&gt;functionName syntax to call a member function that is shadowed by a same-named local variable. We like that because it lets us use the cleanest simplest names for both.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>769784</commentid>
    <comment_count>10</comment_count>
    <who name="Pratik Solanki">psolanki</who>
    <bug_when>2012-11-16 17:00:45 -0800</bug_when>
    <thetext>Reopening to attach new patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>769785</commentid>
    <comment_count>11</comment_count>
      <attachid>174785</attachid>
    <who name="Pratik Solanki">psolanki</who>
    <bug_when>2012-11-16 17:00:46 -0800</bug_when>
    <thetext>Created attachment 174785
Be slightly nicer!

Sounds good. Added a patch with the comments addressed</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>771294</commentid>
    <comment_count>12</comment_count>
      <attachid>174785</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2012-11-19 17:44:03 -0800</bug_when>
    <thetext>Comment on attachment 174785
Be slightly nicer!

Since the Apple guys are on vacation, and you have executed the changes ap and Darin asked for, r=me.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>771316</commentid>
    <comment_count>13</comment_count>
      <attachid>174785</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-11-19 17:55:49 -0800</bug_when>
    <thetext>Comment on attachment 174785
Be slightly nicer!

Clearing flags on attachment: 174785

Committed r135221: &lt;http://trac.webkit.org/changeset/135221&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>774879</commentid>
    <comment_count>14</comment_count>
    <who name="Pratik Solanki">psolanki</who>
    <bug_when>2012-11-24 12:44:12 -0800</bug_when>
    <thetext>Brent, thanks for the r+ and cq+. Marking this bug as fixed.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>174487</attachid>
            <date>2012-11-15 10:49:13 -0800</date>
            <delta_ts>2012-11-15 17:31:10 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-102306-20121115104711.patch</filename>
            <type>text/plain</type>
            <size>4002</size>
            <attacher name="Pratik Solanki">psolanki</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzNjMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTdjYmEzNmQ2MjQxNjAx
NWFjYmIzZWM1ZGJmMTZlMDI4YWU1OGQwYi4uOTI0NjBmN2U2NDM0ODFmMmI4ZTY2MmZkZjJiODVm
MTEwMGJiN2Q2MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDEyLTExLTE1ICBQcmF0
aWsgU29sYW5raSAgPHBzb2xhbmtpQGFwcGxlLmNvbT4KKworICAgICAgICBGb3Igc2luZ2xlIGVs
ZW1lbnQgYXJyYXlzIHVzZSB0aGUgcG9pbnRlciBpbnRvIHRoZSBDRkRhdGFSZWYgaW5zdGVhZCBv
ZiBjb3B5aW5nIGRhdGEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu
Y2dpP2lkPTEwMjMwNgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTIyNjc0NzE+CisKKyAgICAg
ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2UgZ2VuZXJhbGx5IGNv
cHkgdGhlIGRhdGEgcmVjZWl2ZWQgZnJvbSBDRk5ldHdvcmsgaW50byBvdXIgb3duIGJ1ZmZlcnMu
IEJ1dCBpZiB0aGUKKyAgICAgICAgQ0ZBcnJheVJlZiBoYXMgZXhhY3RseSBvbmUgQ0ZEYXRhUmVm
IGluc2lkZSBpdCwgdGhlbiB3ZSBjYW4ganVzdCBob2xkIG9uIHRvIHRoZSBDRkRhdGFSZWYKKyAg
ICAgICAgYW5kIGFjY2VzcyBpdHMgbWVtb3J5IGRpcmVjdGx5IGFuZCBhdm9pZCBtYWtpbmcgYSBj
b3B5LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBiZWNhdXNlIG5vIGNoYW5nZSBpbiBmdW5jdGlv
bmFsaXR5LgorCisgICAgICAgICogcGxhdGZvcm0vU2hhcmVkQnVmZmVyLmNwcDoKKyAgICAgICAg
KFdlYkNvcmU6OlNoYXJlZEJ1ZmZlcjo6ZGF0YSk6CisgICAgICAgICogcGxhdGZvcm0vU2hhcmVk
QnVmZmVyLmg6CisgICAgICAgIChTaGFyZWRCdWZmZXIpOgorICAgICAgICAqIHBsYXRmb3JtL2Nm
L1NoYXJlZEJ1ZmZlckNGLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNoYXJlZEJ1ZmZlcjo6cGxh
dGZvcm1EYXRhKTogVXNlIHJlaW50ZXJwcmV0X2Nhc3QgaW5zdGVhZCBvZiBDLXN0eWxlIGNhc3Qu
CisgICAgICAgIChXZWJDb3JlOjpTaGFyZWRCdWZmZXI6Om1heWJlVHJhbnNmZXJQbGF0Zm9ybURh
dGEpOiBVc2UgcmVpbnRlcnByZXRfY2FzdCBpbnN0ZWFkIG9mIEMtc3R5bGUgY2FzdC4KKyAgICAg
ICAgKFdlYkNvcmUpOgorICAgICAgICAoV2ViQ29yZTo6U2hhcmVkQnVmZmVyOjpzaW5nbGVEYXRh
QXJyYXlCdWZmZXIpOgorCiAyMDEyLTExLTA2ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5v
cmc+CiAKICAgICAgICAgU2NyaXB0V3JhcHBhYmxlIHNob3VsZCB3b3JrIGZvciBtb3JlIHRoYW4g
anVzdCBOb2RlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TaGFyZWRCdWZm
ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2hhcmVkQnVmZmVyLmNwcAppbmRleCAw
ZmUxNmNjZGZlY2ZjZWJhY2JjZWNkODUyMWIxYmY4NzE5NjJkY2ZmLi45MmE1M2UzNTc4Zjk2ZWRk
NGVlZjBjMDI5ZTg2ODQ2OWQxZjJkYTUwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0
Zm9ybS9TaGFyZWRCdWZmZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1NoYXJl
ZEJ1ZmZlci5jcHAKQEAgLTEyOCw2ICsxMjgsMTIgQEAgY29uc3QgY2hhciogU2hhcmVkQnVmZmVy
OjpkYXRhKCkgY29uc3QKIHsKICAgICBpZiAoaGFzUGxhdGZvcm1EYXRhKCkpCiAgICAgICAgIHJl
dHVybiBwbGF0Zm9ybURhdGEoKTsKKworI2lmIFVTRShORVRXT1JLX0NGREFUQV9BUlJBWV9DQUxM
QkFDSykKKyAgICBjb25zdCBjaGFyICpidWZmZXIgPSBzaW5nbGVEYXRhQXJyYXlCdWZmZXIoKTsK
KyAgICBpZiAoYnVmZmVyKQorICAgICAgICByZXR1cm4gYnVmZmVyOworI2VuZGlmCiAgICAgCiAg
ICAgaWYgKG1fcHVyZ2VhYmxlQnVmZmVyKQogICAgICAgICByZXR1cm4gbV9wdXJnZWFibGVCdWZm
ZXItPmRhdGEoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1NoYXJlZEJ1
ZmZlci5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2hhcmVkQnVmZmVyLmgKaW5kZXggZWMz
ZDRkM2M0Y2FkYmExMmM5MTFhMDExZWFlNTk2OTMyMjUzY2E1OS4uZjVjMTlkZGQyMDk3ZTIzZTU2
MmM2NmY2ZjNlYWZjZTE0Nzg2ZGUyZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv
cm0vU2hhcmVkQnVmZmVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2hhcmVkQnVm
ZmVyLmgKQEAgLTE0MSw2ICsxNDEsNyBAQCBwcml2YXRlOgogICAgIG11dGFibGUgVmVjdG9yPFJl
dGFpblB0cjxDRkRhdGFSZWY+ID4gbV9kYXRhQXJyYXk7CiAgICAgdm9pZCBjb3B5RGF0YUFycmF5
QW5kQ2xlYXIoY2hhciAqZGVzdGluYXRpb24sIHVuc2lnbmVkIGJ5dGVzVG9Db3B5KSBjb25zdDsK
ICAgICB1bnNpZ25lZCBjb3B5U29tZURhdGFGcm9tRGF0YUFycmF5KGNvbnN0IGNoYXIqJiBzb21l
RGF0YSwgdW5zaWduZWQgcG9zaXRpb24pIGNvbnN0OworICAgIGNvbnN0IGNoYXIgKnNpbmdsZURh
dGFBcnJheUJ1ZmZlcigpIGNvbnN0OwogI2VuZGlmCiAjaWYgVVNFKENGKQogICAgIGV4cGxpY2l0
IFNoYXJlZEJ1ZmZlcihDRkRhdGFSZWYpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxh
dGZvcm0vY2YvU2hhcmVkQnVmZmVyQ0YuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2Yv
U2hhcmVkQnVmZmVyQ0YuY3BwCmluZGV4IGQwMmNmNDRiNDAzMzMzZjQwYjk2MDE0Zjg4MmM0Njdi
ZDVjYTMxZjkuLjFjNDZlZWQxMjE1MWE2MmY4N2Q2MTI4MWZjYTE4M2FiYTIyMjIyNTUgMTAwNjQ0
Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2NmL1NoYXJlZEJ1ZmZlckNGLmNwcAorKysg
Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jZi9TaGFyZWRCdWZmZXJDRi5jcHAKQEAgLTY2LDcg
KzY2LDcgQEAgYm9vbCBTaGFyZWRCdWZmZXI6Omhhc1BsYXRmb3JtRGF0YSgpIGNvbnN0CiAKIGNv
bnN0IGNoYXIqIFNoYXJlZEJ1ZmZlcjo6cGxhdGZvcm1EYXRhKCkgY29uc3QKIHsKLSAgICByZXR1
cm4gKGNvbnN0IGNoYXIqKUNGRGF0YUdldEJ5dGVQdHIobV9jZkRhdGEuZ2V0KCkpOworICAgIHJl
dHVybiByZWludGVycHJldF9jYXN0PGNvbnN0IGNoYXIqPihDRkRhdGFHZXRCeXRlUHRyKG1fY2ZE
YXRhLmdldCgpKSk7CiB9CiAKIHVuc2lnbmVkIFNoYXJlZEJ1ZmZlcjo6cGxhdGZvcm1EYXRhU2l6
ZSgpIGNvbnN0CkBAIC04MSw3ICs4MSw3IEBAIHZvaWQgU2hhcmVkQnVmZmVyOjptYXliZVRyYW5z
ZmVyUGxhdGZvcm1EYXRhKCkKICAgICAKICAgICBBU1NFUlQoIW1fc2l6ZSk7CiAgICAgICAgIAot
ICAgIGFwcGVuZCgoY29uc3QgY2hhciopQ0ZEYXRhR2V0Qnl0ZVB0cihtX2NmRGF0YS5nZXQoKSks
IENGRGF0YUdldExlbmd0aChtX2NmRGF0YS5nZXQoKSkpOworICAgIGFwcGVuZChyZWludGVycHJl
dF9jYXN0PGNvbnN0IGNoYXIqPihDRkRhdGFHZXRCeXRlUHRyKG1fY2ZEYXRhLmdldCgpKSksIENG
RGF0YUdldExlbmd0aChtX2NmRGF0YS5nZXQoKSkpOwogICAgICAgICAKICAgICBtX2NmRGF0YSA9
IDA7CiB9CkBAIC0xMzIsNiArMTMyLDE0IEBAIHVuc2lnbmVkIFNoYXJlZEJ1ZmZlcjo6Y29weVNv
bWVEYXRhRnJvbURhdGFBcnJheShjb25zdCBjaGFyKiYgc29tZURhdGEsIHVuc2lnbmVkCiAgICAg
fQogICAgIHJldHVybiAwOwogfQorCitjb25zdCBjaGFyICpTaGFyZWRCdWZmZXI6OnNpbmdsZURh
dGFBcnJheUJ1ZmZlcigpIGNvbnN0Cit7CisgICAgaWYgKG1fZGF0YUFycmF5LnNpemUoKSA9PSAx
KQorICAgICAgICByZXR1cm4gcmVpbnRlcnByZXRfY2FzdDxjb25zdCBjaGFyICo+KENGRGF0YUdl
dEJ5dGVQdHIobV9kYXRhQXJyYXkuYXQoMCkuZ2V0KCkpKTsKKworICAgIHJldHVybiAwOworfQog
I2VuZGlmCiAKIH0K
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>174569</attachid>
            <date>2012-11-15 17:31:12 -0800</date>
            <delta_ts>2012-11-16 14:51:15 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-102306-20121115172909.patch</filename>
            <type>text/plain</type>
            <size>8258</size>
            <attacher name="Pratik Solanki">psolanki</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0Nzk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMThmM2E0MGEzNGQxNTY4
MDc2ZWY5ODUwNTlmNTRhMzAwMjY1M2YzYS4uYzExZmYzYzgxNjE1OWZlZmRkNjI1YTJiMWM4MzBh
NjBmMjg3YmY1YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDQxIEBACisyMDEyLTExLTE1ICBQcmF0
aWsgU29sYW5raSAgPHBzb2xhbmtpQGFwcGxlLmNvbT4KKworICAgICAgICBGb3Igc2luZ2xlIGVs
ZW1lbnQgYXJyYXlzIHVzZSB0aGUgcG9pbnRlciBpbnRvIHRoZSBDRkRhdGFSZWYgaW5zdGVhZCBv
ZiBjb3B5aW5nIGRhdGEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu
Y2dpP2lkPTEwMjMwNgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTIyNjc0NzE+CisKKyAgICAg
ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2UgZ2VuZXJhbGx5IGNv
cHkgdGhlIGRhdGEgcmVjZWl2ZWQgZnJvbSBDRk5ldHdvcmsgaW50byBvdXIgb3duIGJ1ZmZlcnMu
IEJ1dCBpZiB0aGUKKyAgICAgICAgQ0ZBcnJheVJlZiBoYXMgZXhhY3RseSBvbmUgQ0ZEYXRhUmVm
IGluc2lkZSBpdCwgdGhlbiB3ZSBjYW4ganVzdCBob2xkIG9uIHRvIHRoZSBDRkRhdGFSZWYKKyAg
ICAgICAgYW5kIGFjY2VzcyBpdHMgbWVtb3J5IGRpcmVjdGx5IGFuZCBhdm9pZCBtYWtpbmcgYSBj
b3B5LgorCisgICAgICAgIFRoaXMgYWxzbyBtb3ZlcyB0aGUgY3JlYXRpb24gb2YgUHVyZ2VhYmxl
QnVmZmVyIGZyb20gQ2FjaGVkUmVzb3VyY2UgdG8gU2hhcmVkQnVmZmVyLgorICAgICAgICBTaGFy
ZWRCdWZmZXI6OmNyZWF0ZVB1cmdlYWJsZUJ1ZmZlcigpIHdpbGwgYXZvaWQgY3JlYXRpbmcgUHVy
Z2VhYmxlQnVmZmVyIHdoZW4gdGhlCisgICAgICAgIFNoYXJlZEJ1ZmZlciBpcyBiYWNrZWQgYnkg
YSBOU0RhdGEvQ0ZEYXRhUmVmIGFuZCB3aGVuIHdlIHdhbnQgdG8gb3B0aW1pemUgYW5kIGRpcmVj
dGx5IHVzZQorICAgICAgICB0aGUgbWVtb3J5IGluIHRoZSBkYXRhIGFycmF5LgorCisgICAgICAg
IE5vIG5ldyB0ZXN0cyBiZWNhdXNlIG5vIGNoYW5nZSBpbiBmdW5jdGlvbmFsaXR5LgorCisgICAg
ICAgICogbG9hZGVyL1Jlc291cmNlQnVmZmVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlc291
cmNlQnVmZmVyOjpjcmVhdGVQdXJnZWFibGVCdWZmZXIpOgorICAgICAgICAoV2ViQ29yZSk6Cisg
ICAgICAgICogbG9hZGVyL1Jlc291cmNlQnVmZmVyLmg6CisgICAgICAgIChSZXNvdXJjZUJ1ZmZl
cik6CisgICAgICAgICogbG9hZGVyL2NhY2hlL0NhY2hlZFJlc291cmNlLmNwcDoKKyAgICAgICAg
KFdlYkNvcmU6OkNhY2hlZFJlc291cmNlOjptYWtlUHVyZ2VhYmxlKToKKyAgICAgICAgKiBwbGF0
Zm9ybS9TaGFyZWRCdWZmZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2hhcmVkQnVmZmVyOjpj
cmVhdGVQdXJnZWFibGVCdWZmZXIpOgorICAgICAgICAoV2ViQ29yZSk6CisgICAgICAgIChXZWJD
b3JlOjpTaGFyZWRCdWZmZXI6OmRhdGEpOgorICAgICAgICAqIHBsYXRmb3JtL1NoYXJlZEJ1ZmZl
ci5oOgorICAgICAgICAoU2hhcmVkQnVmZmVyKToKKyAgICAgICAgKiBwbGF0Zm9ybS9jZi9TaGFy
ZWRCdWZmZXJDRi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTaGFyZWRCdWZmZXI6OnBsYXRmb3Jt
RGF0YSk6IFVzZSByZWludGVycHJldF9jYXN0IGluc3RlYWQgb2YgQy1zdHlsZSBjYXN0LgorICAg
ICAgICAoV2ViQ29yZTo6U2hhcmVkQnVmZmVyOjptYXliZVRyYW5zZmVyUGxhdGZvcm1EYXRhKTog
VXNlIHJlaW50ZXJwcmV0X2Nhc3QgaW5zdGVhZCBvZiBDLXN0eWxlIGNhc3QuCisgICAgICAgIChX
ZWJDb3JlKToKKyAgICAgICAgKFdlYkNvcmU6OlNoYXJlZEJ1ZmZlcjo6c2luZ2xlRGF0YUFycmF5
QnVmZmVyKToKKwogMjAxMi0xMS0xNSAgRWxsaW90dCBTcHJlaG4gIDxlc3ByZWhuQGNocm9taXVt
Lm9yZz4KIAogICAgICAgICBSZW1vdmUgaXNIVE1MSW5wdXRFbGVtZW50IHNpbmNlIGl0J3MgdW51
c2VkIGFuZCB0b0lucHV0RWxlbWVudCBleGlzdHMgCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y
ZS9sb2FkZXIvUmVzb3VyY2VCdWZmZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL1Jlc291
cmNlQnVmZmVyLmNwcAppbmRleCBkNTc5MTQzMWNmNTViMzA0NGE5ZDg2ZTkyNjI2NWFmYjg0MjVk
ZTVjLi4wZTMwZWMzMjM1YzM0OWUwYWY3Mzc0MzlhZWRiYTkxNWIwMjAyZTE5IDEwMDY0NAotLS0g
YS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvUmVzb3VyY2VCdWZmZXIuY3BwCisrKyBiL1NvdXJjZS9X
ZWJDb3JlL2xvYWRlci9SZXNvdXJjZUJ1ZmZlci5jcHAKQEAgLTEwMCw2ICsxMDAsMTIgQEAgYm9v
bCBSZXNvdXJjZUJ1ZmZlcjo6aGFzUHVyZ2VhYmxlQnVmZmVyKCkgY29uc3QKICAgICByZXR1cm4g
bV9zaGFyZWRCdWZmZXItPmhhc1B1cmdlYWJsZUJ1ZmZlcigpOwogfQogCit2b2lkIFJlc291cmNl
QnVmZmVyOjpjcmVhdGVQdXJnZWFibGVCdWZmZXIoKSBjb25zdAoreworICAgIEFTU0VSVChtX3No
YXJlZEJ1ZmZlcik7CisgICAgc2hhcmVkQnVmZmVyKCktPmNyZWF0ZVB1cmdlYWJsZUJ1ZmZlcigp
OworfQorCiBQYXNzT3duUHRyPFB1cmdlYWJsZUJ1ZmZlcj4gUmVzb3VyY2VCdWZmZXI6OnJlbGVh
c2VQdXJnZWFibGVCdWZmZXIoKQogewogICAgIHJldHVybiBtX3NoYXJlZEJ1ZmZlci0+cmVsZWFz
ZVB1cmdlYWJsZUJ1ZmZlcigpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL1Jl
c291cmNlQnVmZmVyLmggYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvUmVzb3VyY2VCdWZmZXIuaApp
bmRleCA3MzUwNjcxZDhhNGU2MmVjZGFkNWE4ZmZlNjE1MWY5ZmY2ZjA1NTYyLi44MzY0MmZmZDM5
OTExYjJlNjA3ZWI1Yzg2YjlhMzRkNmQ3NWIxMjM5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9sb2FkZXIvUmVzb3VyY2VCdWZmZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvUmVz
b3VyY2VCdWZmZXIuaApAQCAtNjMsNiArNjMsNyBAQCBwdWJsaWM6CiAgICAgUGFzc1JlZlB0cjxS
ZXNvdXJjZUJ1ZmZlcj4gY29weSgpIGNvbnN0OwogCiAgICAgYm9vbCBoYXNQdXJnZWFibGVCdWZm
ZXIoKSBjb25zdDsKKyAgICB2b2lkIGNyZWF0ZVB1cmdlYWJsZUJ1ZmZlcigpIGNvbnN0OwogICAg
IAogICAgIC8vIEVuc3VyZSB0aGlzIGJ1ZmZlciBoYXMgbm8gb3RoZXIgY2xpZW50cyBiZWZvcmUg
Y2FsbGluZyB0aGlzLgogICAgIFBhc3NPd25QdHI8UHVyZ2VhYmxlQnVmZmVyPiByZWxlYXNlUHVy
Z2VhYmxlQnVmZmVyKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUv
Q2FjaGVkUmVzb3VyY2UuY3BwIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL2NhY2hlL0NhY2hlZFJl
c291cmNlLmNwcAppbmRleCAxMDliNzZiY2M2ZGQwY2JmYzlmMzJlNWYxODkwNzA0MGE1NTFlZTQ5
Li4wZTg3NDUwNDg1MTM4ODUzNzdhNmRkYzNiNjk3MzY1YTk1Njc1MjgxIDEwMDY0NAotLS0gYS9T
b3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkUmVzb3VyY2UuY3BwCisrKyBiL1NvdXJj
ZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRSZXNvdXJjZS5jcHAKQEAgLTgwMSwxNiArODAx
LDEzIEBAIGJvb2wgQ2FjaGVkUmVzb3VyY2U6Om1ha2VQdXJnZWFibGUoYm9vbCBwdXJnZWFibGUp
CiAgICAgICAgIC8vIFNob3VsZCBub3QgbWFrZSBidWZmZXIgcHVyZ2VhYmxlIGlmIGl0IGhhcyBy
ZWZzIG90aGVyIHRoYW4gdGhpcyBzaW5jZSB3ZSBkb24ndCB3YW50IHR3byBjb3BpZXMuCiAgICAg
ICAgIGlmICghbV9kYXRhLT5oYXNPbmVSZWYoKSkKICAgICAgICAgICAgIHJldHVybiBmYWxzZTsK
LSAgICAgICAgCi0gICAgICAgIGlmIChtX2RhdGEtPmhhc1B1cmdlYWJsZUJ1ZmZlcigpKSB7Ci0g
ICAgICAgICAgICBtX3B1cmdlYWJsZURhdGEgPSBtX2RhdGEtPnJlbGVhc2VQdXJnZWFibGVCdWZm
ZXIoKTsKLSAgICAgICAgfSBlbHNlIHsKLSAgICAgICAgICAgIG1fcHVyZ2VhYmxlRGF0YSA9IFB1
cmdlYWJsZUJ1ZmZlcjo6Y3JlYXRlKG1fZGF0YS0+ZGF0YSgpLCBtX2RhdGEtPnNpemUoKSk7Ci0g
ICAgICAgICAgICBpZiAoIW1fcHVyZ2VhYmxlRGF0YSkKLSAgICAgICAgICAgICAgICByZXR1cm4g
ZmFsc2U7Ci0gICAgICAgICAgICBtX3B1cmdlYWJsZURhdGEtPnNldFB1cmdlUHJpb3JpdHkocHVy
Z2VQcmlvcml0eSgpKTsKLSAgICAgICAgfQotICAgICAgICAKKworICAgICAgICBtX2RhdGEtPmNy
ZWF0ZVB1cmdlYWJsZUJ1ZmZlcigpOworICAgICAgICBpZiAoIW1fZGF0YS0+aGFzUHVyZ2VhYmxl
QnVmZmVyKCkpCisgICAgICAgICAgICByZXR1cm4gZmFsc2U7CisKKyAgICAgICAgbV9wdXJnZWFi
bGVEYXRhID0gbV9kYXRhLT5yZWxlYXNlUHVyZ2VhYmxlQnVmZmVyKCk7CisgICAgICAgIG1fcHVy
Z2VhYmxlRGF0YS0+c2V0UHVyZ2VQcmlvcml0eShwdXJnZVByaW9yaXR5KCkpOwogICAgICAgICBt
X3B1cmdlYWJsZURhdGEtPm1ha2VQdXJnZWFibGUodHJ1ZSk7CiAgICAgICAgIG1fZGF0YS5jbGVh
cigpOwogICAgICAgICByZXR1cm4gdHJ1ZTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bs
YXRmb3JtL1NoYXJlZEJ1ZmZlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TaGFyZWRC
dWZmZXIuY3BwCmluZGV4IDBmZTE2Y2NkZmVjZmNlYmFjYmNlY2Q4NTIxYjFiZjg3MTk2MmRjZmYu
LjVhZmYwYzA1NGZmMWRhZjkyNjM3NDZkMDA5YzhiYWJjMzVkOGRhN2YgMTAwNjQ0Ci0tLSBhL1Nv
dXJjZS9XZWJDb3JlL3BsYXRmb3JtL1NoYXJlZEJ1ZmZlci5jcHAKKysrIGIvU291cmNlL1dlYkNv
cmUvcGxhdGZvcm0vU2hhcmVkQnVmZmVyLmNwcApAQCAtMTI0LDEwICsxMjQsMzIgQEAgdW5zaWdu
ZWQgU2hhcmVkQnVmZmVyOjpzaXplKCkgY29uc3QKICAgICByZXR1cm4gbV9zaXplOwogfQogCit2
b2lkIFNoYXJlZEJ1ZmZlcjo6Y3JlYXRlUHVyZ2VhYmxlQnVmZmVyKCkgY29uc3QKK3sKKyAgICBp
ZiAobV9wdXJnZWFibGVCdWZmZXIpCisgICAgICAgIHJldHVybjsKKworICAgIGlmIChoYXNQbGF0
Zm9ybURhdGEoKSkKKyAgICAgICAgcmV0dXJuOworCisjaWYgVVNFKE5FVFdPUktfQ0ZEQVRBX0FS
UkFZX0NBTExCQUNLKQorICAgIGlmIChzaW5nbGVEYXRhQXJyYXlCdWZmZXIoKSkKKyAgICAgICAg
cmV0dXJuOworI2VuZGlmCisKKyAgICBtX3B1cmdlYWJsZUJ1ZmZlciA9IFB1cmdlYWJsZUJ1ZmZl
cjo6Y3JlYXRlKGJ1ZmZlcigpLmRhdGEoKSwgbV9zaXplKTsKK30KKwogY29uc3QgY2hhciogU2hh
cmVkQnVmZmVyOjpkYXRhKCkgY29uc3QKIHsKICAgICBpZiAoaGFzUGxhdGZvcm1EYXRhKCkpCiAg
ICAgICAgIHJldHVybiBwbGF0Zm9ybURhdGEoKTsKKworI2lmIFVTRShORVRXT1JLX0NGREFUQV9B
UlJBWV9DQUxMQkFDSykKKyAgICBjb25zdCBjaGFyICpidWZmZXIgPSBzaW5nbGVEYXRhQXJyYXlC
dWZmZXIoKTsKKyAgICBpZiAoYnVmZmVyKQorICAgICAgICByZXR1cm4gYnVmZmVyOworI2VuZGlm
CiAgICAgCiAgICAgaWYgKG1fcHVyZ2VhYmxlQnVmZmVyKQogICAgICAgICByZXR1cm4gbV9wdXJn
ZWFibGVCdWZmZXItPmRhdGEoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt
L1NoYXJlZEJ1ZmZlci5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2hhcmVkQnVmZmVyLmgK
aW5kZXggZWMzZDRkM2M0Y2FkYmExMmM5MTFhMDExZWFlNTk2OTMyMjUzY2E1OS4uMzJlNzFhZjFm
OTljM2YyYWMyOGNiN2JkM2Y5ZTJiZjQyZDQ1ZGU3MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv
cmUvcGxhdGZvcm0vU2hhcmVkQnVmZmVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v
U2hhcmVkQnVmZmVyLmgKQEAgLTExNiw2ICsxMTYsOCBAQCBwdWJsaWM6CiAKICAgICB2b2lkIHJl
cG9ydE1lbW9yeVVzYWdlKE1lbW9yeU9iamVjdEluZm8qKSBjb25zdDsKIAorICAgIHZvaWQgY3Jl
YXRlUHVyZ2VhYmxlQnVmZmVyKCkgY29uc3Q7CisKIHByaXZhdGU6CiAgICAgU2hhcmVkQnVmZmVy
KCk7CiAgICAgZXhwbGljaXQgU2hhcmVkQnVmZmVyKHNpemVfdCk7CkBAIC0xMzYsMTEgKzEzOCwx
MiBAQCBwcml2YXRlOgogICAgIHVuc2lnbmVkIG1fc2l6ZTsKICAgICBtdXRhYmxlIFZlY3Rvcjxj
aGFyPiBtX2J1ZmZlcjsKICAgICBtdXRhYmxlIFZlY3RvcjxjaGFyKj4gbV9zZWdtZW50czsKLSAg
ICBPd25QdHI8UHVyZ2VhYmxlQnVmZmVyPiBtX3B1cmdlYWJsZUJ1ZmZlcjsKKyAgICBtdXRhYmxl
IE93blB0cjxQdXJnZWFibGVCdWZmZXI+IG1fcHVyZ2VhYmxlQnVmZmVyOwogI2lmIFVTRShORVRX
T1JLX0NGREFUQV9BUlJBWV9DQUxMQkFDSykKICAgICBtdXRhYmxlIFZlY3RvcjxSZXRhaW5QdHI8
Q0ZEYXRhUmVmPiA+IG1fZGF0YUFycmF5OwogICAgIHZvaWQgY29weURhdGFBcnJheUFuZENsZWFy
KGNoYXIgKmRlc3RpbmF0aW9uLCB1bnNpZ25lZCBieXRlc1RvQ29weSkgY29uc3Q7CiAgICAgdW5z
aWduZWQgY29weVNvbWVEYXRhRnJvbURhdGFBcnJheShjb25zdCBjaGFyKiYgc29tZURhdGEsIHVu
c2lnbmVkIHBvc2l0aW9uKSBjb25zdDsKKyAgICBjb25zdCBjaGFyICpzaW5nbGVEYXRhQXJyYXlC
dWZmZXIoKSBjb25zdDsKICNlbmRpZgogI2lmIFVTRShDRikKICAgICBleHBsaWNpdCBTaGFyZWRC
dWZmZXIoQ0ZEYXRhUmVmKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Nm
L1NoYXJlZEJ1ZmZlckNGLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2NmL1NoYXJlZEJ1
ZmZlckNGLmNwcAppbmRleCBkMDJjZjQ0YjQwMzMzM2Y0MGI5NjAxNGY4ODJjNDY3YmQ1Y2EzMWY5
Li5hMTMzZDk0Yjk2YWRjODJmNWU3M2JkNDk2NDg1NDExYmM5NWM4NGRkIDEwMDY0NAotLS0gYS9T
b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jZi9TaGFyZWRCdWZmZXJDRi5jcHAKKysrIGIvU291cmNl
L1dlYkNvcmUvcGxhdGZvcm0vY2YvU2hhcmVkQnVmZmVyQ0YuY3BwCkBAIC02Niw3ICs2Niw3IEBA
IGJvb2wgU2hhcmVkQnVmZmVyOjpoYXNQbGF0Zm9ybURhdGEoKSBjb25zdAogCiBjb25zdCBjaGFy
KiBTaGFyZWRCdWZmZXI6OnBsYXRmb3JtRGF0YSgpIGNvbnN0CiB7Ci0gICAgcmV0dXJuIChjb25z
dCBjaGFyKilDRkRhdGFHZXRCeXRlUHRyKG1fY2ZEYXRhLmdldCgpKTsKKyAgICByZXR1cm4gcmVp
bnRlcnByZXRfY2FzdDxjb25zdCBjaGFyKj4oQ0ZEYXRhR2V0Qnl0ZVB0cihtX2NmRGF0YS5nZXQo
KSkpOwogfQogCiB1bnNpZ25lZCBTaGFyZWRCdWZmZXI6OnBsYXRmb3JtRGF0YVNpemUoKSBjb25z
dApAQCAtODEsNyArODEsNyBAQCB2b2lkIFNoYXJlZEJ1ZmZlcjo6bWF5YmVUcmFuc2ZlclBsYXRm
b3JtRGF0YSgpCiAgICAgCiAgICAgQVNTRVJUKCFtX3NpemUpOwogICAgICAgICAKLSAgICBhcHBl
bmQoKGNvbnN0IGNoYXIqKUNGRGF0YUdldEJ5dGVQdHIobV9jZkRhdGEuZ2V0KCkpLCBDRkRhdGFH
ZXRMZW5ndGgobV9jZkRhdGEuZ2V0KCkpKTsKKyAgICBhcHBlbmQocmVpbnRlcnByZXRfY2FzdDxj
b25zdCBjaGFyKj4oQ0ZEYXRhR2V0Qnl0ZVB0cihtX2NmRGF0YS5nZXQoKSkpLCBDRkRhdGFHZXRM
ZW5ndGgobV9jZkRhdGEuZ2V0KCkpKTsKICAgICAgICAgCiAgICAgbV9jZkRhdGEgPSAwOwogfQpA
QCAtMTMyLDYgKzEzMiwxOSBAQCB1bnNpZ25lZCBTaGFyZWRCdWZmZXI6OmNvcHlTb21lRGF0YUZy
b21EYXRhQXJyYXkoY29uc3QgY2hhciomIHNvbWVEYXRhLCB1bnNpZ25lZAogICAgIH0KICAgICBy
ZXR1cm4gMDsKIH0KKworY29uc3QgY2hhciAqU2hhcmVkQnVmZmVyOjpzaW5nbGVEYXRhQXJyYXlC
dWZmZXIoKSBjb25zdAoreworICAgIC8vIElmIHdlIGhhZCBwcmV2aW91c2x5IGNvcGllZCBkYXRh
IGludG8gbV9idWZmZXIgaW4gY29weURhdGFBcnJheUFuZENsZWFyKCkgb3Igc29tZSBvdGhlcgor
ICAgIC8vIGZ1bmN0aW9uLCB0aGVuIHdlIGNhbid0IHJldHVybiBhIHBvaW50ZXIgdG8gdGhlIENG
RGF0YVJlZiBidWZmZXIuCisgICAgaWYgKG1fYnVmZmVyLnNpemUoKSkKKyAgICAgICAgcmV0dXJu
IDA7CisKKyAgICBpZiAobV9kYXRhQXJyYXkuc2l6ZSgpID09IDEpCisgICAgICAgIHJldHVybiBy
ZWludGVycHJldF9jYXN0PGNvbnN0IGNoYXIgKj4oQ0ZEYXRhR2V0Qnl0ZVB0cihtX2RhdGFBcnJh
eS5hdCgwKS5nZXQoKSkpOworCisgICAgcmV0dXJuIDA7Cit9CiAjZW5kaWYKIAogfQo=
</data>
<flag name="review"
          id="189677"
          type_id="1"
          status="+"
          setter="ap"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>174785</attachid>
            <date>2012-11-16 17:00:46 -0800</date>
            <delta_ts>2012-11-19 17:55:49 -0800</delta_ts>
            <desc>Be slightly nicer!</desc>
            <filename>bug-102306-20121116165842.patch</filename>
            <type>text/plain</type>
            <size>2403</size>
            <attacher name="Pratik Solanki">psolanki</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1MDAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTMxMTdkMGM5OGVkMTBi
ZWFjMWRmYjg2MjVjMjBjNDczYTRjMDYxNS4uNTJmYjVjNTU4ZDU2MGVlNjkzZmJkNWJjYTI1OGM4
M2RkOGRiNWUyZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTExLTE2ICBQcmF0
aWsgU29sYW5raSAgPHBzb2xhbmtpQGFwcGxlLmNvbT4KKworICAgICAgICBGb3Igc2luZ2xlIGVs
ZW1lbnQgYXJyYXlzIHVzZSB0aGUgcG9pbnRlciBpbnRvIHRoZSBDRkRhdGFSZWYgaW5zdGVhZCBv
ZiBjb3B5aW5nIGRhdGEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu
Y2dpP2lkPTEwMjMwNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg
ICAgICAgIEFkZHJlc3MgcmV2aWV3IGNvbW1lbnRzIGZvciBzbGlnaHRseSBuaWNlciBjb2RlLgor
CisgICAgICAgICogcGxhdGZvcm0vU2hhcmVkQnVmZmVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6
OlNoYXJlZEJ1ZmZlcjo6ZGF0YSk6CisgICAgICAgICogcGxhdGZvcm0vY2YvU2hhcmVkQnVmZmVy
Q0YuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2hhcmVkQnVmZmVyOjpzaW5nbGVEYXRhQXJyYXlC
dWZmZXIpOgorCiAyMDEyLTExLTE2ICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KIAog
ICAgICAgICBEZXBsb3kgU2NyaXB0V3JhcHBhYmxlIHRvIG1vcmUgYWx3YXlzLXdyYXBwZWQgb2Jq
ZWN0cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2hhcmVkQnVmZmVyLmNw
cCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1NoYXJlZEJ1ZmZlci5jcHAKaW5kZXggYzc2YmU1
ZDA1YTRhZDJkNDQ0ODRlNzQxYzUxOWUxZjhmZTliYjExNi4uOTYxYjczNWUyY2ZjY2UxMmUzODMy
NDFhYjc2MmQ5ZGZjYzFiNzljYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v
U2hhcmVkQnVmZmVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TaGFyZWRCdWZm
ZXIuY3BwCkBAIC0xNDYsMTUgKzE0NiwxNCBAQCBjb25zdCBjaGFyKiBTaGFyZWRCdWZmZXI6OmRh
dGEoKSBjb25zdAogICAgICAgICByZXR1cm4gcGxhdGZvcm1EYXRhKCk7CiAKICNpZiBVU0UoTkVU
V09SS19DRkRBVEFfQVJSQVlfQ0FMTEJBQ0spCi0gICAgY29uc3QgY2hhciogZGlyZWN0QnVmZmVy
ID0gc2luZ2xlRGF0YUFycmF5QnVmZmVyKCk7Ci0gICAgaWYgKGRpcmVjdEJ1ZmZlcikKLSAgICAg
ICAgcmV0dXJuIGRpcmVjdEJ1ZmZlcjsKKyAgICBpZiAoY29uc3QgY2hhciogYnVmZmVyID0gc2lu
Z2xlRGF0YUFycmF5QnVmZmVyKCkpCisgICAgICAgIHJldHVybiBidWZmZXI7CiAjZW5kaWYKICAg
ICAKICAgICBpZiAobV9wdXJnZWFibGVCdWZmZXIpCiAgICAgICAgIHJldHVybiBtX3B1cmdlYWJs
ZUJ1ZmZlci0+ZGF0YSgpOwogICAgIAotICAgIHJldHVybiBidWZmZXIoKS5kYXRhKCk7CisgICAg
cmV0dXJuIHRoaXMtPmJ1ZmZlcigpLmRhdGEoKTsKIH0KIAogdm9pZCBTaGFyZWRCdWZmZXI6OmFw
cGVuZChTaGFyZWRCdWZmZXIqIGRhdGEpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0
Zm9ybS9jZi9TaGFyZWRCdWZmZXJDRi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jZi9T
aGFyZWRCdWZmZXJDRi5jcHAKaW5kZXggNzQzMDQwMGQzMzFmOTM3MGRiMGVmMDNjYTJhYTIxYjRj
YjNiNThkMy4uOGExZTExMjAwYTRjZDJkYzI5ZjVhNWNkYTVmODgwMTU3OGUyNzdhMSAxMDA2NDQK
LS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2YvU2hhcmVkQnVmZmVyQ0YuY3BwCisrKyBi
L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2NmL1NoYXJlZEJ1ZmZlckNGLmNwcApAQCAtMTQwLDEw
ICsxNDAsMTAgQEAgY29uc3QgY2hhciAqU2hhcmVkQnVmZmVyOjpzaW5nbGVEYXRhQXJyYXlCdWZm
ZXIoKSBjb25zdAogICAgIGlmIChtX2J1ZmZlci5zaXplKCkpCiAgICAgICAgIHJldHVybiAwOwog
Ci0gICAgaWYgKG1fZGF0YUFycmF5LnNpemUoKSA9PSAxKQotICAgICAgICByZXR1cm4gcmVpbnRl
cnByZXRfY2FzdDxjb25zdCBjaGFyKj4oQ0ZEYXRhR2V0Qnl0ZVB0cihtX2RhdGFBcnJheS5hdCgw
KS5nZXQoKSkpOworICAgIGlmIChtX2RhdGFBcnJheS5zaXplKCkgIT0gMSkKKyAgICAgICAgcmV0
dXJuIDA7CiAKLSAgICByZXR1cm4gMDsKKyAgICByZXR1cm4gcmVpbnRlcnByZXRfY2FzdDxjb25z
dCBjaGFyKj4oQ0ZEYXRhR2V0Qnl0ZVB0cihtX2RhdGFBcnJheS5hdCgwKS5nZXQoKSkpOwogfQog
I2VuZGlmCiAK
</data>

          </attachment>
      

    </bug>

</bugzilla>