102305 2012-11-14 17:39:48 -0800 biquadfilternode-basic.html test should cover default value of frequency, Q and gain. 2012-11-17 11:59:27 -0800 1 1 1 Unclassified WebKit Web Audio 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 li.yin li.yin crogers eric.carlson feature-media-reviews webkit.review.bot oldest_to_newest 767518 0 li.yin 2012-11-14 17:39:48 -0800 According yo Spec: https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#BiquadFilterNode The default values of frequency, Q and gain are clearly specified, we should have related sub test to over them. 767525 1 174299 li.yin 2012-11-14 17:43:27 -0800 Created attachment 174299 Patch 769426 2 174299 crogers 2012-11-16 10:32:12 -0800 Comment on attachment 174299 Patch thanks 769441 3 174299 webkit.review.bot 2012-11-16 10:42:09 -0800 Comment on attachment 174299 Patch Rejecting attachment 174299 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: angeLog CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog Failed to merge in the changes. Patch failed at 0001 [chromium] Copy linux theme related files to default When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 154. Full output: http://queues.webkit.org/results/14872229 769885 4 li.yin 2012-11-16 21:59:55 -0800 The conflict is not resulted from this patch, since the conflict came from Source/WebCore/ChangeLog and Source/Platform/ChangeLog, and there is no change to these files in this patch. Let me mark cq? again. 769981 5 174299 webkit.review.bot 2012-11-17 11:59:24 -0800 Comment on attachment 174299 Patch Clearing flags on attachment: 174299 Committed r135049: <http://trac.webkit.org/changeset/135049> 769982 6 webkit.review.bot 2012-11-17 11:59:27 -0800 All reviewed patches have been landed. Closing bug. 174299 2012-11-14 17:43:27 -0800 2012-11-17 11:59:24 -0800 Patch bug-102305-20121115094124.patch text/plain 2938 li.yin U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0Njk4CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZWY1YjVjMDc3NGY1MzU0MDBjNzEx ZGU1ZjUyZjkxZGM0ZTJlMjFkNC4uMzJmMWJhZjc3NjcwOWFiZTA5ZjdjMjgzMjgyYmU3N2I1NDQ1 NGY1MSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTExLTE0ICBMaSBZaW4gIDxsaS55aW5A aW50ZWwuY29tPgorCisgICAgICAgIGJpcXVhZGZpbHRlcm5vZGUtYmFzaWMuaHRtbCB0ZXN0IHNo b3VsZCBjb3ZlciBkZWZhdWx0IHZhbHVlIG9mIGZyZXF1ZW5jeSwgUSBhbmQgZ2Fpbi4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMjMwNQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNwZWM6IGh0dHBzOi8v ZHZjcy53My5vcmcvaGcvYXVkaW8vcmF3LWZpbGUvdGlwL3dlYmF1ZGlvL3NwZWNpZmljYXRpb24u aHRtbCNCaXF1YWRGaWx0ZXJOb2RlCisgICAgICAgIFRoZSBkZWZhdWx0IHZhbHVlcyBvZiBmcmVx dWVuY3ksIFEgYW5kIGdhaW4gYXJlIGNsZWFybHkgc3BlY2lmaWVkLCB3ZSBzaG91bGQKKyAgICAg ICAgaGF2ZSByZWxhdGVkIHN1YiB0ZXN0IHRvIG92ZXIgdGhlbS4KKworICAgICAgICAqIHdlYmF1 ZGlvL2JpcXVhZGZpbHRlcm5vZGUtYmFzaWMtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIHdlYmF1 ZGlvL2JpcXVhZGZpbHRlcm5vZGUtYmFzaWMuaHRtbDoKKwogMjAxMi0xMS0xNCAgRmlsaXAgUGl6 bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIFJlYWQtb25seSBwcm9wZXJ0aWVzIGNy ZWF0ZWQgd2l0aCBwdXREaXJlY3QoKSBzaG91bGQgdGVsbCB0aGUgc3RydWN0dXJlIHRoYXQgdGhl cmUgYXJlIHJlYWQtb25seSBwcm9wZXJ0aWVzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy93ZWJh dWRpby9iaXF1YWRmaWx0ZXJub2RlLWJhc2ljLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL3dl YmF1ZGlvL2JpcXVhZGZpbHRlcm5vZGUtYmFzaWMtZXhwZWN0ZWQudHh0CmluZGV4IDcwMWZlY2Zk ODVkNjdmOGM1NTc1ZGFjYjg0YzUxZDI4NWM0Mzk3YWYuLjkyNTFmMDA1ZWU0NTE1NjU3NmIxOGJj MDliNzJjMGJlOGRlYjMxZTIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3dlYmF1ZGlvL2JpcXVh ZGZpbHRlcm5vZGUtYmFzaWMtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL3dlYmF1ZGlv L2JpcXVhZGZpbHRlcm5vZGUtYmFzaWMtZXhwZWN0ZWQudHh0CkBAIC01LDYgKzUsOSBAQCBPbiBz dWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dl ZCBieSAiVEVTVCBDT01QTEVURQogUEFTUyBCaXF1YWRGaWx0ZXJOb2RlIGhhcyBvbmUgaXV0cHV0 LgogUEFTUyBCaXF1YWRGaWx0ZXJOb2RlIGhhcyBvbmUgb3V0cHV0LgogUEFTUyBCaXF1YWQgZmls dGVyIGRlZmF1bHRzIHRvIGxvdy1wYXNzIGZpbHRlci4KK1BBU1MgVGhlIGRlZmF1bHQgdmFsdWUg b2YgZnJlcXVlbmN5IGlzIDM1MC4KK1BBU1MgVGhlIGRlZmF1bHQgdmFsdWUgb2YgUSBpcyAxLgor UEFTUyBUaGUgZGVmYXVsdCB2YWx1ZSBvZiBnYWluIGlzIDAuCiBQQVNTIEJpcXVhZCBmaWx0ZXIg dHlwZSAwIGlzIHNldHRhYmxlLgogUEFTUyBCaXF1YWQgZmlsdGVyIHR5cGUgMSBpcyBzZXR0YWJs ZS4KIFBBU1MgQmlxdWFkIGZpbHRlciB0eXBlIDIgaXMgc2V0dGFibGUuCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy93ZWJhdWRpby9iaXF1YWRmaWx0ZXJub2RlLWJhc2ljLmh0bWwgYi9MYXlvdXRU ZXN0cy93ZWJhdWRpby9iaXF1YWRmaWx0ZXJub2RlLWJhc2ljLmh0bWwKaW5kZXggNjBlM2MxNDYw MzE1MzA4Mzk5NzU3ZWEyMzBhYTZkY2NlNzgwMWFmNi4uMzY3ZmMwODM4MWZlYmRiMzVhYmY3NGVj NWYxNTc3MGRlOTc5ZWI1ZiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvd2ViYXVkaW8vYmlxdWFk ZmlsdGVybm9kZS1iYXNpYy5odG1sCisrKyBiL0xheW91dFRlc3RzL3dlYmF1ZGlvL2JpcXVhZGZp bHRlcm5vZGUtYmFzaWMuaHRtbApAQCAtMzksNiArMzksMjEgQEAgZnVuY3Rpb24gcnVuVGVzdCgp IHsKICAgICAgICAgdGVzdFBhc3NlZCgiQmlxdWFkIGZpbHRlciBkZWZhdWx0cyB0byBsb3ctcGFz cyBmaWx0ZXIuIik7CiAgICAgZWxzZQogICAgICAgICB0ZXN0RmFpbGVkKCJCaXF1YWQgZmlsdGVy IHNob3VsZCBkZWZhdWx0IHRvIGxvdy1wYXNzIGZpbHRlci4iKTsKKyAgICAKKyAgICBpZiAoZmls dGVyLmZyZXF1ZW5jeS52YWx1ZSA9PT0gMzUwKQorICAgICAgICB0ZXN0UGFzc2VkKCJUaGUgZGVm YXVsdCB2YWx1ZSBvZiBmcmVxdWVuY3kgaXMgMzUwLiIpOworICAgIGVsc2UKKyAgICAgICAgdGVz dEZhaWxlZCgiVGhlIGRlZmF1bHQgdmFsdWUgb2YgZnJlcXVlbmN5IHNob3VsZCBiZSAzNTAuIik7 CisgICAgCisgICAgaWYgKGZpbHRlci5RLnZhbHVlID09PSAxKQorICAgICAgICB0ZXN0UGFzc2Vk KCJUaGUgZGVmYXVsdCB2YWx1ZSBvZiBRIGlzIDEuIik7CisgICAgZWxzZQorICAgICAgICB0ZXN0 RmFpbGVkKCJUaGUgZGVmYXVsdCB2YWx1ZSBvZiBRIHNob3VsZCBiZSAxLiIpOworICAgIAorICAg IGlmIChmaWx0ZXIuZ2Fpbi52YWx1ZSA9PT0gMCkKKyAgICAgICAgdGVzdFBhc3NlZCgiVGhlIGRl ZmF1bHQgdmFsdWUgb2YgZ2FpbiBpcyAwLiIpOworICAgIGVsc2UKKyAgICAgICAgdGVzdEZhaWxl ZCgiVGhlIGRlZmF1bHQgdmFsdWUgb2YgZ2FpbiBzaG91bGQgYmUgMC4iKTsKIAogICAgIC8vIENo ZWNrIHRoYXQgYWxsIGxlZ2FsIGZpbHRlciB0eXBlcyBjYW4gYmUgc2V0LgogICAgIHZhciBmaWx0 ZXJUeXBlQXJyYXkgPSBbZmlsdGVyLkxPV1BBU1MsCg==