102303 2012-11-14 17:00:06 -0800 [CSS3] Move CSSPropertyWebkitTextAlignLast into isValidKeywordPropertyAndValue function. 2012-11-19 03:30:02 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dw.im dw.im cmarcelo macpherson menard webkit.review.bot oldest_to_newest 767482 0 dw.im 2012-11-14 17:00:06 -0800 Regarding the comment from darktears (https://bugs.webkit.org/show_bug.cgi?id=100058#c2), I'll move CSSPropertyWebkitTextAlignLast into isValidKeywordPropertyAndValue function like the same kind of properties.. This will help speed wise in JS. 767519 1 174297 dw.im 2012-11-14 17:40:18 -0800 Created attachment 174297 Patch 770556 2 174297 webkit.review.bot 2012-11-19 03:29:59 -0800 Comment on attachment 174297 Patch Clearing flags on attachment: 174297 Committed r135136: <http://trac.webkit.org/changeset/135136> 770557 3 webkit.review.bot 2012-11-19 03:30:02 -0800 All reviewed patches have been landed. Closing bug. 174297 2012-11-14 17:40:18 -0800 2012-11-19 03:29:57 -0800 Patch bug-102303-20121115103816.patch text/plain 3458 dw.im U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0Njk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGMxMWYwYWU1Yzc4YzZh MmQ0NDdlYTM5MjA4OTM2NTE2ODBlZjYzZi4uN2M4MmFjMzJmYmRiY2VkZDcwNmUwNjcwMjdmY2I5 MDA1ZWE4MjNlMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTExLTE0ICBEb25n d29vIEpvc2h1YSBJbSAgPGR3LmltQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtDU1MzXSBNb3Zl IENTU1Byb3BlcnR5V2Via2l0VGV4dEFsaWduTGFzdCBpbnRvIGlzVmFsaWRLZXl3b3JkUHJvcGVy dHlBbmRWYWx1ZSBmdW5jdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTAyMzAzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgTW92ZSB0aGUgcGFydCB3aGljaCBjaGVjayB3aGV0aGVyIENTU1Byb3BlcnR5 V2Via2l0VGV4dEFsaWduTGFzdCBoYXMgYXZhaWxhYmxlIHZhbHVlCisgICAgICAgIGludG8gdGhl IGlzVmFsaWRLZXl3b3JkUHJvcGVydHlBbmRWYWx1ZSBmdW5jdGlvbiwgbGlrZSB0aGUgc2FtZSBr aW5kIG9mIHByb3BlcnRpZXMuCisgICAgICAgIFRoaXMgd2lsbCBoZWxwIHNwZWVkIHdpc2UgaW4g SlMuCisKKyAgICAgICAgTm8gbmV3IGZ1bmN0aW9uYWxpdHksIG5vIG5ldyB0ZXN0cy4KKworICAg ICAgICAqIGNzcy9DU1NQYXJzZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6aXNWYWxpZEtleXdv cmRQcm9wZXJ0eUFuZFZhbHVlKToKKyAgICAgICAgKFdlYkNvcmU6OmlzS2V5d29yZFByb3BlcnR5 SUQpOgorICAgICAgICAoV2ViQ29yZTo6Q1NTUGFyc2VyOjpwYXJzZVZhbHVlKToKKwogMjAxMi0x MS0xNCAgRGFuIENhcm5leSAgPGRjYXJuZXlAZ29vZ2xlLmNvbT4KIAogICAgICAgICBbVjhdIFJl bmFtZSBkaXNwYXRjaFdyYXAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJz ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAKaW5kZXggMDZlZjU0Mzg1 YTdlZGU3NGNlYWJhNmIwNzgxMmJiYTVmYTgyMTIzNC4uYjZiY2UyNmE5NWM0YjQzNzZhNDYzMzk4 NTExZmRkMDQ2YTE2NGFhOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNl ci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAKQEAgLTg4NSw2ICs4 ODUsMTMgQEAgc3RhdGljIGlubGluZSBib29sIGlzVmFsaWRLZXl3b3JkUHJvcGVydHlBbmRWYWx1 ZShDU1NQcm9wZXJ0eUlEIHByb3BlcnR5SWQsIGludAogICAgICAgICBpZiAodmFsdWVJRCA9PSBD U1NWYWx1ZUxvZ2ljYWwgfHwgdmFsdWVJRCA9PSBDU1NWYWx1ZVZpc3VhbCkKICAgICAgICAgICAg IHJldHVybiB0cnVlOwogICAgICAgICBicmVhazsKKyNpZiBFTkFCTEUoQ1NTM19URVhUKQorICAg IGNhc2UgQ1NTUHJvcGVydHlXZWJraXRUZXh0QWxpZ25MYXN0OgorICAgICAgICAvLyBhdXRvIHwg c3RhcnQgfCBlbmQgfCBsZWZ0IHwgcmlnaHQgfCBjZW50ZXIgfCBqdXN0aWZ5CisgICAgICAgIGlm ICgodmFsdWVJRCA+PSBDU1NWYWx1ZUxlZnQgJiYgdmFsdWVJRCA8PSBDU1NWYWx1ZUp1c3RpZnkp IHx8IHZhbHVlSUQgPT0gQ1NTVmFsdWVTdGFydCB8fCB2YWx1ZUlEID09IENTU1ZhbHVlRW5kIHx8 IHZhbHVlSUQgPT0gQ1NTVmFsdWVBdXRvKQorICAgICAgICAgICAgcmV0dXJuIHRydWU7CisgICAg ICAgIGJyZWFrOworI2VuZGlmIC8vIENTUzNfVEVYVAogICAgIGNhc2UgQ1NTUHJvcGVydHlXZWJr aXRUZXh0Q29tYmluZToKICAgICAgICAgaWYgKHZhbHVlSUQgPT0gQ1NTVmFsdWVOb25lIHx8IHZh bHVlSUQgPT0gQ1NTVmFsdWVIb3Jpem9udGFsKQogICAgICAgICAgICAgcmV0dXJuIHRydWU7CkBA IC0xMDQ1LDYgKzEwNTIsOSBAQCBzdGF0aWMgaW5saW5lIGJvb2wgaXNLZXl3b3JkUHJvcGVydHlJ RChDU1NQcm9wZXJ0eUlEIHByb3BlcnR5SWQpCiAgICAgY2FzZSBDU1NQcm9wZXJ0eVdlYmtpdFJl Z2lvbk92ZXJmbG93OgogI2VuZGlmCiAgICAgY2FzZSBDU1NQcm9wZXJ0eVdlYmtpdFJ0bE9yZGVy aW5nOgorI2lmIEVOQUJMRShDU1MzX1RFWFQpCisgICAgY2FzZSBDU1NQcm9wZXJ0eVdlYmtpdFRl eHRBbGlnbkxhc3Q6CisjZW5kaWYgLy8gQ1NTM19URVhUCiAgICAgY2FzZSBDU1NQcm9wZXJ0eVdl YmtpdFRleHRDb21iaW5lOgogICAgIGNhc2UgQ1NTUHJvcGVydHlXZWJraXRUZXh0RW1waGFzaXNQ b3NpdGlvbjoKICAgICBjYXNlIENTU1Byb3BlcnR5V2Via2l0VGV4dFNlY3VyaXR5OgpAQCAtMTg1 OCwxNCArMTg2OCw2IEBAIGJvb2wgQ1NTUGFyc2VyOjpwYXJzZVZhbHVlKENTU1Byb3BlcnR5SUQg cHJvcElkLCBib29sIGltcG9ydGFudCkKICAgICAgICAgfQogICAgICAgICBicmVhazsKIAotI2lm IEVOQUJMRShDU1MzX1RFWFQpCi0gICAgY2FzZSBDU1NQcm9wZXJ0eVdlYmtpdFRleHRBbGlnbkxh c3Q6Ci0gICAgICAgIC8vIGF1dG8gfCBzdGFydCB8IGVuZCB8IGxlZnQgfCByaWdodCB8IGNlbnRl ciB8IGp1c3RpZnkKLSAgICAgICAgaWYgKChpZCA+PSBDU1NWYWx1ZUxlZnQgJiYgaWQgPD0gQ1NT VmFsdWVKdXN0aWZ5KSB8fCBpZCA9PSBDU1NWYWx1ZVN0YXJ0IHx8IGlkID09IENTU1ZhbHVlRW5k IHx8IGlkID09IENTU1ZhbHVlQXV0bykKLSAgICAgICAgICAgIHZhbGlkUHJpbWl0aXZlID0gdHJ1 ZTsKLSAgICAgICAgYnJlYWs7Ci0jZW5kaWYgLy8gQ1NTM19URVhUCi0KICAgICBjYXNlIENTU1By b3BlcnR5Q3Vyc29yOiB7CiAgICAgICAgIC8vIFs8dXJpPixdKiAgWyBhdXRvIHwgY3Jvc3NoYWly IHwgZGVmYXVsdCB8IHBvaW50ZXIgfCBwcm9ncmVzcyB8IG1vdmUgfCBlLXJlc2l6ZSB8IG5lLXJl c2l6ZSB8CiAgICAgICAgIC8vIG53LXJlc2l6ZSB8IG4tcmVzaXplIHwgc2UtcmVzaXplIHwgc3ct cmVzaXplIHwgcy1yZXNpemUgfCB3LXJlc2l6ZSB8IGV3LXJlc2l6ZSB8CkBAIC0yODQ0LDYgKzI4 NDYsOSBAQCBib29sIENTU1BhcnNlcjo6cGFyc2VWYWx1ZShDU1NQcm9wZXJ0eUlEIHByb3BJZCwg Ym9vbCBpbXBvcnRhbnQpCiAgICAgY2FzZSBDU1NQcm9wZXJ0eVdlYmtpdFJlZ2lvbk92ZXJmbG93 OgogI2VuZGlmCiAgICAgY2FzZSBDU1NQcm9wZXJ0eVdlYmtpdFJ0bE9yZGVyaW5nOgorI2lmIEVO QUJMRShDU1MzX1RFWFQpCisgICAgY2FzZSBDU1NQcm9wZXJ0eVdlYmtpdFRleHRBbGlnbkxhc3Q6 CisjZW5kaWYgLy8gQ1NTM19URVhUCiAgICAgY2FzZSBDU1NQcm9wZXJ0eVdlYmtpdFRleHRDb21i aW5lOgogICAgIGNhc2UgQ1NTUHJvcGVydHlXZWJraXRUZXh0RW1waGFzaXNQb3NpdGlvbjoKICAg ICBjYXNlIENTU1Byb3BlcnR5V2Via2l0VGV4dFNlY3VyaXR5Ogo=