102297 2012-11-14 16:19:41 -0800 [V8] We can shave one instruction off toV8Fast 2012-11-14 22:11:52 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth dcarney eric haraken japhet webkit.review.bot oldest_to_newest 767424 0 abarth 2012-11-14 16:19:41 -0800 [V8] We can shave one instruction off toV8Fast 767425 1 174281 abarth 2012-11-14 16:21:16 -0800 Created attachment 174281 Patch 767433 2 174281 haraken 2012-11-14 16:24:44 -0800 Comment on attachment 174281 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174281&action=review > Source/WebCore/ChangeLog:8 > + There's no reason to store info.Holder in a local variable. Calling Just in case, would you check the performance in Bindings/first-child.html ? In the DOM binding benchmark suite in v8-internal (which is a super micro benchmark), info.Holder() is not free. 767435 3 abarth 2012-11-14 16:28:29 -0800 (In reply to comment #2) > (From update of attachment 174281 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=174281&action=review > > > Source/WebCore/ChangeLog:8 > > + There's no reason to store info.Holder in a local variable. Calling > > Just in case, would you check the performance in Bindings/first-child.html ? In the DOM binding benchmark suite in v8-internal (which is a super micro benchmark), info.Holder() is not free. Sure, I'm happy to check it. In this case, when we call info.Holder() a second time, we're actually going to call an out-of-line function that allocates a bunch of memory, etc, etc. I probably should have said that it's free compared to those operations. :) 767601 4 abarth 2012-11-14 19:01:19 -0800 I looked at Bindings/first-child.html. That doesn't actually execute the instruction that changed (since it always finds the wrapper). 767602 5 174318 abarth 2012-11-14 19:01:45 -0800 Created attachment 174318 Patch for landing 767604 6 174318 haraken 2012-11-14 19:02:29 -0800 Comment on attachment 174318 Patch for landing Ah, makes sense. Your change just changes a slow path. Thanks. 767629 7 174318 webkit.review.bot 2012-11-14 19:41:54 -0800 Comment on attachment 174318 Patch for landing Clearing flags on attachment: 174318 Committed r134729: <http://trac.webkit.org/changeset/134729> 767630 8 webkit.review.bot 2012-11-14 19:41:58 -0800 All reviewed patches have been landed. Closing bug. 767723 9 haraken 2012-11-14 22:11:52 -0800 Updated run-bindings-tests results in r134738. 174281 2012-11-14 16:21:16 -0800 2012-11-14 19:01:41 -0800 Patch bug-102297-20121114161914.patch text/plain 3876 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0NjQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmM0NzFlMGQ4Y2IyZjY3 MDgzYTM0NmQ4ZjVhN2M5ZGU5ZTBlMDU1NS4uNmY1ODg1NDdkODMzOTk4NmVhNTdiMTI2ZjczZWQ0 NmViODI2NDljNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTExLTE0ICBBZGFt IEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAgICAgICAgW1Y4XSBXZSBjYW4gc2hhdmUg b25lIGluc3RydWN0aW9uIG9mZiB0b1Y4RmFzdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAyMjk3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgVGhlcmUncyBubyByZWFzb24gdG8gc3RvcmUgaW5mby5Ib2xk ZXIgaW4gYSBsb2NhbCB2YXJpYWJsZS4gQ2FsbGluZworICAgICAgICBIb2xkZXIoKSBpcyBlc3Nl bnRpYWxseSBmcmVlIGJlY2F1c2UgaXQncyBpbmxpbmVkIHRvIGFuIG9mZnNldCByZWFkLgorCisg ICAgICAgIEkgZG91YnQgdGhpcyBwYXRjaCBtb3ZlcyB0aGUgcGVyZm9ybWFuY2UgbmVlZGxlIGlu IGFueSBtZWFzdXJhYmxlIHdheSwKKyAgICAgICAgYnV0IGl0IG1ha2VzIHRoZSBjb2RlIHNsaWdo dGx5IHByZXR0aWVyLgorCisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9y VjgucG06CisgICAgICAgIChHZW5lcmF0ZUhlYWRlcik6CisgICAgICAgICogYmluZGluZ3Mvc2Ny aXB0cy90ZXN0L1Y4L1Y4VGVzdE5vZGUuaDoKKyAgICAgICAgKFdlYkNvcmU6OnRvVjhGYXN0KToK KwogMjAxMi0xMS0xNCAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAog ICAgICAgICBEb24ndCBwYXNzIGEgcGFpbnRpbmdSb290IHdoZW4gcGFpbnRpbmcgZnJvbSBSZW5k ZXJMYXllckJhY2tpbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Njcmlw dHMvQ29kZUdlbmVyYXRvclY4LnBtIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9D b2RlR2VuZXJhdG9yVjgucG0KaW5kZXggYjJjZWEyY2YwN2I2MmMyZWE3ZTZjODJiY2QyNWM2NDYw N2EwYzYwZi4uYzQ3MTYwMjM0ZTdkMmU5NTQ1NjgwM2E0NGExOGU5MjJiNzg2MDQ2YSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0K KysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0K QEAgLTU5NSwxNyArNTk1LDEwIEBAIGlubGluZSB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gdG9WOEZh c3QoJHtuYXRpdmVUeXBlfSogaW1wbCwgY29uc3Qgdjg6OkFjY2Vzc29ySW5mCiAgICAgLy8gaW4g YW4gaXNvbGF0ZWQgd29ybGQuIFRoZSBmYXN0ZXN0IHdheSB3ZSBrbm93IGhvdyB0byBkbyB0aGF0 IGlzIHRvIGNoZWNrCiAgICAgLy8gd2hldGhlciB0aGUgaG9sZGVyJ3MgaW5saW5lIHdyYXBwZXIg aXMgdGhlIHNhbWUgd3JhcHBlciB3ZSBzZWUgaW4gdGhlCiAgICAgLy8gdjg6OkFjY2Vzc29ySW5m by4KLSAgICB2ODo6SGFuZGxlPHY4OjpPYmplY3Q+IGhvbGRlcldyYXBwZXIgPSBpbmZvLkhvbGRl cigpOwotICAgIGlmIChob2xkZXItPndyYXBwZXIoKSA9PSBob2xkZXJXcmFwcGVyKSB7Ci0gICAg ICAgIHY4OjpIYW5kbGU8djg6Ok9iamVjdD4gd3JhcHBlciA9IGltcGwtPndyYXBwZXIoKTsKLSAg ICAgICAgaWYgKCF3cmFwcGVyLklzRW1wdHkoKSkKLSAgICAgICAgICAgIHJldHVybiB3cmFwcGVy OwotICAgIH0gZWxzZSB7Ci0gICAgICAgIHY4OjpIYW5kbGU8djg6Ok9iamVjdD4gd3JhcHBlciA9 IFY4RE9NV3JhcHBlcjo6Z2V0Q2FjaGVkV3JhcHBlcihpbXBsKTsKLSAgICAgICAgaWYgKCF3cmFw cGVyLklzRW1wdHkoKSkKLSAgICAgICAgICAgIHJldHVybiB3cmFwcGVyOwotICAgIH0KLSAgICBy ZXR1cm4gZGlzcGF0Y2hXcmFwKGltcGwsIGhvbGRlcldyYXBwZXIsIGluZm8uR2V0SXNvbGF0ZSgp KTsKKyAgICB2ODo6SGFuZGxlPHY4OjpPYmplY3Q+IHdyYXBwZXIgPSAoaG9sZGVyLT53cmFwcGVy KCkgPT0gaW5mby5Ib2xkZXIoKSkgPyBpbXBsLT53cmFwcGVyKCkgOiBWOERPTVdyYXBwZXI6Omdl dENhY2hlZFdyYXBwZXIoaW1wbCk7CisgICAgaWYgKCF3cmFwcGVyLklzRW1wdHkoKSkKKyAgICAg ICAgcmV0dXJuIHdyYXBwZXI7CisgICAgcmV0dXJuIGRpc3BhdGNoV3JhcChpbXBsLCBpbmZvLkhv bGRlcigpLCBpbmZvLkdldElzb2xhdGUoKSk7CiB9CiBFTkQKICAgICAgICAgfQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L1Y4L1Y4VGVzdE5vZGUuaCBi L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9WOC9WOFRlc3ROb2RlLmgKaW5k ZXggNzliOThjNzZhOTA2Mjk4MDQyOTRkZDM2YzU5ZmJhY2I2YWIwY2RlYS4uMmI4ODA2YzgwNzcz MDBjMDZhYTdhNDFmMWE2MzJmZjY4Y2UwNWQ1ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv YmluZGluZ3Mvc2NyaXB0cy90ZXN0L1Y4L1Y4VGVzdE5vZGUuaAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvVjgvVjhUZXN0Tm9kZS5oCkBAIC04OSwxNyArODksMTAg QEAgaW5saW5lIHY4OjpIYW5kbGU8djg6OlZhbHVlPiB0b1Y4RmFzdChUZXN0Tm9kZSogaW1wbCwg Y29uc3Qgdjg6OkFjY2Vzc29ySW5mbyYgaW4KICAgICAvLyBpbiBhbiBpc29sYXRlZCB3b3JsZC4g VGhlIGZhc3Rlc3Qgd2F5IHdlIGtub3cgaG93IHRvIGRvIHRoYXQgaXMgdG8gY2hlY2sKICAgICAv LyB3aGV0aGVyIHRoZSBob2xkZXIncyBpbmxpbmUgd3JhcHBlciBpcyB0aGUgc2FtZSB3cmFwcGVy IHdlIHNlZSBpbiB0aGUKICAgICAvLyB2ODo6QWNjZXNzb3JJbmZvLgotICAgIHY4OjpIYW5kbGU8 djg6Ok9iamVjdD4gaG9sZGVyV3JhcHBlciA9IGluZm8uSG9sZGVyKCk7Ci0gICAgaWYgKGhvbGRl ci0+d3JhcHBlcigpID09IGhvbGRlcldyYXBwZXIpIHsKLSAgICAgICAgdjg6OkhhbmRsZTx2ODo6 T2JqZWN0PiB3cmFwcGVyID0gaW1wbC0+d3JhcHBlcigpOwotICAgICAgICBpZiAoIXdyYXBwZXIu SXNFbXB0eSgpKQotICAgICAgICAgICAgcmV0dXJuIHdyYXBwZXI7Ci0gICAgfSBlbHNlIHsKLSAg ICAgICAgdjg6OkhhbmRsZTx2ODo6T2JqZWN0PiB3cmFwcGVyID0gVjhET01XcmFwcGVyOjpnZXRD YWNoZWRXcmFwcGVyKGltcGwpOwotICAgICAgICBpZiAoIXdyYXBwZXIuSXNFbXB0eSgpKQotICAg ICAgICAgICAgcmV0dXJuIHdyYXBwZXI7Ci0gICAgfQotICAgIHJldHVybiBkaXNwYXRjaFdyYXAo aW1wbCwgaG9sZGVyV3JhcHBlciwgaW5mby5HZXRJc29sYXRlKCkpOworICAgIHY4OjpIYW5kbGU8 djg6Ok9iamVjdD4gd3JhcHBlciA9IChob2xkZXItPndyYXBwZXIoKSA9PSBpbmZvLkhvbGRlcigp KSA/IGltcGwtPndyYXBwZXIoKSA6IFY4RE9NV3JhcHBlcjo6Z2V0Q2FjaGVkV3JhcHBlcihpbXBs KTsKKyAgICBpZiAoIXdyYXBwZXIuSXNFbXB0eSgpKQorICAgICAgICByZXR1cm4gd3JhcHBlcjsK KyAgICByZXR1cm4gZGlzcGF0Y2hXcmFwKGltcGwsIGluZm8uSG9sZGVyKCksIGluZm8uR2V0SXNv bGF0ZSgpKTsKIH0KIAogaW5saW5lIHY4OjpIYW5kbGU8djg6OlZhbHVlPiB0b1Y4KFBhc3NSZWZQ dHI8IFRlc3ROb2RlID4gaW1wbCwgdjg6OkhhbmRsZTx2ODo6T2JqZWN0PiBjcmVhdGlvbkNvbnRl eHQgPSB2ODo6SGFuZGxlPHY4OjpPYmplY3Q+KCksIHY4OjpJc29sYXRlKiBpc29sYXRlID0gMCkK 174318 2012-11-14 19:01:45 -0800 2012-11-14 19:41:54 -0800 Patch for landing bug-102297-20121114185943.patch text/plain 2349 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0NzIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGNiY2U2YzQyZmZiMjhm N2M2Y2MwN2NkYWY2ODFiY2VhM2RlYWZkMy4uM2FkNzFiOTQ2NjUwNDEyOWE0YzQxZDAxZjA5M2Yy MTliMDNiYzY4YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTExLTE0ICBBZGFt IEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAgICAgICAgW1Y4XSBXZSBjYW4gc2hhdmUg b25lIGluc3RydWN0aW9uIG9mZiB0b1Y4RmFzdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAyMjk3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgS2VudGFy byBIYXJhLgorCisgICAgICAgIFRoZXJlJ3Mgbm8gcmVhc29uIHRvIHN0b3JlIGluZm8uSG9sZGVy IGluIGEgbG9jYWwgdmFyaWFibGUuIENhbGxpbmcKKyAgICAgICAgSG9sZGVyKCkgaXMgZXNzZW50 aWFsbHkgZnJlZSBiZWNhdXNlIGl0J3MgaW5saW5lZCB0byBhbiBvZmZzZXQgcmVhZC4KKworICAg ICAgICBJIGRvdWJ0IHRoaXMgcGF0Y2ggbW92ZXMgdGhlIHBlcmZvcm1hbmNlIG5lZWRsZSBpbiBh bnkgbWVhc3VyYWJsZSB3YXksCisgICAgICAgIGJ1dCBpdCBtYWtlcyB0aGUgY29kZSBzbGlnaHRs eSBwcmV0dGllci4KKworICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4 LnBtOgorICAgICAgICAoR2VuZXJhdGVIZWFkZXIpOgorICAgICAgICAqIGJpbmRpbmdzL3Njcmlw dHMvdGVzdC9WOC9WOFRlc3ROb2RlLmg6CisgICAgICAgIChXZWJDb3JlOjp0b1Y4RmFzdCk6CisK IDIwMTItMTEtMTQgIEVyaWsgQXJ2aWRzc29uICA8YXJ2QGNocm9taXVtLm9yZz4KIAogICAgICAg ICBVcGRhdGUgRE9NRXhjZXB0aW9uIG5hbWU6IEludmFsaWRNb2RpZmljYXRpb25FcnJvcgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgu cG0gYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQpp bmRleCBkMTI5ZTg5MDdjOWY0MWM3NjI5NmM5MDc1M2I5MTNkNDc3OWE4NWIxLi4yMjFlYWJkMGE5 MGM5YWU2MDJiNTQwN2E2NGI4ZGY0MDMwNWE2OWFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQorKysgYi9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQpAQCAtNjA0LDE3ICs2MDQsMTAg QEAgaW5saW5lIHY4OjpIYW5kbGU8djg6OlZhbHVlPiB0b1Y4RmFzdCgke25hdGl2ZVR5cGV9KiBp bXBsLCBjb25zdCB2ODo6QWNjZXNzb3JJbmYKICAgICAvLyBpbiBhbiBpc29sYXRlZCB3b3JsZC4g VGhlIGZhc3Rlc3Qgd2F5IHdlIGtub3cgaG93IHRvIGRvIHRoYXQgaXMgdG8gY2hlY2sKICAgICAv LyB3aGV0aGVyIHRoZSBob2xkZXIncyBpbmxpbmUgd3JhcHBlciBpcyB0aGUgc2FtZSB3cmFwcGVy IHdlIHNlZSBpbiB0aGUKICAgICAvLyB2ODo6QWNjZXNzb3JJbmZvLgotICAgIHY4OjpIYW5kbGU8 djg6Ok9iamVjdD4gaG9sZGVyV3JhcHBlciA9IGluZm8uSG9sZGVyKCk7Ci0gICAgaWYgKGhvbGRl ci0+d3JhcHBlcigpID09IGhvbGRlcldyYXBwZXIpIHsKLSAgICAgICAgdjg6OkhhbmRsZTx2ODo6 T2JqZWN0PiB3cmFwcGVyID0gaW1wbC0+d3JhcHBlcigpOwotICAgICAgICBpZiAoIXdyYXBwZXIu SXNFbXB0eSgpKQotICAgICAgICAgICAgcmV0dXJuIHdyYXBwZXI7Ci0gICAgfSBlbHNlIHsKLSAg ICAgICAgdjg6OkhhbmRsZTx2ODo6T2JqZWN0PiB3cmFwcGVyID0gVjhET01XcmFwcGVyOjpnZXRD YWNoZWRXcmFwcGVyKGltcGwpOwotICAgICAgICBpZiAoIXdyYXBwZXIuSXNFbXB0eSgpKQotICAg ICAgICAgICAgcmV0dXJuIHdyYXBwZXI7Ci0gICAgfQotICAgIHJldHVybiB3cmFwKGltcGwsIGhv bGRlcldyYXBwZXIsIGluZm8uR2V0SXNvbGF0ZSgpKTsKKyAgICB2ODo6SGFuZGxlPHY4OjpPYmpl Y3Q+IHdyYXBwZXIgPSAoaG9sZGVyLT53cmFwcGVyKCkgPT0gaW5mby5Ib2xkZXIoKSkgPyBpbXBs LT53cmFwcGVyKCkgOiBWOERPTVdyYXBwZXI6OmdldENhY2hlZFdyYXBwZXIoaW1wbCk7CisgICAg aWYgKCF3cmFwcGVyLklzRW1wdHkoKSkKKyAgICAgICAgcmV0dXJuIHdyYXBwZXI7CisgICAgcmV0 dXJuIHdyYXAoaW1wbCwgaW5mby5Ib2xkZXIoKSwgaW5mby5HZXRJc29sYXRlKCkpOwogfQogRU5E CiAgICAgICAgIH0K