102294 2012-11-14 15:37:30 -0800 Layout Test platform/chromium/virtual/deferred/fast/images/exif-orientation.html is failing 2012-11-27 17:48:54 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dglazkov jamesr danakj jamesr oldest_to_newest 767379 0 dglazkov 2012-11-14 15:37:30 -0800 The following layout test is failing on all platforms. platform/chromium/virtual/deferred/fast/images/exif-orientation.html Probable cause: http://src.chromium.org/viewvc/chrome?view=rev&revision=167750 767399 1 danakj 2012-11-14 15:53:31 -0800 I am seeing the exact same result locally with a debug DRT before my large chromium-side change, with WebKit DEPS at that time, vs trunk for chromium and WebKit. 767422 2 dglazkov 2012-11-14 16:18:20 -0800 Also platform/chromium/virtual/deferred/fast/images/gray-scale-jpeg-with-color-profile.html and platform/chromium/virtual/deferred/fast/images/exif-orientation-css.html 767426 3 danakj 2012-11-14 16:21:22 -0800 The scrollbar thumb is gone on mac? Are you seeing that in any other tests? 767441 4 dglazkov 2012-11-14 16:32:15 -0800 (In reply to comment #3) > The scrollbar thumb is gone on mac? Are you seeing that in any other tests? No. This stuff only started happening on virtual/deferred. 767447 5 danakj 2012-11-14 16:37:50 -0800 Hey check this out. -void Settings::setPerTilePaintingEnabled(bool enabled) -{ - if (!s_settingsInitialized) - reset(); - s_partialSwapEnabled = enabled; <---------------- partialSwap! -} Seems like per-tile was never on for those tests. Now it is, and they are broken because per-tile is broken. Should we turn off per-tile for the test suite? 767466 6 danakj 2012-11-14 16:50:47 -0800 Well.. It is my opinion that we should rebaseline the linux result, it seems harmless. And we can rebaseline, or mark as failing, the mac 10.6 ones, with a bug that the scrollbar thumbs disappear with per-tile painting. 767501 7 danakj 2012-11-14 17:14:29 -0800 I have filed bugs For EXIF orientation being broken on Mac with per-tile: http://code.google.com/p/chromium/issues/detail?id=161164 For missing scrollbar thumbs on Mac 10.6 with per-tile: http://code.google.com/p/chromium/issues/detail?id=161167&thanks=161167&ts=1352941830 I think what's left to do for this bug here is to decide to rebaseline or mark as failing these tests. Rebaseline Linux, Mark as failing Mac? What do you think James? 775145 8 jamesr 2012-11-25 22:13:08 -0800 (In reply to comment #7) > I have filed bugs > > For EXIF orientation being broken on Mac with per-tile: http://code.google.com/p/chromium/issues/detail?id=161164 > > For missing scrollbar thumbs on Mac 10.6 with per-tile: http://code.google.com/p/chromium/issues/detail?id=161167&thanks=161167&ts=1352941830 > > I think what's left to do for this bug here is to decide to rebaseline or mark as failing these tests. > > Rebaseline Linux, Mark as failing Mac? What do you think James? That sounds right. 777421 9 danakj 2012-11-27 17:48:54 -0800 Committed r135961: <http://trac.webkit.org/changeset/135961>