102280 2012-11-14 13:51:16 -0800 [BlackBerry] Leave surface resizing to the client 2012-11-15 09:03:11 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jpetsovits jpetsovits anilsson manyoso mifenton rwlbuis staikos tonikitoo webkit.review.bot oldest_to_newest 767261 0 jpetsovits 2012-11-14 13:51:16 -0800 Now that we always blit on the user interface thread and use the client's userInterfaceViewportAccessor() to determine the destination rectangle for blitting, changing the viewport size does not affect the window or target surface directly. The only way that blitted output is affected is through layout, scroll position or scale changes. None of these require us to synchronize with the UI thread to resize its target surface. The commit below simplifies setViewportSize() and removes a blocking message dispatch by simply offloading all surface resizing responsibilities to the client. This is safer, cleaner and easier. 767313 1 174262 jpetsovits 2012-11-14 14:22:04 -0800 Created attachment 174262 Patch 768124 2 174262 manyoso 2012-11-15 08:44:22 -0800 Comment on attachment 174262 Patch LGTM 768143 3 174262 webkit.review.bot 2012-11-15 09:03:07 -0800 Comment on attachment 174262 Patch Clearing flags on attachment: 174262 Committed r134782: <http://trac.webkit.org/changeset/134782> 768144 4 webkit.review.bot 2012-11-15 09:03:11 -0800 All reviewed patches have been landed. Closing bug. 174262 2012-11-14 14:22:04 -0800 2012-11-15 09:03:07 -0800 Patch bug-102280-20121114172000.patch text/plain 6693 jpetsovits U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0NjYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCA4MDgyMTk4NDIyMmNkY2JmNWZjNjcyOWZiZjA5YTNjN2IyN2YwZDQ0Li5hMmU4ZWExNDdl MGEwOWY5MGFhNmNiNGE2ZGUzYmRiNmJhZmNlYzU1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwzNSBAQAorMjAxMi0xMS0xNCAgSmFrb2IgUGV0c292aXRzICA8anBl dHNvdml0c0ByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBMZWF2ZSBzdXJmYWNlIHJl c2l6aW5nIHRvIHRoZSBjbGllbnQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMDIyODAKKyAgICAgICAgUklNIFBSIDIzNTAzNAorICAgICAgICBSSU0g UFIgMTYwNjE5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgTm93IHRoYXQgd2UgYWx3YXlzIGJsaXQgb24gdGhlIHVzZXIgaW50ZXJmYWNlIHRocmVhZCBh bmQKKyAgICAgICAgdXNlIHRoZSBjbGllbnQncyB1c2VySW50ZXJmYWNlVmlld3BvcnRBY2Nlc3Nv cigpIHRvIGRldGVybWluZQorICAgICAgICB0aGUgZGVzdGluYXRpb24gcmVjdGFuZ2xlIGZvciBi bGl0dGluZywgY2hhbmdpbmcgdGhlIHZpZXdwb3J0CisgICAgICAgIHNpemUgZG9lcyBub3QgYWZm ZWN0IHRoZSB3aW5kb3cgb3IgdGFyZ2V0IHN1cmZhY2UgZGlyZWN0bHkuCisgICAgICAgIFRoZSBv bmx5IHdheSB0aGF0IGJsaXR0ZWQgb3V0cHV0IGlzIGFmZmVjdGVkIGlzIHRocm91Z2gKKyAgICAg ICAgbGF5b3V0LCBzY3JvbGwgcG9zaXRpb24gb3Igc2NhbGUgY2hhbmdlcy4gTm9uZSBvZiB0aGVz ZQorICAgICAgICByZXF1aXJlIHVzIHRvIHN5bmNocm9uaXplIHdpdGggdGhlIFVJIHRocmVhZCB0 byByZXNpemUgaXRzCisgICAgICAgIHRhcmdldCBzdXJmYWNlLgorCisgICAgICAgIFRoaXMgY29t bWl0IHNpbXBsaWZpZXMgc2V0Vmlld3BvcnRTaXplKCkgYW5kIHJlbW92ZXMgYQorICAgICAgICBi bG9ja2luZyBtZXNzYWdlIGRpc3BhdGNoIGJ5IHNpbXBseSBvZmZsb2FkaW5nIGFsbCBzdXJmYWNl CisgICAgICAgIHJlc2l6aW5nIHJlc3BvbnNpYmlsaXRpZXMgdG8gdGhlIGNsaWVudC4gVGhpcyBp cyBzYWZlciwKKyAgICAgICAgY2xlYW5lciBhbmQgZWFzaWVyLgorCisgICAgICAgICogQXBpL1dl YlBhZ2UuY3BwOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpXZWJQYWdlUHJpdmF0ZTo6 V2ViUGFnZVByaXZhdGUpOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpXZWJQYWdlOjpz ZXRTY3JlZW5PcmllbnRhdGlvbik6CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OldlYlBh Z2VQcml2YXRlOjpzZXRWaWV3cG9ydFNpemUpOgorICAgICAgICAqIEFwaS9XZWJQYWdlLmg6Cisg ICAgICAgICogQXBpL1dlYlBhZ2VDbGllbnQuaDoKKyAgICAgICAgKiBBcGkvV2ViUGFnZV9wLmg6 CisgICAgICAgIChXZWJQYWdlUHJpdmF0ZSk6CisKIDIwMTItMTEtMTQgIFJvYiBCdWlzICA8cmJ1 aXNAcmltLmNvbT4KIAogICAgICAgICBbQmxhY2tCZXJyeV0gSW1wcm92ZSBkZWJ1ZyBmdW5jdGlv bmFsaXR5IGluIEZhdEZpbmdlcnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJy eS9BcGkvV2ViUGFnZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2Uu Y3BwCmluZGV4IDk3MmZlYjg5NTMzMDNiOTYzNGM1MjdlOTc0ZGQxMzdlYTY2MmEzNmQuLmYxZWMx ZTM0MDA1NWJhOGQwNjAyYTk3ZDcyNThmYTkzMDE5ODY0NmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFj a2JlcnJ5L0FwaS9XZWJQYWdlLmNwcApAQCAtNDE5LDcgKzQxOSw2IEBAIFdlYlBhZ2VQcml2YXRl OjpXZWJQYWdlUHJpdmF0ZShXZWJQYWdlKiB3ZWJQYWdlLCBXZWJQYWdlQ2xpZW50KiBjbGllbnQs IGNvbnN0IEluCiAgICAgLCBtX25lZWRzQ29tbWl0KGZhbHNlKQogICAgICwgbV9zdXNwZW5kUm9v dExheWVyQ29tbWl0KGZhbHNlKQogI2VuZGlmCi0gICAgLCBtX2hhc1BlbmRpbmdTdXJmYWNlU2l6 ZUNoYW5nZShmYWxzZSkKICAgICAsIG1fcGVuZGluZ09yaWVudGF0aW9uKC0xKQogICAgICwgbV9m dWxsc2NyZWVuVmlkZW9Ob2RlKDApCiAgICAgLCBtX2hhc0luUmVnaW9uU2Nyb2xsYWJsZUFyZWFz KGZhbHNlKQpAQCAtMzU1OCwxMiArMzU1Nyw2IEBAIHZvaWQgV2ViUGFnZVByaXZhdGU6OnNldFNj cmVlbk9yaWVudGF0aW9uKGludCBvcmllbnRhdGlvbikKIHZvaWQgV2ViUGFnZTo6c2V0U2NyZWVu T3JpZW50YXRpb24oaW50IG9yaWVudGF0aW9uKQogewogICAgIGQtPm1fcGVuZGluZ09yaWVudGF0 aW9uID0gb3JpZW50YXRpb247Ci0gICAgZC0+bV9oYXNQZW5kaW5nU3VyZmFjZVNpemVDaGFuZ2Ug PSB0cnVlOwotfQotCi12b2lkIFdlYlBhZ2U6OnNldEhhc1BlbmRpbmdTdXJmYWNlU2l6ZUNoYW5n ZSgpCi17Ci0gICAgZC0+bV9oYXNQZW5kaW5nU3VyZmFjZVNpemVDaGFuZ2UgPSB0cnVlOwogfQog CiB2b2lkIFdlYlBhZ2U6OmFwcGx5UGVuZGluZ09yaWVudGF0aW9uSWZOZWVkZWQoKQpAQCAtMzU3 MiwyNCArMzU2NSw5IEBAIHZvaWQgV2ViUGFnZTo6YXBwbHlQZW5kaW5nT3JpZW50YXRpb25JZk5l ZWRlZCgpCiAgICAgICAgIGQtPnNldFNjcmVlbk9yaWVudGF0aW9uKGQtPm1fcGVuZGluZ09yaWVu dGF0aW9uKTsKIH0KIAotdm9pZCBXZWJQYWdlUHJpdmF0ZTo6cmVzaXplU3VyZmFjZUlmTmVlZGVk KCkKLXsKLSAgICAvLyBUaGlzIGNhbGwgd2lsbCBjYXVzZSB0aGUgY2xpZW50IHRvIHJlYWxsb2Nh dGUgdGhlIHdpbmRvdyBidWZmZXIgdG8gbmV3IHNpemUsCi0gICAgLy8gd2hpY2ggbmVlZHMgdG8g YmUgc2VyaWFsaXplZCB3aXRoIHVzYWdlIG9mIHRoZSB3aW5kb3cgYnVmZmVyLiBBY2NvbXBsaXNo Ci0gICAgLy8gdGhpcyBieSBzZW5kaW5nIGEgc3luYyBtZXNzYWdlIHRvIHRoZSBjb21wb3NpdGlu ZyB0aHJlYWQuIEFsbCBvdGhlciB1c2FnZSBvZgotICAgIC8vIHRoZSB3aW5kb3cgYnVmZmVyIGhh cHBlbnMgb24gdGhlIGNvbXBvc2l0aW5nIHRocmVhZC4KLSAgICBpZiAoIVBsYXRmb3JtOjp1c2Vy SW50ZXJmYWNlVGhyZWFkTWVzc2FnZUNsaWVudCgpLT5pc0N1cnJlbnRUaHJlYWQoKSkgewotICAg ICAgICBQbGF0Zm9ybTo6dXNlckludGVyZmFjZVRocmVhZE1lc3NhZ2VDbGllbnQoKS0+ZGlzcGF0 Y2hTeW5jTWVzc2FnZSgKLSAgICAgICAgICAgIFBsYXRmb3JtOjpjcmVhdGVNZXRob2RDYWxsTWVz c2FnZSgmV2ViUGFnZVByaXZhdGU6OnJlc2l6ZVN1cmZhY2VJZk5lZWRlZCwgdGhpcykpOwotICAg ICAgICByZXR1cm47Ci0gICAgfQotCi0gICAgbV9jbGllbnQtPnJlc2l6ZVN1cmZhY2VJZk5lZWRl ZCgpOwotfQotCiB2b2lkIFdlYlBhZ2VQcml2YXRlOjpzZXRWaWV3cG9ydFNpemUoY29uc3QgSW50 U2l6ZSYgdHJhbnNmb3JtZWRBY3R1YWxWaXNpYmxlU2l6ZSwgYm9vbCBlbnN1cmVGb2N1c0VsZW1l bnRWaXNpYmxlKQogewotICAgIGlmIChtX3BlbmRpbmdPcmllbnRhdGlvbiA9PSAtMSAmJiAhbV9o YXNQZW5kaW5nU3VyZmFjZVNpemVDaGFuZ2UgJiYgdHJhbnNmb3JtZWRBY3R1YWxWaXNpYmxlU2l6 ZSA9PSB0aGlzLT50cmFuc2Zvcm1lZEFjdHVhbFZpc2libGVTaXplKCkpCisgICAgaWYgKG1fcGVu ZGluZ09yaWVudGF0aW9uID09IC0xICYmIHRyYW5zZm9ybWVkQWN0dWFsVmlzaWJsZVNpemUgPT0g dGhpcy0+dHJhbnNmb3JtZWRBY3R1YWxWaXNpYmxlU2l6ZSgpKQogICAgICAgICByZXR1cm47CiAK ICAgICAvLyBTdXNwZW5kIGFsbCBzY3JlZW4gdXBkYXRlcyB0byB0aGUgYmFja2luZ3N0b3JlIHRv IG1ha2Ugc3VyZSBuby1vbmUgdHJpZXMgdG8gYmxpdApAQCAtMzYwNiwxMSArMzU4NCw2IEBAIHZv aWQgV2ViUGFnZVByaXZhdGU6OnNldFZpZXdwb3J0U2l6ZShjb25zdCBJbnRTaXplJiB0cmFuc2Zv cm1lZEFjdHVhbFZpc2libGVTaXplCiAKICAgICBib29sIGhhc1BlbmRpbmdPcmllbnRhdGlvbiA9 IG1fcGVuZGluZ09yaWVudGF0aW9uICE9IC0xOwogCi0gICAgaWYgKG1faGFzUGVuZGluZ1N1cmZh Y2VTaXplQ2hhbmdlKSB7Ci0gICAgICAgIHJlc2l6ZVN1cmZhY2VJZk5lZWRlZCgpOwotICAgICAg ICBtX2hhc1BlbmRpbmdTdXJmYWNlU2l6ZUNoYW5nZSA9IGZhbHNlOwotICAgIH0KLQogICAgIC8v IFRoZSB3aW5kb3cgYnVmZmVycyBtaWdodCBoYXZlIGJlZW4gcmVjcmVhdGVkLCBjbGVhcmVkLCBt b3ZlZCwgZXRjLiwgc286CiAgICAgbV9iYWNraW5nU3RvcmUtPmQtPndpbmRvd0Zyb250QnVmZmVy U3RhdGUoKS0+Y2xlYXJCbGl0dGVkUmVnaW9uKCk7CiAgICAgbV9iYWNraW5nU3RvcmUtPmQtPndp bmRvd0JhY2tCdWZmZXJTdGF0ZSgpLT5jbGVhckJsaXR0ZWRSZWdpb24oKTsKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5oIGIvU291cmNlL1dlYktpdC9i bGFja2JlcnJ5L0FwaS9XZWJQYWdlLmgKaW5kZXggNDA2YmE0NTI1YzMwOGJkYmYzZDc0NjkzMGJm MDdiZWVlN2JmOWFiNy4uMmZhZTBjNThlOTY3MDgwNDQyZjhmNGU4YTBiMDQwMDMwMmYyOGUzYSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmgKKysrIGIv U291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmgKQEAgLTEzNSw3ICsxMzUsNiBA QCBwdWJsaWM6CiAgICAgYm9vbCBpc1Zpc2libGUoKSBjb25zdDsKIAogICAgIHZvaWQgc2V0U2Ny ZWVuT3JpZW50YXRpb24oaW50KTsKLSAgICB2b2lkIHNldEhhc1BlbmRpbmdTdXJmYWNlU2l6ZUNo YW5nZSgpOwogICAgIHZvaWQgYXBwbHlQZW5kaW5nT3JpZW50YXRpb25JZk5lZWRlZCgpOwogCiAg ICAgUGxhdGZvcm06OlZpZXdwb3J0QWNjZXNzb3IqIHdlYmtpdFRocmVhZFZpZXdwb3J0QWNjZXNz b3IoKSBjb25zdDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2Vi UGFnZUNsaWVudC5oIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlQ2xpZW50 LmgKaW5kZXggODM1NzRjNjUxOTQ3ODk4MDRhNzNkMmJjMmM0NWFiNGVmMTY4NjVmYS4uNjkwMzVi YTFmMDk5OGQ0YTE5ZWE1ZGMyNjQ2OTU5N2Q2MTUyYjEwZCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlQ2xpZW50LmgKKysrIGIvU291cmNlL1dlYktpdC9i bGFja2JlcnJ5L0FwaS9XZWJQYWdlQ2xpZW50LmgKQEAgLTE0MSw3ICsxNDEsNiBAQCBwdWJsaWM6 CiAgICAgdmlydHVhbCBQbGF0Zm9ybTo6R3JhcGhpY3M6OldpbmRvdyogd2luZG93KCkgY29uc3Qg PSAwOwogCiAgICAgdmlydHVhbCB2b2lkIG5vdGlmeVBpeGVsQ29udGVudFJlbmRlcmVkKGNvbnN0 IFBsYXRmb3JtOjpJbnRSZWN0JikgPSAwOwotICAgIHZpcnR1YWwgdm9pZCByZXNpemVTdXJmYWNl SWZOZWVkZWQoKSA9IDA7CiAKICAgICB2aXJ0dWFsIHZvaWQgaW5wdXRGb2N1c0dhaW5lZChpbnQ2 NF90IGlucHV0U3R5bGUsIFBsYXRmb3JtOjpWaXJ0dWFsS2V5Ym9hcmRUeXBlLCBQbGF0Zm9ybTo6 VmlydHVhbEtleWJvYXJkRW50ZXJLZXlUeXBlKSA9IDA7CiAgICAgdmlydHVhbCB2b2lkIGlucHV0 Rm9jdXNMb3N0KCkgPSAwOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0Fw aS9XZWJQYWdlX3AuaCBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZV9wLmgK aW5kZXggNDMzMWIzZWQ5MjBjMmQ1YjAzZWU1N2JjNzRmMzU0M2U2NWI5MGVmYS4uOWMwYTI2ZGNi OGM5NWVmMjg1MjYxOWMwZWYzMGM5ZmYyZThhZWI1NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlX3AuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVy cnkvQXBpL1dlYlBhZ2VfcC5oCkBAIC0zNjcsNyArMzY3LDYgQEAgcHVibGljOgogICAgIC8vIFNj cm9sbCBhbmQvb3Igem9vbSBzbyB0aGF0IHRoZSBXZWJQYWdlIGZpdHMgdGhlIG5ldyBhY3R1YWwK ICAgICAvLyB2aXNpYmxlIHNpemUuCiAgICAgdm9pZCBzZXRWaWV3cG9ydFNpemUoY29uc3QgV2Vi Q29yZTo6SW50U2l6ZSYgdHJhbnNmb3JtZWRBY3R1YWxWaXNpYmxlU2l6ZSwgYm9vbCBlbnN1cmVG b2N1c0VsZW1lbnRWaXNpYmxlKTsKLSAgICB2b2lkIHJlc2l6ZVN1cmZhY2VJZk5lZWRlZCgpOyAv LyBIZWxwZXIgbWV0aG9kIGZvciBzZXRWaWV3cG9ydFNpemUoKS4KIAogICAgIHZvaWQgc2NoZWR1 bGVEZWZlcnJhYmxlVGltZXIoV2ViQ29yZTo6VGltZXI8V2ViUGFnZVByaXZhdGU+KiwgZG91Ymxl IHRpbWVPdXQpOwogICAgIHZvaWQgdW5zY2hlZHVsZUFsbERlZmVycmFibGVUaW1lcnMoKTsKQEAg LTU2OCw3ICs1NjcsNiBAQCBwdWJsaWM6CiAgICAgYm9vbCBtX3N1c3BlbmRSb290TGF5ZXJDb21t aXQ7CiAjZW5kaWYKIAotICAgIGJvb2wgbV9oYXNQZW5kaW5nU3VyZmFjZVNpemVDaGFuZ2U7CiAg ICAgaW50IG1fcGVuZGluZ09yaWVudGF0aW9uOwogCiAgICAgUmVmUHRyPFdlYkNvcmU6Ok5vZGU+ IG1fZnVsbHNjcmVlblZpZGVvTm9kZTsK