102275 2012-11-14 13:05:01 -0800 More steps towards actually hosting layers in the UI process 2012-11-14 13:17:11 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca kling oldest_to_newest 767213 0 andersca 2012-11-14 13:05:01 -0800 More steps towards actually hosting layers in the UI process 767220 1 174237 andersca 2012-11-14 13:09:52 -0800 Created attachment 174237 Patch 767223 2 174237 kling 2012-11-14 13:13:51 -0800 Comment on attachment 174237 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174237&action=review > Source/WebKit2/UIProcess/mac/RemoteLayerTreeHost.mm:83 > + HashMap<uint64_t, OwnPtr<GraphicsLayer> >::AddResult addResult = m_layers.add(layerID, nullptr); >> 767224 3 andersca 2012-11-14 13:15:01 -0800 (In reply to comment #2) > (From update of attachment 174237 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=174237&action=review > > > Source/WebKit2/UIProcess/mac/RemoteLayerTreeHost.mm:83 > > + HashMap<uint64_t, OwnPtr<GraphicsLayer> >::AddResult addResult = m_layers.add(layerID, nullptr); > > >> auto. 767225 4 kling 2012-11-14 13:16:19 -0800 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 174237 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=174237&action=review > > > > > Source/WebKit2/UIProcess/mac/RemoteLayerTreeHost.mm:83 > > > + HashMap<uint64_t, OwnPtr<GraphicsLayer> >::AddResult addResult = m_layers.add(layerID, nullptr); > > > > >> > > auto. Even better. Truly a glorious day! 767226 5 andersca 2012-11-14 13:17:11 -0800 Committed r134656: <http://trac.webkit.org/changeset/134656> 174237 2012-11-14 13:09:52 -0800 2012-11-14 13:13:51 -0800 Patch bug-102275-20121114130752.patch text/plain 6247 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0NjQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMjczN2ZkOWRkODVlYzJl ZTA2MDVkZWJkOWI0OTBjNzI3NjJkNGNjYi4uNGE5ODQwNTM3OTA1Zjc5NDhjNTNhOTcxOWU4NGVl NmY5NDkzMDcyYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMzIEBACisyMDEyLTExLTE0ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgTW9yZSBzdGVwcyB0 b3dhcmRzIGFjdHVhbGx5IGhvc3RpbmcgbGF5ZXJzIGluIHRoZSBVSSBwcm9jZXNzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDIyNzUKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNoYXJlZC9tYWMvUmVt b3RlTGF5ZXJUcmVlVHJhbnNhY3Rpb24uaDoKKyAgICAgICAgKFdlYktpdDo6UmVtb3RlTGF5ZXJU cmVlVHJhbnNhY3Rpb246OnJvb3RMYXllcklEKToKKyAgICAgICAgQWRkIGEgZ2V0dGVyIGZvciB0 aGUgcm9vdCBsYXllciBJRC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9tYWMvUmVtb3RlTGF5ZXJU cmVlSG9zdC5oOgorICAgICAgICAoUmVtb3RlTGF5ZXJUcmVlSG9zdCk6CisgICAgICAgIEFkZCBy b290IGxheWVyIG1lbWJlciB2YXJpYWJsZS4gTWFrZSB0aGUgUmVtb3RlTGF5ZXJUcmVlSG9zdCBj bGFzcyBhIEdyYXBoaWNzTGF5ZXJDbGllbnQuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvbWFjL1Jl bW90ZUxheWVyVHJlZUhvc3QubW06CisgICAgICAgIChXZWJLaXQ6OlJlbW90ZUxheWVyVHJlZUhv c3Q6OlJlbW90ZUxheWVyVHJlZUhvc3QpOgorICAgICAgICBJbml0aWFsaXplIHRoZSByb290IGxh eWVyIHRvIG51bGwuCisKKyAgICAgICAgKFdlYktpdDo6UmVtb3RlTGF5ZXJUcmVlSG9zdDo6bm90 aWZ5QW5pbWF0aW9uU3RhcnRlZCk6CisgICAgICAgIChXZWJLaXQ6OlJlbW90ZUxheWVyVHJlZUhv c3Q6Om5vdGlmeUZsdXNoUmVxdWlyZWQpOgorICAgICAgICAoV2ViS2l0OjpSZW1vdGVMYXllclRy ZWVIb3N0OjpwYWludENvbnRlbnRzKToKKyAgICAgICAgQWRkIGVtcHR5IHN0dWJzLgorCisgICAg ICAgIChXZWJLaXQ6OlJlbW90ZUxheWVyVHJlZUhvc3Q6OmNvbW1pdCk6CisgICAgICAgIFRyeSB0 byBnZXQgdGhlIHJvb3QgbGF5ZXIuCisKKyAgICAgICAgKFdlYktpdDo6UmVtb3RlTGF5ZXJUcmVl SG9zdDo6Z2V0T3JDcmVhdGVMYXllcik6CisgICAgICAgIExvb2sgdXAgdGhlIGxheWVyIHdpdGgg dGhlIGdpdmVuIElEIGluIHRoZSBtX2xheWVycyBoYXNoIHRhYmxlIGFuZCBjcmVhdGUgaXQgaWYg aXQgZG9lc24ndCBleGlzdC4KKwogMjAxMi0xMS0xNCAgQnJhZHkgRWlkc29uICA8YmVpZHNvbkBh cHBsZS5jb20+CiAKICAgICAgICAgUGFydCBvZiAiTW92ZSBsb2FkaW5nIHJlc3BvbnNpYmlsaXR5 IG91dCBvZiBXZWJSZXNvdXJjZUxvYWRTY2hlZHVsZXIgaW50byBhIG5ldyBXZWJSZXNvdXJjZUxv YWRlciIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9tYWMvUmVtb3RlTGF5ZXJU cmVlVHJhbnNhY3Rpb24uaCBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9tYWMvUmVtb3RlTGF5ZXJU cmVlVHJhbnNhY3Rpb24uaAppbmRleCBmOGUwODYyYmE1ZDEyNWQzNGFlMzliN2ExMDk2YWJmZTc1 ODFkOWY2Li5kOWRkNmEyNmY4ODYzMjcwYjVmOTFkNjQ0MGQ0Y2FmNzcxNGYwYTIwIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvbWFjL1JlbW90ZUxheWVyVHJlZVRyYW5zYWN0aW9u LmgKKysrIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL21hYy9SZW1vdGVMYXllclRyZWVUcmFuc2Fj dGlvbi5oCkBAIC03MCw2ICs3MCw3IEBAIHB1YmxpYzoKICAgICB2b2lkIGVuY29kZShDb3JlSVBD OjpBcmd1bWVudEVuY29kZXImKSBjb25zdDsKICAgICBzdGF0aWMgYm9vbCBkZWNvZGUoQ29yZUlQ Qzo6QXJndW1lbnREZWNvZGVyKiwgUmVtb3RlTGF5ZXJUcmVlVHJhbnNhY3Rpb24mKTsKIAorICAg IHVpbnQ2NF90IHJvb3RMYXllcklEKCkgY29uc3QgeyByZXR1cm4gbV9yb290TGF5ZXJJRDsgfQog ICAgIHZvaWQgc2V0Um9vdExheWVySUQodWludDY0X3Qgcm9vdExheWVySUQpOwogICAgIHZvaWQg bGF5ZXJQcm9wZXJ0aWVzQ2hhbmdlZChjb25zdCBSZW1vdGVHcmFwaGljc0xheWVyKiwgdW5zaWdu ZWQgY2hhbmdlZFByb3BlcnRpZXMpOwogICAgIHZvaWQgc2V0RGVzdHJveWVkTGF5ZXJJRHMoVmVj dG9yPHVpbnQ2NF90Pik7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFj L1JlbW90ZUxheWVyVHJlZUhvc3QuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvUmVt b3RlTGF5ZXJUcmVlSG9zdC5oCmluZGV4IGUyNWYwYzliNDYyZThjMGNjNjcwODdiYzRiZWRjYTk1 NDBkYWMwZmUuLjc4ZDY3NDJmMjQyYTQ0ZDdlODg2NDIxN2JhNWVlYzk4MjlmYWMyNDkgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvUmVtb3RlTGF5ZXJUcmVlSG9zdC5o CisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvUmVtb3RlTGF5ZXJUcmVlSG9zdC5o CkBAIC0yNywxMyArMjcsMTUgQEAKICNkZWZpbmUgUmVtb3RlTGF5ZXJUcmVlSG9zdF9oCiAKICNp bmNsdWRlICJNZXNzYWdlUmVjZWl2ZXIuaCIKKyNpbmNsdWRlIDxXZWJDb3JlL0dyYXBoaWNzTGF5 ZXJDbGllbnQuaD4KKyNpbmNsdWRlIDx3dGYvSGFzaE1hcC5oPgogCiBuYW1lc3BhY2UgV2ViS2l0 IHsKIAogY2xhc3MgUmVtb3RlTGF5ZXJUcmVlVHJhbnNhY3Rpb247CiBjbGFzcyBXZWJQYWdlUHJv eHk7CiAKLWNsYXNzIFJlbW90ZUxheWVyVHJlZUhvc3QgOiBDb3JlSVBDOjpNZXNzYWdlUmVjZWl2 ZXIgeworY2xhc3MgUmVtb3RlTGF5ZXJUcmVlSG9zdCA6IHByaXZhdGUgQ29yZUlQQzo6TWVzc2Fn ZVJlY2VpdmVyLCBXZWJDb3JlOjpHcmFwaGljc0xheWVyQ2xpZW50IHsKIHB1YmxpYzoKICAgICBl eHBsaWNpdCBSZW1vdGVMYXllclRyZWVIb3N0KFdlYlBhZ2VQcm94eSopOwogICAgIH5SZW1vdGVM YXllclRyZWVIb3N0KCk7CkBAIC00MiwxMyArNDQsMjMgQEAgcHJpdmF0ZToKICAgICAvLyBDb3Jl SVBDOjpNZXNzYWdlUmVjZWl2ZXIuCiAgICAgdmlydHVhbCB2b2lkIGRpZFJlY2VpdmVNZXNzYWdl KENvcmVJUEM6OkNvbm5lY3Rpb24qLCBDb3JlSVBDOjpNZXNzYWdlSUQsIENvcmVJUEM6Ok1lc3Nh Z2VEZWNvZGVyJikgT1ZFUlJJREU7CiAKKyAgICAvLyBXZWJDb3JlOjpHcmFwaGljc0xheWVyQ2xp ZW50LgorICAgIHZpcnR1YWwgdm9pZCBub3RpZnlBbmltYXRpb25TdGFydGVkKGNvbnN0IFdlYkNv cmU6OkdyYXBoaWNzTGF5ZXIqLCBkb3VibGUgdGltZSkgT1ZFUlJJREU7CisgICAgdmlydHVhbCB2 b2lkIG5vdGlmeUZsdXNoUmVxdWlyZWQoY29uc3QgV2ViQ29yZTo6R3JhcGhpY3NMYXllciopIE9W RVJSSURFOworICAgIHZpcnR1YWwgdm9pZCBwYWludENvbnRlbnRzKGNvbnN0IFdlYkNvcmU6Okdy YXBoaWNzTGF5ZXIqLCBXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQmLCBXZWJDb3JlOjpHcmFwaGlj c0xheWVyUGFpbnRpbmdQaGFzZSwgY29uc3QgV2ViQ29yZTo6SW50UmVjdCYgY2xpcFJlY3QpIE9W RVJSSURFOworCiAgICAgLy8gSW1wbGVtZW50ZWQgaW4gZ2VuZXJhdGVkIFJlbW90ZUxheWVyVHJl ZUhvc3RNZXNzYWdlUmVjZWl2ZXIuY3BwCiAgICAgdm9pZCBkaWRSZWNlaXZlUmVtb3RlTGF5ZXJU cmVlSG9zdE1lc3NhZ2UoQ29yZUlQQzo6Q29ubmVjdGlvbiosIENvcmVJUEM6Ok1lc3NhZ2VJRCwg Q29yZUlQQzo6TWVzc2FnZURlY29kZXImKTsKIAogICAgIC8vIE1lc3NhZ2UgaGFuZGxlcnMuCiAg ICAgdm9pZCBjb21taXQoY29uc3QgUmVtb3RlTGF5ZXJUcmVlVHJhbnNhY3Rpb24mKTsKIAorICAg IFdlYkNvcmU6OkdyYXBoaWNzTGF5ZXIqIGdldE9yQ3JlYXRlTGF5ZXIodWludDY0X3QgbGF5ZXJJ RCk7CisKICAgICBXZWJQYWdlUHJveHkqIG1fd2ViUGFnZVByb3h5OworCisgICAgV2ViQ29yZTo6 R3JhcGhpY3NMYXllciogbV9yb290TGF5ZXI7CisgICAgSGFzaE1hcDx1aW50NjRfdCwgT3duUHRy PFdlYkNvcmU6OkdyYXBoaWNzTGF5ZXI+PiBtX2xheWVyczsKIH07CiAKIH0gLy8gbmFtZXNwYWNl IFdlYktpdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9SZW1vdGVM YXllclRyZWVIb3N0Lm1tIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9SZW1vdGVMYXll clRyZWVIb3N0Lm1tCmluZGV4IDJkOTdmN2Q3YmE3OGI4YzY1ZTFlZDg0OGMwNWI3ZGMxODQ5MmU5 YTAuLjBkMThiYWQ1ZDdlNjkzNzNjOTNhYmViZDFiYjEzNjYzYjFmNzE2OGEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvUmVtb3RlTGF5ZXJUcmVlSG9zdC5tbQorKysg Yi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1JlbW90ZUxheWVyVHJlZUhvc3QubW0KQEAg LTMwLDExICszMCwxNSBAQAogI2luY2x1ZGUgIlJlbW90ZUxheWVyVHJlZVRyYW5zYWN0aW9uLmgi CiAjaW5jbHVkZSAiV2ViUGFnZVByb3h5LmgiCiAjaW5jbHVkZSAiV2ViUHJvY2Vzc1Byb3h5Lmgi CisjaW5jbHVkZSA8V2ViQ29yZS9HcmFwaGljc0xheWVyLmg+CisKK3VzaW5nIG5hbWVzcGFjZSBX ZWJDb3JlOwogCiBuYW1lc3BhY2UgV2ViS2l0IHsKIAogUmVtb3RlTGF5ZXJUcmVlSG9zdDo6UmVt b3RlTGF5ZXJUcmVlSG9zdChXZWJQYWdlUHJveHkqIHdlYlBhZ2VQcm94eSkKICAgICA6IG1fd2Vi UGFnZVByb3h5KHdlYlBhZ2VQcm94eSkKKyAgICAsIG1fcm9vdExheWVyKG51bGxwdHIpCiB7CiAg ICAgbV93ZWJQYWdlUHJveHktPnByb2Nlc3MoKS0+YWRkTWVzc2FnZVJlY2VpdmVyKE1lc3NhZ2Vz OjpSZW1vdGVMYXllclRyZWVIb3N0OjptZXNzYWdlUmVjZWl2ZXJOYW1lKCksIG1fd2ViUGFnZVBy b3h5LT5wYWdlSUQoKSwgdGhpcyk7CiB9CkBAIC00OSwxMiArNTMsMzggQEAgdm9pZCBSZW1vdGVM YXllclRyZWVIb3N0OjpkaWRSZWNlaXZlTWVzc2FnZShDb3JlSVBDOjpDb25uZWN0aW9uKiBjb25u ZWN0aW9uLCBDb3IKICAgICBkaWRSZWNlaXZlUmVtb3RlTGF5ZXJUcmVlSG9zdE1lc3NhZ2UoY29u bmVjdGlvbiwgbWVzc2FnZUlELCBkZWNvZGVyKTsKIH0KIAordm9pZCBSZW1vdGVMYXllclRyZWVI b3N0Ojpub3RpZnlBbmltYXRpb25TdGFydGVkKGNvbnN0IEdyYXBoaWNzTGF5ZXIqLCBkb3VibGUg dGltZSkKK3sKK30KKwordm9pZCBSZW1vdGVMYXllclRyZWVIb3N0Ojpub3RpZnlGbHVzaFJlcXVp cmVkKGNvbnN0IEdyYXBoaWNzTGF5ZXIqKQoreworfQorCit2b2lkIFJlbW90ZUxheWVyVHJlZUhv c3Q6OnBhaW50Q29udGVudHMoY29uc3QgR3JhcGhpY3NMYXllciosIEdyYXBoaWNzQ29udGV4dCYs IEdyYXBoaWNzTGF5ZXJQYWludGluZ1BoYXNlLCBjb25zdCBJbnRSZWN0JikKK3sKK30KKwogdm9p ZCBSZW1vdGVMYXllclRyZWVIb3N0Ojpjb21taXQoY29uc3QgUmVtb3RlTGF5ZXJUcmVlVHJhbnNh Y3Rpb24mIHRyYW5zYWN0aW9uKQogeworICAgIEdyYXBoaWNzTGF5ZXIqIHJvb3RMYXllciA9IGdl dE9yQ3JlYXRlTGF5ZXIodHJhbnNhY3Rpb24ucm9vdExheWVySUQoKSk7CisgICAgaWYgKG1fcm9v dExheWVyICE9IHJvb3RMYXllcikgeworICAgICAgICAvLyBGSVhNRTogVXBkYXRlIHRoZSByb290 IGxheWVyLgorICAgIH0KKwogI2lmbmRlZiBOREVCVUcKICAgICAvLyBGSVhNRTogQXBwbHkgdGhl IHRyYW5zYWN0aW9uIGluc3RlYWQgb2YgZHVtcGluZyBpdCB0byBzdGRlcnIuCiAgICAgdHJhbnNh Y3Rpb24uZHVtcCgpOwogI2VuZGlmCiB9CiAKK0dyYXBoaWNzTGF5ZXIqIFJlbW90ZUxheWVyVHJl ZUhvc3Q6OmdldE9yQ3JlYXRlTGF5ZXIodWludDY0X3QgbGF5ZXJJRCkKK3sKKyAgICBIYXNoTWFw PHVpbnQ2NF90LCBPd25QdHI8R3JhcGhpY3NMYXllcj4gPjo6QWRkUmVzdWx0IGFkZFJlc3VsdCA9 IG1fbGF5ZXJzLmFkZChsYXllcklELCBudWxscHRyKTsKKyAgICBpZiAoYWRkUmVzdWx0LmlzTmV3 RW50cnkpCisgICAgICAgIGFkZFJlc3VsdC5pdGVyYXRvci0+dmFsdWUgPSBHcmFwaGljc0xheWVy OjpjcmVhdGUodGhpcyk7CisKKyAgICByZXR1cm4gYWRkUmVzdWx0Lml0ZXJhdG9yLT52YWx1ZS5n ZXQoKTsKK30KKwogfSAvLyBuYW1lc3BhY2UgV2ViS2l0Cg==