102273 2012-11-14 13:01:32 -0800 Make old-run-webkit-tests handle setting the results directory properly. 2012-11-28 11:43:22 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 roger_fong webkit-unassigned lforschler roger_fong slewis oldest_to_newest 767205 0 roger_fong 2012-11-14 13:01:32 -0800 A call to chdirWebkit in old-run-webkit-tests set the current working directory to the OpenSource folder. Thus setting --results-directory to OpenSource/layout-test-results would create OpenSource/layout-test-results inside the main OpenSource folder. This caused many other problems including failure to upload test results and failed future test runs. The solution is to save the current working directory before calling chdirWebKit and then reconstructing the full path to the results directory using the saved directory when setting $testResultsDirectory. 767206 1 roger_fong 2012-11-14 13:02:05 -0800 <rdar://problem/11571607> 767448 2 174283 roger_fong 2012-11-14 16:38:34 -0800 Created attachment 174283 patch 174283 2012-11-14 16:38:34 -0800 2012-11-15 13:10:18 -0800 patch test_results.patch text/plain 2214 roger_fong SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEzNDY4OSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE5IEBACisyMDEyLTExLTE0ICBSb2dlciBGb25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+ CisKKyAgICAgICAgTWFrZSBvbGQtcnVuLXdlYmtpdC10ZXN0cyBoYW5kbGUgc2V0dGluZyB0aGUg cmVzdWx0cyBkaXJlY3RvcnkgcHJvcGVybHkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMDIyNzMKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzExNTcx NjA3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEEg Y2FsbCB0byBjaGRpcldlYmtpdCBpbiBvbGQtcnVuLXdlYmtpdC10ZXN0cyBzZXQgdGhlIGN1cnJl bnQgd29ya2luZyBkaXJlY3RvcnkgdG8gdGhlIE9wZW5Tb3VyY2UgZm9sZGVyLgorICAgICAgICBU aHVzIHNldHRpbmcgLS1yZXN1bHRzLWRpcmVjdG9yeSB0byBPcGVuU291cmNlL2xheW91dC10ZXN0 LXJlc3VsdHMgd291bGQgY3JlYXRlIE9wZW5Tb3VyY2UvbGF5b3V0LXRlc3QtcmVzdWx0cyBpbnNp ZGUgdGhlIG1haW4gT3BlblNvdXJjZSBmb2xkZXIuCisgICAgICAgIFRoaXMgY2F1c2VkIG1hbnkg b3RoZXIgcHJvYmxlbXMgaW5jbHVkaW5nIGZhaWx1cmUgdG8gdXBsb2FkIHRlc3QgcmVzdWx0cyBh bmQgZmFpbGVkIGZ1dHVyZSB0ZXN0IHJ1bnMuCisgICAgICAgIFRoZSBzb2x1dGlvbiBpcyB0byBz YXZlIHRoZSBjdXJyZW50IHdvcmtpbmcgZGlyZWN0b3J5IGJlZm9yZSBjYWxsaW5nIGNoZGlyV2Vi S2l0IGFuZCB0aGVuIHJlY29uc3RydWN0aW5nIHRoZSBmdWxsIHBhdGggdG8gdGhlIHJlc3VsdHMg ZGlyZWN0b3J5IAorICAgICAgICB1c2luZyB0aGUgc2F2ZWQgZGlyZWN0b3J5IHdoZW4gc2V0dGlu ZyAkdGVzdFJlc3VsdHNEaXJlY3RvcnkuCisKKyAgICAgICAgKiBTY3JpcHRzL29sZC1ydW4td2Vi a2l0LXRlc3RzOgorCiAyMDEyLTExLTA4ICBBbmR5IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNvbT4K IAogICAgICAgICBbV2ViS2l0Ml0gTmVlZCBBUEkgaW4gVUlQcm9jZXNzIHRvIGVuYWJsZSBsb2Fk aW5nIG9mIGN1c3RvbSBwcm90b2NvbHMKSW5kZXg6IFRvb2xzL1NjcmlwdHMvb2xkLXJ1bi13ZWJr aXQtdGVzdHMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy9vbGQtcnVuLXdlYmtpdC10ZXN0 cwkocmV2aXNpb24gMTM0Njg3KQorKysgVG9vbHMvU2NyaXB0cy9vbGQtcnVuLXdlYmtpdC10ZXN0 cwkod29ya2luZyBjb3B5KQpAQCAtNDIzLDYgKzQyMyw4IEBAIG15ICRwcm9kdWN0RGlyID0gcHJv ZHVjdERpcigpOwogJHByb2R1Y3REaXIgLj0gIi9iaW4iIGlmIGlzUXQoKTsKICRwcm9kdWN0RGly IC49ICIvUHJvZ3JhbXMiIGlmIGlzR3RrKCk7CiAKKyMgU2F2ZSB0aGUgY3VycmVudCBkaXJlY3Rv cnkgYmVmb3JlIGNoYWdpbmcgaXQgdmlhIGNoZGlyV2ViS2l0CitteSAkY3VycmVudERpciA9IGN3 ZCgpOwogY2hkaXJXZWJLaXQoKTsKIAogaWYgKCFkZWZpbmVkKCRyb290KSAmJiAhJG5vQnVpbGRE dW1wVG9vbCkgewpAQCAtNDY3LDcgKzQ2OSw3IEBAIG15IEBwbGF0Zm9ybVRlc3RIaWVyYXJjaHkg PSBidWlsZFBsYXRmb3IKIAogJGV4cGVjdGVkRGlyZWN0b3J5ID0gJEVOVnsiV2ViS2l0RXhwZWN0 ZWRUZXN0UmVzdWx0c0RpcmVjdG9yeSJ9IGlmICRFTlZ7IldlYktpdEV4cGVjdGVkVGVzdFJlc3Vs dHNEaXJlY3RvcnkifTsKIAotJHRlc3RSZXN1bHRzRGlyZWN0b3J5ID0gRmlsZTo6U3BlYy0+cmVs MmFicygkdGVzdFJlc3VsdHNEaXJlY3RvcnkpOworJHRlc3RSZXN1bHRzRGlyZWN0b3J5ID0gRmls ZTo6U3BlYy0+Y2F0ZmlsZSgkY3VycmVudERpciwgJHRlc3RSZXN1bHRzRGlyZWN0b3J5KTsKICMg JHRlc3RSZXN1bHRzRGlyZWN0b3J5IG11c3QgYmUgZW1wdHkgYmVmb3JlIHRlc3RpbmcuCiBybXRy ZWUgJHRlc3RSZXN1bHRzRGlyZWN0b3J5OwogbXkgJHRlc3RSZXN1bHRzID0gRmlsZTo6U3BlYy0+ Y2F0ZmlsZSgkdGVzdFJlc3VsdHNEaXJlY3RvcnksICJyZXN1bHRzLmh0bWwiKTsK