102271 2012-11-14 12:37:09 -0800 [CF]: XMLHttpRequest "timeout" events firing as "error" events 2012-11-14 19:49:44 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 joepeck webkit-unassigned ap ddkilzer d-r joepeck psolanki roger_fong webkit.review.bot oldest_to_newest 767186 0 joepeck 2012-11-14 12:37:09 -0800 When USE(CFNETWORK) timeout ResourceErrors are not being marked timeouts. Init the timeout flag in the USE(CFNETWORK) side of ResourceError just like: <http://webkit.org/b/99478> Init timeout flag in ResourceErrorMac Patch to follow. 767189 1 joepeck 2012-11-14 12:37:51 -0800 <rdar://problem/12693157> 767191 2 174229 joepeck 2012-11-14 12:41:43 -0800 Created attachment 174229 [PATCH] Proposed Fix Do the same as the r131499: <http://trac.webkit.org/changeset/131499> but for the USE(CFNETWORK) ResourceError constructors. 767251 3 ap 2012-11-14 13:41:24 -0800 Isn't this a duplicate of bug 100349? 767252 4 ap 2012-11-14 13:42:55 -0800 The patch looks good to me, but the same change has been found to not work in practice in bug 100349. 767469 5 joepeck 2012-11-14 16:52:45 -0800 Hmm, this does look identical. I can't explain why it doesn't fix the Windows bots. It fixed these tests on the iOS port. 767492 6 ddkilzer 2012-11-14 17:05:05 -0800 (In reply to comment #4) > The patch looks good to me, but the same change has been found to not work in practice in bug 100349. Has anyone run the test on Windows to find out what error code it is returning in this case? If it works on iOS, then perhaps there is a bug in the Windows port of CFNetwork. 767493 7 174229 ddkilzer 2012-11-14 17:07:57 -0800 Comment on attachment 174229 [PATCH] Proposed Fix r=me 767511 8 174229 webkit.review.bot 2012-11-14 17:31:04 -0800 Comment on attachment 174229 [PATCH] Proposed Fix Clearing flags on attachment: 174229 Committed r134702: <http://trac.webkit.org/changeset/134702> 767512 9 webkit.review.bot 2012-11-14 17:31:08 -0800 All reviewed patches have been landed. Closing bug. 767639 10 ap 2012-11-14 19:49:44 -0800 *** Bug 100349 has been marked as a duplicate of this bug. *** 174229 2012-11-14 12:41:43 -0800 2012-11-14 17:31:04 -0800 [PATCH] Proposed Fix xhr-timeout-1.patch text/plain 2040 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA4NDljOWQ2Li45ODBlYzhiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEg QEAKKzIwMTItMTEtMTQgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwor ICAgICAgICBbQ0ZdOiBYTUxIdHRwUmVxdWVzdCAidGltZW91dCIgZXZlbnRzIGZpcmluZyBhcyAi ZXJyb3IiIGV2ZW50cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTAyMjcxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgSW5pdGlhbGl6ZSB0aGUgdGllbW91dCBmbGFnIGlmIHRoZSBlcnJvciByZXN1bHRzIGZy b20gYSB0aW1lb3V0CisgICAgICAgIGluIHRoZSBVU0UoQ0ZORVRXT1JLKSBjYXNlcy4KKworICAg ICAgICBObyBuZXcgdGVzdHMuIFRoaXMgaXMgY292ZXJlZCBieSBodHRwL3Rlc3RzL3htbGh0dHBy ZXF1ZXN0L3RpbWVvdXQKKyAgICAgICAgdGVzdHMgb24gcG9ydHMgdGhhdCBVU0UoQ0ZORVRXT1JL KS4KKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvY2YvUmVzb3VyY2VFcnJvckNGLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OlJlc291cmNlRXJyb3I6OlJlc291cmNlRXJyb3IpOgorICAgICAg ICAqIHBsYXRmb3JtL25ldHdvcmsvbWFjL1Jlc291cmNlRXJyb3JNYWMubW06CisgICAgICAgIChX ZWJDb3JlOjpSZXNvdXJjZUVycm9yOjpSZXNvdXJjZUVycm9yKToKKwogMjAxMi0xMS0wOSAgSm9z ZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAgICAgICAgIFtNYWNdIEd1YXJk IFdlYkNvcmUgUGFnZVZpc2liaWxpdHkgU3ltYm9sIEV4cG9ydApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jZi9SZXNvdXJjZUVycm9yQ0YuY3BwIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jZi9SZXNvdXJjZUVycm9yQ0YuY3BwCmluZGV4IDU4 OTVlZDkuLmU0NzIxMzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdv cmsvY2YvUmVzb3VyY2VFcnJvckNGLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9u ZXR3b3JrL2NmL1Jlc291cmNlRXJyb3JDRi5jcHAKQEAgLTQ1LDYgKzQ1LDggQEAgUmVzb3VyY2VF cnJvcjo6UmVzb3VyY2VFcnJvcihDRkVycm9yUmVmIGNmRXJyb3IpCiAgICAgLCBtX3BsYXRmb3Jt RXJyb3IoY2ZFcnJvcikKIHsKICAgICBtX2lzTnVsbCA9ICFjZkVycm9yOworICAgIGlmICghbV9p c051bGwpCisgICAgICAgIG1faXNUaW1lb3V0ID0gQ0ZFcnJvckdldENvZGUobV9wbGF0Zm9ybUVy cm9yLmdldCgpKSA9PSBrQ0ZVUkxFcnJvclRpbWVkT3V0OwogfQogCiAjaWYgUExBVEZPUk0oV0lO KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9tYWMvUmVzb3Vy Y2VFcnJvck1hYy5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvbWFjL1Jlc291 cmNlRXJyb3JNYWMubW0KaW5kZXggZGY2ZTk4Ni4uNGU4ZDNjNiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9tYWMvUmVzb3VyY2VFcnJvck1hYy5tbQorKysgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL21hYy9SZXNvdXJjZUVycm9yTWFjLm1tCkBA IC02MCw2ICs2MCw4IEBAIFJlc291cmNlRXJyb3I6OlJlc291cmNlRXJyb3IoTlNFcnJvciAqZXJy b3IpCiAgICAgLCBtX3BsYXRmb3JtRXJyb3IocmVpbnRlcnByZXRfY2FzdDxDRkVycm9yUmVmPihl cnJvcikpCiB7CiAgICAgbV9pc051bGwgPSAhZXJyb3I7CisgICAgaWYgKCFtX2lzTnVsbCkKKyAg ICAgICAgbV9pc1RpbWVvdXQgPSBbZXJyb3IgY29kZV0gPT0gTlNVUkxFcnJvclRpbWVkT3V0Owog fQogCiBOU0Vycm9yICpSZXNvdXJjZUVycm9yOjpuc0Vycm9yKCkgY29uc3QK