102255 2012-11-14 11:13:27 -0800 IndexedDB: Remove magic numbers in record comparator, handle missing case 2012-11-14 15:29:30 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 102243 1 jsbell jsbell alecflett dgrogan tony webkit.review.bot oldest_to_newest 767078 0 jsbell 2012-11-14 11:13:27 -0800 IndexedDB: Remove magic numbers in record comparator, handle missing case 767118 1 174210 jsbell 2012-11-14 11:36:54 -0800 Created attachment 174210 Patch 767120 2 174210 jsbell 2012-11-14 11:37:32 -0800 Comment on attachment 174210 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174210&action=review > Source/WebCore/Modules/indexeddb/IDBLevelDBCoding.cpp:-896 > - // FIXME: Assert not reached here? This will fall through to the ASSERT at the end of the function, as the other cases do. 767122 3 jsbell 2012-11-14 11:38:07 -0800 alecflett@, dgrogan@ - please take a look? 767287 4 174210 alecflett 2012-11-14 14:02:43 -0800 Comment on attachment 174210 Patch lgtm, wondering if this is worth merging into M23/M24? 767291 5 jsbell 2012-11-14 14:05:31 -0800 tony@ - r? 767369 6 174210 webkit.review.bot 2012-11-14 15:29:27 -0800 Comment on attachment 174210 Patch Clearing flags on attachment: 174210 Committed r134680: <http://trac.webkit.org/changeset/134680> 767370 7 webkit.review.bot 2012-11-14 15:29:30 -0800 All reviewed patches have been landed. Closing bug. 174210 2012-11-14 11:36:54 -0800 2012-11-14 15:29:27 -0800 Patch bug-102255-20121114113453.patch text/plain 7383 jsbell U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0NjE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDIwYjMzNTU5NmFjOTU4 ZTU2Mjk3ZGMyOWYyMTZmZDliMzFjNjVmMS4uNTBlM2FhZWJhM2VkN2NlYzM1YzZhYzA2YmIyNGRk MWRkZjA5MzIxNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTExLTE0ICBKb3No dWEgQmVsbCAgPGpzYmVsbEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgSW5kZXhlZERCOiBSZW1v dmUgbWFnaWMgbnVtYmVycyBpbiByZWNvcmQgY29tcGFyYXRvciwgaGFuZGxlIG1pc3NpbmcgY2Fz ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAyMjU1 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRm9yIHNv bWUgcmFuZ2VzIG9mIG1ldGFkYXRhIGVudHJpZXMsIGEgc2ltcGxlIHR5cGUgYnl0ZSBjb21wYXJp c29uIGlzIHN1ZmZpY2llbnQKKyAgICAgICAgZm9yIHRoZSBiYWNraW5nIHN0b3JlIGNvbXBhcmF0 b3IuIEluIHR3byBwbGFjZXMgdGhvc2UgcmFuZ2VzIHVzZWQgbWFnaWMgbnVtYmVycywKKyAgICAg ICAgb25lIG9mIHdoaWNoIHdhcyBpbmNvcnJlY3QgLSB3aGljaCBjb3VsZCBsZWFkIHRvIGZhaWxl ZCByZWFkcy93cml0ZXMuCisKKyAgICAgICAgVGVzdDogd2Via2l0X3VuaXRfdGVzdHMgLS1ndGVz dF9maWx0ZXI9J0lEQkxldmVsREJDb2RpbmdUZXN0LkNvbXBhcmlzb25UZXN0JworCisgICAgICAg ICogTW9kdWxlcy9pbmRleGVkZGIvSURCTGV2ZWxEQkNvZGluZy5jcHA6CisgICAgICAgIChJREJM ZXZlbERCQ29kaW5nKToKKyAgICAgICAgKFdlYkNvcmU6OklEQkxldmVsREJDb2Rpbmc6OmNvbXBh cmUpOgorICAgICAgICAqIE1vZHVsZXMvaW5kZXhlZGRiL0lEQkxldmVsREJDb2RpbmcuaDoKKwog MjAxMi0xMS0xNCAgRXJpayBBcnZpZHNzb24gIDxhcnZAY2hyb21pdW0ub3JnPgogCiAgICAgICAg IFVwZGF0ZSBET01FeGNlcHRpb24gbmFtZTogSW5kZXhTaXplRXJyb3IKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9D aGFuZ2VMb2cKaW5kZXggMzMzMjc5Yzc5NDAwMWRkYjAyNTM5NzE2NGVmYTUyMzk4NDM5NzYxYi4u OGMzZGM3YzZkMjA0NzdkZjcyMDY4YmJmMmY5MTBhOGI1MDRlMWE2OCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1 bS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMi0xMS0xNCAgSm9zaHVhIEJlbGwgIDxq c2JlbGxAY2hyb21pdW0ub3JnPgorCisgICAgICAgIEluZGV4ZWREQjogUmVtb3ZlIG1hZ2ljIG51 bWJlcnMgaW4gcmVjb3JkIGNvbXBhcmF0b3IsIGhhbmRsZSBtaXNzaW5nIGNhc2UKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMjI1NQorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCB0ZXN0IGtleXMgZm9y IHZhcmlvdXMgbWV0YWRhdGEgdHlwZXMuCisKKyAgICAgICAgKiB0ZXN0cy9JREJMZXZlbERCQ29k aW5nVGVzdC5jcHA6CisgICAgICAgIChJREJMZXZlbERCQ29kaW5nOjpURVNUKToKKwogMjAxMi0x MS0xNCAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAg ICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjEzNDUyMy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL0lEQkxldmVsREJDb2RpbmcuY3BwIGIvU291cmNlL1dl YkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvSURCTGV2ZWxEQkNvZGluZy5jcHAKaW5kZXggNzBjODE3 ZmNjZmIyNzFhY2FkMzVlMmFiYTVhMWZiNGNhZDFmZDhmZi4uN2FmZmMyOGViMzNhYzM5ODE4ZDM1 ZDhiNTRkYjdlODAzNDNkMmU2NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9p bmRleGVkZGIvSURCTGV2ZWxEQkNvZGluZy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxl cy9pbmRleGVkZGIvSURCTGV2ZWxEQkNvZGluZy5jcHAKQEAgLTYxLDYgKzYxLDcgQEAKIC8vICAg ICA8ZGF0YWJhc2UgaWQsIDAsIDAsIDE+ID0+IHV0ZjE2IGRhdGFiYXNlIG5hbWUgW0RhdGFiYXNl TWV0YURhdGFLZXldCiAvLyAgICAgPGRhdGFiYXNlIGlkLCAwLCAwLCAyPiA9PiB1dGYxNiB1c2Vy IHZlcnNpb24gZGF0YSBbRGF0YWJhc2VNZXRhRGF0YUtleV0KIC8vICAgICA8ZGF0YWJhc2UgaWQs IDAsIDAsIDM+ID0+IG1heGltdW0gb2JqZWN0IHN0b3JlIGlkIGV2ZXIgYWxsb2NhdGVkIFtEYXRh YmFzZU1ldGFEYXRhS2V5XQorLy8gICAgIDxkYXRhYmFzZSBpZCwgMCwgMCwgND4gPT4gdXNlciBp bnRlZ2VyIHZlcnNpb24gKHZhciBpbnQpIFtEYXRhYmFzZU1ldGFEYXRhS2V5XQogLy8KIC8vCiAv LyBPYmplY3Qgc3RvcmUgbWV0YS1kYXRhOgpAQCAtMTUzLDYgKzE1NCw3IEBAIHN0YXRpYyBjb25z dCB1bnNpZ25lZCBjaGFyIEV4aXN0c0VudHJ5SW5kZXhJZCA9IDI7CiAKIHN0YXRpYyBjb25zdCB1 bnNpZ25lZCBjaGFyIFNjaGVtYVZlcnNpb25UeXBlQnl0ZSA9IDA7CiBzdGF0aWMgY29uc3QgdW5z aWduZWQgY2hhciBNYXhEYXRhYmFzZUlkVHlwZUJ5dGUgPSAxOworc3RhdGljIGNvbnN0IHVuc2ln bmVkIGNoYXIgTWF4U2ltcGxlR2xvYmFsTWV0YURhdGFUeXBlQnl0ZSA9IDI7IC8vIEluc2VydCBi ZWZvcmUgdGhpcyBhbmQgaW5jcmVtZW50Lgogc3RhdGljIGNvbnN0IHVuc2lnbmVkIGNoYXIgRGF0 YWJhc2VGcmVlTGlzdFR5cGVCeXRlID0gMTAwOwogc3RhdGljIGNvbnN0IHVuc2lnbmVkIGNoYXIg RGF0YWJhc2VOYW1lVHlwZUJ5dGUgPSAyMDE7CiAKQEAgLTg1Nyw5ICs4NTksOSBAQCBpbnQgY29t cGFyZShjb25zdCBMZXZlbERCU2xpY2UmIGEsIGNvbnN0IExldmVsREJTbGljZSYgYiwgYm9vbCBp bmRleEtleXMpCiAKICAgICAgICAgaWYgKGludCB4ID0gdHlwZUJ5dGVBIC0gdHlwZUJ5dGVCKQog ICAgICAgICAgICAgcmV0dXJuIHg7Ci0KLSAgICAgICAgaWYgKHR5cGVCeXRlQSA8PSAxKQorICAg ICAgICBpZiAodHlwZUJ5dGVBIDwgTWF4U2ltcGxlR2xvYmFsTWV0YURhdGFUeXBlQnl0ZSkKICAg ICAgICAgICAgIHJldHVybiAwOworCiAgICAgICAgIGlmICh0eXBlQnl0ZUEgPT0gRGF0YWJhc2VG cmVlTGlzdFR5cGVCeXRlKQogICAgICAgICAgICAgcmV0dXJuIGNvbXBhcmU8RGF0YWJhc2VGcmVl TGlzdEtleT4oYSwgYik7CiAgICAgICAgIGlmICh0eXBlQnl0ZUEgPT0gRGF0YWJhc2VOYW1lVHlw ZUJ5dGUpCkBAIC04NzUsOSArODc3LDcgQEAgaW50IGNvbXBhcmUoY29uc3QgTGV2ZWxEQlNsaWNl JiBhLCBjb25zdCBMZXZlbERCU2xpY2UmIGIsIGJvb2wgaW5kZXhLZXlzKQogCiAgICAgICAgIGlm IChpbnQgeCA9IHR5cGVCeXRlQSAtIHR5cGVCeXRlQikKICAgICAgICAgICAgIHJldHVybiB4Owot Ci0gICAgICAgIC8vIEZJWE1FOiBSZXBsYWNlIHRoaXMgbWFnaWMgbnVtYmVyLiBTaG91bGQgaXQg YWNjb3VudCBmb3IgVXNlckludFZlcnNpb24/Ci0gICAgICAgIGlmICh0eXBlQnl0ZUEgPD0gMykK KyAgICAgICAgaWYgKHR5cGVCeXRlQSA8IERhdGFiYXNlTWV0YURhdGFLZXk6Ok1heFNpbXBsZU1l dGFEYXRhVHlwZSkKICAgICAgICAgICAgIHJldHVybiAwOwogCiAgICAgICAgIGlmICh0eXBlQnl0 ZUEgPT0gT2JqZWN0U3RvcmVNZXRhRGF0YVR5cGVCeXRlKQpAQCAtODkyLDkgKzg5Miw2IEBAIGlu dCBjb21wYXJlKGNvbnN0IExldmVsREJTbGljZSYgYSwgY29uc3QgTGV2ZWxEQlNsaWNlJiBiLCBi b29sIGluZGV4S2V5cykKICAgICAgICAgICAgIHJldHVybiBjb21wYXJlPE9iamVjdFN0b3JlTmFt ZXNLZXk+KGEsIGIpOwogICAgICAgICBpZiAodHlwZUJ5dGVBID09IEluZGV4TmFtZXNLZXlUeXBl Qnl0ZSkKICAgICAgICAgICAgIHJldHVybiBjb21wYXJlPEluZGV4TmFtZXNLZXk+KGEsIGIpOwot Ci0gICAgICAgIC8vIEZJWE1FOiBBc3NlcnQgbm90IHJlYWNoZWQgaGVyZT8KLSAgICAgICAgcmV0 dXJuIDA7CiAgICAgfQogCiAgICAgaWYgKHByZWZpeEEudHlwZSgpID09IEtleVByZWZpeDo6T2Jq ZWN0U3RvcmVEYXRhKSB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4 ZWRkYi9JREJMZXZlbERCQ29kaW5nLmggYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRk Yi9JREJMZXZlbERCQ29kaW5nLmgKaW5kZXggMWIxNjY2YWU4ZDlhYzcxNjU2YmY5MDI1MzYzZjBk MmZjMGU4NTUzZi4uNzlmODc2MTcwMDRiMGM2ZmQ2OTJmYjM4ZmYyNmI0YTU5MThmNGIxYyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvSURCTGV2ZWxEQkNvZGlu Zy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL0lEQkxldmVsREJDb2Rp bmcuaApAQCAtMTQ2LDcgKzE0Niw4IEBAIHB1YmxpYzoKICAgICAgICAgRGF0YWJhc2VOYW1lID0g MSwKICAgICAgICAgVXNlclZlcnNpb24gPSAyLAogICAgICAgICBNYXhPYmplY3RTdG9yZUlkID0g MywKLSAgICAgICAgVXNlckludFZlcnNpb24gPSA0CisgICAgICAgIFVzZXJJbnRWZXJzaW9uID0g NCwKKyAgICAgICAgTWF4U2ltcGxlTWV0YURhdGFUeXBlID0gNQogICAgIH07CiAKICAgICBzdGF0 aWMgVmVjdG9yPGNoYXI+IGVuY29kZShpbnQ2NF90IGRhdGFiYXNlSWQsIE1ldGFEYXRhVHlwZSk7 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL0lEQkxldmVsREJDb2Rp bmdUZXN0LmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvSURCTGV2ZWxEQkNvZGlu Z1Rlc3QuY3BwCmluZGV4IDFiMmZmNmZlMTg3ZmQ1NWVhNjI3NjZkOGM5ZDlmZWYyMzY2YTVlNDEu LjFkNzVlYmE4ZmVkNzUwYjBkYWEyZmZlOGRlMTFmNTk0ZDcwZDcxMzUgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvSURCTGV2ZWxEQkNvZGluZ1Rlc3QuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvSURCTGV2ZWxEQkNvZGluZ1Rlc3QuY3BwCkBA IC02NTEsMTIgKzY1MSwyNSBAQCBURVNUKElEQkxldmVsREJDb2RpbmdUZXN0LCBDb21wYXJpc29u VGVzdCkKICAgICBrZXlzLmFwcGVuZChEYXRhYmFzZU5hbWVLZXk6OmVuY29kZSgiIiwgImEiKSk7 CiAgICAga2V5cy5hcHBlbmQoRGF0YWJhc2VOYW1lS2V5OjplbmNvZGUoImEiLCAiYSIpKTsKICAg ICBrZXlzLmFwcGVuZChEYXRhYmFzZU1ldGFEYXRhS2V5OjplbmNvZGUoMSwgRGF0YWJhc2VNZXRh RGF0YUtleTo6T3JpZ2luTmFtZSkpOwotICAgIGtleXMuYXBwZW5kKE9iamVjdFN0b3JlTWV0YURh dGFLZXk6OmVuY29kZSgxLCAxLCAwKSk7Ci0gICAga2V5cy5hcHBlbmQoT2JqZWN0U3RvcmVNZXRh RGF0YUtleTo6ZW5jb2RlKDEsIDEsIDEpKTsKKyAgICBrZXlzLmFwcGVuZChEYXRhYmFzZU1ldGFE YXRhS2V5OjplbmNvZGUoMSwgRGF0YWJhc2VNZXRhRGF0YUtleTo6RGF0YWJhc2VOYW1lKSk7Cisg ICAga2V5cy5hcHBlbmQoRGF0YWJhc2VNZXRhRGF0YUtleTo6ZW5jb2RlKDEsIERhdGFiYXNlTWV0 YURhdGFLZXk6OlVzZXJWZXJzaW9uKSk7CisgICAga2V5cy5hcHBlbmQoRGF0YWJhc2VNZXRhRGF0 YUtleTo6ZW5jb2RlKDEsIERhdGFiYXNlTWV0YURhdGFLZXk6Ok1heE9iamVjdFN0b3JlSWQpKTsK KyAgICBrZXlzLmFwcGVuZChEYXRhYmFzZU1ldGFEYXRhS2V5OjplbmNvZGUoMSwgRGF0YWJhc2VN ZXRhRGF0YUtleTo6VXNlckludFZlcnNpb24pKTsKKyAgICBrZXlzLmFwcGVuZChPYmplY3RTdG9y ZU1ldGFEYXRhS2V5OjplbmNvZGUoMSwgMSwgT2JqZWN0U3RvcmVNZXRhRGF0YUtleTo6TmFtZSkp OworICAgIGtleXMuYXBwZW5kKE9iamVjdFN0b3JlTWV0YURhdGFLZXk6OmVuY29kZSgxLCAxLCBP YmplY3RTdG9yZU1ldGFEYXRhS2V5OjpLZXlQYXRoKSk7CisgICAga2V5cy5hcHBlbmQoT2JqZWN0 U3RvcmVNZXRhRGF0YUtleTo6ZW5jb2RlKDEsIDEsIE9iamVjdFN0b3JlTWV0YURhdGFLZXk6OkF1 dG9JbmNyZW1lbnQpKTsKKyAgICBrZXlzLmFwcGVuZChPYmplY3RTdG9yZU1ldGFEYXRhS2V5Ojpl bmNvZGUoMSwgMSwgT2JqZWN0U3RvcmVNZXRhRGF0YUtleTo6RXZpY3RhYmxlKSk7CisgICAga2V5 cy5hcHBlbmQoT2JqZWN0U3RvcmVNZXRhRGF0YUtleTo6ZW5jb2RlKDEsIDEsIE9iamVjdFN0b3Jl TWV0YURhdGFLZXk6Okxhc3RWZXJzaW9uKSk7CisgICAga2V5cy5hcHBlbmQoT2JqZWN0U3RvcmVN ZXRhRGF0YUtleTo6ZW5jb2RlKDEsIDEsIE9iamVjdFN0b3JlTWV0YURhdGFLZXk6Ok1heEluZGV4 SWQpKTsKKyAgICBrZXlzLmFwcGVuZChPYmplY3RTdG9yZU1ldGFEYXRhS2V5OjplbmNvZGUoMSwg MSwgT2JqZWN0U3RvcmVNZXRhRGF0YUtleTo6SGFzS2V5UGF0aCkpOworICAgIGtleXMuYXBwZW5k KE9iamVjdFN0b3JlTWV0YURhdGFLZXk6OmVuY29kZSgxLCAxLCBPYmplY3RTdG9yZU1ldGFEYXRh S2V5OjpLZXlHZW5lcmF0b3JDdXJyZW50TnVtYmVyKSk7CiAgICAga2V5cy5hcHBlbmQoT2JqZWN0 U3RvcmVNZXRhRGF0YUtleTo6ZW5jb2RlTWF4S2V5KDEsIDEpKTsKICAgICBrZXlzLmFwcGVuZChP YmplY3RTdG9yZU1ldGFEYXRhS2V5OjplbmNvZGVNYXhLZXkoMSwgMikpOwogICAgIGtleXMuYXBw ZW5kKE9iamVjdFN0b3JlTWV0YURhdGFLZXk6OmVuY29kZU1heEtleSgxKSk7Ci0gICAga2V5cy5h cHBlbmQoSW5kZXhNZXRhRGF0YUtleTo6ZW5jb2RlKDEsIDEsIDMwLCAwKSk7CisgICAga2V5cy5h cHBlbmQoSW5kZXhNZXRhRGF0YUtleTo6ZW5jb2RlKDEsIDEsIDMwLCBJbmRleE1ldGFEYXRhS2V5 OjpOYW1lKSk7CisgICAga2V5cy5hcHBlbmQoSW5kZXhNZXRhRGF0YUtleTo6ZW5jb2RlKDEsIDEs IDMwLCBJbmRleE1ldGFEYXRhS2V5OjpVbmlxdWUpKTsKKyAgICBrZXlzLmFwcGVuZChJbmRleE1l dGFEYXRhS2V5OjplbmNvZGUoMSwgMSwgMzAsIEluZGV4TWV0YURhdGFLZXk6OktleVBhdGgpKTsK KyAgICBrZXlzLmFwcGVuZChJbmRleE1ldGFEYXRhS2V5OjplbmNvZGUoMSwgMSwgMzAsIEluZGV4 TWV0YURhdGFLZXk6Ok11bHRpRW50cnkpKTsKICAgICBrZXlzLmFwcGVuZChJbmRleE1ldGFEYXRh S2V5OjplbmNvZGUoMSwgMSwgMzEsIDApKTsKICAgICBrZXlzLmFwcGVuZChJbmRleE1ldGFEYXRh S2V5OjplbmNvZGUoMSwgMSwgMzEsIDEpKTsKICAgICBrZXlzLmFwcGVuZChJbmRleE1ldGFEYXRh S2V5OjplbmNvZGVNYXhLZXkoMSwgMSwgMzEpKTsK