102254 2012-11-14 11:12:28 -0800 [chromium] Don't let shift-click turn popup into tab. 2012-11-14 12:53:39 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ericu ericu abarth oldest_to_newest 767075 0 ericu 2012-11-14 11:12:28 -0800 [chromium] Don't let shift-click turn popup into tab. 767084 1 174207 ericu 2012-11-14 11:18:40 -0800 Created attachment 174207 Patch 767117 2 174207 abarth 2012-11-14 11:35:50 -0800 Comment on attachment 174207 Patch Interesting. Can we add a test for this change? (Perhaps a unit test?) 767192 3 ericu 2012-11-14 12:43:30 -0800 Sure, I can put together a unit test for ChromeClientImpl::getNavigationPolicy without pulling in too much else. I'll start a new bug for that. 767199 4 ericu 2012-11-14 12:53:39 -0800 Committed r134654: <http://trac.webkit.org/changeset/134654> 174207 2012-11-14 11:18:40 -0800 2012-11-14 11:35:50 -0800 Patch bug-102254-20121114111638.patch text/plain 2053 ericu U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0NjIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDMzMzI3OWM3OTQwMDFkZGIwMjUzOTcxNjRlZmE1MjM5ODQzOTc2MWIuLmEyZTczYTYwMWRkOTFl NGY0NTQ0YjNlYTc5NGQ1NWYyNGMzZmU5YWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTggQEAKKzIwMTItMTEtMTQgIEVyaWMgVWhyaGFuZSAgPGVyaWN1QGNocm9taXVt Lm9yZz4KKworICAgICAgICBbY2hyb21pdW1dIERvbid0IGxldCBzaGlmdC1jbGljayB0dXJuIHBv cHVwIGludG8gdGFiLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTAyMjU0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQ2hhbmdlIGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzEzMjM5OSBicm9r ZSBzaGlmdC1jbGljayBvbgorICAgICAgICBjb21wb3NlIGluIEdNYWlsLiAgV2UgZGlkbid0IHdh bnQgdG8gY2hhbmdlIGJlaGF2aW9yIHRoYXQgcGVvcGxlIHdlcmUKKyAgICAgICAgZGVwZW5kaW5n IG9uLCBhbmQgdGhpcyBxdWljayBmaXggc2VlbXMgYSBnb29kIGNvbXByb21pc2UgYmV0d2VlbiB1 c2VyCisgICAgICAgIGludGVudCBhbmQgZGV2ZWxvcGVyIGludGVudC4KKworICAgICAgICAqIHNy Yy9DaHJvbWVDbGllbnRJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6dXBkYXRlUG9saWN5Rm9y RXZlbnQpOgorCiAyMDEyLTExLTE0ICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdt YWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTM0NTIzLgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvQ2hyb21lQ2xpZW50SW1wbC5jcHAg Yi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9DaHJvbWVDbGllbnRJbXBsLmNwcAppbmRleCA4 ZmUzZmI3NGIxZjk1MjdlYTg0YWExZDVjMWUyYTFlZTdmODY0Y2JhLi4yYjNhNWMyODc0ZWFkNTY1 ZWUyMzYwYjE1OGQ0N2Q5OTYzYmQ4YTYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3NyYy9DaHJvbWVDbGllbnRJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt L3NyYy9DaHJvbWVDbGllbnRJbXBsLmNwcApAQCAtMjkzLDcgKzI5MywxMiBAQCBzdGF0aWMgaW5s aW5lIHZvaWQgdXBkYXRlUG9saWN5Rm9yRXZlbnQoY29uc3QgV2ViSW5wdXRFdmVudCogaW5wdXRF dmVudCwgV2ViTmF2aQogICAgIGJvb2wgYWx0ID0gbW91c2VFdmVudC0+bW9kaWZpZXJzICYgV2Vi TW91c2VFdmVudDo6QWx0S2V5OwogICAgIGJvb2wgbWV0YSA9IG1vdXNlRXZlbnQtPm1vZGlmaWVy cyAmIFdlYk1vdXNlRXZlbnQ6Ok1ldGFLZXk7CiAKLSAgICBXZWJWaWV3SW1wbDo6bmF2aWdhdGlv blBvbGljeUZyb21Nb3VzZUV2ZW50KGJ1dHRvbk51bWJlciwgY3RybCwgc2hpZnQsIGFsdCwgbWV0 YSwgcG9saWN5KTsKKyAgICBXZWJOYXZpZ2F0aW9uUG9saWN5IHVzZXJQb2xpY3kgPSAqcG9saWN5 OworICAgIFdlYlZpZXdJbXBsOjpuYXZpZ2F0aW9uUG9saWN5RnJvbU1vdXNlRXZlbnQoYnV0dG9u TnVtYmVyLCBjdHJsLCBzaGlmdCwgYWx0LCBtZXRhLCAmdXNlclBvbGljeSk7CisgICAgLy8gVXNl ciBhbmQgYXBwIGFncmVlIHRoYXQgd2Ugd2FudCBhIG5ldyB3aW5kb3c7IGxldCB0aGUgYXBwIG92 ZXJyaWRlIHRoZSBkZWNvcmF0aW9ucy4KKyAgICBpZiAodXNlclBvbGljeSA9PSBXZWJOYXZpZ2F0 aW9uUG9saWN5TmV3V2luZG93ICYmICpwb2xpY3kgPT0gV2ViTmF2aWdhdGlvblBvbGljeU5ld1Bv cHVwKQorICAgICAgICByZXR1cm47CisgICAgKnBvbGljeSA9IHVzZXJQb2xpY3k7CiB9CiAKIFdl Yk5hdmlnYXRpb25Qb2xpY3kgQ2hyb21lQ2xpZW50SW1wbDo6Z2V0TmF2aWdhdGlvblBvbGljeSgp Cg==