102251 2012-11-14 10:56:55 -0800 [Mac] Implement WTR --no-timeout-at-all option 2012-11-15 10:13:26 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap beidson rniwa webkit.review.bot oldest_to_newest 767059 0 ap 2012-11-14 10:56:55 -0800 Currently, WTR just crashes when it's used. A FIXME says that the option is needed for performance testing, but it would also be good if WTR didn't die while being debugged. 767070 1 174204 ap 2012-11-14 11:06:56 -0800 Created attachment 174204 proposed patch 767961 2 174204 buildbot 2012-11-15 04:53:24 -0800 Comment on attachment 174204 proposed patch Attachment 174204 did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14858017 New failing tests: inspector-protocol/nmi-webaudio.html 768112 3 174204 ap 2012-11-15 08:32:07 -0800 Comment on attachment 174204 proposed patch Test failure is obviously unrelated. 768131 4 174204 webkit.review.bot 2012-11-15 08:51:31 -0800 Comment on attachment 174204 proposed patch Clearing flags on attachment: 174204 Committed r134780: <http://trac.webkit.org/changeset/134780> 768132 5 webkit.review.bot 2012-11-15 08:51:35 -0800 All reviewed patches have been landed. Closing bug. 768166 6 174204 beidson 2012-11-15 09:20:06 -0800 Comment on attachment 174204 proposed patch Is m_noTimeout equal to zero? If so, can the conditional be (timeout != m_noTimeout) ? 768167 7 beidson 2012-11-15 09:20:26 -0800 Whoops, didn't mean to remark for review. 768231 8 ap 2012-11-15 10:13:26 -0800 > Is m_noTimeout equal to zero? If so, can the conditional be (timeout != m_noTimeout) ? m_noTimeout is -1, but I don't see any practical difference between these checks. No non-positive timeout ever makes sense, because WTR will immediately die failing to handle any messages to WebProcess. 174204 2012-11-14 11:06:56 -0800 2012-11-15 09:20:33 -0800 proposed patch NoTimeoutAtAll.txt text/plain 1824 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEzNDYyOSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDEyLTExLTE0ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIFtNYWNdIEltcGxlbWVudCBXVFIgLS1uby10aW1lb3V0LWF0LWFsbCBvcHRp b24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMjI1 MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2Vi S2l0VGVzdFJ1bm5lci9tYWMvVGVzdENvbnRyb2xsZXJNYWMubW06IChXVFI6OlRlc3RDb250cm9s bGVyOjpwbGF0Zm9ybVJ1blVudGlsKToKKyAgICAgICAgSnVzdCBkbyBpdCwgYW5kIGNvbnZlcnQg dG8gT2JqZWN0aXZlIEMgb24gdGhlIHdheSBmb3Igc2ltcGxpY2l0eS4KKwogMjAxMi0xMS0xNCAg SsOhbm9zIEJhZGljcyAgPGpiYWRpY3NAaW5mLnUtc3plZ2VkLmh1PgogCiAgICAgICAgIFtRdF1b QVJNXSBGaXggJ251bGxwdHInIGlzIGEga2V5d29yZCBpbiBDKysxMSBbLVdjKysweC1jb21wYXRd IHdhcm5pbmcKSW5kZXg6IFRvb2xzL1dlYktpdFRlc3RSdW5uZXIvbWFjL1Rlc3RDb250cm9sbGVy TWFjLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1dlYktpdFRlc3RSdW5uZXIvbWFjL1Rlc3RDb250 cm9sbGVyTWFjLm1tCShyZXZpc2lvbiAxMzQzMTIpCisrKyBUb29scy9XZWJLaXRUZXN0UnVubmVy L21hYy9UZXN0Q29udHJvbGxlck1hYy5tbQkod29ya2luZyBjb3B5KQpAQCAtNTMsMTIgKzUzLDEw IEBAIHZvaWQgVGVzdENvbnRyb2xsZXI6OmluaXRpYWxpemVUZXN0UGx1Z2kKIAogdm9pZCBUZXN0 Q29udHJvbGxlcjo6cGxhdGZvcm1SdW5VbnRpbChib29sJiBkb25lLCBkb3VibGUgdGltZW91dCkK IHsKLSAgICAvLyBGSVhNRTogTm8gdGltZW91dCBzaG91bGQgb2NjdXIgaWYgdGltZW91dCBpcyBl cXVhbCB0byBtX25vVGltZW91dCAobmVjZXNzYXJ5IHdoZW4gcnVubmluZyBwZXJmb3JtYW5jZSB0 ZXN0cykuCi0gICAgQ0ZBYnNvbHV0ZVRpbWUgZW5kID0gQ0ZBYnNvbHV0ZVRpbWVHZXRDdXJyZW50 KCkgKyB0aW1lb3V0OwotICAgIENGRGF0ZVJlZiBlbmREYXRlID0gQ0ZEYXRlQ3JlYXRlKDAsIGVu ZCk7Ci0gICAgd2hpbGUgKCFkb25lICYmIENGQWJzb2x1dGVUaW1lR2V0Q3VycmVudCgpIDwgZW5k KQotICAgICAgICBbW05TUnVuTG9vcCBjdXJyZW50UnVuTG9vcF0gcnVuTW9kZTpOU0RlZmF1bHRS dW5Mb29wTW9kZSBiZWZvcmVEYXRlOihOU0RhdGUgKillbmREYXRlXTsKLSAgICBDRlJlbGVhc2Uo ZW5kRGF0ZSk7CisgICAgTlNEYXRlICplbmREYXRlID0gKHRpbWVvdXQgPiAwKSA/IFtOU0RhdGUg ZGF0ZVdpdGhUaW1lSW50ZXJ2YWxTaW5jZU5vdzp0aW1lb3V0XSA6IFtOU0RhdGUgZGlzdGFudEZ1 dHVyZV07CisKKyAgICB3aGlsZSAoIWRvbmUgJiYgW2VuZERhdGUgY29tcGFyZTpbTlNEYXRlIGRh dGVdXSA9PSBOU09yZGVyZWREZXNjZW5kaW5nKQorICAgICAgICBbW05TUnVuTG9vcCBjdXJyZW50 UnVuTG9vcF0gcnVuTW9kZTpOU0RlZmF1bHRSdW5Mb29wTW9kZSBiZWZvcmVEYXRlOmVuZERhdGVd OwogfQogCiB2b2lkIFRlc3RDb250cm9sbGVyOjpwbGF0Zm9ybUluaXRpYWxpemVDb250ZXh0KCkK