102249 2012-11-14 10:13:08 -0800 Fix compiler warnings about signed/unsigned comparison on i386 2012-11-15 04:46:32 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tmpsantos tmpsantos fpizlo ggaren gtk-ews haraken mark.lam sam webkit.review.bot xan.lopez oldest_to_newest 767003 0 tmpsantos 2012-11-14 10:13:08 -0800 Breaks ports building with -Werror. 767025 1 174197 tmpsantos 2012-11-14 10:30:38 -0800 Created attachment 174197 Patch 767030 2 174199 tmpsantos 2012-11-14 10:35:50 -0800 Created attachment 174199 Patch Fixed ChangeLog. 767046 3 174199 mark.lam 2012-11-14 10:48:21 -0800 Comment on attachment 174199 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174199&action=review > Source/JavaScriptCore/ChangeLog:8 > + Add casting to unsigned to shut gcc warnings. Build was broken on "shut" ==> "shut up" or "quiet down" > Source/JavaScriptCore/ChangeLog:9 > + ports compiling with -Werror. It's not applicable to every port. So, "ports" ==> "JSVALUE32_64 ports". > Source/JavaScriptCore/llint/LLIntData.cpp:94 > + ASSERT(JSValue::LowestTag == static_cast<unsigned> -7); Conceptually, this is good. But I'm not sure of the style. Elsewhere in the code, I either see examples like "unsigned(-7)" or "static_cast<unsigned>(-7)". I'd be more comfortable if you changed this to use one of those syntax. 767049 4 174199 gtk-ews 2012-11-14 10:51:03 -0800 Comment on attachment 174199 Patch Attachment 174199 did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/14833398 767228 5 174238 tmpsantos 2012-11-14 13:17:51 -0800 Created attachment 174238 Patch 767229 6 mark.lam 2012-11-14 13:19:45 -0800 LGTM, but need someone else to r+ cq+. 767955 7 174238 webkit.review.bot 2012-11-15 04:46:27 -0800 Comment on attachment 174238 Patch Clearing flags on attachment: 174238 Committed r134763: <http://trac.webkit.org/changeset/134763> 767956 8 webkit.review.bot 2012-11-15 04:46:32 -0800 All reviewed patches have been landed. Closing bug. 174197 2012-11-14 10:30:38 -0800 2012-11-14 10:35:42 -0800 Patch bug-102249-20121114203240.patch text/plain 2204 tmpsantos U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0NjIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA4 YjljOTE0MTMzMmZiOTA4ZjFkMTc1ZjcxYWY3OTgwNTIxNTg1ZmY3Li5mYzc2MzM2MWZmMTlkOTJj M2NmMjkzN2YxMTc2NmUwZDQ3MDYwNTZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxMi0xMS0xNCAgVGhpYWdvIE1hcmNvcyBQLiBTYW50b3MgIDx0aGlhZ28u c2FudG9zQGludGVsLmNvbT4KKworICAgICAgICBGaXggY29tcGlsZXIgd2FybmluZ3MgYWJvdXQg c2lnbmVkL3Vuc2lnbmVkIGNvbXBhcmlzb24gb24gaTM4NgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAyMjQ5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGNhc3RpbmcgdG8gc2lnbmVkIHRvIHNodXQg Z2NjIHdhcm5pbmdzLiBCdWlsZCB3YXMgYnJva2VuIG9uCisgICAgICAgIHBvcnRzIGNvbXBpbGlu ZyB3aXRoIC1XZXJyb3IuCisKKyAgICAgICAgKiBsbGludC9MTEludERhdGEuY3BwOgorICAgICAg ICAoSlNDOjpMTEludDo6RGF0YTo6cGVyZm9ybUFzc2VydGlvbnMpOgorCiAyMDEyLTExLTE0ICBQ ZXRlciBHYWwgIDxnYWxwZXRlckBpbmYudS1zemVnZWQuaHU+CiAKICAgICAgICAgW1F0XVtBUk1d UkVHUkVTU0lPTihyMTMzOTg1KTogSXQgYnJva2UgdGhlIGJ1aWxkCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTExJbnREYXRhLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9sbGludC9MTEludERhdGEuY3BwCmluZGV4IGVlYzM3NmIzNzlhZTg2M2RlNjUxNmNjODdk YjM2ZGFiYzRmMzkxZDIuLjMxYzg2ZjZmNzhiYzY4MWRhNzdlZDMzMTMyZjJmYjk5Nzc2OTM5Njcg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9MTEludERhdGEuY3BwCisr KyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9MTEludERhdGEuY3BwCkBAIC04NCwxNCAr ODQsMTQgQEAgdm9pZCBEYXRhOjpwZXJmb3JtQXNzZXJ0aW9ucyhKU0dsb2JhbERhdGEmIGdsb2Jh bERhdGEpCiAgICAgQVNTRVJUKE9CSkVDVF9PRkZTRVRPRihFbmNvZGVkVmFsdWVEZXNjcmlwdG9y LCBhc0JpdHMucGF5bG9hZCkgPT0gMCk7CiAjZW5kaWYKICNpZiBVU0UoSlNWQUxVRTMyXzY0KQot ICAgIEFTU0VSVChKU1ZhbHVlOjpJbnQzMlRhZyA9PSAtMSk7Ci0gICAgQVNTRVJUKEpTVmFsdWU6 OkJvb2xlYW5UYWcgPT0gLTIpOwotICAgIEFTU0VSVChKU1ZhbHVlOjpOdWxsVGFnID09IC0zKTsK LSAgICBBU1NFUlQoSlNWYWx1ZTo6VW5kZWZpbmVkVGFnID09IC00KTsKLSAgICBBU1NFUlQoSlNW YWx1ZTo6Q2VsbFRhZyA9PSAtNSk7Ci0gICAgQVNTRVJUKEpTVmFsdWU6OkVtcHR5VmFsdWVUYWcg PT0gLTYpOwotICAgIEFTU0VSVChKU1ZhbHVlOjpEZWxldGVkVmFsdWVUYWcgPT0gLTcpOwotICAg IEFTU0VSVChKU1ZhbHVlOjpMb3dlc3RUYWcgPT0gLTcpOworICAgIEFTU0VSVChKU1ZhbHVlOjpJ bnQzMlRhZyA9PSBzdGF0aWNfY2FzdDx1bnNpZ25lZD4gLTEpOworICAgIEFTU0VSVChKU1ZhbHVl OjpCb29sZWFuVGFnID09IHN0YXRpY19jYXN0PHVuc2lnbmVkPiAtMik7CisgICAgQVNTRVJUKEpT VmFsdWU6Ok51bGxUYWcgPT0gc3RhdGljX2Nhc3Q8dW5zaWduZWQ+IC0zKTsKKyAgICBBU1NFUlQo SlNWYWx1ZTo6VW5kZWZpbmVkVGFnID09IHN0YXRpY19jYXN0PHVuc2lnbmVkPiAtNCk7CisgICAg QVNTRVJUKEpTVmFsdWU6OkNlbGxUYWcgPT0gc3RhdGljX2Nhc3Q8dW5zaWduZWQ+IC01KTsKKyAg ICBBU1NFUlQoSlNWYWx1ZTo6RW1wdHlWYWx1ZVRhZyA9PSBzdGF0aWNfY2FzdDx1bnNpZ25lZD4g LTYpOworICAgIEFTU0VSVChKU1ZhbHVlOjpEZWxldGVkVmFsdWVUYWcgPT0gc3RhdGljX2Nhc3Q8 dW5zaWduZWQ+IC03KTsKKyAgICBBU1NFUlQoSlNWYWx1ZTo6TG93ZXN0VGFnID09IHN0YXRpY19j YXN0PHVuc2lnbmVkPiAtNyk7CiAjZWxzZQogICAgIEFTU0VSVChUYWdCaXRUeXBlT3RoZXIgPT0g MHgyKTsKICAgICBBU1NFUlQoVGFnQml0Qm9vbCA9PSAweDQpOwo= 174199 2012-11-14 10:35:50 -0800 2012-11-14 13:17:46 -0800 Patch bug-102249-20121114203751.patch text/plain 2206 tmpsantos U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0NjIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA4 YjljOTE0MTMzMmZiOTA4ZjFkMTc1ZjcxYWY3OTgwNTIxNTg1ZmY3Li5kNGZjNGM1MzdhNmVhMDVj ZGM1ZmIwNWRmZWNjYjRmZTRlMzYwYzI2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxMi0xMS0xNCAgVGhpYWdvIE1hcmNvcyBQLiBTYW50b3MgIDx0aGlhZ28u c2FudG9zQGludGVsLmNvbT4KKworICAgICAgICBGaXggY29tcGlsZXIgd2FybmluZ3MgYWJvdXQg c2lnbmVkL3Vuc2lnbmVkIGNvbXBhcmlzb24gb24gaTM4NgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAyMjQ5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGNhc3RpbmcgdG8gdW5zaWduZWQgdG8gc2h1 dCBnY2Mgd2FybmluZ3MuIEJ1aWxkIHdhcyBicm9rZW4gb24KKyAgICAgICAgcG9ydHMgY29tcGls aW5nIHdpdGggLVdlcnJvci4KKworICAgICAgICAqIGxsaW50L0xMSW50RGF0YS5jcHA6CisgICAg ICAgIChKU0M6OkxMSW50OjpEYXRhOjpwZXJmb3JtQXNzZXJ0aW9ucyk6CisKIDIwMTItMTEtMTQg IFBldGVyIEdhbCAgPGdhbHBldGVyQGluZi51LXN6ZWdlZC5odT4KIAogICAgICAgICBbUXRdW0FS TV1SRUdSRVNTSU9OKHIxMzM5ODUpOiBJdCBicm9rZSB0aGUgYnVpbGQKZGlmZiAtLWdpdCBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9MTEludERhdGEuY3BwIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL2xsaW50L0xMSW50RGF0YS5jcHAKaW5kZXggZWVjMzc2YjM3OWFlODYzZGU2NTE2Y2M4 N2RiMzZkYWJjNGYzOTFkMi4uMzFjODZmNmY3OGJjNjgxZGE3N2VkMzMxMzJmMmZiOTk3NzY5Mzk2 NyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xMSW50RGF0YS5jcHAK KysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xMSW50RGF0YS5jcHAKQEAgLTg0LDE0 ICs4NCwxNCBAQCB2b2lkIERhdGE6OnBlcmZvcm1Bc3NlcnRpb25zKEpTR2xvYmFsRGF0YSYgZ2xv YmFsRGF0YSkKICAgICBBU1NFUlQoT0JKRUNUX09GRlNFVE9GKEVuY29kZWRWYWx1ZURlc2NyaXB0 b3IsIGFzQml0cy5wYXlsb2FkKSA9PSAwKTsKICNlbmRpZgogI2lmIFVTRShKU1ZBTFVFMzJfNjQp Ci0gICAgQVNTRVJUKEpTVmFsdWU6OkludDMyVGFnID09IC0xKTsKLSAgICBBU1NFUlQoSlNWYWx1 ZTo6Qm9vbGVhblRhZyA9PSAtMik7Ci0gICAgQVNTRVJUKEpTVmFsdWU6Ok51bGxUYWcgPT0gLTMp OwotICAgIEFTU0VSVChKU1ZhbHVlOjpVbmRlZmluZWRUYWcgPT0gLTQpOwotICAgIEFTU0VSVChK U1ZhbHVlOjpDZWxsVGFnID09IC01KTsKLSAgICBBU1NFUlQoSlNWYWx1ZTo6RW1wdHlWYWx1ZVRh ZyA9PSAtNik7Ci0gICAgQVNTRVJUKEpTVmFsdWU6OkRlbGV0ZWRWYWx1ZVRhZyA9PSAtNyk7Ci0g ICAgQVNTRVJUKEpTVmFsdWU6Okxvd2VzdFRhZyA9PSAtNyk7CisgICAgQVNTRVJUKEpTVmFsdWU6 OkludDMyVGFnID09IHN0YXRpY19jYXN0PHVuc2lnbmVkPiAtMSk7CisgICAgQVNTRVJUKEpTVmFs dWU6OkJvb2xlYW5UYWcgPT0gc3RhdGljX2Nhc3Q8dW5zaWduZWQ+IC0yKTsKKyAgICBBU1NFUlQo SlNWYWx1ZTo6TnVsbFRhZyA9PSBzdGF0aWNfY2FzdDx1bnNpZ25lZD4gLTMpOworICAgIEFTU0VS VChKU1ZhbHVlOjpVbmRlZmluZWRUYWcgPT0gc3RhdGljX2Nhc3Q8dW5zaWduZWQ+IC00KTsKKyAg ICBBU1NFUlQoSlNWYWx1ZTo6Q2VsbFRhZyA9PSBzdGF0aWNfY2FzdDx1bnNpZ25lZD4gLTUpOwor ICAgIEFTU0VSVChKU1ZhbHVlOjpFbXB0eVZhbHVlVGFnID09IHN0YXRpY19jYXN0PHVuc2lnbmVk PiAtNik7CisgICAgQVNTRVJUKEpTVmFsdWU6OkRlbGV0ZWRWYWx1ZVRhZyA9PSBzdGF0aWNfY2Fz dDx1bnNpZ25lZD4gLTcpOworICAgIEFTU0VSVChKU1ZhbHVlOjpMb3dlc3RUYWcgPT0gc3RhdGlj X2Nhc3Q8dW5zaWduZWQ+IC03KTsKICNlbHNlCiAgICAgQVNTRVJUKFRhZ0JpdFR5cGVPdGhlciA9 PSAweDIpOwogICAgIEFTU0VSVChUYWdCaXRCb29sID09IDB4NCk7Cg== 174238 2012-11-14 13:17:51 -0800 2012-11-15 04:46:27 -0800 Patch bug-102249-20121114231549.patch text/plain 2245 tmpsantos U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0NjQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBm OGExMGNjZGUxNjkzNjEwNWE5YmYyNDZjYzBjYzhlNmQzNDZmMWMzLi4zZWVkZDEwOTY0MGNjNzYw Yjc4MDdhMTA4YzJjYzU3M2ZlMTNhYzYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxMi0xMS0xNCAgVGhpYWdvIE1hcmNvcyBQLiBTYW50b3MgIDx0aGlhZ28u c2FudG9zQGludGVsLmNvbT4KKworICAgICAgICBGaXggY29tcGlsZXIgd2FybmluZ3MgYWJvdXQg c2lnbmVkL3Vuc2lnbmVkIGNvbXBhcmlzb24gb24gaTM4NgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAyMjQ5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGNhc3RpbmcgdG8gdW5zaWduZWQgdG8gc2h1 dCB1cCBnY2Mgd2FybmluZ3MuIEJ1aWxkIHdhcyBicm9rZW4gb24KKyAgICAgICAgSlNWQUxVRTMy XzY0IHBvcnRzIGNvbXBpbGluZyB3aXRoIC1XZXJyb3IuCisKKyAgICAgICAgKiBsbGludC9MTElu dERhdGEuY3BwOgorICAgICAgICAoSlNDOjpMTEludDo6RGF0YTo6cGVyZm9ybUFzc2VydGlvbnMp OgorCiAyMDEyLTExLTE0ICBWYWxlcnkgSWduYXR5ZXYgIDx2YWxlcnkuaWduYXR5ZXZAaXNwcmFz LnJ1PgogCiAgICAgICAgIFJlcGxhY2UgKHR5cGVvZih4KSAhPSA8Im9iamVjdCIsICJ1bmRlZmlu ZWQiLCAuLi4+KSB3aXRoCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQv TExJbnREYXRhLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9MTEludERhdGEuY3Bw CmluZGV4IGVlYzM3NmIzNzlhZTg2M2RlNjUxNmNjODdkYjM2ZGFiYzRmMzkxZDIuLjkwZmFmZjJl ZWI5NTc4ZDE2MzE2Mzg3NDgwOGYzMGVlNTk3NzY4MDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9sbGludC9MTEludERhdGEuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9sbGludC9MTEludERhdGEuY3BwCkBAIC04NCwxNCArODQsMTQgQEAgdm9pZCBEYXRhOjpwZXJm b3JtQXNzZXJ0aW9ucyhKU0dsb2JhbERhdGEmIGdsb2JhbERhdGEpCiAgICAgQVNTRVJUKE9CSkVD VF9PRkZTRVRPRihFbmNvZGVkVmFsdWVEZXNjcmlwdG9yLCBhc0JpdHMucGF5bG9hZCkgPT0gMCk7 CiAjZW5kaWYKICNpZiBVU0UoSlNWQUxVRTMyXzY0KQotICAgIEFTU0VSVChKU1ZhbHVlOjpJbnQz MlRhZyA9PSAtMSk7Ci0gICAgQVNTRVJUKEpTVmFsdWU6OkJvb2xlYW5UYWcgPT0gLTIpOwotICAg IEFTU0VSVChKU1ZhbHVlOjpOdWxsVGFnID09IC0zKTsKLSAgICBBU1NFUlQoSlNWYWx1ZTo6VW5k ZWZpbmVkVGFnID09IC00KTsKLSAgICBBU1NFUlQoSlNWYWx1ZTo6Q2VsbFRhZyA9PSAtNSk7Ci0g ICAgQVNTRVJUKEpTVmFsdWU6OkVtcHR5VmFsdWVUYWcgPT0gLTYpOwotICAgIEFTU0VSVChKU1Zh bHVlOjpEZWxldGVkVmFsdWVUYWcgPT0gLTcpOwotICAgIEFTU0VSVChKU1ZhbHVlOjpMb3dlc3RU YWcgPT0gLTcpOworICAgIEFTU0VSVChKU1ZhbHVlOjpJbnQzMlRhZyA9PSBzdGF0aWNfY2FzdDx1 bnNpZ25lZD4oLTEpKTsKKyAgICBBU1NFUlQoSlNWYWx1ZTo6Qm9vbGVhblRhZyA9PSBzdGF0aWNf Y2FzdDx1bnNpZ25lZD4oLTIpKTsKKyAgICBBU1NFUlQoSlNWYWx1ZTo6TnVsbFRhZyA9PSBzdGF0 aWNfY2FzdDx1bnNpZ25lZD4oLTMpKTsKKyAgICBBU1NFUlQoSlNWYWx1ZTo6VW5kZWZpbmVkVGFn ID09IHN0YXRpY19jYXN0PHVuc2lnbmVkPigtNCkpOworICAgIEFTU0VSVChKU1ZhbHVlOjpDZWxs VGFnID09IHN0YXRpY19jYXN0PHVuc2lnbmVkPigtNSkpOworICAgIEFTU0VSVChKU1ZhbHVlOjpF bXB0eVZhbHVlVGFnID09IHN0YXRpY19jYXN0PHVuc2lnbmVkPigtNikpOworICAgIEFTU0VSVChK U1ZhbHVlOjpEZWxldGVkVmFsdWVUYWcgPT0gc3RhdGljX2Nhc3Q8dW5zaWduZWQ+KC03KSk7Cisg ICAgQVNTRVJUKEpTVmFsdWU6Okxvd2VzdFRhZyA9PSBzdGF0aWNfY2FzdDx1bnNpZ25lZD4oLTcp KTsKICNlbHNlCiAgICAgQVNTRVJUKFRhZ0JpdFR5cGVPdGhlciA9PSAweDIpOwogICAgIEFTU0VS VChUYWdCaXRCb29sID09IDB4NCk7Cg==