102247 2012-11-14 10:02:11 -0800 webgl-background-color.html started failing 2012-11-15 16:40:34 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dglazkov jamesr abarth dpranke enne fishd jamesr kbr ojan webkit.review.bot oldest_to_newest 766996 0 dglazkov 2012-11-14 10:02:11 -0800 http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=platform%2Fchromium%2Fvirtual%2Fthreaded%2Fcompositing%2Fwebgl%2Fwebgl-background-color.html It's hard to say why. 767173 1 174223 jamesr 2012-11-14 12:28:10 -0800 Created attachment 174223 Patch 767181 2 jamesr 2012-11-14 12:35:53 -0800 The issue here was actually a timeout due to chromium http://src.chromium.org/viewvc/chrome?view=rev&revision=167537. WebViewHost's d'tor navigates the page (synchronously) to about:blank: http://code.google.com/searchframe#OAMlx_jo-ck/src/third_party/WebKit/Tools/DumpRenderTree/chromium/WebViewHost.cpp&exact_package=chromium&q=~WebViewHost&type=cs&l=1446 one consequence of which is disabling compositing mode, which triggers this finishAllRendering() call: http://code.google.com/searchframe#OAMlx_jo-ck/src/third_party/WebKit/Source/WebKit/chromium/src/WebViewImpl.cpp&exact_package=chromium&q=WebViewImpl.cpp&type=cs&l=3946 which attempts to make a synchronous call to the compositor thread. Since the compositor thread is destroyed first, this call went nowhere and the main thread simply sat blocked until it was killed by the harness. I think the reason http://src.chromium.org/viewvc/chrome?view=rev&revision=167537 tickled this was because of some subtleties in chromium's thread shutdown where the thread was living for longer, but I'm still tracking down exactly how this happened. 767187 3 jamesr 2012-11-14 12:37:36 -0800 This patch also makes TestShell's behavior more similar to chrome's, where the compositor thread always outlives WebView instances. 767195 4 174223 enne 2012-11-14 12:45:56 -0800 Comment on attachment 174223 Patch R=me. This really needs a better comment. 767244 5 dglazkov 2012-11-14 13:32:46 -0800 (In reply to comment #4) > (From update of attachment 174223 [details]) > R=me. This really needs a better comment. I think this change needs a meme. 767255 6 174246 jamesr 2012-11-14 13:45:35 -0800 Created attachment 174246 Patch for landing 767295 7 174246 webkit.review.bot 2012-11-14 14:09:45 -0800 Comment on attachment 174246 Patch for landing Clearing flags on attachment: 174246 Committed r134667: <http://trac.webkit.org/changeset/134667> 767296 8 webkit.review.bot 2012-11-14 14:09:49 -0800 All reviewed patches have been landed. Closing bug. 767421 9 ojan 2012-11-14 16:15:28 -0800 Is there a way to add asserts instead of just a comment? 767508 10 jamesr 2012-11-14 17:28:01 -0800 They aren't passing yet, although I think r134667 was a solid bug fix and should cut down on flaky crashes. There's one more race that https://codereview.chromium.org/11363254 should fix. Leaving open until it goes green... 768665 11 jamesr 2012-11-15 16:40:34 -0800 Fixed by http://src.chromium.org/viewvc/chrome?view=rev&revision=168037, removed failing expectation in http://trac.webkit.org/changeset/134857 174223 2012-11-14 12:28:10 -0800 2012-11-14 13:45:32 -0800 Patch bug-102247-20121114122609.patch text/plain 1384 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0NjIzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZDI4YWM4NjNkYmFkMjBmZTUzYjZiZWM4NGE0NTAzZWRl MmJlNjE2MS4uMjA4ZDVjMzI3YzEzM2RmNmVkZmI2MjRjM2JiYzRlMGMxOWQxYWY4MCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEyLTExLTE0ICBKYW1lcyBSb2JpbnNvbiAgPGphbWVzckBjaHJvbWl1bS5vcmc+CisK KyAgICAgICAgd2ViZ2wtYmFja2dyb3VuZC1jb2xvci5odG1sIHN0YXJ0ZWQgZmFpbGluZworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAyMjQ3CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGNvbXBvc2l0 b3IgdGhyZWFkIHNob3VsZCBvdXRsaXZlIHRoZSBXZWJWaWV3LgorCisgICAgICAgICogRHVtcFJl bmRlclRyZWUvY2hyb21pdW0vVGVzdFNoZWxsLmg6CisgICAgICAgIChUZXN0U2hlbGwpOgorCiAy MDEyLTExLTE0ICBKw6Fub3MgQmFkaWNzICA8amJhZGljc0BpbmYudS1zemVnZWQuaHU+CiAKICAg ICAgICAgW1F0XVtBUk1dIEZpeCAnbnVsbHB0cicgaXMgYSBrZXl3b3JkIGluIEMrKzExIFstV2Mr KzB4LWNvbXBhdF0gd2FybmluZwpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hy b21pdW0vVGVzdFNoZWxsLmggYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9UZXN0U2hl bGwuaAppbmRleCBjNDNiMDg0MTRmODJjNzQ1ODMyYzYwNWY3OWU5MGExNGY5MGE0OTA0Li5mMzc3 Y2YzZGQyM2ExODY3NjQ3ZDFiNGNlMGU0M2JlM2NjNDUzZWE0IDEwMDY0NAotLS0gYS9Ub29scy9E dW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9UZXN0U2hlbGwuaAorKysgYi9Ub29scy9EdW1wUmVuZGVy VHJlZS9jaHJvbWl1bS9UZXN0U2hlbGwuaApAQCAtMjE4LDggKzIxOCw4IEBAIHByaXZhdGU6CiAj aWYgRU5BQkxFKE5PVElGSUNBVElPTlMpIHx8IEVOQUJMRShMRUdBQ1lfTk9USUZJQ0FUSU9OUykK ICAgICBPd25QdHI8Tm90aWZpY2F0aW9uUHJlc2VudGVyPiBtX25vdGlmaWNhdGlvblByZXNlbnRl cjsKICNlbmRpZgotICAgIE93blB0cjxXZWJWaWV3SG9zdD4gbV93ZWJWaWV3SG9zdDsKICAgICBP d25QdHI8V2ViS2l0OjpXZWJUaHJlYWQ+IG1fd2ViQ29tcG9zaXRvclRocmVhZDsKKyAgICBPd25Q dHI8V2ViVmlld0hvc3Q+IG1fd2ViVmlld0hvc3Q7CiAjaWYgRU5BQkxFKExJTktfUFJFUkVOREVS KQogICAgIE93blB0cjxNb2NrV2ViUHJlcmVuZGVyaW5nU3VwcG9ydD4gbV9wcmVyZW5kZXJpbmdT dXBwb3J0OwogI2VuZGlmCg== 174246 2012-11-14 13:45:35 -0800 2012-11-14 14:09:45 -0800 Patch for landing bug-102247-20121114134334.patch text/plain 1461 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0NjIzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZDI4YWM4NjNkYmFkMjBmZTUzYjZiZWM4NGE0NTAzZWRl MmJlNjE2MS4uM2I0YTM5Mjk0MTY3MDQxYTJlYTRiMjAxOTg3Yjc2NThiZjM5ZTAwMyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEyLTExLTE0ICBKYW1lcyBSb2JpbnNvbiAgPGphbWVzckBjaHJvbWl1bS5vcmc+CisK KyAgICAgICAgd2ViZ2wtYmFja2dyb3VuZC1jb2xvci5odG1sIHN0YXJ0ZWQgZmFpbGluZworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAyMjQ3CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgQWRyaWVubmUgV2Fsa2VyLgorCisgICAgICAgIFRoZSBjb21wb3Np dG9yIHRocmVhZCBzaG91bGQgb3V0bGl2ZSB0aGUgV2ViVmlldy4KKworICAgICAgICAqIER1bXBS ZW5kZXJUcmVlL2Nocm9taXVtL1Rlc3RTaGVsbC5oOgorICAgICAgICAoVGVzdFNoZWxsKToKKwog MjAxMi0xMS0xNCAgSsOhbm9zIEJhZGljcyAgPGpiYWRpY3NAaW5mLnUtc3plZ2VkLmh1PgogCiAg ICAgICAgIFtRdF1bQVJNXSBGaXggJ251bGxwdHInIGlzIGEga2V5d29yZCBpbiBDKysxMSBbLVdj KysweC1jb21wYXRdIHdhcm5pbmcKZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2No cm9taXVtL1Rlc3RTaGVsbC5oIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vVGVzdFNo ZWxsLmgKaW5kZXggYzQzYjA4NDE0ZjgyYzc0NTgzMmM2MDVmNzllOTBhMTRmOTBhNDkwNC4uMTU2 MTA0MDAwZjZjZjAyMGNlYzA3NmEzMDhkYjM0NmM0ZTA5N2VkMSAxMDA2NDQKLS0tIGEvVG9vbHMv RHVtcFJlbmRlclRyZWUvY2hyb21pdW0vVGVzdFNoZWxsLmgKKysrIGIvVG9vbHMvRHVtcFJlbmRl clRyZWUvY2hyb21pdW0vVGVzdFNoZWxsLmgKQEAgLTIxOCw4ICsyMTgsOSBAQCBwcml2YXRlOgog I2lmIEVOQUJMRShOT1RJRklDQVRJT05TKSB8fCBFTkFCTEUoTEVHQUNZX05PVElGSUNBVElPTlMp CiAgICAgT3duUHRyPE5vdGlmaWNhdGlvblByZXNlbnRlcj4gbV9ub3RpZmljYXRpb25QcmVzZW50 ZXI7CiAjZW5kaWYKLSAgICBPd25QdHI8V2ViVmlld0hvc3Q+IG1fd2ViVmlld0hvc3Q7CisgICAg Ly8gSXQncyBpbXBvcnRhbnQgdGhhdCB0aGlzIHRocmVhZCBpcyBkZXN0cm95ZWQgYWZ0ZXIgdGhl IFdlYlZpZXdIb3N0LgogICAgIE93blB0cjxXZWJLaXQ6OldlYlRocmVhZD4gbV93ZWJDb21wb3Np dG9yVGhyZWFkOworICAgIE93blB0cjxXZWJWaWV3SG9zdD4gbV93ZWJWaWV3SG9zdDsKICNpZiBF TkFCTEUoTElOS19QUkVSRU5ERVIpCiAgICAgT3duUHRyPE1vY2tXZWJQcmVyZW5kZXJpbmdTdXBw b3J0PiBtX3ByZXJlbmRlcmluZ1N1cHBvcnQ7CiAjZW5kaWYK