102245 2012-11-14 09:56:22 -0800 Running TestWebKitAPI and webkit_unit_tests for Chromium Android should defer to the Chromium-sided test runner 2012-11-16 03:32:52 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 100100 1 peter peter abarth dpranke tony oldest_to_newest 766989 0 peter 2012-11-14 09:56:22 -0800 Duplicating most of the logic for running arbitrary test-suites is not worth the effort, especially given that Chromium already has an excellent testing framework. This change is dependent on the Chromium-side change which prepares it for WebKit usage, but changes there (in the argument usage) should be minimal. https://codereview.chromium.org/11312239/ Patch upcoming.. 767012 1 174193 peter 2012-11-14 10:19:08 -0800 Created attachment 174193 Patch 767087 2 174193 tony 2012-11-14 11:21:00 -0800 Comment on attachment 174193 Patch Do we need to wait for the chromium side to land and roll Source/WebKit/chromium/DEPS first? 767119 3 174193 peter 2012-11-14 11:36:59 -0800 Comment on attachment 174193 Patch It doesn't really matter, it's broken already. I'll pull in DEPS later in the week. Thanks for the review! 769066 4 peter 2012-11-16 03:23:49 -0800 Committed r134924: <http://trac.webkit.org/changeset/134924> 769072 5 174193 peter 2012-11-16 03:32:52 -0800 Comment on attachment 174193 Patch I rolled DEPS earlier today and landed this manually (as it's Android only and all the try-bots are green). Thanks again! 174193 2012-11-14 10:19:08 -0800 2012-11-16 03:32:52 -0800 Patch bug-102245-20121114181706.patch text/plain 3019 peter U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0NjA0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYWQ0ZTgyMmE4ZWI0ZDM5Yjg0YmQ0ZDg4YWQ5YzQ3OGJj ZDQ5NWIzZS4uYzIzOGU1YWIyZDNhM2YzMDQ1ZDFjZGExMWI5MjEyMzA5YzEyZTFmNCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDEyLTExLTE0ICBQZXRlciBCZXZlcmxvbyAgPHBldGVyQGNocm9taXVtLm9yZz4KKwor ICAgICAgICBSdW5uaW5nIFRlc3RXZWJLaXRBUEkgYW5kIHdlYmtpdF91bml0X3Rlc3RzIGZvciBD aHJvbWl1bSBBbmRyb2lkIHNob3VsZCBkZWZlciB0byB0aGUgQ2hyb21pdW0tc2lkZWQgdGVzdCBy dW5uZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEw MjI0NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdo ZW4gcnVubmluZyBUZXN0V2ViS2l0QVBJIGFuZCB3ZWJraXRfdW5pdF90ZXN0IGZvciBDaHJvbWl1 bSBBbmRyb2lkLCBkZWZlcgorICAgICAgICB0aGUgYWN0dWFsIHJ1bm5pbmcgcGFydCB0byB0aGUg dGVzdCBydW5uZXIgd2hpY2ggbGl2ZXMgb24gdGhlIENocm9taXVtIHNpZGUuCisgICAgICAgIFJl LWltcGxlbWVudGluZyBvciBldmVuIGdlbmVyYWxpemluZyB0aGUgZGV2aWNlLWludGVyYWN0aW9u IHBhcnQgaW4gV2ViS2l0CisgICAgICAgIGlzIGVycm9yIHByb25lIGFuZCBub3Qgd29ydGggdGhl IGVmZm9ydC4KKworICAgICAgICAqIFNjcmlwdHMvcnVuLWFwaS10ZXN0czoKKyAgICAgICAgKiBT Y3JpcHRzL3J1bi1jaHJvbWl1bS13ZWJraXQtdW5pdC10ZXN0czoKKwogMjAxMi0xMS0xNCAgVGhp YWdvIE1hcmNvcyBQLiBTYW50b3MgIDx0aGlhZ28uc2FudG9zQGludGVsLmNvbT4KIAogICAgICAg ICBSRUdSRVNTSU9OKHIxMzM3NTcpOiBDYXVzaW5nIHdlYmtpdHB5IHVuaXQgdGVzdHMgdG8gZmFp bApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9ydW4tYXBpLXRlc3RzIGIvVG9vbHMvU2NyaXB0 cy9ydW4tYXBpLXRlc3RzCmluZGV4IDNhM2UwMGNkYTc4NWI2MWNlNTM1YzczMjBmYmYzNjE0OGIw OTc2ZjguLjU5MTNjZWU4ZjM1YWEzMjQ3NzI5NWM2ZDYzMDFlOGJlMjM4ZTYxZWIgMTAwNzU1Ci0t LSBhL1Rvb2xzL1NjcmlwdHMvcnVuLWFwaS10ZXN0cworKysgYi9Ub29scy9TY3JpcHRzL3J1bi1h cGktdGVzdHMKQEAgLTc5LDYgKzc5LDE5IEBAIGlmICgkc2hvd0hlbHApIHsKIH0KIAogc2V0Q29u ZmlndXJhdGlvbigpOworCisjIFdoZW4gcnVubmluZyBUZXN0V2ViS2l0QVBJIGZvciBDaHJvbWl1 bSBvbiBBbmRyb2lkLCBkZWZlciB0byB0aGUgdGVzdCBydW5uZXIgaW4KKyMgQ2hyb21pdW0gYXMg d2UgY2FuJ3QgZXhlY3V0ZSB0aGUgYmluYXJ5IGxvY2FsbHkuCitpZiAoaXNDaHJvbWl1bUFuZHJv aWQoKSkgeworICAgIG15IEBydW5UZXN0Q29tbWFuZCA9ICgnYnVpbGQvYW5kcm9pZC9ydW5fdGVz dHMucHknLCAnLS12ZXJib3NlJywgJy0td2Via2l0JywgJy0tb3V0LWRpcmVjdG9yeScsIHNvdXJj ZURpcigpIC4gJy9vdXQnLCAnLXMnLCAnVGVzdFdlYktpdEFQSScpOworICAgIGlmIChjb25maWd1 cmF0aW9uKCkgZXEgIlJlbGVhc2UiKSB7CisgICAgICAgIHB1c2ggQHJ1blRlc3RDb21tYW5kLCAn LS1yZWxlYXNlJzsKKyAgICB9CisKKyAgICBjaGRpcihzb3VyY2VEaXIoKSAuICcvU291cmNlL1dl YktpdC9jaHJvbWl1bScpIG9yIGRpZSAkITsKKyAgICBleGl0IGV4aXRTdGF0dXMoc3lzdGVtKEBy dW5UZXN0Q29tbWFuZCkpOworfQorCiBidWlsZFRlc3RUb29sKCkgaWYgJGJ1aWxkOwogc2V0UGF0 aEZvclJ1bm5pbmdXZWJLaXRBcHAoXCVFTlYpOwogbXkgQHRlc3RzVG9SdW4gPSBsaXN0QWxsVGVz dHMoKTsKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvcnVuLWNocm9taXVtLXdlYmtpdC11bml0 LXRlc3RzIGIvVG9vbHMvU2NyaXB0cy9ydW4tY2hyb21pdW0td2Via2l0LXVuaXQtdGVzdHMKaW5k ZXggNDNmODVhZDNlZDIzY2JmNGNiMWQzMjczN2IwNjFhNzg0MDlhMmM4My4uMzNjN2NjMjVlNzVh ZjU2ZGRmZDVjNWJmY2UyNDJkZGRiZmY1NzliYiAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9y dW4tY2hyb21pdW0td2Via2l0LXVuaXQtdGVzdHMKKysrIGIvVG9vbHMvU2NyaXB0cy9ydW4tY2hy b21pdW0td2Via2l0LXVuaXQtdGVzdHMKQEAgLTM0LDcgKzM0LDE5IEBAIHVzZSBsaWIgJEZpbmRC aW46OkJpbjsKIHVzZSB3ZWJraXRkaXJzOwogdXNlIFZDU1V0aWxzOwogCi1wdXNoKEBBUkdWLCAi LS1jaHJvbWl1bSIpOwogc2V0Q29uZmlndXJhdGlvbigpOworCisjIERlZmVyIHRvIEFuZHJvaWQn cyB0ZXN0IHJ1bm5lcnMgZm9yIHJ1bm5pbmcgd2Via2l0X3VuaXRfdGVzdHMgb24gYSBkZXZpY2Uu CitpZiAoY2hlY2tGb3JBcmd1bWVudEFuZFJlbW92ZUZyb21BUkdWKCctLXBsYXRmb3JtPWNocm9t aXVtLWFuZHJvaWQnKSkgeworICAgIG15IEBydW5UZXN0Q29tbWFuZCA9ICgnYnVpbGQvYW5kcm9p ZC9ydW5fdGVzdHMucHknLCAnLS12ZXJib3NlJywgJy0td2Via2l0JywgJy0tb3V0LWRpcmVjdG9y eScsIHNvdXJjZURpcigpIC4gJy9vdXQnLCAnLXMnLCAnd2Via2l0X3VuaXRfdGVzdHMnKTsKKyAg ICBpZiAoY29uZmlndXJhdGlvbigpIGVxICJSZWxlYXNlIikgeworICAgICAgICBwdXNoIEBydW5U ZXN0Q29tbWFuZCwgJy0tcmVsZWFzZSc7CisgICAgfQorCisgICAgY2hkaXIoc291cmNlRGlyKCkg LiAnL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0nKSBvciBkaWUgJCE7CisgICAgZXhpdCBleGl0U3Rh dHVzKHN5c3RlbShAcnVuVGVzdENvbW1hbmQpKTsKK30KKworcHVzaChAQVJHViwgIi0tY2hyb21p dW0iKTsKIG15ICRwYXRoVG9CaW5hcnkgPSBwcm9kdWN0RGlyKCkgLiAiL3dlYmtpdF91bml0X3Rl c3RzIjsKIGV4aXQgZXhpdFN0YXR1cyhzeXN0ZW0gKCRwYXRoVG9CaW5hcnksIEBBUkdWKSk7Cg==