102242 2012-11-14 08:52:49 -0800 Dynamically create canvas in Setup() to avoid calling DEPRECATED function setDevice(). 2012-11-14 10:43:57 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 reed reed hclam senorblanco webkit.review.bot oldest_to_newest 766946 0 reed 2012-11-14 08:52:49 -0800 Dynamically create canvas in Setup() to avoid calling DEPRECATED function setDevice(). 766951 1 174174 reed 2012-11-14 08:54:08 -0800 Created attachment 174174 Patch 766958 2 174174 hclam 2012-11-14 09:07:00 -0800 Comment on attachment 174174 Patch LGTM. 766980 3 reed 2012-11-14 09:45:21 -0800 stephen, can I hear a 2nd? 767019 4 174174 senorblanco 2012-11-14 10:24:30 -0800 Comment on attachment 174174 Patch OK. r=me 767041 5 174174 webkit.review.bot 2012-11-14 10:43:54 -0800 Comment on attachment 174174 Patch Clearing flags on attachment: 174174 Committed r134626: <http://trac.webkit.org/changeset/134626> 767042 6 webkit.review.bot 2012-11-14 10:43:57 -0800 All reviewed patches have been landed. Closing bug. 174174 2012-11-14 08:54:08 -0800 2012-11-14 10:43:54 -0800 Patch bug-102242-20121114115206.patch text/plain 2851 reed SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiAxMzQ2MTQpCisrKyBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIw IEBACisyMDEyLTExLTE0ICBNaWtlIFJlZWQgIDxyZWVkQGdvb2dsZS5jb20+CisKKyAgICAgICAg RHluYW1pY2FsbHkgY3JlYXRlIGNhbnZhcyBpbiBTZXR1cCgpIHRvIGF2b2lkIGNhbGxpbmcgREVQ UkVDQVRFRCBmdW5jdGlvbiBzZXREZXZpY2UoKS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMjI0MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgY2hhbmdlIHNob3VsZCBub3QgY2hhbmdlIGFueSB0 ZXN0IHJlc3VsdHMsIGl0IGlzIGFuIGVxdWl2YWxlbnQgaW1wbGVtZW50YXRpb24gdGhhdCBhdm9p ZHMKKyAgICAgICAgdXNpbmcgYSAobm93KSBERVBSRUNBVEVEIGZ1bmN0aW9uLgorCisgICAgICAg ICogdGVzdHMvRGVmZXJyZWRJbWFnZURlY29kZXJUZXN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OmNyZWF0ZVJhc3RlckNhbnZhcyk6CisgICAgICAgIChXZWJDb3JlKToKKyAgICAgICAgKFdlYkNv cmU6OkRlZmVycmVkSW1hZ2VEZWNvZGVyVGVzdDo6U2V0VXApOgorICAgICAgICAoRGVmZXJyZWRJ bWFnZURlY29kZXJUZXN0KToKKyAgICAgICAgKFdlYkNvcmU6OlRFU1RfRik6CisKIDIwMTItMTEt MTQgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAg IFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxMzQ1MjMuCkluZGV4OiBTb3VyY2UvV2ViS2l0L2No cm9taXVtL3Rlc3RzL0RlZmVycmVkSW1hZ2VEZWNvZGVyVGVzdC5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9EZWZlcnJlZEltYWdlRGVjb2RlclRlc3QuY3Bw CShyZXZpc2lvbiAxMzQ2MTEpCisrKyBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL0RlZmVy cmVkSW1hZ2VEZWNvZGVyVGVzdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM5LDYgKzM5LDEyIEBA IHVzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOwogCiBuYW1lc3BhY2UgewogCitzdGF0aWMgU2tDYW52 YXMqIGNyZWF0ZVJhc3RlckNhbnZhcyhpbnQgd2lkdGgsIGludCBoZWlnaHQpCit7CisgICAgU2tB dXRvVFVucmVmPFNrRGV2aWNlPiBkZXZpY2UobmV3IFNrRGV2aWNlKFNrQml0bWFwOjprQVJHQl84 ODg4X0NvbmZpZywgd2lkdGgsIGhlaWdodCkpOworICAgIHJldHVybiBuZXcgU2tDYW52YXMoZGV2 aWNlKTsKK30KKwogY2xhc3MgRGVmZXJyZWRJbWFnZURlY29kZXJUZXN0IDogcHVibGljIDo6dGVz dGluZzo6VGVzdCB7CiBwdWJsaWM6CiAgICAgdmlydHVhbCB2b2lkIFNldFVwKCkKQEAgLTQ3LDcg KzUzLDcgQEAgcHVibGljOgogICAgICAgICBtX2FjdHVhbERlY29kZXIgPSBuZXcgTW9ja0ltYWdl RGVjb2RlcigpOwogICAgICAgICBtX2FjdHVhbERlY29kZXItPnNldFNpemUoNjAwLCA2MTMpOwog ICAgICAgICBtX2xhenlEZWNvZGVyID0gRGVmZXJyZWRJbWFnZURlY29kZXI6OmNyZWF0ZUZvclRl c3RpbmcoYWRvcHRQdHIobV9hY3R1YWxEZWNvZGVyKSk7Ci0gICAgICAgIG1fY2FudmFzLnNldERl dmljZShuZXcgU2tEZXZpY2UoU2tCaXRtYXA6OmtBUkdCXzg4ODhfQ29uZmlnLCAxMDAsIDEwMCkp LT51bnJlZigpOworICAgICAgICBtX2NhbnZhcy5yZXNldChjcmVhdGVSYXN0ZXJDYW52YXMoMTAw LCAxMDApKTsKICAgICB9CiAKICAgICB2aXJ0dWFsIHZvaWQgVGVhckRvd24oKQpAQCAtNjAsNyAr NjYsNyBAQCBwcm90ZWN0ZWQ6CiAgICAgTW9ja0ltYWdlRGVjb2RlciogbV9hY3R1YWxEZWNvZGVy OwogICAgIE93blB0cjxEZWZlcnJlZEltYWdlRGVjb2Rlcj4gbV9sYXp5RGVjb2RlcjsKICAgICBT a1BpY3R1cmUgbV9waWN0dXJlOwotICAgIFNrQ2FudmFzIG1fY2FudmFzOworICAgIFNrQXV0b1RV bnJlZjxTa0NhbnZhcz4gbV9jYW52YXM7CiB9OwogCiBURVNUX0YoRGVmZXJyZWRJbWFnZURlY29k ZXJUZXN0LCBkcmF3SW50b1NrUGljdHVyZSkKQEAgLTc2LDcgKzgyLDcgQEAgVEVTVF9GKERlZmVy cmVkSW1hZ2VEZWNvZGVyVGVzdCwgZHJhd0ludAogICAgIG1fcGljdHVyZS5lbmRSZWNvcmRpbmco KTsKICAgICBFWFBFQ1RfRVEoMCwgbV9hY3R1YWxEZWNvZGVyLT5mcmFtZUJ1ZmZlclJlcXVlc3RD b3VudCgpKTsKIAotICAgIG1fY2FudmFzLmRyYXdQaWN0dXJlKG1fcGljdHVyZSk7CisgICAgbV9j YW52YXMtPmRyYXdQaWN0dXJlKG1fcGljdHVyZSk7CiAgICAgRVhQRUNUX0VRKDEsIG1fYWN0dWFs RGVjb2Rlci0+ZnJhbWVCdWZmZXJSZXF1ZXN0Q291bnQoKSk7CiB9CiAKQEAgLTk1LDcgKzEwMSw3 IEBAIFRFU1RfRihEZWZlcnJlZEltYWdlRGVjb2RlclRlc3QsIGRyYXdTY2EKICAgICBtX3BpY3R1 cmUuZW5kUmVjb3JkaW5nKCk7CiAgICAgRVhQRUNUX0VRKDAsIG1fYWN0dWFsRGVjb2Rlci0+ZnJh bWVCdWZmZXJSZXF1ZXN0Q291bnQoKSk7CiAKLSAgICBtX2NhbnZhcy5kcmF3UGljdHVyZShtX3Bp Y3R1cmUpOworICAgIG1fY2FudmFzLT5kcmF3UGljdHVyZShtX3BpY3R1cmUpOwogICAgIEVYUEVD VF9FUSgxLCBtX2FjdHVhbERlY29kZXItPmZyYW1lQnVmZmVyUmVxdWVzdENvdW50KCkpOwogfQog Cg==