102236 2012-11-14 07:53:14 -0800 [BlackBerry] Use mispelled-marker offsets relative to the element 2012-11-14 09:05:07 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 nima.ghanavatian nima.ghanavatian mifenton rwlbuis tonikitoo webkit.review.bot oldest_to_newest 766895 0 nima.ghanavatian 2012-11-14 07:53:14 -0800 We were using node-relative offsets which do not work correctly with respect to IMF in content editable since a new node is created with every new line. 766900 1 174159 nima.ghanavatian 2012-11-14 07:59:47 -0800 Created attachment 174159 Patch 766902 2 webkit.review.bot 2012-11-14 08:03:18 -0800 Attachment 174159 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/ChangeLog', u'Sou..." exit_code: 1 Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:762: Omit int when using unsigned [runtime/unsigned] [1] Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:763: Omit int when using unsigned [runtime/unsigned] [1] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 766906 3 174159 rwlbuis 2012-11-14 08:09:08 -0800 Comment on attachment 174159 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174159&action=review Looks good but style errors need to be fixed. > Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:759 > + VisiblePosition caretPosition = m_currentFocusElement->document()->frame()->selection()->selection().visibleStart(); Scary. Also selection().selection() looks weird. >> Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:763 >> + if (!rangeSelection) > > Omit int when using unsigned [runtime/unsigned] [1] Style queue bug? I assume it means the unsigned int below.... This is the second time in a week we are hitting style queue problems. Doesn't it like our IMF code? :) > Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:767 > + unsigned int length = 0; I think the warnings are about these lines. 766924 4 174166 nima.ghanavatian 2012-11-14 08:26:34 -0800 Created attachment 174166 Patch 766931 5 174166 rwlbuis 2012-11-14 08:30:14 -0800 Comment on attachment 174166 Patch Looks good. 766956 6 174166 webkit.review.bot 2012-11-14 09:05:03 -0800 Comment on attachment 174166 Patch Clearing flags on attachment: 174166 Committed r134616: <http://trac.webkit.org/changeset/134616> 766957 7 webkit.review.bot 2012-11-14 09:05:07 -0800 All reviewed patches have been landed. Closing bug. 174159 2012-11-14 07:59:47 -0800 2012-11-14 08:26:26 -0800 Patch bug-102236-20121114105233.patch text/plain 3207 nima.ghanavatian U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0MjU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCAyM2VjMWQxNWI3MmEwMjEyYTljZGM5NDg2ZjIxZGZjMTcyZjk0YmQ3Li5mNmRiMDVjZmUx MTcyZWFiNWUwNTdmOWJiNDhiNGNiNzk0YjVkMWI3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMi0xMS0xMyAgTmltYSBHaGFuYXZhdGlhbiAgPG5n aGFuYXZhdGlhbkByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBVc2UgbWlzcGVsbGVk LW1hcmtlciBvZmZzZXRzIHJlbGF0aXZlIHRvIHRoZSBlbGVtZW50CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDIyMzYKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEb2N1bWVudE1hcmtlciBvZmZzZXRzIGFy ZSBjYWxjdWxhdGVkIHJlbGF0aXZlIHRvIGEgbm9kZS4gVGhpcyBpcyBjYXVzaW5nCisgICAgICAg IHByb2JsZW1zIGZvciBjb250ZW50ZWRpdGFibGUgd2hpY2ggY2FuIGhhdmUgbnVtZXJvdXMgbm9k ZXMuIENyZWF0aW5nIGEgUmFuZ2UgYXJvdW5kIGEgd29yZAorICAgICAgICBhbmQgY2FsY3VsYXRp bmcgaXRzIGxvY2F0aW9uIGFuZCBsZW5ndGggZ2l2ZXMgdXMgdGhlIGNvcnJlY3Qgb3ZlcnJpZGUg aW4gdGhpcyBjYXNlIGZvciBzdGFydGluZworICAgICAgICBhbmQgZW5kaW5nIHBvaW50cyB0byBw YXNzIHRvIElNRi4KKworICAgICAgICBJbnRlcm5hbGx5IHJldmlld2VkIGJ5IE1pa2UgRmVudG9u LgorCisgICAgICAgICogV2ViS2l0U3VwcG9ydC9JbnB1dEhhbmRsZXIuY3BwOgorICAgICAgICAo QmxhY2tCZXJyeTo6V2ViS2l0OjpJbnB1dEhhbmRsZXI6OnJlcXVlc3RTcGVsbGluZ0NoZWNraW5n T3B0aW9ucyk6CisKIDIwMTItMTEtMTIgIE5pbWEgR2hhbmF2YXRpYW4gIDxuZ2hhbmF2YXRpYW5A cmltLmNvbT4KIAogICAgICAgICBbQmxhY2tCZXJyeV0gRW5zdXJlIHdlIG9ubHkgcmVjZWl2ZSBv bmUgS2V5VXAgcGVyIGtleSBldmVudApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2Jl cnJ5L1dlYktpdFN1cHBvcnQvSW5wdXRIYW5kbGVyLmNwcCBiL1NvdXJjZS9XZWJLaXQvYmxhY2ti ZXJyeS9XZWJLaXRTdXBwb3J0L0lucHV0SGFuZGxlci5jcHAKaW5kZXggZmEyZDAyZTcxZTUzMjU0 OWQ2ODAzYmQ5Mjc0ZjZjMDMyYTEwYjUzNS4uYTdmNzA5YmYwZjgwNTgzMjY2NTNmMzZiNDBlMTJi MWY2Y2UxN2E1NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1 cHBvcnQvSW5wdXRIYW5kbGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2Vi S2l0U3VwcG9ydC9JbnB1dEhhbmRsZXIuY3BwCkBAIC03NTQsNiArNzU0LDI0IEBAIHZvaWQgSW5w dXRIYW5kbGVyOjpyZXF1ZXN0U3BlbGxpbmdDaGVja2luZ09wdGlvbnMoaW1mX3NwX3RleHRfdCYg c3BlbGxDaGVja2luZ09wCiAgICAgY29uc3QgV2ViQ29yZTo6SW50UG9pbnQgc2Nyb2xsUG9zaXRp b24gPSBtX3dlYlBhZ2UtPm1haW5GcmFtZSgpLT52aWV3KCktPnNjcm9sbFBvc2l0aW9uKCk7CiAg ICAgY2FyZXRSZWN0Lm1vdmUoc2Nyb2xsUG9zaXRpb24ueCgpLCBzY3JvbGxQb3NpdGlvbi55KCkp OwogCisgICAgLy8gQ2FsY3VsYXRlIHRoZSBvZmZzZXQgZm9yIGNvbnRlbnRFZGl0YWJsZSBzaW5j ZSB0aGUgbWFya2VyIG9mZnNldHMgYXJlIHJlbGF0aXZlIHRvIHRoZSBub2RlLgorICAgIC8vIEdl dCBjYXJldCBwb3NpdGlvbi4gVGhvdWdoIHRoZSBzcGVsbGluZyBtYXJrZXJzIG1pZ2h0IG5vIGxv bmdlciBleGlzdCwgaWYgdGhpcyBtZXRob2QgaXMgY2FsbGVkIHdlIGNhbiBhc3N1bWUgdGhlIGNh cmV0IHdhcyBwbGFjZWQgb24gdG9wIG9mIGEgbWFya2VyIGVhcmxpZXIuCisgICAgVmlzaWJsZVBv c2l0aW9uIGNhcmV0UG9zaXRpb24gPSBtX2N1cnJlbnRGb2N1c0VsZW1lbnQtPmRvY3VtZW50KCkt PmZyYW1lKCktPnNlbGVjdGlvbigpLT5zZWxlY3Rpb24oKS52aXNpYmxlU3RhcnQoKTsKKworICAg IC8vIENyZWF0ZSBhIHJhbmdlIGZyb20gdGhlIHN0YXJ0IHRvIGVuZCBvZiB3b3JkLgorICAgIFJl ZlB0cjxSYW5nZT4gcmFuZ2VTZWxlY3Rpb24gPSBWaXNpYmxlU2VsZWN0aW9uKHN0YXJ0T2ZXb3Jk KGNhcmV0UG9zaXRpb24pLCBlbmRPZldvcmQoY2FyZXRQb3NpdGlvbikpLnRvTm9ybWFsaXplZFJh bmdlKCk7CisgICAgaWYgKCFyYW5nZVNlbGVjdGlvbikKKyAgICAgICAgcmV0dXJuOworCisgICAg dW5zaWduZWQgaW50IGxvY2F0aW9uID0gMDsKKyAgICB1bnNpZ25lZCBpbnQgbGVuZ3RoID0gMDsK KyAgICBUZXh0SXRlcmF0b3I6OmdldExvY2F0aW9uQW5kTGVuZ3RoRnJvbVJhbmdlKG1fY3VycmVu dEZvY3VzRWxlbWVudC5nZXQoKSwgcmFuZ2VTZWxlY3Rpb24uZ2V0KCksIGxvY2F0aW9uLCBsZW5n dGgpOworCisgICAgaWYgKGxvY2F0aW9uICE9IG5vdEZvdW5kICYmIGxlbmd0aCkgeworICAgICAg ICBzcGVsbENoZWNraW5nT3B0aW9uUmVxdWVzdC5zdGFydFRleHRQb3NpdGlvbiA9IGxvY2F0aW9u OworICAgICAgICBzcGVsbENoZWNraW5nT3B0aW9uUmVxdWVzdC5lbmRUZXh0UG9zaXRpb24gPSBs b2NhdGlvbiArIGxlbmd0aDsKKyAgICB9CisKICAgICBJbnB1dExvZyhMb2dMZXZlbEluZm8sICJJ bnB1dEhhbmRsZXI6OnJlcXVlc3RTcGVsbGluZ0NoZWNraW5nT3B0aW9ucyBjYXJldFJlY3QgdG9w TGVmdD0oJWQsJWQpLCBib3R0b21SaWdodD0oJWQsJWQpLCBzdGFydFRleHRQb3NpdGlvbj0lZCwg ZW5kVGV4dFBvc2l0aW9uPSVkIgogICAgICAgICAgICAgICAgICAgICAgICAgICAgICwgY2FyZXRS ZWN0Lm1pblhNaW5ZQ29ybmVyKCkueCgpLCBjYXJldFJlY3QubWluWE1pbllDb3JuZXIoKS55KCks IGNhcmV0UmVjdC5tYXhYTWF4WUNvcm5lcigpLngoKSwgY2FyZXRSZWN0Lm1heFhNYXhZQ29ybmVy KCkueSgpCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgLCBzcGVsbENoZWNraW5nT3B0aW9u UmVxdWVzdC5zdGFydFRleHRQb3NpdGlvbiwgc3BlbGxDaGVja2luZ09wdGlvblJlcXVlc3QuZW5k VGV4dFBvc2l0aW9uKTsK 174166 2012-11-14 08:26:34 -0800 2012-11-14 09:05:03 -0800 Patch bug-102236-20121114111921.patch text/plain 3207 nima.ghanavatian U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0Mzk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCAzM2IyOWVmNDgyYTEyNTUyMDU2N2JkNDc4Y2JhZDlmN2JhMGMxZTA5Li5mNjZkMDYxY2Fh MGMzNWRjNjIxZDk4N2ZkZTJiZTgzYWNmYTUzMDU5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMi0xMS0xMyAgTmltYSBHaGFuYXZhdGlhbiAgPG5n aGFuYXZhdGlhbkByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBVc2UgbWlzcGVsbGVk LW1hcmtlciBvZmZzZXRzIHJlbGF0aXZlIHRvIHRoZSBlbGVtZW50CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDIyMzYKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEb2N1bWVudE1hcmtlciBvZmZzZXRzIGFy ZSBjYWxjdWxhdGVkIHJlbGF0aXZlIHRvIGEgbm9kZS4gVGhpcyBpcyBjYXVzaW5nCisgICAgICAg IHByb2JsZW1zIGZvciBjb250ZW50ZWRpdGFibGUgd2hpY2ggY2FuIGhhdmUgbnVtZXJvdXMgbm9k ZXMuIENyZWF0aW5nIGEgUmFuZ2UgYXJvdW5kIGEgd29yZAorICAgICAgICBhbmQgY2FsY3VsYXRp bmcgaXRzIGxvY2F0aW9uIGFuZCBsZW5ndGggZ2l2ZXMgdXMgdGhlIGNvcnJlY3Qgb3ZlcnJpZGUg aW4gdGhpcyBjYXNlIGZvciBzdGFydGluZworICAgICAgICBhbmQgZW5kaW5nIHBvaW50cyB0byBw YXNzIHRvIElNRi4KKworICAgICAgICBJbnRlcm5hbGx5IHJldmlld2VkIGJ5IE1pa2UgRmVudG9u LgorCisgICAgICAgICogV2ViS2l0U3VwcG9ydC9JbnB1dEhhbmRsZXIuY3BwOgorICAgICAgICAo QmxhY2tCZXJyeTo6V2ViS2l0OjpJbnB1dEhhbmRsZXI6OnJlcXVlc3RTcGVsbGluZ0NoZWNraW5n T3B0aW9ucyk6CisKIDIwMTItMTEtMTMgIE1pa2UgRmVudG9uICA8bWlmZW50b25AcmltLmNvbT4K IAogICAgICAgICBbQmxhY2tCZXJyeV0gRnVsbHkgcmVzdG9yZSBib3RoIHpvb20gYW5kIHNjcm9s bCB3aGVuIGxlYXZpbmcgYW4gaW5wdXQgZmllbGQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9JbnB1dEhhbmRsZXIuY3BwIGIvU291cmNlL1dlYktp dC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvSW5wdXRIYW5kbGVyLmNwcAppbmRleCA3NTAxZmZi NjcyYzA2ZTc4ODU1YjIzMTljNWM5MDU2NjYzMzkxNDczLi41ZjAyYzNjNjdkMjI1MGQyMGUxYWNh ZDVjMTFlYTY5NTMwMWQ0ZThkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkv V2ViS2l0U3VwcG9ydC9JbnB1dEhhbmRsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2ti ZXJyeS9XZWJLaXRTdXBwb3J0L0lucHV0SGFuZGxlci5jcHAKQEAgLTc1NCw2ICs3NTQsMjQgQEAg dm9pZCBJbnB1dEhhbmRsZXI6OnJlcXVlc3RTcGVsbGluZ0NoZWNraW5nT3B0aW9ucyhpbWZfc3Bf dGV4dF90JiBzcGVsbENoZWNraW5nT3AKICAgICBjb25zdCBXZWJDb3JlOjpJbnRQb2ludCBzY3Jv bGxQb3NpdGlvbiA9IG1fd2ViUGFnZS0+bWFpbkZyYW1lKCktPnZpZXcoKS0+c2Nyb2xsUG9zaXRp b24oKTsKICAgICBjYXJldFJlY3QubW92ZShzY3JvbGxQb3NpdGlvbi54KCksIHNjcm9sbFBvc2l0 aW9uLnkoKSk7CiAKKyAgICAvLyBDYWxjdWxhdGUgdGhlIG9mZnNldCBmb3IgY29udGVudEVkaXRh YmxlIHNpbmNlIHRoZSBtYXJrZXIgb2Zmc2V0cyBhcmUgcmVsYXRpdmUgdG8gdGhlIG5vZGUuCisg ICAgLy8gR2V0IGNhcmV0IHBvc2l0aW9uLiBUaG91Z2ggdGhlIHNwZWxsaW5nIG1hcmtlcnMgbWln aHQgbm8gbG9uZ2VyIGV4aXN0LCBpZiB0aGlzIG1ldGhvZCBpcyBjYWxsZWQgd2UgY2FuIGFzc3Vt ZSB0aGUgY2FyZXQgd2FzIHBsYWNlZCBvbiB0b3Agb2YgYSBtYXJrZXIgZWFybGllci4KKyAgICBW aXNpYmxlUG9zaXRpb24gY2FyZXRQb3NpdGlvbiA9IG1fY3VycmVudEZvY3VzRWxlbWVudC0+ZG9j dW1lbnQoKS0+ZnJhbWUoKS0+c2VsZWN0aW9uKCktPnNlbGVjdGlvbigpLnZpc2libGVTdGFydCgp OworCisgICAgLy8gQ3JlYXRlIGEgcmFuZ2UgZnJvbSB0aGUgc3RhcnQgdG8gZW5kIG9mIHdvcmQu CisgICAgUmVmUHRyPFJhbmdlPiByYW5nZVNlbGVjdGlvbiA9IFZpc2libGVTZWxlY3Rpb24oc3Rh cnRPZldvcmQoY2FyZXRQb3NpdGlvbiksIGVuZE9mV29yZChjYXJldFBvc2l0aW9uKSkudG9Ob3Jt YWxpemVkUmFuZ2UoKTsKKyAgICBpZiAoIXJhbmdlU2VsZWN0aW9uKQorICAgICAgICByZXR1cm47 CisKKyAgICB1bnNpZ25lZCBsb2NhdGlvbiA9IDA7CisgICAgdW5zaWduZWQgbGVuZ3RoID0gMDsK KyAgICBUZXh0SXRlcmF0b3I6OmdldExvY2F0aW9uQW5kTGVuZ3RoRnJvbVJhbmdlKG1fY3VycmVu dEZvY3VzRWxlbWVudC5nZXQoKSwgcmFuZ2VTZWxlY3Rpb24uZ2V0KCksIGxvY2F0aW9uLCBsZW5n dGgpOworCisgICAgaWYgKGxvY2F0aW9uICE9IG5vdEZvdW5kICYmIGxlbmd0aCkgeworICAgICAg ICBzcGVsbENoZWNraW5nT3B0aW9uUmVxdWVzdC5zdGFydFRleHRQb3NpdGlvbiA9IGxvY2F0aW9u OworICAgICAgICBzcGVsbENoZWNraW5nT3B0aW9uUmVxdWVzdC5lbmRUZXh0UG9zaXRpb24gPSBs b2NhdGlvbiArIGxlbmd0aDsKKyAgICB9CisKICAgICBJbnB1dExvZyhMb2dMZXZlbEluZm8sICJJ bnB1dEhhbmRsZXI6OnJlcXVlc3RTcGVsbGluZ0NoZWNraW5nT3B0aW9ucyBjYXJldFJlY3QgdG9w TGVmdD0oJWQsJWQpLCBib3R0b21SaWdodD0oJWQsJWQpLCBzdGFydFRleHRQb3NpdGlvbj0lZCwg ZW5kVGV4dFBvc2l0aW9uPSVkIgogICAgICAgICAgICAgICAgICAgICAgICAgICAgICwgY2FyZXRS ZWN0Lm1pblhNaW5ZQ29ybmVyKCkueCgpLCBjYXJldFJlY3QubWluWE1pbllDb3JuZXIoKS55KCks IGNhcmV0UmVjdC5tYXhYTWF4WUNvcm5lcigpLngoKSwgY2FyZXRSZWN0Lm1heFhNYXhZQ29ybmVy KCkueSgpCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgLCBzcGVsbENoZWNraW5nT3B0aW9u UmVxdWVzdC5zdGFydFRleHRQb3NpdGlvbiwgc3BlbGxDaGVja2luZ09wdGlvblJlcXVlc3QuZW5k VGV4dFBvc2l0aW9uKTsK