102206 2012-11-14 02:51:36 -0800 Fix the [-Wreturn-type] warning in JavaScriptCore/assembler/MacroAssemblerARM.h 2012-11-14 06:52:38 -0800 1 1 1 Unclassified WebKit New Bugs 420+ All All RESOLVED FIXED P2 Normal --- 1 ossy webkit-unassigned galpeter jbadics ossy webkit.review.bot oldest_to_newest 766691 0 ossy 2012-11-14 02:51:36 -0800 /home/oszi/WebKit/Source/JavaScriptCore/assembler/MacroAssemblerARM.h:1274:5: warning: no return statement in function returning non-void [-Wreturn-type This warning introduced in http://trac.webkit.org/changeset/134383 static CodeLocationLabel startOfPatchableBranchPtrWithPatch(CodeLocationDataLabelPtr label) { UNREACHABLE_FOR_PLATFORM(); } 766824 1 174145 galpeter 2012-11-14 06:29:57 -0800 Created attachment 174145 speculative fix This is same as in the MacroAssemblerARMv7.h. 766827 2 174145 ossy 2012-11-14 06:31:08 -0800 Comment on attachment 174145 speculative fix Thanks for the quick fix, r=me. 766849 3 174145 ossy 2012-11-14 06:52:33 -0800 Comment on attachment 174145 speculative fix Clearing flags on attachment: 174145 Committed r134603: <http://trac.webkit.org/changeset/134603> 766850 4 ossy 2012-11-14 06:52:38 -0800 All reviewed patches have been landed. Closing bug. 174145 2012-11-14 06:29:57 -0800 2012-11-14 06:52:33 -0800 speculative fix arm_warning_fix_return.patch text/plain 1457 galpeter ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDFjMjJhY2EuLjBiMmIyZmYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTExLTE0ICBQZXRlciBHYWwgIDxn YWxwZXRlckBpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgRml4IHRoZSBbLVdyZXR1cm4tdHlw ZV0gd2FybmluZyBpbiBKYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk0u aAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAyMjA2 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGEg cmV0dXJuIHZhbHVlIGZvciB0aGUgZnVuY3Rpb24gdG8gc3VwcHJlc3MgdGhlIHdhcm5pbmcuCisK KyAgICAgICAgKiBhc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk0uaDoKKyAgICAgICAgKEpTQzo6 TWFjcm9Bc3NlbWJsZXJBUk06OnN0YXJ0T2ZQYXRjaGFibGVCcmFuY2hQdHJXaXRoUGF0Y2gpOgor CiAyMDEyLTExLTEzICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAg REZHIENyZWF0ZVRoaXMgc2hvdWxkIGJlIGFibGUgdG8gc3RhdGljYWxseSBhY2NvdW50IGZvciB0 aGUgc3RydWN0dXJlIG9mIHRoZSBvYmplY3QgaXQgY3JlYXRlcywgaWYgcHJvZmlsaW5nIGluZGlj YXRlcyB0aGF0IHRoaXMgc3RydWN0dXJlIGlzIGFsd2F5cyB0aGUgc2FtZQpkaWZmIC0tZ2l0IGEv U291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTS5oIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTS5oCmluZGV4IDAx MmRkMDQuLjBlYmRiZGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJs ZXIvTWFjcm9Bc3NlbWJsZXJBUk0uaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1i bGVyL01hY3JvQXNzZW1ibGVyQVJNLmgKQEAgLTEyNzEsNiArMTI3MSw3IEBAIHB1YmxpYzoKICAg ICBzdGF0aWMgQ29kZUxvY2F0aW9uTGFiZWwgc3RhcnRPZlBhdGNoYWJsZUJyYW5jaFB0cldpdGhQ YXRjaChDb2RlTG9jYXRpb25EYXRhTGFiZWxQdHIgbGFiZWwpCiAgICAgewogICAgICAgICBVTlJF QUNIQUJMRV9GT1JfUExBVEZPUk0oKTsKKyAgICAgICAgcmV0dXJuIENvZGVMb2NhdGlvbkxhYmVs KCk7CiAgICAgfQogCiAgICAgc3RhdGljIHZvaWQgcmV2ZXJ0SnVtcFJlcGxhY2VtZW50VG9QYXRj aGFibGVCcmFuY2hQdHJXaXRoUGF0Y2goQ29kZUxvY2F0aW9uTGFiZWwgaW5zdHJ1Y3Rpb25TdGFy dCwgQWRkcmVzcywgdm9pZCogaW5pdGlhbFZhbHVlKQo=