102159 2012-11-13 17:49:06 -0800 [chromium] Clamp negative sizes to zero when converting to gfx:: types 2012-11-14 19:06:34 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 danakj danakj abarth cc-bugs dglazkov enne fishd jamesr tkent+wkapi webkit.review.bot oldest_to_newest 766242 0 danakj 2012-11-13 17:49:06 -0800 [chromium] Clamp contentsRect to not have negative sizes 766244 1 174038 danakj 2012-11-13 17:50:47 -0800 Created attachment 174038 Patch 766248 2 174040 danakj 2012-11-13 17:53:13 -0800 Created attachment 174040 Patch Add bug to the changelog 767542 3 danakj 2012-11-14 18:03:58 -0800 Review ping 767543 4 174040 jamesr 2012-11-14 18:06:32 -0800 Comment on attachment 174040 Patch Sorry, I thought I had already left feedback. Would it make more sense to do this in the WebFoo -> gfx::Foo conversions in webkit/compositor_bindings? I worry that trying to this here is going to be fragile to other rects/sizes that end up negative for who-knows-what reasons. 767544 5 danakj 2012-11-14 18:07:57 -0800 Sure, I'm good with that. I kind of like that new cases will come to attention easier. But then again it seems like negative sizes in WebCore aren't really a huge problem for us anyways and clamping seems reasonable. 767555 6 174310 danakj 2012-11-14 18:18:30 -0800 Created attachment 174310 Patch 767559 7 webkit.review.bot 2012-11-14 18:21:21 -0800 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 767563 8 jamesr 2012-11-14 18:23:25 -0800 (In reply to comment #4) > (From update of attachment 174040 [details]) > in webkit/compositor_bindings do other WebKit API users have this restriction? If it's a compositor restriction we should do it ^^ 767567 9 danakj 2012-11-14 18:26:27 -0800 Ohh. Well as soon as you try to make a gfx::Rect out of an IntRect with a negative size, it's going to assert. Anyone else who uses these methods to convert will suffer the same assertions. So unless you want to leave them with asserts but protect w_c_bindings, I think we should do it here. 767570 10 jamesr 2012-11-14 18:30:47 -0800 I see. If it's a restriction of the gfx:: types then the only question is how loud we want to be when things other than the compositor pass negative values in to here. How long have the gfx:: types asserted? If it's been a while, then I think we can be pretty confident that nobody else depends on any particular behavior here. 767576 11 danakj 2012-11-14 18:35:21 -0800 They asserted before we came along and started the gtfo thing. Then we removed the assertions to try match webcore behaviour. Now I am putting them back, and there's a few places that we've found trigger them. We've been without them since Fri Sep 28 - chromium a25e25b907d387f0b76a2b8acd522193e777e793 One is contentsRect from GraphicsLayerChromium. One was the thumbLength for scrollbars. And the others were simple things that had cropped up in the meantime. 767577 12 174310 webkit.review.bot 2012-11-14 18:37:03 -0800 Comment on attachment 174310 Patch Attachment 174310 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14845244 767578 13 174310 jamesr 2012-11-14 18:39:39 -0800 Comment on attachment 174310 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174310&action=review OK, thanks for the history. Seems reasonable except for the build failure. > Source/Platform/chromium/public/WebFloatRect.h:111 > + return gfx::RectF(x, y, std::max(0, width), std::max(0, height)); gonna need to use floating point literals or invoke the ::max() override you want with max<float>, i think 767580 14 174313 danakj 2012-11-14 18:40:37 -0800 Created attachment 174313 Patch for landing 767584 15 danakj 2012-11-14 18:41:39 -0800 Cool, thanks! 767608 16 174313 webkit.review.bot 2012-11-14 19:06:28 -0800 Comment on attachment 174313 Patch for landing Clearing flags on attachment: 174313 Committed r134725: <http://trac.webkit.org/changeset/134725> 767609 17 webkit.review.bot 2012-11-14 19:06:34 -0800 All reviewed patches have been landed. Closing bug. 174038 2012-11-13 17:50:47 -0800 2012-11-13 17:53:11 -0800 Patch bug-102159-20121113204847.patch text/plain 1992 danakj U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0NDk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWVhNmQ4YWY3OTVjMzhh ZmMzYjdmYmZmNmU5OTEyNTE5N2NmNmQ4Ni4uZTJlNmFiMDQ1NzA5OGViYjY4NzBlMGM2Y2QxZDM0 NjA2NWRmODAzOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTExLTEzICBEYW5h IEphbnNlbnMgIDxkYW5ha2pAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gQ2xh bXAgY29udGVudHNSZWN0IHRvIG5vdCBoYXZlIG5lZ2F0aXZlIHNpemVzCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDIxNTkKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgR3JhcGhpY3NMYXllcidzIGNv bnRlbnRzUmVjdCBzaG91bGQgbm90IGhhdmUgYSBuZWdhdGl2ZSBzaXplLiBJZiBpdAorICAgICAg ICBkb2VzLCBjbGFtcCB0aGF0IHNpemUgY29tcG9uZW50IHRvIHplcm8uCisKKyAgICAgICAgKiBw bGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9HcmFwaGljc0xheWVyQ2hyb21pdW0uY3BwOgorICAg ICAgICAoV2ViQ29yZTo6R3JhcGhpY3NMYXllckNocm9taXVtOjpzZXRDb250ZW50c1JlY3QpOgor CiAyMDEyLTExLTEzICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBK U0V2ZW50TGlzdGVuZXIgc2hvdWxkIG5vdCBhY2Nlc3MgbV9qc0Z1bmN0aW9uIHdoZW4gaXRzIHdy YXBwZXIgaXMgZ29uZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2Nocm9taXVtL0dyYXBoaWNzTGF5ZXJDaHJvbWl1bS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9HcmFwaGljc0xheWVyQ2hyb21pdW0uY3BwCmluZGV4 IDI4ZmRkMGVjMDM4ZjIxOTc2ODlhMTgwNGYyZDc3Y2ExYmVjZWU4YTAuLmNhODRjMzBlZTI3NTM2 MDg4ODY2MzEwZWVlYjU0Mzg4MDdlMDkwN2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0dyYXBoaWNzTGF5ZXJDaHJvbWl1bS5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vR3JhcGhpY3NMYXllckNo cm9taXVtLmNwcApAQCAtNDg0LDEwICs0ODQsMTYgQEAgdm9pZCBHcmFwaGljc0xheWVyQ2hyb21p dW06OnNldE5lZWRzRGlzcGxheUluUmVjdChjb25zdCBGbG9hdFJlY3QmIHJlY3QpCiAKIHZvaWQg R3JhcGhpY3NMYXllckNocm9taXVtOjpzZXRDb250ZW50c1JlY3QoY29uc3QgSW50UmVjdCYgcmVj dCkKIHsKLSAgICBpZiAocmVjdCA9PSBtX2NvbnRlbnRzUmVjdCkKKyAgICAvLyBXZSBhcmUgcmVj ZWl2aW5nIG5lZ2F0aXZlIHNpemVzIGhlcmUgdGhhdCBjYXVzZSBhc3NlcnRpb25zIHRvIGZhaWwg aW4gdGhlIGNvbXBvc2l0b3IuIENsYW1wIHRoZW0gdG8gMCB0bworICAgIC8vIGF2b2lkIHRob3Nl IGFzc2VydGlvbnMuCisgICAgLy8gRklYTUU6IFRoaXMgc2hvdWxkIGJlIGFuIEFTU0VSVCBpbnN0 ZWFkLCBhcyBuZWdhdGl2ZSBzaXplcyBzaG91bGQgbm90IGV4aXN0IGluIFdlYkNvcmUuCisgICAg SW50UmVjdCBjbGFtcGVkUmVjdCA9IHJlY3Q7CisgICAgY2xhbXBlZFJlY3Quc2V0U2l6ZShjbGFt cGVkUmVjdC5zaXplKCkuZXhwYW5kZWRUbyhJbnRTaXplKCkpKTsKKworICAgIGlmIChjbGFtcGVk UmVjdCA9PSBtX2NvbnRlbnRzUmVjdCkKICAgICAgICAgcmV0dXJuOwogCi0gICAgR3JhcGhpY3NM YXllcjo6c2V0Q29udGVudHNSZWN0KHJlY3QpOworICAgIEdyYXBoaWNzTGF5ZXI6OnNldENvbnRl bnRzUmVjdChjbGFtcGVkUmVjdCk7CiAgICAgdXBkYXRlQ29udGVudHNSZWN0KCk7CiB9CiAK 174040 2012-11-13 17:53:13 -0800 2012-11-14 18:18:28 -0800 Patch bug-102159-20121113205113.patch text/plain 2041 danakj U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0NDk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWVhNmQ4YWY3OTVjMzhh ZmMzYjdmYmZmNmU5OTEyNTE5N2NmNmQ4Ni4uNGIzYjQ3MTA1MDljNzJkYWQ2YjNjOWE3MjEyNzJi NzkyYjJlNjExZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTExLTEzICBEYW5h IEphbnNlbnMgIDxkYW5ha2pAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gQ2xh bXAgY29udGVudHNSZWN0IHRvIG5vdCBoYXZlIG5lZ2F0aXZlIHNpemVzCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDIxNTkKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgR3JhcGhpY3NMYXllcidzIGNv bnRlbnRzUmVjdCBzaG91bGQgbm90IGhhdmUgYSBuZWdhdGl2ZSBzaXplLiBJZiBpdAorICAgICAg ICBkb2VzLCBjbGFtcCB0aGF0IHNpemUgY29tcG9uZW50IHRvIHplcm8uCisKKyAgICAgICAgQ2hy b21pdW0gYnVnOiBodHRwOi8vY3JidWcuY29tLzE2MDc5OQorCisgICAgICAgICogcGxhdGZvcm0v Z3JhcGhpY3MvY2hyb21pdW0vR3JhcGhpY3NMYXllckNocm9taXVtLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkdyYXBoaWNzTGF5ZXJDaHJvbWl1bTo6c2V0Q29udGVudHNSZWN0KToKKwogMjAxMi0x MS0xMyAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CiAKICAgICAgICAgSlNFdmVudExp c3RlbmVyIHNob3VsZCBub3QgYWNjZXNzIG1fanNGdW5jdGlvbiB3aGVuIGl0cyB3cmFwcGVyIGlz IGdvbmUuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJv bWl1bS9HcmFwaGljc0xheWVyQ2hyb21pdW0uY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvY2hyb21pdW0vR3JhcGhpY3NMYXllckNocm9taXVtLmNwcAppbmRleCAyOGZkZDBl YzAzOGYyMTk3Njg5YTE4MDRmMmQ3N2NhMWJlY2VlOGEwLi5jYTg0YzMwZWUyNzUzNjA4ODg2NjMx MGVlZWI1NDM4ODA3ZTA5MDdmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9jaHJvbWl1bS9HcmFwaGljc0xheWVyQ2hyb21pdW0uY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0dyYXBoaWNzTGF5ZXJDaHJvbWl1bS5j cHAKQEAgLTQ4NCwxMCArNDg0LDE2IEBAIHZvaWQgR3JhcGhpY3NMYXllckNocm9taXVtOjpzZXRO ZWVkc0Rpc3BsYXlJblJlY3QoY29uc3QgRmxvYXRSZWN0JiByZWN0KQogCiB2b2lkIEdyYXBoaWNz TGF5ZXJDaHJvbWl1bTo6c2V0Q29udGVudHNSZWN0KGNvbnN0IEludFJlY3QmIHJlY3QpCiB7Ci0g ICAgaWYgKHJlY3QgPT0gbV9jb250ZW50c1JlY3QpCisgICAgLy8gV2UgYXJlIHJlY2VpdmluZyBu ZWdhdGl2ZSBzaXplcyBoZXJlIHRoYXQgY2F1c2UgYXNzZXJ0aW9ucyB0byBmYWlsIGluIHRoZSBj b21wb3NpdG9yLiBDbGFtcCB0aGVtIHRvIDAgdG8KKyAgICAvLyBhdm9pZCB0aG9zZSBhc3NlcnRp b25zLgorICAgIC8vIEZJWE1FOiBUaGlzIHNob3VsZCBiZSBhbiBBU1NFUlQgaW5zdGVhZCwgYXMg bmVnYXRpdmUgc2l6ZXMgc2hvdWxkIG5vdCBleGlzdCBpbiBXZWJDb3JlLgorICAgIEludFJlY3Qg Y2xhbXBlZFJlY3QgPSByZWN0OworICAgIGNsYW1wZWRSZWN0LnNldFNpemUoY2xhbXBlZFJlY3Qu c2l6ZSgpLmV4cGFuZGVkVG8oSW50U2l6ZSgpKSk7CisKKyAgICBpZiAoY2xhbXBlZFJlY3QgPT0g bV9jb250ZW50c1JlY3QpCiAgICAgICAgIHJldHVybjsKIAotICAgIEdyYXBoaWNzTGF5ZXI6OnNl dENvbnRlbnRzUmVjdChyZWN0KTsKKyAgICBHcmFwaGljc0xheWVyOjpzZXRDb250ZW50c1JlY3Qo Y2xhbXBlZFJlY3QpOwogICAgIHVwZGF0ZUNvbnRlbnRzUmVjdCgpOwogfQogCg== 174310 2012-11-14 18:18:30 -0800 2012-11-14 18:40:33 -0800 Patch bug-102159-20121114211628.patch text/plain 3213 danakj U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0Njg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0v Q2hhbmdlTG9nIGIvU291cmNlL1BsYXRmb3JtL0NoYW5nZUxvZwppbmRleCBhOGU4OTI3ODJjMjEx NDNmZDNlMzVhODI0NjEzNWZjYTM2NjNkZGI5Li4wMTZjZDlhNWQzYTBmNjliMTUyYTQ2ZTI0ZmU0 ZWQ0N2RhNzczMGNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyMyBAQAogMjAxMi0xMS0xNCAg RGFuYSBKYW5zZW5zICA8ZGFuYWtqQGNocm9taXVtLm9yZz4KIAorICAgICAgICBbY2hyb21pdW1d IENsYW1wIG5lZ2F0aXZlIHNpemVzIHRvIHplcm8gd2hlbiBjb252ZXJ0aW5nIHRvIGdmeDo6IHR5 cGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDIx NTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBIZXJl IHdlIGNsYW1wIFJlY3QsIFJlY3RGIGFuZCBTaXplIHR5cGVzIHRvIG5vdCBoYXZlIG5lZ2F0aXZl IHdpZHRocyBvcgorICAgICAgICBoZWlnaHRzLiBXZWJTaXplcyB0aGF0IHlvdSB3YW50IHRvIGtl ZXAgdGhlaXIgbmVnYXRpdmUgdmFsdWVzLCBiZWNhdXNlCisgICAgICAgIHRoZXkgYXJlIHZlY3Rv cnMsIHNob3VsZCBiZSBjb252ZXJ0ZWQgdG8gVmVjdG9yMmQgaW5zdGVhZC4KKworICAgICAgICAq IGNocm9taXVtL3B1YmxpYy9XZWJGbG9hdFJlY3QuaDoKKyAgICAgICAgKFdlYktpdDo6V2ViRmxv YXRSZWN0OjpvcGVyYXRvciBnZng6OlJlY3RGKToKKyAgICAgICAgKiBjaHJvbWl1bS9wdWJsaWMv V2ViUmVjdC5oOgorICAgICAgICAoV2ViS2l0OjpXZWJSZWN0OjpvcGVyYXRvciBnZng6OlJlY3Qp OgorICAgICAgICAqIGNocm9taXVtL3B1YmxpYy9XZWJTaXplLmg6CisgICAgICAgIChXZWJLaXQ6 OldlYlNpemU6Om9wZXJhdG9yIGdmeDo6U2l6ZSk6CisKKzIwMTItMTEtMTQgIERhbmEgSmFuc2Vu cyAgPGRhbmFrakBjaHJvbWl1bS5vcmc+CisKICAgICAgICAgW2Nocm9taXVtXSBNYXRjaCB0aGUg TGF5ZXJUcmVlU2V0dGluZyBkZWZhdWx0IGZvciBhY2NlbGVyYXRlZEFuaW1hdGlvbkVuYWJsZWQg aW4gdGhlIFdlYkxheWVyVHJlZVNldHRpbmcKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEwMjI4NQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0v Y2hyb21pdW0vcHVibGljL1dlYkZsb2F0UmVjdC5oIGIvU291cmNlL1BsYXRmb3JtL2Nocm9taXVt L3B1YmxpYy9XZWJGbG9hdFJlY3QuaAppbmRleCA5ZmVjZTRkNTZmMTZlMzY5MzVjYzY1NGZmMzNm Yjk3NmU4Mjk3MThiLi44YjFiMmI5YWE4MWEwMWVlOWJmYzI5ZDRkY2RlYzI4YjA1ZWY4MzA3IDEw MDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vY2hyb21pdW0vcHVibGljL1dlYkZsb2F0UmVjdC5o CisrKyBiL1NvdXJjZS9QbGF0Zm9ybS9jaHJvbWl1bS9wdWJsaWMvV2ViRmxvYXRSZWN0LmgKQEAg LTM2LDYgKzM2LDcgQEAKICNpZiBXRUJLSVRfSU1QTEVNRU5UQVRJT04KICNpbmNsdWRlICJGbG9h dFJlY3QuaCIKICNlbHNlCisjaW5jbHVkZSA8Y21hdGg+CiAjaW5jbHVkZSA8dWkvZ2Z4L3JlY3Rf Zi5oPgogI2VuZGlmCiAKQEAgLTEwNyw3ICsxMDgsNyBAQCBzdHJ1Y3QgV2ViRmxvYXRSZWN0IHsK IAogICAgIG9wZXJhdG9yIGdmeDo6UmVjdEYoKSBjb25zdAogICAgIHsKLSAgICAgICAgcmV0dXJu IGdmeDo6UmVjdEYoeCwgeSwgd2lkdGgsIGhlaWdodCk7CisgICAgICAgIHJldHVybiBnZng6OlJl Y3RGKHgsIHksIHN0ZDo6bWF4KDAsIHdpZHRoKSwgc3RkOjptYXgoMCwgaGVpZ2h0KSk7CiAgICAg fQogI2VuZGlmCiB9OwpkaWZmIC0tZ2l0IGEvU291cmNlL1BsYXRmb3JtL2Nocm9taXVtL3B1Ymxp Yy9XZWJSZWN0LmggYi9Tb3VyY2UvUGxhdGZvcm0vY2hyb21pdW0vcHVibGljL1dlYlJlY3QuaApp bmRleCAwNDViN2E4ZWIzNzljNGRkNmMxMGU4MjRjZDFiMjI4NDg0NGVjNWE4Li4yZjEwMjZkNjAw YTlmZTk0ZTc4ZWFiZDEyOTc1OGJhOTI0ZGI1NWI0IDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZv cm0vY2hyb21pdW0vcHVibGljL1dlYlJlY3QuaAorKysgYi9Tb3VyY2UvUGxhdGZvcm0vY2hyb21p dW0vcHVibGljL1dlYlJlY3QuaApAQCAtMzYsNiArMzYsNyBAQAogI2lmIFdFQktJVF9JTVBMRU1F TlRBVElPTgogI2luY2x1ZGUgIkludFJlY3QuaCIKICNlbHNlCisjaW5jbHVkZSA8Y21hdGg+CiAj aW5jbHVkZSA8dWkvZ2Z4L3JlY3QuaD4KICNlbmRpZgogCkBAIC0xMDcsNyArMTA4LDcgQEAgc3Ry dWN0IFdlYlJlY3QgewogCiAgICAgb3BlcmF0b3IgZ2Z4OjpSZWN0KCkgY29uc3QKICAgICB7Ci0g ICAgICAgIHJldHVybiBnZng6OlJlY3QoeCwgeSwgd2lkdGgsIGhlaWdodCk7CisgICAgICAgIHJl dHVybiBnZng6OlJlY3QoeCwgeSwgc3RkOjptYXgoMCwgd2lkdGgpLCBzdGQ6Om1heCgwLCBoZWln aHQpKTsKICAgICB9CiAjZW5kaWYKIH07CmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0vY2hy b21pdW0vcHVibGljL1dlYlNpemUuaCBiL1NvdXJjZS9QbGF0Zm9ybS9jaHJvbWl1bS9wdWJsaWMv V2ViU2l6ZS5oCmluZGV4IDk3YTI3OTljNWMzMTcxMGRlYzk3NDQ1N2ExMDA2NzFhZTdiNGY4YmUu LmZiNWJjZjhiYjViZmVmNzRkNmMwNDE5MGE1ZGE2M2NiODM4YzgwNzEgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9QbGF0Zm9ybS9jaHJvbWl1bS9wdWJsaWMvV2ViU2l6ZS5oCisrKyBiL1NvdXJjZS9QbGF0 Zm9ybS9jaHJvbWl1bS9wdWJsaWMvV2ViU2l6ZS5oCkBAIC0zNiw2ICszNiw3IEBACiAjaWYgV0VC S0lUX0lNUExFTUVOVEFUSU9OCiAjaW5jbHVkZSAiSW50U2l6ZS5oIgogI2Vsc2UKKyNpbmNsdWRl IDxjbWF0aD4KICNpbmNsdWRlIDx1aS9nZngvc2l6ZS5oPgogI2luY2x1ZGUgPHVpL2dmeC92ZWN0 b3IyZC5oPgogI2VuZGlmCkBAIC0xMDcsNyArMTA4LDcgQEAgc3RydWN0IFdlYlNpemUgewogCiAg ICAgb3BlcmF0b3IgZ2Z4OjpTaXplKCkgY29uc3QKICAgICB7Ci0gICAgICAgIHJldHVybiBnZng6 OlNpemUod2lkdGgsIGhlaWdodCk7CisgICAgICAgIHJldHVybiBnZng6OlNpemUoc3RkOjptYXgo MCwgd2lkdGgpLCBzdGQ6Om1heCgwLCBoZWlnaHQpKTsKICAgICB9CiAKICAgICBvcGVyYXRvciBn Zng6OlZlY3RvcjJkKCkgY29uc3QK 174313 2012-11-14 18:40:37 -0800 2012-11-14 19:06:28 -0800 Patch for landing bug-102159-20121114213835.patch text/plain 3219 danakj U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0Njg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0v Q2hhbmdlTG9nIGIvU291cmNlL1BsYXRmb3JtL0NoYW5nZUxvZwppbmRleCBhOGU4OTI3ODJjMjEx NDNmZDNlMzVhODI0NjEzNWZjYTM2NjNkZGI5Li4wYzEwODM1Y2VlZWExMTA1YTAzYTM2YTcyMmFj YzZjNzliNTZjNjUyIDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyMyBAQAogMjAxMi0xMS0xNCAg RGFuYSBKYW5zZW5zICA8ZGFuYWtqQGNocm9taXVtLm9yZz4KIAorICAgICAgICBbY2hyb21pdW1d IENsYW1wIG5lZ2F0aXZlIHNpemVzIHRvIHplcm8gd2hlbiBjb252ZXJ0aW5nIHRvIGdmeDo6IHR5 cGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDIx NTkKKworICAgICAgICBSZXZpZXdlZCBieSBKYW1lcyBSb2JpbnNvbi4KKworICAgICAgICBIZXJl IHdlIGNsYW1wIFJlY3QsIFJlY3RGIGFuZCBTaXplIHR5cGVzIHRvIG5vdCBoYXZlIG5lZ2F0aXZl IHdpZHRocyBvcgorICAgICAgICBoZWlnaHRzLiBXZWJTaXplcyB0aGF0IHlvdSB3YW50IHRvIGtl ZXAgdGhlaXIgbmVnYXRpdmUgdmFsdWVzLCBiZWNhdXNlCisgICAgICAgIHRoZXkgYXJlIHZlY3Rv cnMsIHNob3VsZCBiZSBjb252ZXJ0ZWQgdG8gVmVjdG9yMmQgaW5zdGVhZC4KKworICAgICAgICAq IGNocm9taXVtL3B1YmxpYy9XZWJGbG9hdFJlY3QuaDoKKyAgICAgICAgKFdlYktpdDo6V2ViRmxv YXRSZWN0OjpvcGVyYXRvciBnZng6OlJlY3RGKToKKyAgICAgICAgKiBjaHJvbWl1bS9wdWJsaWMv V2ViUmVjdC5oOgorICAgICAgICAoV2ViS2l0OjpXZWJSZWN0OjpvcGVyYXRvciBnZng6OlJlY3Qp OgorICAgICAgICAqIGNocm9taXVtL3B1YmxpYy9XZWJTaXplLmg6CisgICAgICAgIChXZWJLaXQ6 OldlYlNpemU6Om9wZXJhdG9yIGdmeDo6U2l6ZSk6CisKKzIwMTItMTEtMTQgIERhbmEgSmFuc2Vu cyAgPGRhbmFrakBjaHJvbWl1bS5vcmc+CisKICAgICAgICAgW2Nocm9taXVtXSBNYXRjaCB0aGUg TGF5ZXJUcmVlU2V0dGluZyBkZWZhdWx0IGZvciBhY2NlbGVyYXRlZEFuaW1hdGlvbkVuYWJsZWQg aW4gdGhlIFdlYkxheWVyVHJlZVNldHRpbmcKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEwMjI4NQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0v Y2hyb21pdW0vcHVibGljL1dlYkZsb2F0UmVjdC5oIGIvU291cmNlL1BsYXRmb3JtL2Nocm9taXVt L3B1YmxpYy9XZWJGbG9hdFJlY3QuaAppbmRleCA5ZmVjZTRkNTZmMTZlMzY5MzVjYzY1NGZmMzNm Yjk3NmU4Mjk3MThiLi5lMDRjN2E1MzYwZWY2NjUwYWY1MjlhYWFhYmVlOWMzOGM3ZmRjYTIwIDEw MDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vY2hyb21pdW0vcHVibGljL1dlYkZsb2F0UmVjdC5o CisrKyBiL1NvdXJjZS9QbGF0Zm9ybS9jaHJvbWl1bS9wdWJsaWMvV2ViRmxvYXRSZWN0LmgKQEAg LTM2LDYgKzM2LDcgQEAKICNpZiBXRUJLSVRfSU1QTEVNRU5UQVRJT04KICNpbmNsdWRlICJGbG9h dFJlY3QuaCIKICNlbHNlCisjaW5jbHVkZSA8Y21hdGg+CiAjaW5jbHVkZSA8dWkvZ2Z4L3JlY3Rf Zi5oPgogI2VuZGlmCiAKQEAgLTEwNyw3ICsxMDgsNyBAQCBzdHJ1Y3QgV2ViRmxvYXRSZWN0IHsK IAogICAgIG9wZXJhdG9yIGdmeDo6UmVjdEYoKSBjb25zdAogICAgIHsKLSAgICAgICAgcmV0dXJu IGdmeDo6UmVjdEYoeCwgeSwgd2lkdGgsIGhlaWdodCk7CisgICAgICAgIHJldHVybiBnZng6OlJl Y3RGKHgsIHksIHN0ZDo6bWF4KDAuMGYsIHdpZHRoKSwgc3RkOjptYXgoMC4wZiwgaGVpZ2h0KSk7 CiAgICAgfQogI2VuZGlmCiB9OwpkaWZmIC0tZ2l0IGEvU291cmNlL1BsYXRmb3JtL2Nocm9taXVt L3B1YmxpYy9XZWJSZWN0LmggYi9Tb3VyY2UvUGxhdGZvcm0vY2hyb21pdW0vcHVibGljL1dlYlJl Y3QuaAppbmRleCAwNDViN2E4ZWIzNzljNGRkNmMxMGU4MjRjZDFiMjI4NDg0NGVjNWE4Li4yZjEw MjZkNjAwYTlmZTk0ZTc4ZWFiZDEyOTc1OGJhOTI0ZGI1NWI0IDEwMDY0NAotLS0gYS9Tb3VyY2Uv UGxhdGZvcm0vY2hyb21pdW0vcHVibGljL1dlYlJlY3QuaAorKysgYi9Tb3VyY2UvUGxhdGZvcm0v Y2hyb21pdW0vcHVibGljL1dlYlJlY3QuaApAQCAtMzYsNiArMzYsNyBAQAogI2lmIFdFQktJVF9J TVBMRU1FTlRBVElPTgogI2luY2x1ZGUgIkludFJlY3QuaCIKICNlbHNlCisjaW5jbHVkZSA8Y21h dGg+CiAjaW5jbHVkZSA8dWkvZ2Z4L3JlY3QuaD4KICNlbmRpZgogCkBAIC0xMDcsNyArMTA4LDcg QEAgc3RydWN0IFdlYlJlY3QgewogCiAgICAgb3BlcmF0b3IgZ2Z4OjpSZWN0KCkgY29uc3QKICAg ICB7Ci0gICAgICAgIHJldHVybiBnZng6OlJlY3QoeCwgeSwgd2lkdGgsIGhlaWdodCk7CisgICAg ICAgIHJldHVybiBnZng6OlJlY3QoeCwgeSwgc3RkOjptYXgoMCwgd2lkdGgpLCBzdGQ6Om1heCgw LCBoZWlnaHQpKTsKICAgICB9CiAjZW5kaWYKIH07CmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZv cm0vY2hyb21pdW0vcHVibGljL1dlYlNpemUuaCBiL1NvdXJjZS9QbGF0Zm9ybS9jaHJvbWl1bS9w dWJsaWMvV2ViU2l6ZS5oCmluZGV4IDk3YTI3OTljNWMzMTcxMGRlYzk3NDQ1N2ExMDA2NzFhZTdi NGY4YmUuLmZiNWJjZjhiYjViZmVmNzRkNmMwNDE5MGE1ZGE2M2NiODM4YzgwNzEgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9QbGF0Zm9ybS9jaHJvbWl1bS9wdWJsaWMvV2ViU2l6ZS5oCisrKyBiL1NvdXJj ZS9QbGF0Zm9ybS9jaHJvbWl1bS9wdWJsaWMvV2ViU2l6ZS5oCkBAIC0zNiw2ICszNiw3IEBACiAj aWYgV0VCS0lUX0lNUExFTUVOVEFUSU9OCiAjaW5jbHVkZSAiSW50U2l6ZS5oIgogI2Vsc2UKKyNp bmNsdWRlIDxjbWF0aD4KICNpbmNsdWRlIDx1aS9nZngvc2l6ZS5oPgogI2luY2x1ZGUgPHVpL2dm eC92ZWN0b3IyZC5oPgogI2VuZGlmCkBAIC0xMDcsNyArMTA4LDcgQEAgc3RydWN0IFdlYlNpemUg ewogCiAgICAgb3BlcmF0b3IgZ2Z4OjpTaXplKCkgY29uc3QKICAgICB7Ci0gICAgICAgIHJldHVy biBnZng6OlNpemUod2lkdGgsIGhlaWdodCk7CisgICAgICAgIHJldHVybiBnZng6OlNpemUoc3Rk OjptYXgoMCwgd2lkdGgpLCBzdGQ6Om1heCgwLCBoZWlnaHQpKTsKICAgICB9CiAKICAgICBvcGVy YXRvciBnZng6OlZlY3RvcjJkKCkgY29uc3QK