102153 2012-11-13 16:38:13 -0800 [chromium] Remove the WebCompositorSupport virtual methods from the base class 2012-11-19 17:22:59 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 101968 102700 1 danakj danakj backer dglazkov jamesr peter+ews piman webkit.review.bot oldest_to_newest 766175 0 danakj 2012-11-13 16:38:13 -0800 [chromium] Remove the WebCompositorSupport virtual methods from the base class 766176 1 174025 danakj 2012-11-13 16:38:52 -0800 Created attachment 174025 Patch 766177 2 danakj 2012-11-13 16:39:39 -0800 This also depends on https://codereview.chromium.org/11410075 766425 3 174025 webkit.review.bot 2012-11-13 22:10:14 -0800 Comment on attachment 174025 Patch Attachment 174025 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14831207 766460 4 174025 peter+ews 2012-11-13 22:55:47 -0800 Comment on attachment 174025 Patch Attachment 174025 did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/14826483 769952 5 danakj 2012-11-17 08:50:14 -0800 Once chromium rolls into WebKit, this'll be ready to land. Can I get a review please? 770809 6 174025 webkit.review.bot 2012-11-19 09:19:30 -0800 Comment on attachment 174025 Patch Rejecting attachment 174025 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: /chromium/tests/LinkHighlightTest.o Source/WebKit/chromium/tests/GraphicsLayerChromiumTest.cpp: In constructor '<unnamed>::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest()': Source/WebKit/chromium/tests/GraphicsLayerChromiumTest.cpp:63: error: 'class WebKit::WebCompositorSupport' has no member named 'setAcceleratedAnimationEnabled' make: *** [out/Release/obj.target/webkit_unit_tests/Source/WebKit/chromium/tests/GraphicsLayerChromiumTest.o] Error 1 make: *** Waiting for unfinished jobs.... Full output: http://queues.webkit.org/results/14899255 770867 7 175007 danakj 2012-11-19 11:03:04 -0800 Created attachment 175007 Patch for landing 770882 8 175007 webkit.review.bot 2012-11-19 11:23:34 -0800 Comment on attachment 175007 Patch for landing Clearing flags on attachment: 175007 Committed r135180: <http://trac.webkit.org/changeset/135180> 770884 9 webkit.review.bot 2012-11-19 11:23:39 -0800 All reviewed patches have been landed. Closing bug. 770904 10 webkit.review.bot 2012-11-19 11:57:44 -0800 Re-opened since this is blocked by bug 102700 770911 11 danakj 2012-11-19 12:00:28 -0800 http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests/builds/24838/steps/compile/logs/stdio#error1 771224 12 175007 danakj 2012-11-19 16:57:58 -0800 Comment on attachment 175007 Patch for landing ui/compositor is fixed now. Chrome for ChromeOS is building locally. Let's try again. 771253 13 175007 webkit.review.bot 2012-11-19 17:22:55 -0800 Comment on attachment 175007 Patch for landing Clearing flags on attachment: 175007 Committed r135216: <http://trac.webkit.org/changeset/135216> 771254 14 webkit.review.bot 2012-11-19 17:22:59 -0800 All reviewed patches have been landed. Closing bug. 174025 2012-11-13 16:38:52 -0800 2012-11-19 11:03:00 -0800 Patch bug-102153-20121113193652.patch text/plain 1962 danakj U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0NDk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0v Q2hhbmdlTG9nIGIvU291cmNlL1BsYXRmb3JtL0NoYW5nZUxvZwppbmRleCBhNTgxMzZhNjJiMGEw MDMyNzMzNGQyYWQ2YjE5NGZlOTY1MTBhOWYyLi44ODlhZjEyZWIwM2RkMjk4YmUzZjhkZjU3NzAw YmMyMTM3YWZmN2JmIDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxOCBAQAogMjAxMi0xMS0xMyAg RGFuYSBKYW5zZW5zICA8ZGFuYWtqQGNocm9taXVtLm9yZz4KIAorICAgICAgICBbY2hyb21pdW1d IFJlbW92ZSB0aGUgV2ViQ29tcG9zaXRvclN1cHBvcnQgdmlydHVhbCBtZXRob2RzIGZyb20gdGhl IGJhc2UgY2xhc3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEwMjE1MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFRoZXNlIG1ldGhvZHMgaGF2ZSBub3cgYmVlbiByZW1vdmVkIGZyb20gV2ViQ29tcG9zaXRv clN1cHBvcnRJbXBsIGluCisgICAgICAgIGNocm9taXVtIGFuZCBzaG91bGQgYmUgcmVtb3ZlZCBm cm9tIHRoZSBiYXNlIGNsYXNzLiBFdmVyeXRoaW5nIGlzCisgICAgICAgIGdvaW5nIHRocm91Z2gg V2ViTGF5ZXJUcmVlU2V0dGluZ3Mgbm93LgorCisgICAgICAgICogY2hyb21pdW0vcHVibGljL1dl YkNvbXBvc2l0b3JTdXBwb3J0Lmg6CisKKzIwMTItMTEtMTMgIERhbmEgSmFuc2VucyAgPGRhbmFr akBjaHJvbWl1bS5vcmc+CisKICAgICAgICAgW2Nocm9taXVtXSBQbHVtYiBXZWJDb21wb3NpdG9y U3VwcG9ydCBzZXR0aW5ncyB0aHJvdWdoIFdlYkxheWVyVHJlZVNldHRpbmdzIGFzIHdlbGwsIGlu IHByZXBhcmF0aW9uIGZvciByZW1vdmluZyB0aGUgc2V0dGluZ3MgZnJvbSBXZWJDb21wb3NpdG9y U3VwcG9ydAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTAyMTQ2CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9QbGF0Zm9ybS9jaHJvbWl1bS9wdWJsaWMvV2Vi Q29tcG9zaXRvclN1cHBvcnQuaCBiL1NvdXJjZS9QbGF0Zm9ybS9jaHJvbWl1bS9wdWJsaWMvV2Vi Q29tcG9zaXRvclN1cHBvcnQuaAppbmRleCBiMTQ1MzQzYWY0YzYxY2QzNzNlMzg2MDBiYWExMjIw M2U5MzBmZjAwLi4yZmVlNzU4ZWY1OGE5YjdhOWEyZTFjOTE4N2JhNDFhZjNiY2VkNTI0IDEwMDY0 NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vY2hyb21pdW0vcHVibGljL1dlYkNvbXBvc2l0b3JTdXBw b3J0LmgKKysrIGIvU291cmNlL1BsYXRmb3JtL2Nocm9taXVtL3B1YmxpYy9XZWJDb21wb3NpdG9y U3VwcG9ydC5oCkBAIC02NywxMyArNjcsNiBAQCBwdWJsaWM6CiAgICAgLy8gYWZ0ZXIgc2h1dGRv d24uCiAgICAgdmlydHVhbCB2b2lkIHNodXRkb3duKCkgeyB9CiAKLSAgICAvLyBUaGVzZSBtYXkg b25seSBiZSBjYWxsZWQgYmVmb3JlIGluaXRpYWxpemUuCi0gICAgLy8gRklYTUU6IFJlbW92ZSB0 aGVzZS4KLSAgICB2aXJ0dWFsIHZvaWQgc2V0UGVyVGlsZVBhaW50aW5nRW5hYmxlZChib29sKSB7 IH0KLSAgICB2aXJ0dWFsIHZvaWQgc2V0UGFydGlhbFN3YXBFbmFibGVkKGJvb2wpIHsgfQotICAg IHZpcnR1YWwgdm9pZCBzZXRBY2NlbGVyYXRlZEFuaW1hdGlvbkVuYWJsZWQoYm9vbCkgeyB9Ci0g ICAgdmlydHVhbCB2b2lkIHNldFBhZ2VTY2FsZVBpbmNoWm9vbUVuYWJsZWQoYm9vbCkgeyB9Ci0K ICAgICAvLyBNYXkgcmV0dXJuIDAgaWYgaW5pdGlhbGl6YXRpb24gZmFpbHMuCiAgICAgdmlydHVh bCBXZWJMYXllclRyZWVWaWV3KiBjcmVhdGVMYXllclRyZWVWaWV3KFdlYkxheWVyVHJlZVZpZXdD bGllbnQqLCBjb25zdCBXZWJMYXllciYgcm9vdCwgY29uc3QgV2ViTGF5ZXJUcmVlVmlldzo6U2V0 dGluZ3MmKSB7IHJldHVybiAwOyB9CiAK 175007 2012-11-19 11:03:04 -0800 2012-11-19 17:22:55 -0800 Patch for landing bug-102153-20121119140054.patch text/plain 2692 danakj U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1MTc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0v Q2hhbmdlTG9nIGIvU291cmNlL1BsYXRmb3JtL0NoYW5nZUxvZwppbmRleCA0M2NmZDA3MzhkZTM0 MTM5NWEyOWVkZTY5MWM5YjVlYjRkOTliODIxLi4xY2JmZDI3YTc1ZGI3Y2IwYTBiN2Y1ZjczZmQ2 MDNhZTRmMDdkNjcyIDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMi0xMS0xMyAg RGFuYSBKYW5zZW5zICA8ZGFuYWtqQGNocm9taXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1d IFJlbW92ZSB0aGUgV2ViQ29tcG9zaXRvclN1cHBvcnQgdmlydHVhbCBtZXRob2RzIGZyb20gdGhl IGJhc2UgY2xhc3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEwMjE1MworCisgICAgICAgIFJldmlld2VkIGJ5IEphbWVzIFJvYmluc29uLgorCisgICAg ICAgIFRoZXNlIG1ldGhvZHMgaGF2ZSBub3cgYmVlbiByZW1vdmVkIGZyb20gV2ViQ29tcG9zaXRv clN1cHBvcnRJbXBsIGluCisgICAgICAgIGNocm9taXVtIGFuZCBzaG91bGQgYmUgcmVtb3ZlZCBm cm9tIHRoZSBiYXNlIGNsYXNzLiBFdmVyeXRoaW5nIGlzCisgICAgICAgIGdvaW5nIHRocm91Z2gg V2ViTGF5ZXJUcmVlU2V0dGluZ3Mgbm93LgorCisgICAgICAgICogY2hyb21pdW0vcHVibGljL1dl YkNvbXBvc2l0b3JTdXBwb3J0Lmg6CisKIDIwMTItMTEtMTYgIERhbmEgSmFuc2VucyAgPGRhbmFr akBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW2Nocm9taXVtXSBBZGQgY29udmVyc2lvbiBiZXR3 ZWVuIFdlYlRyYW5zZm9ybWF0aW9uIGFuZCBnZng6OlRyYW5zZm9ybQpkaWZmIC0tZ2l0IGEvU291 cmNlL1BsYXRmb3JtL2Nocm9taXVtL3B1YmxpYy9XZWJDb21wb3NpdG9yU3VwcG9ydC5oIGIvU291 cmNlL1BsYXRmb3JtL2Nocm9taXVtL3B1YmxpYy9XZWJDb21wb3NpdG9yU3VwcG9ydC5oCmluZGV4 IGIxNDUzNDNhZjRjNjFjZDM3M2UzODYwMGJhYTEyMjAzZTkzMGZmMDAuLjJmZWU3NThlZjU4YTli N2E5YTJlMWM5MTg3YmE0MWFmM2JjZWQ1MjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9QbGF0Zm9ybS9j aHJvbWl1bS9wdWJsaWMvV2ViQ29tcG9zaXRvclN1cHBvcnQuaAorKysgYi9Tb3VyY2UvUGxhdGZv cm0vY2hyb21pdW0vcHVibGljL1dlYkNvbXBvc2l0b3JTdXBwb3J0LmgKQEAgLTY3LDEzICs2Nyw2 IEBAIHB1YmxpYzoKICAgICAvLyBhZnRlciBzaHV0ZG93bi4KICAgICB2aXJ0dWFsIHZvaWQgc2h1 dGRvd24oKSB7IH0KIAotICAgIC8vIFRoZXNlIG1heSBvbmx5IGJlIGNhbGxlZCBiZWZvcmUgaW5p dGlhbGl6ZS4KLSAgICAvLyBGSVhNRTogUmVtb3ZlIHRoZXNlLgotICAgIHZpcnR1YWwgdm9pZCBz ZXRQZXJUaWxlUGFpbnRpbmdFbmFibGVkKGJvb2wpIHsgfQotICAgIHZpcnR1YWwgdm9pZCBzZXRQ YXJ0aWFsU3dhcEVuYWJsZWQoYm9vbCkgeyB9Ci0gICAgdmlydHVhbCB2b2lkIHNldEFjY2VsZXJh dGVkQW5pbWF0aW9uRW5hYmxlZChib29sKSB7IH0KLSAgICB2aXJ0dWFsIHZvaWQgc2V0UGFnZVNj YWxlUGluY2hab29tRW5hYmxlZChib29sKSB7IH0KLQogICAgIC8vIE1heSByZXR1cm4gMCBpZiBp bml0aWFsaXphdGlvbiBmYWlscy4KICAgICB2aXJ0dWFsIFdlYkxheWVyVHJlZVZpZXcqIGNyZWF0 ZUxheWVyVHJlZVZpZXcoV2ViTGF5ZXJUcmVlVmlld0NsaWVudCosIGNvbnN0IFdlYkxheWVyJiBy b290LCBjb25zdCBXZWJMYXllclRyZWVWaWV3OjpTZXR0aW5ncyYpIHsgcmV0dXJuIDA7IH0KIApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9HcmFwaGljc0xheWVyQ2hy b21pdW1UZXN0LmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvR3JhcGhpY3NMYXll ckNocm9taXVtVGVzdC5jcHAKaW5kZXggYjA0YjNhOTQ1M2ExZmUyYmI0ODljNzUwYTUwYTAxNjk5 OTdhOTEyNC4uN2Q5YzJlYzhjYWNlMDUzMTk4YTI5OWI1NDgwZTFlZDc3YzMxOWExMiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9HcmFwaGljc0xheWVyQ2hyb21pdW1U ZXN0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL0dyYXBoaWNzTGF5ZXJD aHJvbWl1bVRlc3QuY3BwCkBAIC01OSw4ICs1OSw2IEBAIGNsYXNzIEdyYXBoaWNzTGF5ZXJDaHJv bWl1bVRlc3QgOiBwdWJsaWMgdGVzdGluZzo6VGVzdCB7CiBwdWJsaWM6CiAgICAgR3JhcGhpY3NM YXllckNocm9taXVtVGVzdCgpCiAgICAgewotICAgICAgICAvLyBGb3IgdGhlc2UgdGVzdHMsIHdl IHdpbGwgZW5hYmxlIHRocmVhZGVkIGFuaW1hdGlvbnMuCi0gICAgICAgIFBsYXRmb3JtOjpjdXJy ZW50KCktPmNvbXBvc2l0b3JTdXBwb3J0KCktPnNldEFjY2VsZXJhdGVkQW5pbWF0aW9uRW5hYmxl ZCh0cnVlKTsKICAgICAgICAgUGxhdGZvcm06OmN1cnJlbnQoKS0+Y29tcG9zaXRvclN1cHBvcnQo KS0+aW5pdGlhbGl6ZSgwKTsKICAgICAgICAgbV9ncmFwaGljc0xheWVyID0gc3RhdGljX3BvaW50 ZXJfY2FzdDxHcmFwaGljc0xheWVyQ2hyb21pdW0+KEdyYXBoaWNzTGF5ZXI6OmNyZWF0ZSgmbV9j bGllbnQpKTsKICAgICAgICAgbV9wbGF0Zm9ybUxheWVyID0gbV9ncmFwaGljc0xheWVyLT5wbGF0 Zm9ybUxheWVyKCk7Cg==