102152 2012-11-13 16:36:26 -0800 PDFPlugin should support downloading PDFs 2012-11-14 12:30:03 -0800 1 1 1 Unclassified WebKit PDF 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton ap mitz simon.fraser webkit.review.bot oldest_to_newest 766172 0 thorton 2012-11-13 16:36:26 -0800 The HUD button to download a PDF is not currently implemented. I have a patch. <rdar://problem/12555313> 766200 1 174032 thorton 2012-11-13 17:09:16 -0800 Created attachment 174032 patch 766205 2 webkit.review.bot 2012-11-13 17:11:53 -0800 Attachment 174032 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/UIProcess/WebPageProxy.h:724: The parameter name "data" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style. 766309 3 174032 ap 2012-11-13 19:04:15 -0800 Comment on attachment 174032 patch View in context: https://bugs.webkit.org/attachment.cgi?id=174032&action=review > Source/WebKit2/UIProcess/WebPageProxy.cpp:4102 > + if (mimeType != "application/pdf") > + return; I'm not sure about the value of this check (and the argument, which is just hardcoded on the other side anyway). 767177 4 thorton 2012-11-14 12:30:03 -0800 Thanks, Alexey! http://trac.webkit.org/changeset/134647 174032 2012-11-13 17:09:16 -0800 2012-11-13 19:04:14 -0800 patch save-pdf.diff text/plain 7395 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA3ODAyMmUwLi4xOTdkZjA0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzMg QEAKKzIwMTItMTEtMTMgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgUERGUGx1Z2luIHNob3VsZCBzdXBwb3J0IGRvd25sb2FkaW5nIFBERnMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMjE1MgorICAgICAg ICA8cmRhcjovL3Byb2JsZW0vMTI1NTUzMTM+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQ2xpY2tpbmcgb24gdGhlICJEb3dubG9hZCBQREYiIEhVRCBi dXR0b24gc2hvdWxkIGRvd25sb2FkIHRoZSBjdXJyZW50CisgICAgICAgIFBERiB0byB0aGUgRG93 bmxvYWRzIGZvbGRlci4KKworICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwOgor ICAgICAgICAoV2ViS2l0OjpXZWJQYWdlUHJveHk6OnNhdmVQREZUb0ZpbGVJbkRvd25sb2Fkc0Zv bGRlcik6IEFkZGVkLiBTYXZlIHRoZQorICAgICAgICBQREYgZGF0YSB0byBkaXNrLCBpbiB0aGUg RG93bmxvYWRzIGZvbGRlci4gVGhpcyB3aWxsIG9ubHkgc2F2ZSBmaWxlcyB3aXRoCisgICAgICAg IHRoZSAucGRmIGV4dGVuc2lvbiwgYW5kIG9mIE1JTUUgdHlwZSAiYXBwbGljYXRpb24vcGRmIi4K KyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUGFnZVByb3h5Lmg6CisgICAgICAgIChXZWJQYWdlUHJv eHkpOiBBZGQgc2F2ZVBERlRvRmlsZUluRG93bmxvYWRzRm9sZGVyLgorICAgICAgICAqIFVJUHJv Y2Vzcy9XZWJQYWdlUHJveHkubWVzc2FnZXMuaW46IEFkZCBzYXZlUERGVG9GaWxlSW5Eb3dubG9h ZHNGb2xkZXIuCisgICAgICAgICogV2ViUHJvY2Vzcy9QbHVnaW5zL1BERi9QREZQbHVnaW4uaDoK KyAgICAgICAgKFBERlBsdWdpbik6IEFkZCBzYXZlVG9QREYoKS4KKyAgICAgICAgKiBXZWJQcm9j ZXNzL1BsdWdpbnMvUERGL1BERlBsdWdpbi5tbToKKyAgICAgICAgKC1bV0tQREZMYXllckNvbnRy b2xsZXJEZWxlZ2F0ZSBzYXZlVG9QREZdKTogRm9yd2FyZCBzYXZlVG9QREYgZGVsZWdhdGUgY2Fs bGJhY2sgdG8gUERGUGx1Z2luLgorICAgICAgICAoV2ViS2l0OjpQREZQbHVnaW46OnNhdmVUb1BE Rik6IEhhbmQgV2ViUGFnZVByb3h5IHRoZSByYXcgZGF0YSBmb3IgdGhlCisgICAgICAgIGN1cnJl bnQgUERGLCB3aGljaCBpdCB3aWxsIHNhdmUgdG8gdGhlIERvd25sb2FkcyBmb2xkZXIuIFdlIHJl Y2VpdmUKKyAgICAgICAgdGhlIHN1Z2dlc3RlZCBmaWxlbmFtZSBkdXJpbmcgbG9hZGluZy4KKyAg ICAgICAgKiBXZWJQcm9jZXNzL1BsdWdpbnMvUERGL1NpbXBsZVBERlBsdWdpbi5oOgorICAgICAg ICAoV2ViS2l0OjpTaW1wbGVQREZQbHVnaW46OnN1Z2dlc3RlZEZpbGVuYW1lKTogRXhwb3NlIGEg Z2V0dGVyIGZvciBzdWdnZXN0ZWRGaWxlbmFtZS4KKyAgICAgICAgKiBXZWJQcm9jZXNzL1BsdWdp bnMvUERGL1NpbXBsZVBERlBsdWdpbi5tbToKKyAgICAgICAgKFdlYktpdDo6U2ltcGxlUERGUGx1 Z2luOjpwbHVnaW5JbmZvKTogQWRkIGEgbWlzc2luZyBzcGFjZSBhZnRlciBhbiBvcGVyYXRvci4K KwogMjAxMi0xMS0xMSAgU2hpbnlhIEthd2FuYWthICA8c2hpbnlha0BjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgW1NoYWRvd10gRWxlbWVudFNoYWRvdyBzaG91bGQgaGF2ZSBSdWxlRmVhdHVyZVNl dCBmb3Igc2VsZWN0IGF0dHJpYnV0ZSBzZWxlY3RvcnMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9XZWJQYWdlUHJveHkuY3BwCmluZGV4IDA3MDQwNTUuLmJmNjIyMTIgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCkBAIC00MDk2LDYgKzQwOTYsMTkgQEAgdm9p ZCBXZWJQYWdlUHJveHk6OnNhdmVEYXRhVG9GaWxlSW5Eb3dubG9hZHNGb2xkZXIoY29uc3QgU3Ry aW5nJiBzdWdnZXN0ZWRGaWxlbmEKICAgICBtX3VpQ2xpZW50LnNhdmVEYXRhVG9GaWxlSW5Eb3du bG9hZHNGb2xkZXIodGhpcywgc3VnZ2VzdGVkRmlsZW5hbWUsIG1pbWVUeXBlLCBvcmlnaW5hdGlu Z1VSTFN0cmluZywgZGF0YSk7CiB9CiAKK3ZvaWQgV2ViUGFnZVByb3h5OjpzYXZlUERGVG9GaWxl SW5Eb3dubG9hZHNGb2xkZXIoY29uc3QgU3RyaW5nJiBzdWdnZXN0ZWRGaWxlbmFtZSwgY29uc3Qg U3RyaW5nJiBtaW1lVHlwZSwgY29uc3QgU3RyaW5nJiBvcmlnaW5hdGluZ1VSTFN0cmluZywgY29u c3QgQ29yZUlQQzo6RGF0YVJlZmVyZW5jZSYgZGF0YSkKK3sKKyAgICBpZiAobWltZVR5cGUgIT0g ImFwcGxpY2F0aW9uL3BkZiIpCisgICAgICAgIHJldHVybjsKKworICAgIGlmICghc3VnZ2VzdGVk RmlsZW5hbWUuZW5kc1dpdGgoIi5wZGYiLCBmYWxzZSkpCisgICAgICAgIHJldHVybjsKKworICAg IFJlZlB0cjxXZWJEYXRhPiB3ZWJEYXRhID0gV2ViRGF0YTo6Y3JlYXRlKGRhdGEuZGF0YSgpLCBk YXRhLnNpemUoKSk7CisKKyAgICBzYXZlRGF0YVRvRmlsZUluRG93bmxvYWRzRm9sZGVyKHN1Z2dl c3RlZEZpbGVuYW1lLCBtaW1lVHlwZSwgb3JpZ2luYXRpbmdVUkxTdHJpbmcsIHdlYkRhdGEuZ2V0 KCkpOworfQorCiB2b2lkIFdlYlBhZ2VQcm94eTo6bGlua0NsaWNrZWQoY29uc3QgU3RyaW5nJiB1 cmwsIGNvbnN0IFdlYk1vdXNlRXZlbnQmIGV2ZW50KQogewogICAgIG1fcHJvY2Vzcy0+c2VuZChN ZXNzYWdlczo6V2ViUGFnZTo6TGlua0NsaWNrZWQodXJsLCBldmVudCksIG1fcGFnZUlELCAwKTsK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuaCBiL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuaAppbmRleCAzOWQ3MTZjLi43NTk5 ZmJlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmgK KysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5oCkBAIC03MjEsNiAr NzIxLDcgQEAgcHVibGljOgogICAgIHN0YXRpYyBXZWJDb3JlOjpDb2xvciBiYWNraW5nU3RvcmVV cGRhdGVzRmxhc2hDb2xvcigpOwogCiAgICAgdm9pZCBzYXZlRGF0YVRvRmlsZUluRG93bmxvYWRz Rm9sZGVyKGNvbnN0IFN0cmluZyYgc3VnZ2VzdGVkRmlsZW5hbWUsIGNvbnN0IFN0cmluZyYgbWlt ZVR5cGUsIGNvbnN0IFN0cmluZyYgb3JpZ2luYXRpbmdVUkxTdHJpbmcsIFdlYkRhdGEqKTsKKyAg ICB2b2lkIHNhdmVQREZUb0ZpbGVJbkRvd25sb2Fkc0ZvbGRlcihjb25zdCBTdHJpbmcmIHN1Z2dl c3RlZEZpbGVuYW1lLCBjb25zdCBTdHJpbmcmIG1pbWVUeXBlLCBjb25zdCBTdHJpbmcmIG9yaWdp bmF0aW5nVVJMU3RyaW5nLCBjb25zdCBDb3JlSVBDOjpEYXRhUmVmZXJlbmNlJiBkYXRhKTsKIAog ICAgIHZvaWQgbGlua0NsaWNrZWQoY29uc3QgU3RyaW5nJiwgY29uc3QgV2ViTW91c2VFdmVudCYp OwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5Lm1l c3NhZ2VzLmluIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5tZXNzYWdl cy5pbgppbmRleCBiNDNjOWM1Li5mZjMxZDhhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvV2ViUGFnZVByb3h5Lm1lc3NhZ2VzLmluCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9XZWJQYWdlUHJveHkubWVzc2FnZXMuaW4KQEAgLTMzNSw0ICszMzUsNiBAQCBtZXNz YWdlcyAtPiBXZWJQYWdlUHJveHkgewogICAgICMgU291cCBjdXN0b20gVVJJIHJlcXVlc3QgbWVz c2FnZXMKICAgICBEaWRSZWNlaXZlVVJJUmVxdWVzdChXVEY6OlN0cmluZyB1cmlTdHJpbmcsIHVp bnQ2NF90IHJlcXVlc3RJRCk7CiAjZW5kaWYKKworICAgIFNhdmVQREZUb0ZpbGVJbkRvd25sb2Fk c0ZvbGRlcihXVEY6OlN0cmluZyBzdWdnZXN0ZWRGaWxlbmFtZSwgV1RGOjpTdHJpbmcgbWltZVR5 cGUsIFdURjo6U3RyaW5nIG9yaWdpbmF0aW5nVVJMU3RyaW5nLCBDb3JlSVBDOjpEYXRhUmVmZXJl bmNlIGRhdGEpCiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdp bnMvUERGL1BERlBsdWdpbi5oIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL1BE Ri9QREZQbHVnaW4uaAppbmRleCA2ZWNjNjc4Li4xY2YxZjRiIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvUERGL1BERlBsdWdpbi5oCisrKyBiL1NvdXJjZS9X ZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9QREYvUERGUGx1Z2luLmgKQEAgLTY1LDYgKzY1LDcg QEAgcHVibGljOgogICAgIHVzaW5nIFNjcm9sbGFibGVBcmVhOjpub3RpZnlTY3JvbGxQb3NpdGlv bkNoYW5nZWQ7CiAKICAgICB2b2lkIGNsaWNrZWRMaW5rKE5TVVJMICopOworICAgIHZvaWQgc2F2 ZVRvUERGKCk7CiAKIHByaXZhdGU6CiAgICAgZXhwbGljaXQgUERGUGx1Z2luKFdlYkZyYW1lKik7 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvUERGL1BERlBs dWdpbi5tbSBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9QREYvUERGUGx1Z2lu Lm1tCmluZGV4IDljMmNiMDQuLjljY2M4MTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dl YlByb2Nlc3MvUGx1Z2lucy9QREYvUERGUGx1Z2luLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dl YlByb2Nlc3MvUGx1Z2lucy9QREYvUERGUGx1Z2luLm1tCkBAIC0yOCw2ICsyOCw4IEBACiAjaW1w b3J0ICJjb25maWcuaCIKICNpbXBvcnQgIlBERlBsdWdpbi5oIgogCisjaW1wb3J0ICJBcmd1bWVu dENvZGVycy5oIgorI2ltcG9ydCAiRGF0YVJlZmVyZW5jZS5oIgogI2ltcG9ydCAiUERGS2l0SW1w b3J0cy5oIgogI2ltcG9ydCAiUERGTGF5ZXJDb250cm9sbGVyRGV0YWlscy5oIgogI2ltcG9ydCAi UERGUGx1Z2luQW5ub3RhdGlvbi5oIgpAQCAtMzUsNiArMzcsOCBAQAogI2ltcG9ydCAiU2hhcmVh YmxlQml0bWFwLmgiCiAjaW1wb3J0ICJXZWJFdmVudC5oIgogI2ltcG9ydCAiV2ViRXZlbnRDb252 ZXJzaW9uLmgiCisjaW1wb3J0ICJXZWJQYWdlLmgiCisjaW1wb3J0ICJXZWJQYWdlUHJveHlNZXNz YWdlcy5oIgogI2ltcG9ydCA8UERGS2l0L1BERktpdC5oPgogI2ltcG9ydCA8UXVhcnR6Q29yZS9R dWFydHpDb3JlLmg+CiAjaW1wb3J0IDxXZWJDb3JlL0FyY2hpdmVSZXNvdXJjZS5oPgpAQCAtMTc2 LDcgKzE4MCw3IEBAIHN0YXRpYyBjb25zdCBjaGFyKiBhbm5vdGF0aW9uU3R5bGUgPQogCiAtICh2 b2lkKXNhdmVUb1BERgogewotICAgIC8vIEZJWE1FOiBJbXBsZW1lbnQuCisgICAgX3BkZlBsdWdp bi0+c2F2ZVRvUERGKCk7CiB9CiAKIC0gKHZvaWQpcGRmTGF5ZXJDb250cm9sbGVyOihQREZMYXll ckNvbnRyb2xsZXIgKilwZGZMYXllckNvbnRyb2xsZXIgY2xpY2tlZExpbmtXaXRoVVJMOihOU1VS TCAqKXVybApAQCAtNjMyLDYgKzYzNiwxNSBAQCBib29sIFBERlBsdWdpbjo6c3VwcG9ydHNGb3Jt cygpCiAgICAgcmV0dXJuIHdlYkZyYW1lKCktPmlzTWFpbkZyYW1lKCk7CiB9CiAKK3ZvaWQgUERG UGx1Z2luOjpzYXZlVG9QREYoKQoreworICAgIFJldGFpblB0cjxDRk11dGFibGVEYXRhUmVmPiBj ZkRhdGEgPSBkYXRhKCk7CisKKyAgICBDb3JlSVBDOjpEYXRhUmVmZXJlbmNlIGRhdGFSZWZlcmVu Y2UoQ0ZEYXRhR2V0Qnl0ZVB0cihjZkRhdGEuZ2V0KCkpLCBDRkRhdGFHZXRMZW5ndGgoY2ZEYXRh LmdldCgpKSk7CisKKyAgICB3ZWJGcmFtZSgpLT5wYWdlKCktPnNlbmQoTWVzc2FnZXM6OldlYlBh Z2VQcm94eTo6U2F2ZVBERlRvRmlsZUluRG93bmxvYWRzRm9sZGVyKHN1Z2dlc3RlZEZpbGVuYW1l KCksICJhcHBsaWNhdGlvbi9wZGYiLCB3ZWJGcmFtZSgpLT51cmwoKSwgZGF0YVJlZmVyZW5jZSkp OworfQorCiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQKIAogI2VuZGlmIC8vIEVOQUJMRShQREZLSVRf UExVR0lOKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL1BE Ri9TaW1wbGVQREZQbHVnaW4uaCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9Q REYvU2ltcGxlUERGUGx1Z2luLmgKaW5kZXggNzk4ZjBiNy4uYTZiMTIyNSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL1BERi9TaW1wbGVQREZQbHVnaW4uaAor KysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvUERGL1NpbXBsZVBERlBsdWdp bi5oCkBAIC02Niw2ICs2Niw4IEBAIHByb3RlY3RlZDoKIAogICAgIFdlYkNvcmU6OkludFNpemUg cGRmRG9jdW1lbnRTaXplKCkgY29uc3QgeyByZXR1cm4gbV9wZGZEb2N1bWVudFNpemU7IH0KICAg ICB2b2lkIHNldFBERkRvY3VtZW50U2l6ZShXZWJDb3JlOjpJbnRTaXplIHNpemUpIHsgbV9wZGZE b2N1bWVudFNpemUgPSBzaXplOyB9CisKKyAgICBjb25zdCBTdHJpbmcmIHN1Z2dlc3RlZEZpbGVu YW1lKCkgeyByZXR1cm4gbV9zdWdnZXN0ZWRGaWxlbmFtZTsgfQogICAgIAogICAgIFJldGFpblB0 cjxDRk11dGFibGVEYXRhUmVmPiBkYXRhKCkgY29uc3QgeyByZXR1cm4gbV9kYXRhOyB9CiAKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9QREYvU2ltcGxlUERG UGx1Z2luLm1tIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL1BERi9TaW1wbGVQ REZQbHVnaW4ubW0KaW5kZXggOThhNzNiMi4uMzIwMzJjMiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL1BERi9TaW1wbGVQREZQbHVnaW4ubW0KKysrIGIvU291 cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL1BERi9TaW1wbGVQREZQbHVnaW4ubW0KQEAg LTE3Niw3ICsxNzYsNyBAQCBQbHVnaW5JbmZvIFNpbXBsZVBERlBsdWdpbjo6cGx1Z2luSW5mbygp CiAgICAgaW5mby5uYW1lID0gYnVpbHRJblBERlBsdWdpbk5hbWUoKTsKIAogICAgIE1pbWVDbGFz c0luZm8gbWltZUNsYXNzSW5mbzsKLSAgICBtaW1lQ2xhc3NJbmZvLnR5cGUgPSJhcHBsaWNhdGlv bi9wZGYiOworICAgIG1pbWVDbGFzc0luZm8udHlwZSA9ICJhcHBsaWNhdGlvbi9wZGYiOwogICAg IG1pbWVDbGFzc0luZm8uZGVzYyA9IHBkZkRvY3VtZW50VHlwZURlc2NyaXB0aW9uKCk7CiAgICAg bWltZUNsYXNzSW5mby5leHRlbnNpb25zLmFwcGVuZCgicGRmIik7CiAK