102108 2012-11-13 10:57:31 -0800 Missing NodeRenderStyle.h include in WebCore/html/TextFieldInputType.cpp 2012-11-13 15:54:17 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 wangxianzhu wangxianzhu abarth tasak tkent webkit.review.bot oldest_to_newest 765812 0 wangxianzhu 2012-11-13 10:57:31 -0800 Node::renderStyle() is declared in Node.h, defined as an inline function in NodeRenderStyle.h. TextFieldInputType.cpp doesn't include NodeRenderStyle.h but uses Node::renderStyle(). This causes link error on a Chromium bot (http://build.chromium.org/p/chromium.linux/builders/Android%20Clang%20Builder%20%28dbg%29/builds/1238/steps/compile/logs/stdio/text). 765842 1 173932 wangxianzhu 2012-11-13 11:24:42 -0800 Created attachment 173932 Patch 765861 2 173932 abarth 2012-11-13 11:41:49 -0800 Comment on attachment 173932 Patch ok 765890 3 173932 webkit.review.bot 2012-11-13 11:57:02 -0800 Comment on attachment 173932 Patch Rejecting attachment 173932 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/14818667 765901 4 173944 wangxianzhu 2012-11-13 12:03:01 -0800 Created attachment 173944 rebased 766137 5 173944 wangxianzhu 2012-11-13 15:54:15 -0800 Comment on attachment 173944 rebased Clearing flags on attachment: 173944 Committed r134500: <http://trac.webkit.org/changeset/134500> 766138 6 wangxianzhu 2012-11-13 15:54:17 -0800 All reviewed patches have been landed. Closing bug. 173932 2012-11-13 11:24:42 -0800 2012-11-13 12:02:56 -0800 Patch bug-102108-20121113112242.patch text/plain 1200 wangxianzhu U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0NDQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTQ0YjM3NTMzYTI0MWM0 N2U1ZmYxYzE4YTM5NmMyNTQ3ZTc0MjZjMy4uODJmZmU4NTk4MDNjZGMxNDMzZGQxZDQyZjQ2ZmJh MjUwMTljNzA1ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTExLTEzICBYaWFu emh1IFdhbmcgIDx3YW5neGlhbnpodUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgTWlzc2luZyBO b2RlUmVuZGVyU3R5bGUuaCBpbmNsdWRlIGluIFdlYkNvcmUvaHRtbC9UZXh0RmllbGRJbnB1dFR5 cGUuY3BwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MDIxMDgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBO byBuZXcgdGVzdHMuIEZpeCBjbGFuZyBidWlsZCBicmVhay4KKworICAgICAgICAqIGh0bWwvVGV4 dEZpZWxkSW5wdXRUeXBlLmNwcDoKKwogMjAxMi0xMS0xMyAgRGFuIENhcm5leSAgPGRjYXJuZXlA Z29vZ2xlLmNvbT4KIAogICAgICAgICBbVjhdIE1vcmUgZWZmaWNpZW50IHdyYXBwZXIgZGlzcGF0 Y2gKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvVGV4dEZpZWxkSW5wdXRUeXBlLmNw cCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvVGV4dEZpZWxkSW5wdXRUeXBlLmNwcAppbmRleCBjYTNm MWQ3NmNkNWE5ZDI0NTY4Yjg3ZTNjNDJkZmUyMjVhZmI1NjczLi40NDlmZDhkNTkzYjU4NTE0ZjZk ZDdlODljNTNhY2JjOGIwY2UxZjM4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL1Rl eHRGaWVsZElucHV0VHlwZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9UZXh0RmllbGRJ bnB1dFR5cGUuY3BwCkBAIC00MSw2ICs0MSw3IEBACiAjaW5jbHVkZSAiSFRNTElucHV0RWxlbWVu dC5oIgogI2luY2x1ZGUgIkhUTUxOYW1lcy5oIgogI2luY2x1ZGUgIktleWJvYXJkRXZlbnQuaCIK KyNpbmNsdWRlICJOb2RlUmVuZGVyU3R5bGUuaCIKICNpbmNsdWRlICJQYWdlLmgiCiAjaW5jbHVk ZSAiUmVuZGVyTGF5ZXIuaCIKICNpbmNsdWRlICJSZW5kZXJUZXh0Q29udHJvbFNpbmdsZUxpbmUu aCIK 173944 2012-11-13 12:03:01 -0800 2012-11-13 15:54:15 -0800 rebased bug-102108-20121113120101.patch text/plain 1205 wangxianzhu U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0NDYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTdiNDlhMjA0YmM0MDUz MGE3MjM4ODk2ODFkNmU5MmE3OTU3MjhiOC4uMmRlMWQ5NWZlNGVmNTBjNWRmOTcwZGVlZmY4ZGMw MTY2MTg4ODFkNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTExLTEzICBYaWFu emh1IFdhbmcgIDx3YW5neGlhbnpodUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgTWlzc2luZyBO b2RlUmVuZGVyU3R5bGUuaCBpbmNsdWRlIGluIFdlYkNvcmUvaHRtbC9UZXh0RmllbGRJbnB1dFR5 cGUuY3BwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MDIxMDgKKworICAgICAgICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgorCisgICAgICAgIE5vIG5l dyB0ZXN0cy4gRml4IGNsYW5nIGJ1aWxkIGJyZWFrLgorCisgICAgICAgICogaHRtbC9UZXh0Rmll bGRJbnB1dFR5cGUuY3BwOiBBZGRlZCAjaW5jbHVkZSAiTm9kZVJlbmRlclN0eWxlLmgiCisKIDIw MTItMTEtMTMgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJl dmlld2VkLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9UZXh0RmllbGRJbnB1dFR5 cGUuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9UZXh0RmllbGRJbnB1dFR5cGUuY3BwCmluZGV4 IGNhM2YxZDc2Y2Q1YTlkMjQ1NjhiODdlM2M0MmRmZTIyNWFmYjU2NzMuLjQ0OWZkOGQ1OTNiNTg1 MTRmNmRkN2U4OWM1M2FjYmM4YjBjZTFmMzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0 bWwvVGV4dEZpZWxkSW5wdXRUeXBlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL1RleHRG aWVsZElucHV0VHlwZS5jcHAKQEAgLTQxLDYgKzQxLDcgQEAKICNpbmNsdWRlICJIVE1MSW5wdXRF bGVtZW50LmgiCiAjaW5jbHVkZSAiSFRNTE5hbWVzLmgiCiAjaW5jbHVkZSAiS2V5Ym9hcmRFdmVu dC5oIgorI2luY2x1ZGUgIk5vZGVSZW5kZXJTdHlsZS5oIgogI2luY2x1ZGUgIlBhZ2UuaCIKICNp bmNsdWRlICJSZW5kZXJMYXllci5oIgogI2luY2x1ZGUgIlJlbmRlclRleHRDb250cm9sU2luZ2xl TGluZS5oIgo=