102088 2012-11-13 08:04:34 -0800 [BlackBerry] FCC doesn't work in textarea 2012-11-16 12:06:47 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rwlbuis rwlbuis allan.jensen mifenton tonikitoo webkit.review.bot oldest_to_newest 765608 0 rwlbuis 2012-11-13 08:04:34 -0800 SSIA 765611 1 173894 rwlbuis 2012-11-13 08:07:30 -0800 Created attachment 173894 Patch 765620 2 173894 yong.li.webkit 2012-11-13 08:13:21 -0800 Comment on attachment 173894 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173894&action=review > Source/WebKit/blackberry/WebKitSupport/FatFingers.cpp:95 > + || element->isContentEditable() && (element->shadowPseudoId() != "-webkit-search-cancel-button" || !element->isInShadowTree()); So || element->shadowPseudoId() == "-webkit-search-cancel-button" is no longer clickable? Nit: One more pair of braces would be nice. 765636 3 173894 tonikitoo 2012-11-13 08:32:05 -0800 Comment on attachment 173894 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173894&action=review To me the proper solution is: use the respondToMouseXXXEvent set of new functions in WebCore. >> Source/WebKit/blackberry/WebKitSupport/FatFingers.cpp:95 >> + || element->isContentEditable() && (element->shadowPseudoId() != "-webkit-search-cancel-button" || !element->isInShadowTree()); > > So || element->shadowPseudoId() == "-webkit-search-cancel-button" is no longer clickable? > > Nit: One more pair of braces would be nice. This is getting too tricky. 765990 4 173969 rwlbuis 2012-11-13 13:29:54 -0800 Created attachment 173969 Patch 767248 5 174244 rwlbuis 2012-11-14 13:38:13 -0800 Created attachment 174244 Patch 769554 6 rwlbuis 2012-11-16 12:06:47 -0800 Committed r134980: <http://trac.webkit.org/changeset/134980> 173894 2012-11-13 08:07:30 -0800 2012-11-13 13:29:51 -0800 Patch bug-102088-20121113120523.patch text/plain 1888 rwlbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0MjU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCA5YjRmY2ZiNWE3NDc5ZDMzNDM3MWEwYzU5M2ZiZWY4MmVkOTJlMmNmLi44NTc2NWU5OWJi MzlmMjU4ZmQwMTRiMjE3ZTM2NjJhODA4NzMzY2IxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMi0xMS0xMyAgUm9iIEJ1aXMgIDxyYnVpc0ByaW0u Y29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBGQ0MgZG9lc24ndCB3b3JrIGluIHRleHRhcmVh CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDIwODgK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWFrZW4g dGhlIGNvbmRpdGlvbnMgc28gYm90aCB0aGUgLXdlYmtpdC1zZWFyY2gtY2FuY2VsLWJ1dHRvbiBh cyB3ZWxsIGFzIHRoZQorICAgICAgICB0ZXh0YXJlYSBhcmUgY2xpY2thYmxlLgorCisgICAgICAg IFJJTSBQUiAyMjE4MzcKKyAgICAgICAgSW50ZXJuYWxseSByZXZpZXdlZCBieSBNaWtlIEZlbnRv bi4KKworICAgICAgICAqIFdlYktpdFN1cHBvcnQvRmF0RmluZ2Vycy5jcHA6CisgICAgICAgIChC bGFja0JlcnJ5OjpXZWJLaXQ6OkZhdEZpbmdlcnM6OmlzRWxlbWVudENsaWNrYWJsZSk6CisKIDIw MTItMTEtMTIgIFJvYiBCdWlzICA8cmJ1aXNAcmltLmNvbT4KIAogICAgICAgICBbQmxhY2tCZXJy eV0gQ3Jhc2ggaW4gSW5SZWdpb25TY3JvbGxlclByaXZhdGUuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9GYXRGaW5nZXJzLmNwcCBiL1NvdXJjZS9X ZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0ZhdEZpbmdlcnMuY3BwCmluZGV4IDg3N2Rj MjAwOWY1Y2Q2OTEwZDYyNGRkY2MyOWY4ZmZiNjZhNjI4MWUuLmYwM2Y1NDcxOGQxMjAwOTkwZTg0 ZjY5ZGFlMGI3ZmU4Yzc5MWY1YzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJy eS9XZWJLaXRTdXBwb3J0L0ZhdEZpbmdlcnMuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2ti ZXJyeS9XZWJLaXRTdXBwb3J0L0ZhdEZpbmdlcnMuY3BwCkBAIC05Miw4ICs5Miw3IEBAIGJvb2wg RmF0RmluZ2Vyczo6aXNFbGVtZW50Q2xpY2thYmxlKEVsZW1lbnQqIGVsZW1lbnQpIGNvbnN0CiAg ICAgICAgIEV4Y2VwdGlvbkNvZGUgZWMgPSAwOwogICAgICAgICByZXR1cm4gZWxlbWVudC0+d2Vi a2l0TWF0Y2hlc1NlbGVjdG9yKCJhW2hyZWZdLCo6bGluaywqOnZpc2l0ZWQsKltyb2xlPWJ1dHRv bl0sYnV0dG9uLGlucHV0LHNlbGVjdCxsYWJlbFtmb3JdLGFyZWFbaHJlZl0sdGV4dGFyZWEsZW1i ZWQsb2JqZWN0IiwgZWMpCiAgICAgICAgICAgICB8fCBlbGVtZW50LT5pc01lZGlhQ29udHJvbEVs ZW1lbnQoKQotICAgICAgICAgICAgfHwgKGVsZW1lbnQtPmlzQ29udGVudEVkaXRhYmxlKCkgJiYg IWVsZW1lbnQtPmlzSW5TaGFkb3dUcmVlKCkpCi0gICAgICAgICAgICB8fCBlbGVtZW50LT5zaGFk b3dQc2V1ZG9JZCgpID09ICItd2Via2l0LXNlYXJjaC1jYW5jZWwtYnV0dG9uIjsKKyAgICAgICAg ICAgIHx8IGVsZW1lbnQtPmlzQ29udGVudEVkaXRhYmxlKCkgJiYgKGVsZW1lbnQtPnNoYWRvd1Bz ZXVkb0lkKCkgIT0gIi13ZWJraXQtc2VhcmNoLWNhbmNlbC1idXR0b24iIHx8ICFlbGVtZW50LT5p c0luU2hhZG93VHJlZSgpKTsKICAgICB9CiAgICAgY2FzZSBNYWRlQ2xpY2thYmxlQnlUaGVXZWJw YWdlOgogCg== 173969 2012-11-13 13:29:54 -0800 2012-11-14 13:38:10 -0800 Patch bug-102088-20121113172740.patch text/plain 2070 rwlbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0NDIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCA4ZjYzYmZiYmEwNjU4YTVlODRiN2E2NmY4ZjZjMDQ0N2VmMTM3NmU4Li4xZTBjMTEzYzYw Y2Q0YWE5ZmE5OGUxMjY2YTZjNDkzMGE4OWJmZjRiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMi0xMS0xMyAgUm9iIEJ1aXMgIDxyYnVpc0ByaW0u Y29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBGQ0MgZG9lc24ndCB3b3JrIGluIHRleHRhcmVh CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDIwODgK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBbGxvdyB0 aGUgY29udGVudEVkaXRhYmxlIHRlc3QgZm9yIHNoYWRvdyB0cmVlIGVsZW1lbnRzIG90aGVyIHRo YW4gaW5wdXQuIFRoaXMgaXMgbmVlZGVkCisgICAgICAgIHNvIHRoZSBjYW5jZWwgYnV0dG9uIHdp bGwgYmUgZWFzeSB0byBoaXQgYXMgYmVmb3JlLiBGb3IgdGhlIHRleHRhcmVhIHRoaXMgbmV3IHBh dGNoCisgICAgICAgIGJhc2ljYWxseSBtZWFucyBhIHJldmVydCB0byB0aGUgb2xkIHNpdHVhdGlv biwgc28gRkNDIG9uIHRleHRhcmVhIGlzIHJlc3RvcmVkLgorCisgICAgICAgIFJJTSBQUiAyMjE4 MzcKKyAgICAgICAgSW50ZXJuYWxseSByZXZpZXdlZCBieSBNaWtlIEZlbnRvbi4KKworICAgICAg ICAqIFdlYktpdFN1cHBvcnQvRmF0RmluZ2Vycy5jcHA6CisgICAgICAgIChCbGFja0JlcnJ5OjpX ZWJLaXQ6OkZhdEZpbmdlcnM6OmlzRWxlbWVudENsaWNrYWJsZSk6CisKIDIwMTItMTEtMTIgIE5p bWEgR2hhbmF2YXRpYW4gIDxuZ2hhbmF2YXRpYW5AcmltLmNvbT4KIAogICAgICAgICBbQmxhY2tC ZXJyeV0gRW5zdXJlIHdlIG9ubHkgcmVjZWl2ZSBvbmUgS2V5VXAgcGVyIGtleSBldmVudApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvRmF0RmluZ2Vy cy5jcHAgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9GYXRGaW5nZXJz LmNwcAppbmRleCA4NzdkYzIwMDlmNWNkNjkxMGQ2MjRkZGNjMjlmOGZmYjY2YTYyODFlLi41YjQ3 MTUyYTFkZDE3NTk5ODRkMzlhYmIzNmU1OGFmNjRhNzdmZDRkIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9GYXRGaW5nZXJzLmNwcAorKysgYi9Tb3Vy Y2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9GYXRGaW5nZXJzLmNwcApAQCAtOTIs NyArOTIsNyBAQCBib29sIEZhdEZpbmdlcnM6OmlzRWxlbWVudENsaWNrYWJsZShFbGVtZW50KiBl bGVtZW50KSBjb25zdAogICAgICAgICBFeGNlcHRpb25Db2RlIGVjID0gMDsKICAgICAgICAgcmV0 dXJuIGVsZW1lbnQtPndlYmtpdE1hdGNoZXNTZWxlY3RvcigiYVtocmVmXSwqOmxpbmssKjp2aXNp dGVkLCpbcm9sZT1idXR0b25dLGJ1dHRvbixpbnB1dCxzZWxlY3QsbGFiZWxbZm9yXSxhcmVhW2hy ZWZdLHRleHRhcmVhLGVtYmVkLG9iamVjdCIsIGVjKQogICAgICAgICAgICAgfHwgZWxlbWVudC0+ aXNNZWRpYUNvbnRyb2xFbGVtZW50KCkKLSAgICAgICAgICAgIHx8IChlbGVtZW50LT5pc0NvbnRl bnRFZGl0YWJsZSgpICYmICFlbGVtZW50LT5pc0luU2hhZG93VHJlZSgpKQorICAgICAgICAgICAg fHwgKGVsZW1lbnQtPmlzQ29udGVudEVkaXRhYmxlKCkgJiYgKCFlbGVtZW50LT5pc0luU2hhZG93 VHJlZSgpIHx8ICFlbGVtZW50LT5zaGFkb3dIb3N0KCktPmhhc1RhZ05hbWUoSFRNTE5hbWVzOjpp bnB1dFRhZykpKQogICAgICAgICAgICAgfHwgZWxlbWVudC0+c2hhZG93UHNldWRvSWQoKSA9PSAi LXdlYmtpdC1zZWFyY2gtY2FuY2VsLWJ1dHRvbiI7CiAgICAgfQogICAgIGNhc2UgTWFkZUNsaWNr YWJsZUJ5VGhlV2VicGFnZToK 174244 2012-11-14 13:38:13 -0800 2012-11-15 19:30:10 -0800 Patch bug-102088-20121114173559.patch text/plain 1836 rwlbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0NjUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCA4MDgyMTk4NDIyMmNkY2JmNWZjNjcyOWZiZjA5YTNjN2IyN2YwZDQ0Li4wYjY4MWJkODJj MWFlODJhNTMxN2U5YmM1NGZjMTBjMGVjYjZlMTgyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsNSArMSwxOCBAQAogMjAxMi0xMS0xNCAgUm9iIEJ1aXMgIDxyYnVpc0ByaW0u Y29tPgogCisgICAgICAgIFtCbGFja0JlcnJ5XSBGQ0MgZG9lc24ndCB3b3JrIGluIHRleHRhcmVh CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDIwODgK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUg dGhlIGNhbmNlbCBidXR0b24gc3BlY2lhbGl6YXRpb25zLCBpdCB3YXMgbmVlZGVkIGF0IHNvbWUg cG9pbnQgYnV0IGhpdHRpbmcgaXQKKyAgICAgICAgd29ya3MganVzdCBhcyB3ZWxsIHdpdGhvdXQg aXQuIFRoaXMgdW5icmVha3MgRkNDIGluIHRleHRhcmVhJ3MuCisKKyAgICAgICAgKiBXZWJLaXRT dXBwb3J0L0ZhdEZpbmdlcnMuY3BwOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpGYXRG aW5nZXJzOjppc0VsZW1lbnRDbGlja2FibGUpOgorCisyMDEyLTExLTE0ICBSb2IgQnVpcyAgPHJi dWlzQHJpbS5jb20+CisKICAgICAgICAgW0JsYWNrQmVycnldIEltcHJvdmUgZGVidWcgZnVuY3Rp b25hbGl0eSBpbiBGYXRGaW5nZXJzCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMDIyNjMKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2Jl cnJ5L1dlYktpdFN1cHBvcnQvRmF0RmluZ2Vycy5jcHAgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVy cnkvV2ViS2l0U3VwcG9ydC9GYXRGaW5nZXJzLmNwcAppbmRleCAwYmMxYTU2ZGYyMGRkOWI4Y2Vl OGY0YTk0M2UwY2FjNWVkZDhkOTFkLi42NDk0MTg2YmUxNDRiZTUwMTg5MWI2Mjc5ZDlhYTg1MTI2 ZTMxMzBiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9y dC9GYXRGaW5nZXJzLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3Vw cG9ydC9GYXRGaW5nZXJzLmNwcApAQCAtOTIsOCArOTIsNyBAQCBib29sIEZhdEZpbmdlcnM6Omlz RWxlbWVudENsaWNrYWJsZShFbGVtZW50KiBlbGVtZW50KSBjb25zdAogICAgICAgICBFeGNlcHRp b25Db2RlIGVjID0gMDsKICAgICAgICAgcmV0dXJuIGVsZW1lbnQtPndlYmtpdE1hdGNoZXNTZWxl Y3RvcigiYVtocmVmXSwqOmxpbmssKjp2aXNpdGVkLCpbcm9sZT1idXR0b25dLGJ1dHRvbixpbnB1 dCxzZWxlY3QsbGFiZWxbZm9yXSxhcmVhW2hyZWZdLHRleHRhcmVhLGVtYmVkLG9iamVjdCIsIGVj KQogICAgICAgICAgICAgfHwgZWxlbWVudC0+aXNNZWRpYUNvbnRyb2xFbGVtZW50KCkKLSAgICAg ICAgICAgIHx8IChlbGVtZW50LT5pc0NvbnRlbnRFZGl0YWJsZSgpICYmICFlbGVtZW50LT5pc0lu U2hhZG93VHJlZSgpKQotICAgICAgICAgICAgfHwgZWxlbWVudC0+c2hhZG93UHNldWRvSWQoKSA9 PSAiLXdlYmtpdC1zZWFyY2gtY2FuY2VsLWJ1dHRvbiI7CisgICAgICAgICAgICB8fCBlbGVtZW50 LT5pc0NvbnRlbnRFZGl0YWJsZSgpOwogCiAgICAgfQogICAgIGNhc2UgTWFkZUNsaWNrYWJsZUJ5 VGhlV2VicGFnZToK