102083 2012-11-13 07:36:32 -0800 [Qt][ARM] Fix 'nullptr' is a keyword in C++11 [-Wc++0x-compat] warning 2012-11-14 08:31:39 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jbadics webkit-unassigned abecsi galpeter ossy rgabor vestbo webkit.review.bot oldest_to_newest 765584 0 jbadics 2012-11-13 07:36:32 -0800 When building on ARMv7 Linux Qt5 Release Buildbot, the following warnings appear again and again on the standard IO: In file included from /mnt/raptor2/slaves/qt5-linux-armv7-release/build/Source/WTF/wtf/PassRefPtr.h:26:0, from /mnt/raptor2/slaves/qt5-linux-armv7-release/build/Source/WTF/wtf/RefPtr.h:28, . . . from /mnt/raptor2/slaves/qt5-linux-armv7-release/build/Source/WebCore/Modules/geolocation/GeolocationController.h:31, from /mnt/raptor2/slaves/qt5-linux-armv7-release/build/Source/WebCore/Modules/geolocation/GeolocationController.cpp:27: /mnt/raptor2/slaves/qt5-linux-armv7-release/build/Source/WTF/wtf/NullPtr.h:52:1: warning: identifier 'nullptr' is a keyword in C++11 [-Wc++0x-compat] For example, see: http://build.webkit.sed.hu/builders/ARMv7%20Linux%20Qt5%20Release%20%28Build%29/builds/14457/steps/compile-webkit/logs/stdio 766832 1 jbadics 2012-11-14 06:37:22 -0800 Tools/qmake/mkspecs/features/unix/default_post.prf checks if -std=(c|gnu)\\+\\+(0x|11) is enabled and if it's true, enables -Wno-c++0x-compat. But this check is applied only if the compiler name matches the linux-g++* regex. However, the bot uses linux-arm-gnueabi-g++ that does not math. Using linux-*g++* will match with linux-arm-gnueabi-g++. 766869 2 174152 jbadics 2012-11-14 07:17:33 -0800 Created attachment 174152 proposed patch Modified regex that matches compiler name. Now linux-arm-gnueabi-g++ matches too, so flag checking is applied on ARM too. 766933 3 174152 webkit.review.bot 2012-11-14 08:31:36 -0800 Comment on attachment 174152 proposed patch Clearing flags on attachment: 174152 Committed r134614: <http://trac.webkit.org/changeset/134614> 766934 4 webkit.review.bot 2012-11-14 08:31:39 -0800 All reviewed patches have been landed. Closing bug. 174152 2012-11-14 07:17:33 -0800 2012-11-14 08:31:35 -0800 proposed patch armbot_warnings_4_changelog.patch text/plain 1363 jbadics ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBhZDRl ODIyLi4xYzRiZmQ2IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMTEtMTQgIErDoW5vcyBCYWRpY3MgIDxqYmFk aWNzQGluZi51LXN6ZWdlZC5odT4KKworICAgICAgICBbUXRdW0FSTV0gRml4ICdudWxscHRyJyBp cyBhIGtleXdvcmQgaW4gQysrMTEgWy1XYysrMHgtY29tcGF0XSB3YXJuaW5nCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDIwODMKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNb2RpZmllZCBjb21waWxlciBu YW1lIHJlZ2V4IGluIGNvbmRpdGlvbiB0aGF0IHRlc3RzIGlmIC1zdGQ9YysrMHgsIGMrKzExLAor ICAgICAgICBnbnUrKzB4IG9yIGdudSsrMTEgYXJlIGVuYWJsZWQgaW4gb3JkZXIgdG8gbWF0Y2gg bGludXgtYXJtLWdudWVhYmktZysrIHRvbywKKyAgICAgICAgdGh1cyBlbmFibGluZyAtV25vLWMr KzB4LWNvbXBhdCBhbHNvIG9uIEFSTSBjb21waWxlci4KKworICAgICAgICAqIHFtYWtlL21rc3Bl Y3MvZmVhdHVyZXMvdW5peC9kZWZhdWx0X3Bvc3QucHJmOgorCiAyMDEyLTExLTE0ICBUaGlhZ28g TWFyY29zIFAuIFNhbnRvcyAgPHRoaWFnby5zYW50b3NAaW50ZWwuY29tPgogCiAgICAgICAgIFJF R1JFU1NJT04ocjEzMzc1Nyk6IENhdXNpbmcgd2Via2l0cHkgdW5pdCB0ZXN0cyB0byBmYWlsCmRp ZmYgLS1naXQgYS9Ub29scy9xbWFrZS9ta3NwZWNzL2ZlYXR1cmVzL3VuaXgvZGVmYXVsdF9wb3N0 LnByZiBiL1Rvb2xzL3FtYWtlL21rc3BlY3MvZmVhdHVyZXMvdW5peC9kZWZhdWx0X3Bvc3QucHJm CmluZGV4IDVhNzNmMTcuLjhhZWUzMGYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL3FtYWtlL21rc3BlY3Mv ZmVhdHVyZXMvdW5peC9kZWZhdWx0X3Bvc3QucHJmCisrKyBiL1Rvb2xzL3FtYWtlL21rc3BlY3Mv ZmVhdHVyZXMvdW5peC9kZWZhdWx0X3Bvc3QucHJmCkBAIC0xMiw3ICsxMiw3IEBAIGxpbnV4LWcr Kyo6aXNFcXVhbChRVF9BUkNILGkzODYpIHsKICAgICBRTUFLRV9DWFhGTEFHUyArPSAtbWFyY2g9 cGVudGl1bTQgLW1zc2UyIC1tZnBtYXRoPXNzZQogfQogCi1saW51eC1nKysqIHsKK2xpbnV4LSpn KysqIHsKICAgICAhcHJvZHVjdGlvbl9idWlsZCB7CiAgICAgICAgICMgVHJlYXQgd2FybmluZ3Mg YXMgZXJyb3JzIG9uIHg4Ni9MaW51eC9HQ0MKICAgICAgICAgaXNFcXVhbChRVF9BUkNILHg4Nl82 NCl8aXNFcXVhbChRVF9BUkNILGkzODYpOiBRTUFLRV9DWFhGTEFHUyArPSAtV2Vycm9yCg==