102077 2012-11-13 06:02:35 -0800 [WinCairo] Favicons are flipped in vertical direction in WinCairo builds. 2013-10-30 11:20:50 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Unspecified RESOLVED FIXED P2 Normal --- 0 peavo webkit-unassigned bfulgham commit-queue peavo oldest_to_newest 765520 0 peavo 2012-11-13 06:02:35 -0800 The method BitmapImage::getHBITMAPOfSize() in WebCore/platform/graphics/win/ImageCairoWin.cpp seems to flip the bitmap in the vertical direction. 765536 1 173882 peavo 2012-11-13 06:29:37 -0800 Created attachment 173882 Patch 768151 2 173882 bfulgham 2012-11-15 09:07:39 -0800 Comment on attachment 173882 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173882&action=review The code changes seem reasonable, but do you have a test case that can be used to show that it currently doesn't work, and that this change fixes it? > Source/WebCore/platform/graphics/win/ImageCairoWin.cpp:70 > + unsigned char *bmpdata = (unsigned char*)bmpInfo.bmBits + bmpInfo.bmWidthBytes*(bmpInfo.bmHeight-1); This should be declared "unsigned char*" 768363 3 peavo 2012-11-15 11:56:19 -0800 When I call IWebIconDatabase::iconForURL() to get the HBITMAP of the favicon, and draw it with the StretchBlt() win32 api function, I can see that it's been flipped in the Y direction. With this code change, I can see that it is drawn correctly. Should I attach screenshots, or should I make a new test for this? If so, is there a framework, or guidelines I should follow? 769160 4 174655 peavo 2012-11-16 05:38:19 -0800 Created attachment 174655 Patch 944992 5 174655 bfulgham 2013-10-30 10:42:35 -0700 Comment on attachment 174655 Patch r=me 945056 6 174655 commit-queue 2013-10-30 11:20:48 -0700 Comment on attachment 174655 Patch Clearing flags on attachment: 174655 Committed r158292: <http://trac.webkit.org/changeset/158292> 945058 7 commit-queue 2013-10-30 11:20:50 -0700 All reviewed patches have been landed. Closing bug. 173882 2012-11-13 06:29:37 -0800 2012-11-16 05:38:11 -0800 Patch bug-102077-20121113152738.patch text/plain 1766 peavo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzNDQwOCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEyLTExLTEzICBwZWF2b0Bv dXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIEZhdmljb25zIGFyZSBm bGlwcGVkIGluIHZlcnRpY2FsIGRpcmVjdGlvbiBpbiBXaW5DYWlybyBidWlsZHMuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDIwNzcKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL3dpbi9JbWFnZUNhaXJvV2luLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkJpdG1hcEltYWdl OjpnZXRIQklUTUFQT2ZTaXplKToKKwogMjAxMi0xMS0xMyAgQW5kcmVhcyBLbGluZyAgPGtsaW5n QHdlYmtpdC5vcmc+CiAKICAgICAgICAgRXhwbG9pdCBFbGVtZW50QXR0cmlidXRlRGF0YSBzaGFy aW5nIGluIE5vZGUuY2xvbmVOb2RlLgpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3Mvd2luL0ltYWdlQ2Fpcm9XaW4uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL3dpbi9JbWFnZUNhaXJvV2luLmNwcAkocmV2aXNpb24gMTM0NDA4 KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd2luL0ltYWdlQ2Fpcm9XaW4u Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC02NywxMiArNjcsOSBAQCBib29sIEJpdG1hcEltYWdlOjpn ZXRIQklUTUFQT2ZTaXplKEhCSVRNCiAgICAgICAgIG1lbXNldChibXBJbmZvLmJtQml0cywgMjU1 LCBidWZmZXJTaXplKTsKICAgICB9CiAKLSAgICBjYWlyb19zdXJmYWNlX3QqIGltYWdlID0gY2Fp cm9faW1hZ2Vfc3VyZmFjZV9jcmVhdGVfZm9yX2RhdGEoKHVuc2lnbmVkIGNoYXIqKWJtcEluZm8u Ym1CaXRzLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBD QUlST19GT1JNQVRfQVJHQjMyLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBibXBJbmZvLmJtV2lkdGgsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIGJtcEluZm8uYm1IZWlnaHQsCi0gICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGJtcEluZm8uYm1XaWR0aEJ5dGVzKTsKKyAgICB1 bnNpZ25lZCBjaGFyICpibXBkYXRhID0gKHVuc2lnbmVkIGNoYXIqKWJtcEluZm8uYm1CaXRzICsg Ym1wSW5mby5ibVdpZHRoQnl0ZXMqKGJtcEluZm8uYm1IZWlnaHQtMSk7CiAKKyAgICBjYWlyb19z dXJmYWNlX3QqIGltYWdlID0gY2Fpcm9faW1hZ2Vfc3VyZmFjZV9jcmVhdGVfZm9yX2RhdGEoYm1w ZGF0YSwgQ0FJUk9fRk9STUFUX0FSR0IzMiwgYm1wSW5mby5ibVdpZHRoLCBibXBJbmZvLmJtSGVp Z2h0LCAtYm1wSW5mby5ibVdpZHRoQnl0ZXMpOwogCiAgICAgY2Fpcm9fdCogdGFyZ2V0UmVmID0g Y2Fpcm9fY3JlYXRlKGltYWdlKTsKICAgICBjYWlyb19zdXJmYWNlX2Rlc3Ryb3koaW1hZ2UpOwo= 174655 2012-11-16 05:38:19 -0800 2013-10-30 11:20:48 -0700 Patch bug-102077-20121116143613.patch text/plain 1773 peavo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzNDkzNikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEyLTExLTE2ICBwZWF2b0Bv dXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIEZhdmljb25zIGFyZSBm bGlwcGVkIGluIHZlcnRpY2FsIGRpcmVjdGlvbiBpbiBXaW5DYWlybyBidWlsZHMuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDIwNzcKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL3dpbi9JbWFnZUNhaXJvV2luLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkJpdG1hcEltYWdl OjpnZXRIQklUTUFQT2ZTaXplKToKKwogMjAxMi0xMS0xNiAgTWFyayBQaWxncmltICA8cGlsZ3Jp bUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgRXhwYW5kIFBsYXRmb3JtQ29va2llSmFyIGludGVy ZmFjZSB0byBhbGxvdyBmb3Igb3RoZXIgcG9ydHMKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL3dpbi9JbWFnZUNhaXJvV2luLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy93aW4vSW1hZ2VDYWlyb1dpbi5jcHAJKHJldmlzaW9u IDEzNDkyNSkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dpbi9JbWFnZUNh aXJvV2luLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjcsMTIgKzY3LDkgQEAgYm9vbCBCaXRtYXBJ bWFnZTo6Z2V0SEJJVE1BUE9mU2l6ZShIQklUTQogICAgICAgICBtZW1zZXQoYm1wSW5mby5ibUJp dHMsIDI1NSwgYnVmZmVyU2l6ZSk7CiAgICAgfQogCi0gICAgY2Fpcm9fc3VyZmFjZV90KiBpbWFn ZSA9IGNhaXJvX2ltYWdlX3N1cmZhY2VfY3JlYXRlX2Zvcl9kYXRhKCh1bnNpZ25lZCBjaGFyKili bXBJbmZvLmJtQml0cywKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgQ0FJUk9fRk9STUFUX0FSR0IzMiwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgYm1wSW5mby5ibVdpZHRoLAotICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBibXBJbmZvLmJtSGVpZ2h0LAotICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBibXBJbmZvLmJtV2lkdGhCeXRlcyk7 CisgICAgdW5zaWduZWQgY2hhciogYm1wZGF0YSA9ICh1bnNpZ25lZCBjaGFyKilibXBJbmZvLmJt Qml0cyArIGJtcEluZm8uYm1XaWR0aEJ5dGVzKihibXBJbmZvLmJtSGVpZ2h0LTEpOwogCisgICAg Y2Fpcm9fc3VyZmFjZV90KiBpbWFnZSA9IGNhaXJvX2ltYWdlX3N1cmZhY2VfY3JlYXRlX2Zvcl9k YXRhKGJtcGRhdGEsIENBSVJPX0ZPUk1BVF9BUkdCMzIsIGJtcEluZm8uYm1XaWR0aCwgYm1wSW5m by5ibUhlaWdodCwgLWJtcEluZm8uYm1XaWR0aEJ5dGVzKTsKIAogICAgIGNhaXJvX3QqIHRhcmdl dFJlZiA9IGNhaXJvX2NyZWF0ZShpbWFnZSk7CiAgICAgY2Fpcm9fc3VyZmFjZV9kZXN0cm95KGlt YWdlKTsK