102076 2012-11-13 06:01:16 -0800 [CMake] Incorrect dependency calculation when generating forwarding headers 2012-11-17 07:50:35 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rakuco rakuco dglazkov gyuyoung.kim kenneth tmpsantos webkit.review.bot oldest_to_newest 765519 0 rakuco 2012-11-13 06:01:16 -0800 See <http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/11/steps/compile-webkit/logs/stdio>, for example. Targets such as `test_wtf' in Tools/TestWebKitAPI correctly depend on the targets `forwarding-headersEflForTestWebKitAPI' and `forwarding-headersSoupForTestWebKitAPI' which call generate-forwarding-headers.pl. However, these dependencies are not enough, since some headers, such as WKBaseSoup.h are not generated. This comes from the fact that generate-forwarding-headers.pl is called with Tools/TestWebKitAPI as the base directory, and some headers are only found when run with WebKit2 as the base directory (which happens on the `forwarding-headerEfl' and `forwarding-headerSoup' targets in Source/WebKit2/PlatformEfl.cmake. 765594 1 173892 rakuco 2012-11-13 07:54:59 -0800 Created attachment 173892 Patch 765629 2 173892 webkit.review.bot 2012-11-13 08:26:12 -0800 Comment on attachment 173892 Patch Rejecting attachment 173892 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/14818622 765647 3 173892 rakuco 2012-11-13 08:43:18 -0800 Comment on attachment 173892 Patch Clearing flags on attachment: 173892 Committed r134424: <http://trac.webkit.org/changeset/134424> 765648 4 rakuco 2012-11-13 08:43:28 -0800 All reviewed patches have been landed. Closing bug. 765829 5 dglazkov 2012-11-13 11:11:14 -0800 Reverted r134424 for reason: Made fast/dom/Window/open-window-min-size.html crash. Committed r134449: <http://trac.webkit.org/changeset/134449> 765840 6 dglazkov 2012-11-13 11:21:29 -0800 Reverted r134449 for reason: Re-rolling in the patch, it was innocent. Committed r134450: <http://trac.webkit.org/changeset/134450> 173892 2012-11-13 07:54:59 -0800 2012-11-13 08:43:18 -0800 Patch bug-102076-20121113175152.patch text/plain 2412 rakuco U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0NDA2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMTk1MTMxMTcyMzg3OWMzMDBiYmIwYTFhODUxZWVhNTIz OGVkMmI3OC4uNWEzM2MxOWQ3MWE1MjBjMGM4ODE0ZGYxMWQzYTFkZGE4OWI0OGM0MCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIz IEBACiAyMDEyLTExLTEzICBSYXBoYWVsIEt1Ym8gZGEgQ29zdGEgIDxyYXBoYWVsLmt1Ym8uZGEu Y29zdGFAaW50ZWwuY29tPgogCisgICAgICAgIFtDTWFrZV0gSW5jb3JyZWN0IGRlcGVuZGVuY3kg Y2FsY3VsYXRpb24gd2hlbiBnZW5lcmF0aW5nIGZvcndhcmRpbmcgaGVhZGVycworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAyMDc2CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRXhwbGljaXRseSBjYWxsIGdl bmVyYXRlLWZvcndhcmRpbmctaGVhZGVycy5wbCBvbiAke1dFQktJVDJfRElSfSBhcworICAgICAg ICB3ZWxsLCBzaW5jZSBzb21lIGRlcGVuZGVuY2llcyBwdWxsZWQgaW4gdmlhIHRoZSBXZWJLaXQy L1dlYktpdDJfQy5oCisgICAgICAgIGluY2x1ZGUgaW4gY29uZmlnLmggYXJlIG9ubHkgZ2VuZXJh dGVkIGZyb20gdGhlcmUuCisKKyAgICAgICAgVGhpcyBpcyBhIGJpdCByZWR1bmRhbnQgc2luY2Ug dGhpcyBpcyBhbHNvIGRvbmUgaW4gV2ViS2l0MidzCisgICAgICAgIFBsYXRmb3JtRWZsLmNtYWtl LCBob3dldmVyIHRoZSBXVEYgYW5kIFdlYkNvcmUgQVBJIHRlc3RzIGRvIG5vdCBkZXBlbmQKKyAg ICAgICAgb24gV2ViS2l0MiBzbyB0aGUgc2NyaXB0IG1heSBub3QgaGF2ZSBiZWVuIGNhbGxlZCB3 aGVuIHRoZXNlIHRlc3RzIGFyZQorICAgICAgICBiZWluZyBidWlsdC4KKworICAgICAgICAqIFRl c3RXZWJLaXRBUEkvUGxhdGZvcm1FZmwuY21ha2U6CisKKzIwMTItMTEtMTMgIFJhcGhhZWwgS3Vi byBkYSBDb3N0YSAgPHJhcGhhZWwua3Viby5kYS5jb3N0YUBpbnRlbC5jb20+CisKICAgICAgICAg W0VGTF1bRFJUXSBSZW1vdmUgZXh0cmEgbGF5b3V0RnJhbWUoKSBjYWxsIHdoZW4gcHJlcGFyaW5n IHRvIHNlbmQgYW4gZXZlbnQgdmlhIEV2ZW50U2VuZGVyLgogICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAyMDc0CiAKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rl c3RXZWJLaXRBUEkvUGxhdGZvcm1FZmwuY21ha2UgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1BsYXRm b3JtRWZsLmNtYWtlCmluZGV4IDdkZWZiMTEzODBkMzUwMzRjOWNmNDYyYjc3NTQ1ZjJkZjNmNDMy YjAuLmQ2ZDkxMzAwNWU3NjA4MTQ5OTMxZTljM2JlZDliYjM0MjA3YjhkYzQgMTAwNjQ0Ci0tLSBh L1Rvb2xzL1Rlc3RXZWJLaXRBUEkvUGxhdGZvcm1FZmwuY21ha2UKKysrIGIvVG9vbHMvVGVzdFdl YktpdEFQSS9QbGF0Zm9ybUVmbC5jbWFrZQpAQCAtMSw5ICsxLDExIEBACiBBRERfQ1VTVE9NX1RB UkdFVChmb3J3YXJkaW5nLWhlYWRlcnNFZmxGb3JUZXN0V2ViS2l0QVBJCisgICAgQ09NTUFORCAk e1BFUkxfRVhFQ1VUQUJMRX0gJHtXRUJLSVQyX0RJUn0vU2NyaXB0cy9nZW5lcmF0ZS1mb3J3YXJk aW5nLWhlYWRlcnMucGwgJHtXRUJLSVQyX0RJUn0gJHtERVJJVkVEX1NPVVJDRVNfV0VCS0lUMl9E SVJ9L2luY2x1ZGUgZWZsCiAgICAgQ09NTUFORCAke1BFUkxfRVhFQ1VUQUJMRX0gJHtXRUJLSVQy X0RJUn0vU2NyaXB0cy9nZW5lcmF0ZS1mb3J3YXJkaW5nLWhlYWRlcnMucGwgJHtURVNUV0VCS0lU QVBJX0RJUn0gJHtERVJJVkVEX1NPVVJDRVNfV0VCS0lUMl9ESVJ9L2luY2x1ZGUgZWZsCiApCiBT RVQoRm9yd2FyZGluZ0hlYWRlcnNGb3JUZXN0V2ViS2l0QVBJX05BTUUgZm9yd2FyZGluZy1oZWFk ZXJzRWZsRm9yVGVzdFdlYktpdEFQSSkKIAogQUREX0NVU1RPTV9UQVJHRVQoZm9yd2FyZGluZy1o ZWFkZXJzU291cEZvclRlc3RXZWJLaXRBUEkKKyAgICBDT01NQU5EICR7UEVSTF9FWEVDVVRBQkxF fSAke1dFQktJVDJfRElSfS9TY3JpcHRzL2dlbmVyYXRlLWZvcndhcmRpbmctaGVhZGVycy5wbCAk e1dFQktJVDJfRElSfSAke0RFUklWRURfU09VUkNFU19XRUJLSVQyX0RJUn0vaW5jbHVkZSBzb3Vw CiAgICAgQ09NTUFORCAke1BFUkxfRVhFQ1VUQUJMRX0gJHtXRUJLSVQyX0RJUn0vU2NyaXB0cy9n ZW5lcmF0ZS1mb3J3YXJkaW5nLWhlYWRlcnMucGwgJHtURVNUV0VCS0lUQVBJX0RJUn0gJHtERVJJ VkVEX1NPVVJDRVNfV0VCS0lUMl9ESVJ9L2luY2x1ZGUgc291cAogKQogU0VUKEZvcndhcmRpbmdO ZXR3b3JrSGVhZGVyc0ZvclRlc3RXZWJLaXRBUElfTkFNRSBmb3J3YXJkaW5nLWhlYWRlcnNTb3Vw Rm9yVGVzdFdlYktpdEFQSSkK