102058 2012-11-13 00:49:05 -0800 Memory instrumentation: remove reportMemoryUsage method from ImageObserver 2012-11-13 23:27:27 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 102185 1 yurys yurys abarth apavlov haraken japhet keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 765362 0 yurys 2012-11-13 00:49:05 -0800 The class is an interface whose implementation we don't control. When counting memory usage of the particular client we should instrument concrete implementation. 765364 1 173844 yurys 2012-11-13 00:51:35 -0800 Created attachment 173844 Patch 765443 2 173844 webkit.review.bot 2012-11-13 03:22:07 -0800 Comment on attachment 173844 Patch Clearing flags on attachment: 173844 Committed r134393: <http://trac.webkit.org/changeset/134393> 765444 3 webkit.review.bot 2012-11-13 03:22:11 -0800 All reviewed patches have been landed. Closing bug. 173844 2012-11-13 00:51:35 -0800 2012-11-13 03:22:07 -0800 Patch bug-102058-20121113124936.patch text/plain 3247 yurys U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0MTkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGRjMjEyODQ4MWNhZGU2 NGZiNTIzNTc0ZGY1ZmZkZjI0YzRkNWY2OC4uZjA5ODNiOWMwNGEzMzVlOGNlYWM4YTNlYmVhMTlk MWEzZDc0NDc2MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTExLTEzICBZdXJ5 IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIE1lbW9yeSBpbnN0 cnVtZW50YXRpb246IHJlbW92ZSByZXBvcnRNZW1vcnlVc2FnZSBtZXRob2QgZnJvbSBJbWFnZU9i c2VydmVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MDIwNTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IGJpbmRpbmdzL3Y4L1Y4UGVySXNvbGF0ZURhdGEuY3BwOgorICAgICAgICAoV2ViQ29yZTo6VjhQ ZXJJc29sYXRlRGF0YTo6cmVwb3J0TWVtb3J5VXNhZ2UpOiBkcml2ZS1ieSBmaXgsIG5vIG5lZWQg dG8gcmVwb3J0CisgICAgICAgIGVhY2ggZWxlbWVudCBvZiB0aGUgdmVjdG9yIGFzIGdlbmVyaWMg dmVjdG9yIGluc3RydW1lbnRhdGlvbiB3aWxsIHRha2UgY2FyZSBvZiBpdC4KKyAgICAgICAgKiBw bGF0Zm9ybS9ncmFwaGljcy9JbWFnZS5jcHA6IHRoZSBjbGllbnQgaXMgcmVwb3J0ZWQgYXMgd2Vh ayBwb2ludGVyIHRvIG1ha2Ugc3VyZQorICAgICAgICB3ZSBkb24ndCBjb3VudCBpdHMgYnkgdGhl IHBvaW50ZXIgdG8gdGhlIGJhc2UgY2xhc3Mgd2hpY2ggbWF5IGRpZmZlciBmcm9tIHRoZSBhY3R1 YWwKKyAgICAgICAgb2JqZWN0IGFkZHJlc3MuCisgICAgICAgIChXZWJDb3JlOjpJbWFnZTo6cmVw b3J0TWVtb3J5VXNhZ2UpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0ltYWdlT2JzZXJ2 ZXIuaDogcmVtb3ZlZCByZXBvcnRNZW1vcnlVc2FnZSBtZXRob2QgZnJvbSB0aGUgaW50ZXJmYWNl LgorICAgICAgICAoSW1hZ2VPYnNlcnZlcik6CisKIDIwMTItMTEtMDkgIFJ5b3N1a2UgTml3YSAg PHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgTXVsdGlwbGUgTGF5b3V0IFRlc3RzIChlLmcu IGZhc3QvcmVwYWludC9qYXBhbmVzZS1ybC1zZWxlY3Rpb24tY2xlYXIuaHRtbCkgaXMgZmFpbGlu ZyBhZnRlciByMTMzODQwLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvdjgv VjhQZXJJc29sYXRlRGF0YS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFBlcklz b2xhdGVEYXRhLmNwcAppbmRleCBmNjMzMGYxOTgxMjc3ZjhlZmI5NWExMWY3NTlmZjE0ZDU5MjYw OTg5Li5iOWIxOWFjYTNiYjg0NmM1OGVjMGE2N2VkNWI0MGEzMmNkZmVmNDY3IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFBlcklzb2xhdGVEYXRhLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFBlcklzb2xhdGVEYXRhLmNwcApAQCAtMTA4LDkg KzEwOCw2IEBAIHZvaWQgVjhQZXJJc29sYXRlRGF0YTo6cmVwb3J0TWVtb3J5VXNhZ2UoTWVtb3J5 T2JqZWN0SW5mbyogbWVtb3J5T2JqZWN0SW5mbykgY29uCiAgICAgaW5mby5hZGRNZW1iZXIobV9z dHJpbmdDYWNoZSk7CiAgICAgaW5mby5hZGRNZW1iZXIobV9kb21EYXRhTGlzdCk7CiAKLSAgICBm b3IgKHNpemVfdCBpID0gMDsgaSA8IG1fZG9tRGF0YUxpc3Quc2l6ZSgpOyBpKyspCi0gICAgICAg IGluZm8uYWRkTWVtYmVyKG1fZG9tRGF0YUxpc3RbaV0pOwotCiAgICAgaW5mby5hZGRQcml2YXRl QnVmZmVyKFNjcmlwdFByb2ZpbGVyOjpwcm9maWxlclNuYXBzaG90c1NpemUoKSwgV2ViQ29yZU1l bW9yeVR5cGVzOjpJbnNwZWN0b3JQcm9maWxlckFnZW50KTsKIH0KIApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvSW1hZ2UuY3BwIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvSW1hZ2UuY3BwCmluZGV4IDc4ZTVlNDg2Mzc0NWQ3ODRjY2MyZjFi M2E3NzIxZWIyYTgwYzFlZTEuLjFjYWM5OTcyYjlhZjM0NTFiNDZlOWVjMjg1NzlkYjZmY2FhNDFl YzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ltYWdlLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9JbWFnZS5jcHAKQEAgLTIw Miw3ICsyMDIsNyBAQCB2b2lkIEltYWdlOjpyZXBvcnRNZW1vcnlVc2FnZShNZW1vcnlPYmplY3RJ bmZvKiBtZW1vcnlPYmplY3RJbmZvKSBjb25zdAogewogICAgIE1lbW9yeUNsYXNzSW5mbyBpbmZv KG1lbW9yeU9iamVjdEluZm8sIHRoaXMsIFBsYXRmb3JtTWVtb3J5VHlwZXM6OkltYWdlKTsKICAg ICBpbmZvLmFkZE1lbWJlcihtX2RhdGEpOwotICAgIGluZm8uYWRkTWVtYmVyKG1faW1hZ2VPYnNl cnZlcik7CisgICAgaW5mby5hZGRXZWFrUG9pbnRlcihtX2ltYWdlT2JzZXJ2ZXIpOwogfQogCiB9 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9JbWFnZU9ic2Vy dmVyLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9JbWFnZU9ic2VydmVyLmgK aW5kZXggODA0Y2RlYjk3YWVlYmQyZWYwMTZkNzg0NjRkNGY0NGI4ZmNhZGQ2Ni4uOGI2OTNkOTg0 OGUyYzBiMzA1MzU0ZTBlZDE2YTM1NDhhYjVlMTU4NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvSW1hZ2VPYnNlcnZlci5oCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL0ltYWdlT2JzZXJ2ZXIuaApAQCAtMjYsOCArMjYsNiBAQAogI2lm bmRlZiBJbWFnZU9ic2VydmVyX2gKICNkZWZpbmUgSW1hZ2VPYnNlcnZlcl9oCiAKLSNpbmNsdWRl IDx3dGYvRm9yd2FyZC5oPgotCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIGNsYXNzIEltYWdlOwpA QCAtNDYsOCArNDQsNiBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCB2b2lkIGFuaW1hdGlvbkFkdmFu Y2VkKGNvbnN0IEltYWdlKikgPSAwOwogCiAgICAgdmlydHVhbCB2b2lkIGNoYW5nZWRJblJlY3Qo Y29uc3QgSW1hZ2UqLCBjb25zdCBJbnRSZWN0JikgPSAwOwotCi0gICAgdmlydHVhbCB2b2lkIHJl cG9ydE1lbW9yeVVzYWdlKE1lbW9yeU9iamVjdEluZm8qKSBjb25zdCA9IDA7CiB9OwogCiB9Cg==