102056 2012-11-13 00:43:44 -0800 [BlackBerry] DRT - platform/blackberry/editing/text-iterator/findString-markers.html failed 2012-11-13 04:50:18 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 0 xiaobwang webkit-unassigned mifenton rwlbuis tonikitoo webkit.review.bot oldest_to_newest 765358 0 xiaobwang 2012-11-13 00:43:44 -0800 testRunner.findString() was changed to call Page::findString() instead of WebPage::findNextString(). Page::findString() doesn't update TextMatch markers. Work-around by calling both Page::findString() and WebPage::findNextString(). 765379 1 173847 xiaobwang 2012-11-13 01:11:27 -0800 Created attachment 173847 patch 765458 2 173847 rwlbuis 2012-11-13 04:26:35 -0800 Comment on attachment 173847 patch Looks good. 765473 3 173847 webkit.review.bot 2012-11-13 04:50:15 -0800 Comment on attachment 173847 patch Clearing flags on attachment: 173847 Committed r134398: <http://trac.webkit.org/changeset/134398> 765474 4 webkit.review.bot 2012-11-13 04:50:18 -0800 All reviewed patches have been landed. Closing bug. 173847 2012-11-13 01:11:27 -0800 2012-11-13 04:50:15 -0800 patch 0001-BlackBerry-DRT-platform-blackberry-editing-text-iter.patch text/plain 4792 xiaobwang RnJvbSBmOGQzNjk2YjJhYWNjNGM3MjdjMGYwYzI3NTM2NWY2NjE5ZDEwMzQ4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBYaWFvYm8gV2FuZyA8eGJ3YW5nQHRvcmNobW9iaWxlLmNvbS5j bj4KRGF0ZTogVHVlLCAxMyBOb3YgMjAxMiAxNjo1Mzo1MiArMDgwMApTdWJqZWN0OiBbUEFUQ0hd IFtCbGFja0JlcnJ5XSBEUlQgLQogcGxhdGZvcm0vYmxhY2tiZXJyeS9lZGl0aW5nL3RleHQtaXRl cmF0b3IvZmluZFN0cmluZy1tYXJrZXJzLmh0bWwKIGZhaWxlZCBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAyMDU2CgpSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K ClJJTSBQUiAyMzU4MzYKClRlc3RSdW5uZXI6OmZpbmRTdHJpbmcoKSB3YXMgY2hhbmdlZCB0byBj YWxsIFBhZ2U6OmZpbmRTdHJpbmcoKSBpbnN0ZWFkCm9mIFdlYlBhZ2U6OmZpbmROZXh0U3RyaW5n KCkuIFBhZ2U6OmZpbmRTdHJpbmcoKSBkb2Vzbid0IHVwZGF0ZQpUZXh0TWF0Y2ggbWFya2Vycy4K V29yay1hcm91bmQgYnkgY2FsbGluZyBib3RoIFBhZ2U6OmZpbmRTdHJpbmcoKSBhbmQgV2ViUGFn ZTo6ZmluZE5leHRTdHJpbmcoKS4KCiogRHVtcFJlbmRlclRyZWUvYmxhY2tiZXJyeS9UZXN0UnVu bmVyQmxhY2tCZXJyeS5jcHA6CihUZXN0UnVubmVyOjpmaW5kU3RyaW5nKToKLS0tCiBUb29scy9D aGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTcgKysrKysr KysrKysrKysrKwogLi4uL2JsYWNrYmVycnkvVGVzdFJ1bm5lckJsYWNrQmVycnkuY3BwICAgICAg ICAgICAgfCAgIDIxICsrKysrKysrKysrKystLS0tLS0KIDIgZmlsZXMgY2hhbmdlZCwgMzEgaW5z ZXJ0aW9ucygrKSwgNyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYzQ1NGE1OS4uNDBkMzk2ZCAxMDA2NDQKLS0tIGEvVG9v bHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEy LTExLTEzICBYaWFvYm8gV2FuZyAgPHhid2FuZ0B0b3JjaG1vYmlsZS5jb20uY24+CisKKyAgICAg ICAgW0JsYWNrQmVycnldIERSVCAtIHBsYXRmb3JtL2JsYWNrYmVycnkvZWRpdGluZy90ZXh0LWl0 ZXJhdG9yL2ZpbmRTdHJpbmctbWFya2Vycy5odG1sIGZhaWxlZAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAyMDU2CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUklNIFBSIDIzNTgzNgorCisgICAgICAgIFRl c3RSdW5uZXI6OmZpbmRTdHJpbmcoKSB3YXMgY2hhbmdlZCB0byBjYWxsIFBhZ2U6OmZpbmRTdHJp bmcoKSBpbnN0ZWFkCisgICAgICAgIG9mIFdlYlBhZ2U6OmZpbmROZXh0U3RyaW5nKCkuIFBhZ2U6 OmZpbmRTdHJpbmcoKSBkb2Vzbid0IHVwZGF0ZQorICAgICAgICBUZXh0TWF0Y2ggbWFya2Vycy4K KyAgICAgICAgV29yay1hcm91bmQgYnkgY2FsbGluZyBib3RoIFBhZ2U6OmZpbmRTdHJpbmcoKSBh bmQgV2ViUGFnZTo6ZmluZE5leHRTdHJpbmcoKS4KKworICAgICAgICAqIER1bXBSZW5kZXJUcmVl L2JsYWNrYmVycnkvVGVzdFJ1bm5lckJsYWNrQmVycnkuY3BwOgorICAgICAgICAoVGVzdFJ1bm5l cjo6ZmluZFN0cmluZyk6CisKIDIwMTItMTEtMTIgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgcmVtb3ZlICd3ZWJraXQtcGF0Y2ggb3B0aW1pemUtZXhwZWN0 YXRpb25zJwpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvYmxhY2tiZXJyeS9UZXN0 UnVubmVyQmxhY2tCZXJyeS5jcHAgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9ibGFja2JlcnJ5L1Rl c3RSdW5uZXJCbGFja0JlcnJ5LmNwcAppbmRleCBjODBhOTZkLi5mMDZmNGE4IDEwMDY0NAotLS0g YS9Ub29scy9EdW1wUmVuZGVyVHJlZS9ibGFja2JlcnJ5L1Rlc3RSdW5uZXJCbGFja0JlcnJ5LmNw cAorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9ibGFja2JlcnJ5L1Rlc3RSdW5uZXJCbGFja0Jl cnJ5LmNwcApAQCAtNDAyLDcgKzQwMiw3IEBAIHVuc2lnbmVkIFRlc3RSdW5uZXI6Om51bWJlck9m QWN0aXZlQW5pbWF0aW9ucygpIGNvbnN0CiAgICAgcmV0dXJuIGFuaW1hdGlvbkNvbnRyb2xsZXIt Pm51bWJlck9mQWN0aXZlQW5pbWF0aW9ucyhtYWluRnJhbWUtPmRvY3VtZW50KCkpOwogfQogCi11 bnNpZ25lZCBpbnQgVGVzdFJ1bm5lcjo6d29ya2VyVGhyZWFkQ291bnQoKSBjb25zdAordW5zaWdu ZWQgVGVzdFJ1bm5lcjo6d29ya2VyVGhyZWFkQ291bnQoKSBjb25zdAogewogI2lmIEVOQUJMRV9X T1JLRVJTCiAgICAgcmV0dXJuIFdlYkNvcmU6OldvcmtlclRocmVhZDo6d29ya2VyVGhyZWFkQ291 bnQoKTsKQEAgLTUzOCwxNyArNTM4LDE3IEBAIHZvaWQgVGVzdFJ1bm5lcjo6c2V0U3BhdGlhbE5h dmlnYXRpb25FbmFibGVkKGJvb2wgZW5hYmxlKQogdm9pZCBUZXN0UnVubmVyOjphZGRPcmlnaW5B Y2Nlc3NXaGl0ZWxpc3RFbnRyeShKU1N0cmluZ1JlZiBzb3VyY2VPcmlnaW4sIEpTU3RyaW5nUmVm IGRlc3RpbmF0aW9uUHJvdG9jb2wsIEpTU3RyaW5nUmVmIGRlc3RpbmF0aW9uSG9zdCwgYm9vbCBh bGxvd0Rlc3RpbmF0aW9uU3ViZG9tYWlucykKIHsKICAgICBXZWJDb3JlOjpTZWN1cml0eVBvbGlj eTo6YWRkT3JpZ2luQWNjZXNzV2hpdGVsaXN0RW50cnkoKldlYkNvcmU6OlNlY3VyaXR5T3JpZ2lu OjpjcmVhdGVGcm9tU3RyaW5nKGpzU3RyaW5nUmVmVG9XZWJDb3JlU3RyaW5nKHNvdXJjZU9yaWdp bikpLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBq c1N0cmluZ1JlZlRvV2ViQ29yZVN0cmluZyhkZXN0aW5hdGlvblByb3RvY29sKSwKLSAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAganNTdHJpbmdSZWZUb1dl YkNvcmVTdHJpbmcoZGVzdGluYXRpb25Ib3N0KSwKLSAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgYWxsb3dEZXN0aW5hdGlvblN1YmRvbWFpbnMpOworICAg ICAgICBqc1N0cmluZ1JlZlRvV2ViQ29yZVN0cmluZyhkZXN0aW5hdGlvblByb3RvY29sKSwKKyAg ICAgICAganNTdHJpbmdSZWZUb1dlYkNvcmVTdHJpbmcoZGVzdGluYXRpb25Ib3N0KSwKKyAgICAg ICAgYWxsb3dEZXN0aW5hdGlvblN1YmRvbWFpbnMpOwogfQogCiB2b2lkIFRlc3RSdW5uZXI6OnJl bW92ZU9yaWdpbkFjY2Vzc1doaXRlbGlzdEVudHJ5KEpTU3RyaW5nUmVmIHNvdXJjZU9yaWdpbiwg SlNTdHJpbmdSZWYgZGVzdGluYXRpb25Qcm90b2NvbCwgSlNTdHJpbmdSZWYgZGVzdGluYXRpb25I b3N0LCBib29sIGFsbG93RGVzdGluYXRpb25TdWJkb21haW5zKQogewogICAgIFdlYkNvcmU6OlNl Y3VyaXR5UG9saWN5OjpyZW1vdmVPcmlnaW5BY2Nlc3NXaGl0ZWxpc3RFbnRyeSgqV2ViQ29yZTo6 U2VjdXJpdHlPcmlnaW46OmNyZWF0ZUZyb21TdHJpbmcoanNTdHJpbmdSZWZUb1dlYkNvcmVTdHJp bmcoc291cmNlT3JpZ2luKSksCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIGpzU3RyaW5nUmVmVG9XZWJDb3JlU3RyaW5nKGRlc3RpbmF0aW9uUHJv dG9jb2wpLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBqc1N0cmluZ1JlZlRvV2ViQ29yZVN0cmluZyhkZXN0aW5hdGlvbkhvc3QpLAotICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBhbGxvd0Rlc3Rp bmF0aW9uU3ViZG9tYWlucyk7CisgICAgICAgIGpzU3RyaW5nUmVmVG9XZWJDb3JlU3RyaW5nKGRl c3RpbmF0aW9uUHJvdG9jb2wpLAorICAgICAgICBqc1N0cmluZ1JlZlRvV2ViQ29yZVN0cmluZyhk ZXN0aW5hdGlvbkhvc3QpLAorICAgICAgICBhbGxvd0Rlc3RpbmF0aW9uU3ViZG9tYWlucyk7CiB9 CiAKIHZvaWQgVGVzdFJ1bm5lcjo6c2V0QWxsb3dGaWxlQWNjZXNzRnJvbUZpbGVVUkxzKGJvb2wg ZW5hYmxlZCkKQEAgLTc1Miw2ICs3NTIsMTMgQEAgYm9vbCBUZXN0UnVubmVyOjpmaW5kU3RyaW5n KEpTQ29udGV4dFJlZiBjb250ZXh0LCBKU1N0cmluZ1JlZiB0YXJnZXQsIEpTT2JqZWN0UmUKICAg ICAgICAgICAgIG9wdGlvbnMgfD0gV2ViQ29yZTo6U3RhcnRJblNlbGVjdGlvbjsKICAgICB9CiAK KyAgICAvLyBGSVhNRTogd2UgZG9uJ3QgbmVlZCB0byBjYWxsIFdlYlBhZ2U6OmZpbmROZXh0U3Ry aW5nKCksIHRoaXMgaXMgYSB3b3JrYXJvdW5kCisgICAgLy8gc28gdGhhdCB0ZXN0IHBsYXRmb3Jt L2JsYWNrYmVycnkvZWRpdGluZy90ZXh0LWl0ZXJhdG9yL2ZpbmRTdHJpbmctbWFya2Vycy5odG1s IGNhbiBwYXNzLgorCisgICAgLy8gT3VyIGxheW91dCB0ZXN0cyBhc3N1bWUgZmluZCB3aWxsIHdy YXAgYW5kIGhpZ2hsaWdodCBhbGwgbWF0Y2hlcy4KKyAgICBCbGFja0JlcnJ5OjpXZWJLaXQ6OkR1 bXBSZW5kZXJUcmVlOjpjdXJyZW50SW5zdGFuY2UoKS0+cGFnZSgpLT5maW5kTmV4dFN0cmluZyhu YW1lU3RyLnV0ZjgoKS5kYXRhKCksCisgICAgICAgICEob3B0aW9ucyAmIFdlYkNvcmU6OkJhY2t3 YXJkcyksICEob3B0aW9ucyAmIFdlYkNvcmU6OkNhc2VJbnNlbnNpdGl2ZSksIHRydWUgLyogd3Jh cCAqLywgdHJ1ZSAvKiBoaWdobGlnaHRBbGxNYXRjaGVzICovKTsKKwogICAgIHJldHVybiBtYWlu RnJhbWUtPnBhZ2UoKS0+ZmluZFN0cmluZyhuYW1lU3RyLCBvcHRpb25zKTsKIH0KIAotLSAKMS43 LjYKCg==