102044 2012-11-12 21:51:04 -0800 Fix the ARM traditional build after r134332 2012-11-13 00:53:49 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P1 Critical --- 101909 1 ossy webkit-unassigned fpizlo gaborb galpeter ggaren loki ossy rgabor webkit.review.bot zherczeg oldest_to_newest 765222 0 ossy 2012-11-12 21:51:04 -0800 In file included from /mnt/raptor2/slaves/qt5-linux-armv7-release/build/Source/JavaScriptCore/bytecode/CallLinkInfo.cpp:31:0: /mnt/raptor2/slaves/qt5-linux-armv7-release/build/Source/JavaScriptCore/assembler/RepatchBuffer.h: In static member function 'static JSC::CodeLocationLabel JSC::RepatchBuffer::startOfPatchableBranchPtrWithPatch(JSC::CodeLocationDataLabelPtr)': /mnt/raptor2/slaves/qt5-linux-armv7-release/build/Source/JavaScriptCore/assembler/RepatchBuffer.h:146:16: error: 'startOfPatchableBranchPtrWithPatch' is not a member of 'JSC::MacroAssembler' In file included from /mnt/raptor2/slaves/qt5-linux-armv7-release/build/Source/JavaScriptCore/bytecode/CallLinkInfo.cpp:31:0: /mnt/raptor2/slaves/qt5-linux-armv7-release/build/Source/JavaScriptCore/assembler/RepatchBuffer.h: In member function 'void JSC::RepatchBuffer::revertJumpReplacementToPatchableBranchPtrWithPatch(JSC::CodeLocationLabel, JSC::AbstractMacroAssembler<JSC::ARMAssembler>::Address, void*)': /mnt/raptor2/slaves/qt5-linux-armv7-release/build/Source/JavaScriptCore/assembler/RepatchBuffer.h:159:9: error: 'revertJumpReplacementToPatchableBranchPtrWithPatch' is not a member of 'JSC::MacroAssembler' In file included from /mnt/raptor2/slaves/qt5-linux-armv7-release/build/Source/JavaScriptCore/bytecode/CodeBlock.cpp:46:0: /mnt/raptor2/slaves/qt5-linux-armv7-release/build/Source/JavaScriptCore/assembler/RepatchBuffer.h: In static member function 'static JSC::CodeLocationLabel JSC::RepatchBuffer::startOfPatchableBranchPtrWithPatch(JSC::CodeLocationDataLabelPtr)': /mnt/raptor2/slaves/qt5-linux-armv7-release/build/Source/JavaScriptCore/assembler/RepatchBuffer.h:146:16: error: 'startOfPatchableBranchPtrWithPatch' is not a member of 'JSC::MacroAssembler' In file included from /mnt/raptor2/slaves/qt5-linux-armv7-release/build/Source/JavaScriptCore/bytecode/CodeBlock.cpp:46:0: /mnt/raptor2/slaves/qt5-linux-armv7-release/build/Source/JavaScriptCore/assembler/RepatchBuffer.h: In member function 'void JSC::RepatchBuffer::revertJumpReplacementToPatchableBranchPtrWithPatch(JSC::CodeLocationLabel, JSC::AbstractMacroAssembler<JSC::ARMAssembler>::Address, void*)': /mnt/raptor2/slaves/qt5-linux-armv7-release/build/Source/JavaScriptCore/assembler/RepatchBuffer.h:159:9: error: 'revertJumpReplacementToPatchableBranchPtrWithPatch' is not a member of 'JSC::MacroAssembler' 765354 1 173843 galpeter 2012-11-13 00:41:50 -0800 Created attachment 173843 speculative fix 765360 2 173843 zherczeg 2012-11-13 00:44:13 -0800 Comment on attachment 173843 speculative fix rs=me 765365 3 173843 ossy 2012-11-13 00:53:43 -0800 Comment on attachment 173843 speculative fix Clearing flags on attachment: 173843 Committed r134383: <http://trac.webkit.org/changeset/134383> 765366 4 ossy 2012-11-13 00:53:49 -0800 All reviewed patches have been landed. Closing bug. 173843 2012-11-13 00:41:50 -0800 2012-11-13 00:53:43 -0800 speculative fix arm_fix_after_r134332.patch text/plain 1781 galpeter ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGJmZDg3NTguLjBmYzc2YTMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTExLTEzICBQZXRlciBHYWwgIDxn YWxwZXRlckBpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgRml4IHRoZSBBUk0gdHJhZGl0aW9u YWwgYnVpbGQgYWZ0ZXIgcjEzNDMzMgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTAyMDQ0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgQWRkZWQgbWlzc2luZyBtZXRob2RzIGZvciB0aGUgTWFjcm9Bc3NlbWJs ZXJBUk0sIGJhc2VkIG9uIHRoZSBNYWNyb0Fzc2VtYmxlckFSTXY3LgorCisgICAgICAgICogYXNz ZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNLmg6CisgICAgICAgIChKU0M6Ok1hY3JvQXNzZW1ibGVy QVJNOjpjYW5KdW1wUmVwbGFjZVBhdGNoYWJsZUJyYW5jaFB0cldpdGhQYXRjaCk6CisgICAgICAg IChNYWNyb0Fzc2VtYmxlckFSTSk6CisgICAgICAgIChKU0M6Ok1hY3JvQXNzZW1ibGVyQVJNOjpz dGFydE9mUGF0Y2hhYmxlQnJhbmNoUHRyV2l0aFBhdGNoKToKKyAgICAgICAgKEpTQzo6TWFjcm9B c3NlbWJsZXJBUk06OnJldmVydEp1bXBSZXBsYWNlbWVudFRvUGF0Y2hhYmxlQnJhbmNoUHRyV2l0 aFBhdGNoKToKKwogMjAxMi0xMS0xMiAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgog CiAgICAgICAgIFRoZSBhY3Qgb2YgZ2V0dGluZyB0aGUgY2FsbGVlIGR1cmluZyAndGhpcycgY29u c3RydWN0aW9uIHNob3VsZCBiZSBleHBsaWNpdCBpbiBieXRlY29kZQpkaWZmIC0tZ2l0IGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTS5oIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTS5oCmluZGV4IDM5ZDk0 YWQuLjAxMmRkMDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIv TWFjcm9Bc3NlbWJsZXJBUk0uaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVy L01hY3JvQXNzZW1ibGVyQVJNLmgKQEAgLTEyNjYsNiArMTI2NiwxOCBAQCBwdWJsaWM6CiAgICAg ICAgIHJldHVybiAwOwogICAgIH0KIAorICAgIHN0YXRpYyBib29sIGNhbkp1bXBSZXBsYWNlUGF0 Y2hhYmxlQnJhbmNoUHRyV2l0aFBhdGNoKCkgeyByZXR1cm4gZmFsc2U7IH0KKworICAgIHN0YXRp YyBDb2RlTG9jYXRpb25MYWJlbCBzdGFydE9mUGF0Y2hhYmxlQnJhbmNoUHRyV2l0aFBhdGNoKENv ZGVMb2NhdGlvbkRhdGFMYWJlbFB0ciBsYWJlbCkKKyAgICB7CisgICAgICAgIFVOUkVBQ0hBQkxF X0ZPUl9QTEFURk9STSgpOworICAgIH0KKworICAgIHN0YXRpYyB2b2lkIHJldmVydEp1bXBSZXBs YWNlbWVudFRvUGF0Y2hhYmxlQnJhbmNoUHRyV2l0aFBhdGNoKENvZGVMb2NhdGlvbkxhYmVsIGlu c3RydWN0aW9uU3RhcnQsIEFkZHJlc3MsIHZvaWQqIGluaXRpYWxWYWx1ZSkKKyAgICB7CisgICAg ICAgIFVOUkVBQ0hBQkxFX0ZPUl9QTEFURk9STSgpOworICAgIH0KKwogcHJvdGVjdGVkOgogICAg IEFSTUFzc2VtYmxlcjo6Q29uZGl0aW9uIEFSTUNvbmRpdGlvbihSZWxhdGlvbmFsQ29uZGl0aW9u IGNvbmQpCiAgICAgewo=