102038 2012-11-12 20:17:04 -0800 [EFL] In ewk_tiled_backing_store_pre_render_region, the 'slicer' may be uninitialized 2012-11-12 22:36:43 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 101762 1 ktf.kim ktf.kim gyuyoung.kim lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 765155 0 ktf.kim 2012-11-12 20:17:04 -0800 In ewk_tiled_backing_store_pre_render_region, the member variables of 'slicer' are initialized in eina_tile_grid_slicer_setup, and used in eina_tile_grid_slicer_next. But, because some of them may be uninitialized, initialize it definitely with memset seems better. It's for fixing the following build warning : WebKitBuild/Dependencies/Root/include/eina-1/eina/eina_inline_tiler.x: In function 'bool ewk_tiled_backing_store_pre_render_region(Evas_Object*, Evas_Coord, Evas_Coord, Evas_Coord, Evas_Coord, float)': WebKitBuild/Dependencies/Root/include/eina-1/eina/eina_inline_tiler.x:82:4: warning: 'slicer._Eina_Tile_Grid_Slicer::tile_w' may be used uninitialized in this function [-Wuninitialized] Source/WebKit/efl/ewk/ewk_tiled_backing_store.cpp:1857:27: note: 'slicer._Eina_Tile_Grid_Slicer::tile_w' was declared here WebKitBuild/Dependencies/Root/include/eina-1/eina/eina_inline_tiler.x:82:4: warning: 'slicer._Eina_Tile_Grid_Slicer::w2_rel' may be used uninitialized in this function [-Wuninitialized] Source/WebKit/efl/ewk/ewk_tiled_backing_store.cpp:1857:27: note: 'slicer._Eina_Tile_Grid_Slicer::w2_rel' was declared here 765157 1 173802 ktf.kim 2012-11-12 20:25:54 -0800 Created attachment 173802 Patch 765259 2 173802 webkit.review.bot 2012-11-12 22:36:39 -0800 Comment on attachment 173802 Patch Clearing flags on attachment: 173802 Committed r134365: <http://trac.webkit.org/changeset/134365> 765261 3 webkit.review.bot 2012-11-12 22:36:43 -0800 All reviewed patches have been landed. Closing bug. 173802 2012-11-12 20:25:54 -0800 2012-11-12 22:36:38 -0800 Patch bug-102038-20121113132356.patch text/plain 1689 ktf.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0MzQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Vm bC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKaW5kZXggNmI5OWE2NjBm ZjU1MDk2YWEzZDRiMmY0MTEwMjliMTg1YzIwODU1Ny4uNWE1Yjc4MjhkMWQ4MjM5YWM2MmZkM2Y0 OTUyNjA5MWU3ZDAwYWQ4NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEy LTExLTEyICBLeXVuZ1RhZSBLaW0gIDxrdGYua2ltQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtF RkxdIEluIGV3a190aWxlZF9iYWNraW5nX3N0b3JlX3ByZV9yZW5kZXJfcmVnaW9uLCB0aGUgJ3Ns aWNlcicgbWF5IGJlIHVuaW5pdGlhbGl6ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEwMjAzOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFRvIGZpeCBidWlsZCB3YXJuaW5nIC1XdW5pbml0aWFsaXplZCwK KyAgICAgICAgaW5pdGlhbGl6ZSB0aGUgJ3NsaWNlcicgaW4gZXdrX3RpbGVkX2JhY2tpbmdfc3Rv cmVfcHJlX3JlbmRlcl9yZWdpb24uCisKKyAgICAgICAgKiBld2svZXdrX3RpbGVkX2JhY2tpbmdf c3RvcmUuY3BwOgorICAgICAgICAoZXdrX3RpbGVkX2JhY2tpbmdfc3RvcmVfcHJlX3JlbmRlcl9y ZWdpb24pOgorCiAyMDEyLTExLTA5ICBSYXBoYWVsIEt1Ym8gZGEgQ29zdGEgIDxyYXBoYWVsLmt1 Ym8uZGEuY29zdGFAaW50ZWwuY29tPgogCiAgICAgICAgIFtFRkxdW0RSVF0gRm9yY2UgYSByZXBh aW50IGJlZm9yZSB0cmFja2luZyByZXBhaW50IHJlY3RzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9lZmwvZXdrL2V3a190aWxlZF9iYWNraW5nX3N0b3JlLmNwcCBiL1NvdXJjZS9XZWJLaXQv ZWZsL2V3ay9ld2tfdGlsZWRfYmFja2luZ19zdG9yZS5jcHAKaW5kZXggZGRhZTE3MzQ3ZWJlMjEy NjNjMTdiNzM1MzM3MGViMTkwODEwMmZlZi4uMWM1MDg3OTc4MjQ1ZTYwZmMyNmE2NTg2ZmJjMGE2 MDhhYjYxMDc5YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a190aWxlZF9i YWNraW5nX3N0b3JlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3RpbGVkX2Jh Y2tpbmdfc3RvcmUuY3BwCkBAIC0xODU1LDYgKzE4NTUsOCBAQCBib29sIGV3a190aWxlZF9iYWNr aW5nX3N0b3JlX3ByZV9yZW5kZXJfcmVnaW9uKEV2YXNfT2JqZWN0KiBld2tCYWNraW5nU3RvcmUs IEV2YQogICAgIHpvb20gPSBST1VOREVEX1pPT00ocHJpdi0+dmlldy50aWxlLndpZHRoLCB6b29t KTsKIAogICAgIEVpbmFfVGlsZV9HcmlkX1NsaWNlciBzbGljZXI7CisgICAgbWVtc2V0KCZzbGlj ZXIsIDAsIHNpemVvZihFaW5hX1RpbGVfR3JpZF9TbGljZXIpKTsKKwogICAgIGlmICghZWluYV90 aWxlX2dyaWRfc2xpY2VyX3NldHVwKCZzbGljZXIsIHgsIHksIHdpZHRoLCBoZWlnaHQsIHRpbGVX aWR0aCwgdGlsZUhlaWdodCkpIHsKICAgICAgICAgRVJSKCJjb3VsZCBub3Qgc2V0dXAgZ3JpZCBz bGljZXIgZm9yICVkLCVkKyVkeCVkIHRpbGU9JWR4JWQiLAogICAgICAgICAgICAgeCwgeSwgd2lk dGgsIGhlaWdodCwgdGlsZVdpZHRoLCB0aWxlSGVpZ2h0KTsK