102034 2012-11-12 18:44:54 -0800 [BlackBerry] NetworkJob should not check if data is received with HEAD 2012-11-12 22:29:26 -0800 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joenotcharles joenotcharles mifenton rwlbuis tonikitoo webkit.review.bot oldest_to_newest 765114 0 joenotcharles 2012-11-12 18:44:54 -0800 shouldNotifyClientFailed checks if a failure status has been received, and data has been received. The "data has been received" part of the check should not apply for HEAD, since obviously no data is ever received for HEAD. 765142 1 173799 joenotcharles 2012-11-12 19:54:01 -0800 Created attachment 173799 fix 765254 2 173799 webkit.review.bot 2012-11-12 22:29:23 -0800 Comment on attachment 173799 fix Clearing flags on attachment: 173799 Committed r134364: <http://trac.webkit.org/changeset/134364> 765255 3 webkit.review.bot 2012-11-12 22:29:26 -0800 All reviewed patches have been landed. Closing bug. 173799 2012-11-12 19:54:01 -0800 2012-11-12 22:29:23 -0800 fix 0001-BlackBerry-NetworkJob-should-not-check-if-data-is-re.patch text/plain 6256 joenotcharles RnJvbSBmMDNmYmMwODFlODExY2VmNmU3NDZhODdiNTcxMTExMGQ2OWE1YmZlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKb2UgTWFzb24gPGptYXNvbkByaW0uY29tPgpEYXRlOiBNb24s IDEyIE5vdiAyMDEyIDIyOjUwOjU5IC0wNTAwClN1YmplY3Q6IFtQQVRDSF0gW0JsYWNrQmVycnld IE5ldHdvcmtKb2Igc2hvdWxkIG5vdCBjaGVjayBpZiBkYXRhIGlzIHJlY2VpdmVkCiB3aXRoIEhF QUQgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMjAzNAoKUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCgpJbnRlcm5hbCBQUjogMjQxMzkxCgpNYWtlIEhFQUQgcmVx dWVzdHMgY2FsbCBkaWRGaW5pc2ggaW5zdGVhZCBvZiBkaWRGYWlsIG9uIGEgNDA0IHJlc3BvbnNl LCBldmVuIHRob3VnaCB0aGV5CmhhdmUgbm8gZGF0YS4KClRlc3RzOiBNYW51YWxUZXN0cy9ibGFj a2JlcnJ5L2hlYWQteGhyLW5vbmV4aXN0YW50LWZpbGUuaHRtbAoKKiBwbGF0Zm9ybS9uZXR3b3Jr L2JsYWNrYmVycnkvTmV0d29ya0pvYi5jcHA6CihXZWJDb3JlOjpOZXR3b3JrSm9iOjpOZXR3b3Jr Sm9iKToKKFdlYkNvcmU6Ok5ldHdvcmtKb2I6OmluaXRpYWxpemUpOgooV2ViQ29yZTo6TmV0d29y a0pvYjo6c2hvdWxkTm90aWZ5Q2xpZW50RmFpbGVkKToKKiBwbGF0Zm9ybS9uZXR3b3JrL2JsYWNr YmVycnkvTmV0d29ya0pvYi5oOgooTmV0d29ya0pvYik6Ci0tLQogQ2hhbmdlTG9nICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDEzICsrKysrKysrKwogLi4uL2Js YWNrYmVycnkvaGVhZC14aHItbm9uZXhpc3RhbnQtZmlsZS5odG1sICAgICAgfCAgIDI3ICsrKysr KysrKysrKysrKysrKysrCiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAg ICAgICAgICAgICB8ICAgMjEgKysrKysrKysrKysrKysrCiAuLi4vcGxhdGZvcm0vbmV0d29yay9i bGFja2JlcnJ5L05ldHdvcmtKb2IuY3BwICAgICB8ICAgIDcgKysrKy0KIC4uLi9wbGF0Zm9ybS9u ZXR3b3JrL2JsYWNrYmVycnkvTmV0d29ya0pvYi5oICAgICAgIHwgICAgMSArCiA1IGZpbGVzIGNo YW5nZWQsIDY4IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb25zKC0pCiBjcmVhdGUgbW9kZSAxMDA2 NDQgTWFudWFsVGVzdHMvYmxhY2tiZXJyeS9oZWFkLXhoci1ub25leGlzdGFudC1maWxlLmh0bWwK CmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggMWU5ODA4Yi4uYTA4ODA0 OSAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBA CisyMDEyLTExLTEyICBKb2UgTWFzb24gIDxqbWFzb25AcmltLmNvbT4KKworICAgICAgICBbQmxh Y2tCZXJyeV0gTmV0d29ya0pvYiBzaG91bGQgbm90IGNoZWNrIGlmIGRhdGEgaXMgcmVjZWl2ZWQg d2l0aCBIRUFECisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMDIwMzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBJbnRlcm5hbCBQUjogMjQxMzkxCisKKyAgICAgICAgQWRkIHRlc3QgdGhhdCBIRUFEIFhNTEh0 dHBSZXF1ZXN0cyByZXR1cm4gc3RhdHVzIDQwNCBpbnN0ZWFkIG9mIGNhbGxpbmcgb25lcnJvci4K KworICAgICAgICAqIE1hbnVhbFRlc3RzL2JsYWNrYmVycnkvaGVhZC14aHItbm9uZXhpc3RhbnQt ZmlsZS5odG1sOiBBZGRlZC4KKwogMjAxMi0xMC0yNiAgUm9iIEJ1aXMgIDxyYnVpc0ByaW0uY29t PgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBQbGF0Zm9ybSBBYnN0cmFjdGlvbiBmb3IgV2ViS2l0 IFJlc291cmNlL0ltYWdlIExvYWRpbmcKZGlmZiAtLWdpdCBhL01hbnVhbFRlc3RzL2JsYWNrYmVy cnkvaGVhZC14aHItbm9uZXhpc3RhbnQtZmlsZS5odG1sIGIvTWFudWFsVGVzdHMvYmxhY2tiZXJy eS9oZWFkLXhoci1ub25leGlzdGFudC1maWxlLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5k ZXggMDAwMDAwMC4uODgyYjZjYwotLS0gL2Rldi9udWxsCisrKyBiL01hbnVhbFRlc3RzL2JsYWNr YmVycnkvaGVhZC14aHItbm9uZXhpc3RhbnQtZmlsZS5odG1sCkBAIC0wLDAgKzEsMjcgQEAKKzxo dG1sPgorPGhlYWQ+Cis8c2NyaXB0PgordmFyIHhociA9IG5ldyBYTUxIdHRwUmVxdWVzdCgpOwor eGhyLm9wZW4oIkhFQUQiLCAibm90aGluZy50eHQiLCB0cnVlKTsKK3hoci5vbnJlYWR5c3RhdGVj aGFuZ2UgPSBmdW5jdGlvbigpIHsKKyAgICBpZiAoeGhyLnJlYWR5U3RhdGUgIT0gNCkgeworICAg ICAgICByZXR1cm47CisgICAgfQorICAgIGlmICh4aHIuc3RhdHVzID09IDQwNCkgeworICAgICAg ICBhbGVydCgiUEFTU0VEOiBvbnJlYWR5c3RhdGVjaGFuZ2UgZmlyZWQgd2l0aCBzdGF0dXMgNDA0 Iik7CisgICAgfSBlbHNlIHsKKyAgICAgICAgYWxlcnQoIkZBSUxFRDogb25yZWFkeXN0YXRlY2hh bmdlIGZpcmVkIHdpdGggc3RhdHVzICIgKyB4aHIuc3RhdHVzKTsKKyAgICB9CisKK30KK3hoci5v bmVycm9yID0gZnVuY3Rpb24oKSB7CisgICAgYWxlcnQoIkZBSUxFRDogb25lcnJvciBmaXJlZCIp OworfQoreGhyLnNlbmQoKTsKKzwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHk+Cis8cD5UaGlzIHRl c3QgbXVzdCBiZSBob3N0ZWQgb24gYSB3ZWIgc2VydmVyLCBub3QgcnVuIGZyb20gYSBmaWxlIHVy bCwgYmVjYXVzZSBYTUxIdHRwUmVxdWVzdCBmcm9tIGZpbGUgdXJsIGNhdXNlcyBhIHNlY3VyaXR5 IGVycm9yLjwvcD4KKzxwPllvdSBzaG91bGQgc2VlIGFuIGFsZXJ0IGJveCBzYXlpbmcgd2hldGhl ciB0aGUgdGVzdCB3YXMgcGFzc2VkIG9yIGZhaWxlZC4gSWYgdGhlcmUgaXMgbm8gYWxlcnQgYm94 LCB0aGUgdGVzdCB3YXMgRkFJTEVELjwvcD4KKzwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRl eCAyNWE1NWRkLi40MTI2ZGYzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTItMTEt MTIgIEpvZSBNYXNvbiAgPGptYXNvbkByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBO ZXR3b3JrSm9iIHNob3VsZCBub3QgY2hlY2sgaWYgZGF0YSBpcyByZWNlaXZlZCB3aXRoIEhFQUQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMjAzNAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEludGVybmFs IFBSOiAyNDEzOTEKKworICAgICAgICBNYWtlIEhFQUQgcmVxdWVzdHMgY2FsbCBkaWRGaW5pc2gg aW5zdGVhZCBvZiBkaWRGYWlsIG9uIGEgNDA0IHJlc3BvbnNlLCBldmVuIHRob3VnaCB0aGV5Cisg ICAgICAgIGhhdmUgbm8gZGF0YS4KKworICAgICAgICBUZXN0czogTWFudWFsVGVzdHMvYmxhY2ti ZXJyeS9oZWFkLXhoci1ub25leGlzdGFudC1maWxlLmh0bWwKKworICAgICAgICAqIHBsYXRmb3Jt L25ldHdvcmsvYmxhY2tiZXJyeS9OZXR3b3JrSm9iLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok5l dHdvcmtKb2I6Ok5ldHdvcmtKb2IpOgorICAgICAgICAoV2ViQ29yZTo6TmV0d29ya0pvYjo6aW5p dGlhbGl6ZSk6CisgICAgICAgIChXZWJDb3JlOjpOZXR3b3JrSm9iOjpzaG91bGROb3RpZnlDbGll bnRGYWlsZWQpOgorICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9OZXR3b3Jr Sm9iLmg6CisgICAgICAgIChOZXR3b3JrSm9iKToKKwogMjAxMi0xMS0wOCAgSm9lIE1hc29uICA8 am1hc29uQHJpbS5jb20+CiAKICAgICAgICAgW0JsYWNrQmVycnldIFVwZGF0ZSB0byBuZXcgcHJv eHlJbmZvIEFQSQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9i bGFja2JlcnJ5L05ldHdvcmtKb2IuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29y ay9ibGFja2JlcnJ5L05ldHdvcmtKb2IuY3BwCmluZGV4IDA2YjQ3MjguLjM2MjlmNzEgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9OZXR3b3Jr Sm9iLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkv TmV0d29ya0pvYi5jcHAKQEAgLTg0LDYgKzg0LDcgQEAgTmV0d29ya0pvYjo6TmV0d29ya0pvYigp CiAgICAgLCBtX25lZWRzUmV0cnlBc0ZUUERpcmVjdG9yeShmYWxzZSkKICAgICAsIG1faXNPdmVy cmlkZUNvbnRlbnRUeXBlKGZhbHNlKQogICAgICwgbV9uZXdKb2JXaXRoQ3JlZGVudGlhbHNTdGFy dGVkKGZhbHNlKQorICAgICwgbV9pc0hlYWRNZXRob2QoZmFsc2UpCiAgICAgLCBtX2V4dGVuZGVk U3RhdHVzQ29kZSgwKQogICAgICwgbV9yZWRpcmVjdENvdW50KDApCiAgICAgLCBtX2RlZmVycmVk RGF0YSgqdGhpcykKQEAgLTEwOSw2ICsxMTAsOCBAQCBib29sIE5ldHdvcmtKb2I6OmluaXRpYWxp emUoaW50IHBsYXllcklkLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgIGludCBkZWZlckxv YWRpbmdDb3VudCwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpbnQgcmVkaXJlY3RDb3Vu dCkKIHsKKyAgICBCTEFDS0JFUlJZX0FTU0VSVChoYW5kbGUpOworCiAgICAgbV9wbGF5ZXJJZCA9 IHBsYXllcklkOwogICAgIG1fcGFnZUdyb3VwTmFtZSA9IHBhZ2VHcm91cE5hbWU7CiAKQEAgLTEz MSw2ICsxMzQsOCBAQCBib29sIE5ldHdvcmtKb2I6OmluaXRpYWxpemUoaW50IHBsYXllcklkLAog ICAgIG1fcmVkaXJlY3RDb3VudCA9IHJlZGlyZWN0Q291bnQ7CiAgICAgbV9kZWZlckxvYWRpbmdD b3VudCA9IGRlZmVyTG9hZGluZ0NvdW50OwogCisgICAgbV9pc0hlYWRNZXRob2QgPSBtX2hhbmRs ZS0+Zmlyc3RSZXF1ZXN0KCkuaHR0cE1ldGhvZCgpLnVwcGVyKCkgPT0gIkhFQUQiOworCiAgICAg Ly8gV2UgZG9uJ3QgbmVlZCB0byBleHBsaWNpdGx5IGNhbGwgbm90aWZ5SGVhZGVyUmVjZWl2ZWQs IGFzIHRoZSBDb250ZW50LVR5cGUKICAgICAvLyB3aWxsIHVsdGltYXRlbHkgZ2V0IHBhcnNlZCB3 aGVuIHNlbmRSZXNwb25zZUlmTmVlZGVkIGdldHMgY2FsbGVkLgogICAgIGlmICghcmVxdWVzdC5n ZXRPdmVycmlkZUNvbnRlbnRUeXBlKCkuZW1wdHkoKSkgewpAQCAtNTQ0LDcgKzU0OSw3IEBAIGJv b2wgTmV0d29ya0pvYjo6c2hvdWxkUmVsZWFzZUNsaWVudFJlc291cmNlKCkKIAogYm9vbCBOZXR3 b3JrSm9iOjpzaG91bGROb3RpZnlDbGllbnRGYWlsZWQoKSBjb25zdAogewotICAgIHJldHVybiBt X2V4dGVuZGVkU3RhdHVzQ29kZSA8IDAgfHwgKGlzRXJyb3IobV9leHRlbmRlZFN0YXR1c0NvZGUp ICYmICFtX2RhdGFSZWNlaXZlZCk7CisgICAgcmV0dXJuIG1fZXh0ZW5kZWRTdGF0dXNDb2RlIDwg MCB8fCAoaXNFcnJvcihtX2V4dGVuZGVkU3RhdHVzQ29kZSkgJiYgIW1fZGF0YVJlY2VpdmVkICYm ICFtX2lzSGVhZE1ldGhvZCk7CiB9CiAKIGJvb2wgTmV0d29ya0pvYjo6cmV0cnlBc0ZUUERpcmVj dG9yeSgpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNr YmVycnkvTmV0d29ya0pvYi5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9ibGFj a2JlcnJ5L05ldHdvcmtKb2IuaAppbmRleCAyMzU5YzNlLi4yNTE0ODU0IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkvTmV0d29ya0pvYi5oCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9OZXR3b3JrSm9i LmgKQEAgLTE2NCw2ICsxNjQsNyBAQCBwcml2YXRlOgogICAgIGJvb2wgbV9uZWVkc1JldHJ5QXNG VFBEaXJlY3Rvcnk7CiAgICAgYm9vbCBtX2lzT3ZlcnJpZGVDb250ZW50VHlwZTsKICAgICBib29s IG1fbmV3Sm9iV2l0aENyZWRlbnRpYWxzU3RhcnRlZDsKKyAgICBib29sIG1faXNIZWFkTWV0aG9k OwogCiAgICAgLy8gSWYgYW4gSFRUUCBzdGF0dXMgY29kZSBpcyByZWNlaXZlZCwgbV9leHRlbmRl ZFN0YXR1c0NvZGUgYW5kIG1fcmVzcG9uc2UuaHR0cFN0YXR1c0NvZGUgd2lsbCBib3RoIGJlIHNl dCB0byBpdC4KICAgICAvLyBJZiBhIHBsYXRmb3JtIGVycm9yIGNvZGUgaXMgcmVjZWl2ZWQsIG1f ZXh0ZW5kZWRTdGF0dXNDb2RlIHdpbGwgYmUgc2V0IHRvIGl0IGFuZCBtX3Jlc3BvbnNlLmh0dHBT dGF0dXNDb2RlIHdpbGwgYmUgc2V0IHRvIDQwNC4KLS0gCjEuNy41LjQKCg==