102027 2012-11-12 18:03:01 -0800 Some CSS properties are not handled on StyleResolver::applyProperty 2012-11-12 21:33:36 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ktf.kim ktf.kim allan.jensen cmarcelo macpherson menard webkit.review.bot oldest_to_newest 765064 0 ktf.kim 2012-11-12 18:03:01 -0800 The CSSPropertyMaxZoom, CSSPropertyMinZoom, CSSPropertyOrientation, CSSPropertyUserZoom properties, that are used when CSS_DEVICE_ADAPTATION enabled, are not properly handled on StyleResolver::applyProperty. When SVG enabled, they are go to applySVGProperty, and when SVG disabled, the below build warning occurs: (In the below case, that was error because -Werror=switch was on) Source/WebCore/css/StyleResolver.cpp: In member function ‘void WebCore::StyleResolver::applyProperty(WebCore::CSSPropertyID, WebCore::CSSValue*)’: Source/WebCore/css/StyleResolver.cpp:2860:12: error: enumeration value ‘CSSPropertyMaxZoom’ not handled in switch [-Werror=switch] Source/WebCore/css/StyleResolver.cpp:2860:12: error: enumeration value ‘CSSPropertyMinZoom’ not handled in switch [-Werror=switch] Source/WebCore/css/StyleResolver.cpp:2860:12: error: enumeration value ‘CSSPropertyOrientation’ not handled in switch [-Werror=switch] Source/WebCore/css/StyleResolver.cpp:2860:12: error: enumeration value ‘CSSPropertyUserZoom’ not handled in switch [-Werror=switch] So, they need to be listed on the StyleResolver::applyProperty. 765088 1 173782 ktf.kim 2012-11-12 18:15:47 -0800 Created attachment 173782 Patch 765206 2 173782 webkit.review.bot 2012-11-12 21:33:33 -0800 Comment on attachment 173782 Patch Clearing flags on attachment: 173782 Committed r134357: <http://trac.webkit.org/changeset/134357> 765207 3 webkit.review.bot 2012-11-12 21:33:36 -0800 All reviewed patches have been landed. Closing bug. 173782 2012-11-12 18:15:47 -0800 2012-11-12 21:33:32 -0800 Patch bug-102027-20121113111348.patch text/plain 1567 ktf.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0MzE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDQ2NDQyZTEyNzM2MDc0 NDZkZjY0MjE5ODAyOTdmYTEwN2VlMTI1My4uZWM0NTdhZWQzMTBkNmI1YzMwMjgzMzEwOWIxNGU3 YTY2MzE2NTkyMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTExLTEyICBLeXVu Z1RhZSBLaW0gIDxrdGYua2ltQHNhbXN1bmcuY29tPgorCisgICAgICAgIFNvbWUgQ1NTIHByb3Bl cnRpZXMgYXJlIG5vdCBoYW5kbGVkIG9uIFN0eWxlUmVzb2x2ZXI6OmFwcGx5UHJvcGVydHkKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMjAyNworCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBDU1NQcm9w ZXJ0eU1heFpvb20sIENTU1Byb3BlcnR5TWluWm9vbSwgQ1NTUHJvcGVydHlPcmllbnRhdGlvbiBh bmQgQ1NTUHJvcGVydHlVc2VyWm9vbQorICAgICAgICBuZWVkIHRvIGJlIGhhbmRsZWQgb24gU3R5 bGVSZXNvbHZlcjo6YXBwbHlQcm9wZXJ0eS4KKworICAgICAgICAqIGNzcy9TdHlsZVJlc29sdmVy LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlN0eWxlUmVzb2x2ZXI6OmFwcGx5UHJvcGVydHkpOgor CiAyMDEyLTExLTEyICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAg ICAgICAgIFJlZHVjZSB0aGUgY3JhenkgbnVtYmVyIG9mIHBhcmFtZXRlcnMgdG8gUmVuZGVyTGF5 ZXIgcGFpbnRpbmcgbWVtYmVyIGZ1bmN0aW9ucwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv Y3NzL1N0eWxlUmVzb2x2ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlUmVzb2x2ZXIu Y3BwCmluZGV4IGVjYTY5YWE0MTJjNGViNjVjZGMyMTQ3YmY3MThiNmVjYzQ5ZGQ5MDguLmNlMjMz NDlkZTA2YzgwZmJmZmM4Y2FjMDE2MTY1ZDM2YjRkNzUwODYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2Nzcy9TdHlsZVJlc29sdmVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5 bGVSZXNvbHZlci5jcHAKQEAgLTM4OTIsNiArMzg5MiwxMiBAQCB2b2lkIFN0eWxlUmVzb2x2ZXI6 OmFwcGx5UHJvcGVydHkoQ1NTUHJvcGVydHlJRCBpZCwgQ1NTVmFsdWUqIHZhbHVlKQogICAgIGNh c2UgQ1NTUHJvcGVydHlXb3JkV3JhcDoKICAgICBjYXNlIENTU1Byb3BlcnR5WkluZGV4OgogICAg IGNhc2UgQ1NTUHJvcGVydHlab29tOgorI2lmIEVOQUJMRShDU1NfREVWSUNFX0FEQVBUQVRJT04p CisgICAgY2FzZSBDU1NQcm9wZXJ0eU1heFpvb206CisgICAgY2FzZSBDU1NQcm9wZXJ0eU1pblpv b206CisgICAgY2FzZSBDU1NQcm9wZXJ0eU9yaWVudGF0aW9uOgorICAgIGNhc2UgQ1NTUHJvcGVy dHlVc2VyWm9vbToKKyNlbmRpZgogICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKICAgICAg ICAgcmV0dXJuOwogI2lmIEVOQUJMRShTVkcpCg==