102020 2012-11-12 17:38:13 -0800 [V8] We should be able to recover the V8DOMWindowShell more quickly 2012-11-16 11:13:43 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth eric haraken ojan webkit.review.bot oldest_to_newest 765033 0 abarth 2012-11-12 17:38:13 -0800 [V8] We should be able to recover the V8DOMWindowShell more quickly 765038 1 173772 abarth 2012-11-12 17:41:34 -0800 Created attachment 173772 Patch 765040 2 abarth 2012-11-12 17:41:53 -0800 I should run this patch through dom_perf too. 765044 3 173772 haraken 2012-11-12 17:44:50 -0800 Comment on attachment 173772 Patch > dom_perf As far as I tested with PerformanceTests/DOM, the results were flaky though. 765045 4 abarth 2012-11-12 17:45:30 -0800 > As far as I tested with PerformanceTests/DOM, the results were flaky though. Do you mean with this patch or in general? 765048 5 haraken 2012-11-12 17:54:29 -0800 (In reply to comment #4) > > As far as I tested with PerformanceTests/DOM, the results were flaky though. > > Do you mean with this patch or in general? In general. Just my experience when I was optimizing DOM bindings. Some tests in PerformanceTests/DOM finish too short and flaky. (Dromaeo shows more reliable results in my experience.) 765302 6 173772 webkit.review.bot 2012-11-12 23:32:41 -0800 Comment on attachment 173772 Patch Clearing flags on attachment: 173772 Committed r134372: <http://trac.webkit.org/changeset/134372> 765303 7 webkit.review.bot 2012-11-12 23:32:44 -0800 All reviewed patches have been landed. Closing bug. 769482 8 ojan 2012-11-16 11:13:43 -0800 Looks like a 6% improvement on http://build.chromium.org/f/chromium/perf/mac-release-10.6-webkit-latest/dromaeo_jslibstylejquery/report.html?rev=167701&graph=jslib_style_jquery_jQuery___height___x10&history=50 173772 2012-11-12 17:41:34 -0800 2012-11-12 23:32:41 -0800 Patch bug-102020-20121112173936.patch text/plain 5322 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0MzIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjlhMzQ1ZDdjM2JjMmU2 MDE2ZDViODgyNDRjMTI1MWQ3N2VjMWRiMC4uYmQ5NGNkMTdjNTNkNGVkMmVlZTBkMTkxMDEwM2Vj MDMwZTg2MjM5NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDMwIEBACiAyMDEyLTExLTEyICBBZGFt IEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKKyAgICAgICAgW1Y4XSBXZSBzaG91bGQgYmUg YWJsZSB0byByZWNvdmVyIHRoZSBWOERPTVdpbmRvd1NoZWxsIG1vcmUgcXVpY2tseQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAyMDIwCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRm9yIGlzb2xhdGVkIHdv cmxkcywgd2UgdXNlZCB0byBzdG9yZSB0aGUgVjhET01XaW5kb3dTaGVsbCBhcyBhbgorICAgICAg ICBpbnRlcm5hbCBmaWVsZCBvZiB0aGUgaW5uZXIgRE9NIHdpbmRvdy4gVGhpcyBwYXRjaCBtb3Zl cyB0aGUgcG9pbnRlciB0bworICAgICAgICBhbiBpbnRlcm5hbCBmaWVsZCBvZiB0aGUgdjg6OkNv bnRleHQsIHdoaWNoIHNhdmVzIHVzIHRoZSB3b3JrIG9mCisgICAgICAgIGxvb2tpbmcgdXAgdGhl IGlubmVyIERPTSB3aW5kb3cuCisKKyAgICAgICAgVW5mb3J0dW5hdGVseSwgd2UgY2Fubm90IHN0 b3JlIHRoZSBWOERPTVdpbmRvd1NoZWxsIGluIFY4UGVyQ29udGV4dERhdGEKKyAgICAgICAgYmVj YXVzZSB0aGUgVjhET01XaW5kb3dTaGVsbCBvdXRsaXZlcyB0aGUgVjhQZXJDb250ZXh0RGF0YS4g KFdlIGRlc3Ryb3kKKyAgICAgICAgdGhlIFY4UGVyQ29udGV4dERhdGEgd2hlbiB3ZSBkZXRhY2gg dGhlIFY4RE9NV2luZG93U2hlbGwgZnJvbSB0aGUKKyAgICAgICAgZnJhbWUuKQorCisgICAgICAg ICogYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG06CisgICAgICAgIChHZXRJbnRl cm5hbEZpZWxkcyk6CisgICAgICAgICogYmluZGluZ3MvdjgvVjhET01XaW5kb3dTaGVsbC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpWOERPTVdpbmRvd1NoZWxsOjppbml0aWFsaXplSWZOZWVkZWQp OgorICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4RE9NV2luZG93U2hlbGwuaDoKKyAgICAgICAgKFdl YkNvcmU6OlY4RE9NV2luZG93U2hlbGw6OmdldEVudGVyZWQpOgorICAgICAgICAqIGJpbmRpbmdz L3Y4L1Y4UGVyQ29udGV4dERhdGEuaDoKKworMjAxMi0xMS0xMiAgQWRhbSBCYXJ0aCAgPGFiYXJ0 aEB3ZWJraXQub3JnPgorCiAgICAgICAgIFtWOF0gVjhET01XcmFwcGVyOjppbnN0YW50aWF0ZVY4 T2JqZWN0IHNob3VsZG4ndCB1c2UgZGVwcmVjYXRlZERvY3VtZW50CiAgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDIwMTUKIApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0gYi9Tb3VyY2Uv V2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQppbmRleCBkMjNlMGFi Y2EyYTUzMzQyNzliM2MwNTdmZjZiYmU5YzJlYTRkYzg0Li41MDQxNjQxNzRjNWE4MjY0ZWMyYmI3 ZDRhODYyNDJjYTE3OGMwN2M0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9z Y3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9z Y3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQpAQCAtNjExLDkgKzYxMSw2IEBAIHN1YiBHZXRJbnRl cm5hbEZpZWxkcwogICAgICAgICBwdXNoKEBjdXN0b21JbnRlcm5hbEZpZWxkcywgImV2ZW50TGlz dGVuZXJDYWNoZUluZGV4Iik7CiAgICAgfQogCi0gICAgaWYgKCRuYW1lIGVxICJET01XaW5kb3ci KSB7Ci0gICAgICAgIHB1c2goQGN1c3RvbUludGVybmFsRmllbGRzLCAiZW50ZXJlZElzb2xhdGVk V29ybGRJbmRleCIpOwotICAgIH0KICAgICByZXR1cm4gQGN1c3RvbUludGVybmFsRmllbGRzOwog fQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTVdpbmRvd1No ZWxsLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9NV2luZG93U2hlbGwuY3Bw CmluZGV4IGE5ZGVjYWUzNzRiMjk4YWY5ZDQ2ZWQzOTc1YzViMzFkOWU5Yzg0MjAuLjM5MDBkODkz Nzc4NzdmZDRiNDM0ZjZlZDNiODhhZjQxYmEwODgzZTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL3Y4L1Y4RE9NV2luZG93U2hlbGwuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL3Y4L1Y4RE9NV2luZG93U2hlbGwuY3BwCkBAIC0xNjksMTYgKzE2OSw2IEBAIHN0 YXRpYyB2b2lkIGNoZWNrRG9jdW1lbnRXcmFwcGVyKHY4OjpIYW5kbGU8djg6Ok9iamVjdD4gd3Jh cHBlciwgRG9jdW1lbnQqIGRvY3VtCiAgICAgQVNTRVJUKCFkb2N1bWVudC0+aXNIVE1MRG9jdW1l bnQoKSB8fCAoVjhEb2N1bWVudDo6dG9OYXRpdmUodjg6OkhhbmRsZTx2ODo6T2JqZWN0Pjo6Q2Fz dCh3cmFwcGVyLT5HZXRQcm90b3R5cGUoKSkpID09IGRvY3VtZW50KSk7CiB9CiAKLXN0YXRpYyB2 b2lkIHNldElzb2xhdGVkV29ybGRGaWVsZChWOERPTVdpbmRvd1NoZWxsKiBzaGVsbCwgdjg6Okxv Y2FsPHY4OjpDb250ZXh0PiBjb250ZXh0KQotewotICAgIHRvSW5uZXJHbG9iYWxPYmplY3QoY29u dGV4dCktPlNldEFsaWduZWRQb2ludGVySW5JbnRlcm5hbEZpZWxkKFY4RE9NV2luZG93OjplbnRl cmVkSXNvbGF0ZWRXb3JsZEluZGV4LCBzaGVsbCk7Ci19Ci0KLVY4RE9NV2luZG93U2hlbGwqIFY4 RE9NV2luZG93U2hlbGw6OmVudGVyZWRJc29sYXRlZFdvcmxkQ29udGV4dCgpCi17Ci0gICAgcmV0 dXJuIHN0YXRpY19jYXN0PFY4RE9NV2luZG93U2hlbGwqPih0b0lubmVyR2xvYmFsT2JqZWN0KHY4 OjpDb250ZXh0OjpHZXRFbnRlcmVkKCkpLT5HZXRBbGlnbmVkUG9pbnRlckZyb21JbnRlcm5hbEZp ZWxkKFY4RE9NV2luZG93OjplbnRlcmVkSXNvbGF0ZWRXb3JsZEluZGV4KSk7Ci19Ci0KIHN0YXRp YyB2b2lkIHNldEluamVjdGVkU2NyaXB0Q29udGV4dERlYnVnSWQodjg6OkhhbmRsZTx2ODo6Q29u dGV4dD4gdGFyZ2V0Q29udGV4dCwgaW50IGRlYnVnSWQpCiB7CiAgICAgY2hhciBidWZmZXJbMzJd OwpAQCAtMzM5LDEyICszMjksMTIgQEAgYm9vbCBWOERPTVdpbmRvd1NoZWxsOjppbml0aWFsaXpl SWZOZWVkZWQoKQogICAgIH0KIAogICAgIGlmIChpc01haW5Xb3JsZCkKLSAgICAgICAgc2V0SXNv bGF0ZWRXb3JsZEZpZWxkKDAsIGNvbnRleHQpOworICAgICAgICBjb250ZXh0LT5TZXRBbGlnbmVk UG9pbnRlckluRW1iZWRkZXJEYXRhKHY4Q29udGV4dElzb2xhdGVkV2luZG93U2hlbGwsIDApOwog ICAgIGVsc2UgewogICAgICAgICBWOERPTVdpbmRvd1NoZWxsKiBtYWluV2luZG93ID0gbV9mcmFt ZS0+c2NyaXB0KCktPmV4aXN0aW5nV2luZG93U2hlbGwobWFpblRocmVhZE5vcm1hbFdvcmxkKCkp OwogICAgICAgICBpZiAobWFpbldpbmRvdyAmJiAhbWFpbldpbmRvdy0+Y29udGV4dCgpLklzRW1w dHkoKSkKICAgICAgICAgICAgIHNldEluamVjdGVkU2NyaXB0Q29udGV4dERlYnVnSWQobV9jb250 ZXh0LmdldCgpLCBtX2ZyYW1lLT5zY3JpcHQoKS0+Y29udGV4dERlYnVnSWQobWFpbldpbmRvdy0+ Y29udGV4dCgpKSk7Ci0gICAgICAgIHNldElzb2xhdGVkV29ybGRGaWVsZCh0aGlzLCBjb250ZXh0 KTsKKyAgICAgICAgY29udGV4dC0+U2V0QWxpZ25lZFBvaW50ZXJJbkVtYmVkZGVyRGF0YSh2OENv bnRleHRJc29sYXRlZFdpbmRvd1NoZWxsLCB0aGlzKTsKICAgICB9CiAKICAgICBtX3BlckNvbnRl eHREYXRhID0gVjhQZXJDb250ZXh0RGF0YTo6Y3JlYXRlKG1fY29udGV4dC5nZXQoKSk7CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTVdpbmRvd1NoZWxsLmggYi9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTVdpbmRvd1NoZWxsLmgKaW5kZXggOTVmNjE4 ZmUxOTgyOWZjMDFiZTcyNWUzZTMyODEwZDVkOGE0ZDIwZS4uY2RiNjg3YmI3ZjU4MzhiNGQyYzJj MjZlNTkwMzEyMjE2YzA3ZmQ4ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv djgvVjhET01XaW5kb3dTaGVsbC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4 RE9NV2luZG93U2hlbGwuaApAQCAtOTksNyArOTksNyBAQCBwdWJsaWM6CiAgICAgICAgICAgICBy ZXR1cm4gMDsKICAgICAgICAgaWYgKCF2ODo6Q29udGV4dDo6SW5Db250ZXh0KCkpCiAgICAgICAg ICAgICByZXR1cm4gMDsKLSAgICAgICAgcmV0dXJuIGVudGVyZWRJc29sYXRlZFdvcmxkQ29udGV4 dCgpOworICAgICAgICByZXR1cm4gc3RhdGljX2Nhc3Q8VjhET01XaW5kb3dTaGVsbCo+KHY4OjpD b250ZXh0OjpHZXRFbnRlcmVkKCktPkdldEFsaWduZWRQb2ludGVyRnJvbUVtYmVkZGVyRGF0YSh2 OENvbnRleHRJc29sYXRlZFdpbmRvd1NoZWxsKSk7CiAgICAgfQogCiAgICAgdm9pZCBkZXN0cm95 SXNvbGF0ZWRTaGVsbCgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvdjgv VjhQZXJDb250ZXh0RGF0YS5oIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhQZXJDb250 ZXh0RGF0YS5oCmluZGV4IDM5NzlmOWEzN2RkNjZkOTQ2OWQyMzUzNzBiODQyNWFjMjIyMTcxNzQu LmEzM2NlY2VlMzVlNWQyMTBkMzlkZDhmZTViOGJkYzQ1ODUyOTI5NDEgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4UGVyQ29udGV4dERhdGEuaAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9iaW5kaW5ncy92OC9WOFBlckNvbnRleHREYXRhLmgKQEAgLTQ2LDcgKzQ2LDggQEAg dHlwZWRlZiBXVEY6Okhhc2hNYXA8aW50LCBWOE5QT2JqZWN0VmVjdG9yPiBWOE5QT2JqZWN0TWFw OwogCiBlbnVtIFY4Q29udGV4dEVtYmVkZGVyRGF0YUZpZWxkIHsKICAgICB2OENvbnRleHREZWJ1 Z0lkSW5kZXgsCi0gICAgdjhDb250ZXh0UGVyQ29udGV4dERhdGFJbmRleAorICAgIHY4Q29udGV4 dFBlckNvbnRleHREYXRhSW5kZXgsCisgICAgdjhDb250ZXh0SXNvbGF0ZWRXaW5kb3dTaGVsbCwK ICAgICAvLyBSYXRoZXIgdGhhbiBhZGRpbmcgbW9yZSBlbWJlZGRlciBkYXRhIGZpZWxkcyB0byB2 ODo6Q29udGV4dCwKICAgICAvLyBjb25zaWRlciBhZGRpbmcgdGhlIGRhdGEgdG8gVjhQZXJDb250 ZXh0RGF0YSBpbnN0ZWFkLgogfTsK