102011 2012-11-12 16:57:35 -0800 [TEXMAP] Check imageBuffer Creation failure when updateBackingStore 2022-06-21 20:12:21 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 146147 P2 Normal --- 0 ys.suh webkit-unassigned fujii noam webkit.review.bot oldest_to_newest 764979 0 ys.suh 2012-11-12 16:57:35 -0800 [TEXMAP] Check imageBuffer Creation failure when updateBackingStore 764998 1 173763 ys.suh 2012-11-12 17:11:03 -0800 Created attachment 173763 Patch 765022 2 173763 noam 2012-11-12 17:28:37 -0800 Comment on attachment 173763 Patch The right way to fix it is to tile the dirtyRects before uploading them. Your fix will create bugs along the way, like "Why does this layer not appear correctly on the screen" :) 765058 3 ys.suh 2012-11-12 18:00:42 -0800 (In reply to comment #2) > (From update of attachment 173763 [details]) > The right way to fix it is to tile the dirtyRects before uploading them. > Your fix will create bugs along the way, like "Why does this layer not appear correctly on the screen" :) I totally agree with you. But in my opinion, not appearing layer would be better than crashing. How about clipping the layer to some size just before calling setCompositedBounds in RenderLayerBacking::updateCompositedBounds? 766046 4 noam 2012-11-13 14:15:59 -0800 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 173763 [details] [details]) > > The right way to fix it is to tile the dirtyRects before uploading them. > > Your fix will create bugs along the way, like "Why does this layer not appear correctly on the screen" :) > > I totally agree with you. But in my opinion, not appearing layer would be better than crashing. Maybe for a production branch - in webkit.org trunk we hold a higher standard - meaning a patch has to take things forward, not replace a bug with one symptom (crash) with a bug with another symptom (layers not appearing). > > How about clipping the layer to some size just before calling setCompositedBounds in RenderLayerBacking::updateCompositedBounds? It's another hack. I will only accepts patches that take this code forward - workarounds only in extreme cases where the "good" solution is not trivial. 1877201 5 fujii 2022-06-21 20:12:21 -0700 *** This bug has been marked as a duplicate of bug 146147 *** 173763 2012-11-12 17:11:03 -0800 2012-11-12 17:28:37 -0800 Patch bug-102011-20121113100904.patch text/plain 1806 ys.suh U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0MTY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmNiMjdkNDRhMTczMzA0 ODFjZmY2NzcyZTQ5ODAwZTFjNDRlZTYxNy4uNzA4OWRlMDQ5NGI3YmM1NzcxMzVmNTc0NzQwMzcw NTYzNmNhYmZlYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTExLTEyICBZb3Vu Z3N1biBTdWggIDx5cy5zdWhAbGdlLmNvbT4KKworICAgICAgICBbVEVYTUFQXSBDaGVjayBpbWFn ZUJ1ZmZlciBDcmVhdGlvbiBmYWlsdXJlIHdoZW4gdXBkYXRlQmFja2luZ1N0b3JlCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDIwMTEKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJZiB0aGUgbGF5ZXIgc2l6 ZSBpcyB0b28gQklHKGV4OiB3aWR0aDoxMDAwMDBweCksIGJyb3dzZXIgY3Jhc2hzLgorICAgICAg ICBUaGlzIHBhdGNoIGFkZGVkIGEgY3JlYXRpb24gZmFpbHVyZSBjaGVjayB0byBwcmV2ZW50IGNy YXNoLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJM YXllci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpUZXh0dXJlTWFwcGVyTGF5ZXI6OnVwZGF0ZUJh Y2tpbmdTdG9yZSk6CisKIDIwMTItMTEtMTAgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5i b3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxMzQwNjku CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4 dHVyZU1hcHBlckxheWVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3Rl eG1hcC9UZXh0dXJlTWFwcGVyTGF5ZXIuY3BwCmluZGV4IGZlNmI2YzBlMWVlOTUwNzUyNzEwMjBl N2E3ZDQ0NTM4YzJkYmU4MjguLjBjMzIwMWNjNjRlZDNiOTU3ZmEzZjdiOWEzZjFmNjVjMzM2YTlh ZGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9U ZXh0dXJlTWFwcGVyTGF5ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyTGF5ZXIuY3BwCkBAIC0xMjMsNiArMTIzLDExIEBAIHZv aWQgVGV4dHVyZU1hcHBlckxheWVyOjp1cGRhdGVCYWNraW5nU3RvcmUoVGV4dHVyZU1hcHBlciog dGV4dHVyZU1hcHBlciwgR3JhcGhpCiAKICAgICAvLyBQYWludCB0aGUgZW50aXJlIGRpcnR5IHJl Y3QgaW50byBhbiBpbWFnZSBidWZmZXIuIFRoaXMgZW5zdXJlcyB3ZSBvbmx5IHBhaW50IG9uY2Uu CiAgICAgT3duUHRyPEltYWdlQnVmZmVyPiBpbWFnZUJ1ZmZlciA9IEltYWdlQnVmZmVyOjpjcmVh dGUoZGlydHlSZWN0LnNpemUoKSk7CisgICAgaWYgKCFpbWFnZUJ1ZmZlci5nZXQoKSkgeworICAg ICAgICBtX2JhY2tpbmdTdG9yZS5jbGVhcigpOworICAgICAgICByZXR1cm47CisgICAgfQorCiAg ICAgR3JhcGhpY3NDb250ZXh0KiBjb250ZXh0ID0gaW1hZ2VCdWZmZXItPmNvbnRleHQoKTsKICAg ICBjb250ZXh0LT5zZXRJbWFnZUludGVycG9sYXRpb25RdWFsaXR5KHRleHR1cmVNYXBwZXItPmlt YWdlSW50ZXJwb2xhdGlvblF1YWxpdHkoKSk7CiAgICAgY29udGV4dC0+c2V0VGV4dERyYXdpbmdN b2RlKHRleHR1cmVNYXBwZXItPnRleHREcmF3aW5nTW9kZSgpKTsK