102008 2012-11-12 16:37:47 -0800 [V8] We should be able to get V8PerContextData from a v8::Context more quickly 2012-11-16 11:13:44 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth eric haraken japhet ojan webkit.review.bot oldest_to_newest 764960 0 abarth 2012-11-12 16:37:47 -0800 [V8] We should be able to get V8PerContextData from a v8::Context more quickly 764964 1 173760 abarth 2012-11-12 16:39:51 -0800 Created attachment 173760 Patch 765173 2 173760 webkit.review.bot 2012-11-12 20:46:53 -0800 Comment on attachment 173760 Patch Clearing flags on attachment: 173760 Committed r134351: <http://trac.webkit.org/changeset/134351> 765174 3 webkit.review.bot 2012-11-12 20:46:57 -0800 All reviewed patches have been landed. Closing bug. 765767 4 ojan 2012-11-13 10:25:24 -0800 It's hard to be sure it was this patch, but it looks like this was a 18% improvement on dromaeo_jslibeventprototype/jslib_event_prototype_Prototype___fire: http://build.chromium.org/f/chromium/perf/chromium-rel-win7-webkit/dromaeo_jslibeventprototype/report.html?graph=jslib_event_prototype_Prototype___fire&history=150&rev=167405 769483 5 ojan 2012-11-16 11:13:44 -0800 8% improvement on http://build.chromium.org/f/chromium/perf/linux-release-webkit-latest/dromaeo_jslibstylejquery/report.html?rev=167458&graph=jslib_style_jquery_jQuery____is__visible_&history=150 10% improvement on http://build.chromium.org/f/chromium/perf/linux-release-webkit-latest/dromaeo_jslibstylejquery/report.html?rev=167602&graph=jslib_style_jquery_jQuery____show__&history=150 11% improvement on http://build.chromium.org/f/chromium/perf/linux-release-webkit-latest/dromaeo_jslibstylejquery/report.html?rev=167628&graph=jslib_style_jquery_jQuery___css_color__x100&history=150 There's a bunch more, but collating them all is too time consuming. Nice patch! 173760 2012-11-12 16:39:51 -0800 2012-11-12 20:46:53 -0800 Patch bug-102008-20121112163753.patch text/plain 4701 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0MzIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmQ1N2NhMGY2OWMwNGE1 M2IzMjI2ZWZlZjgzYjg1MWFhNGQxNTk5YS4uMGJjZTE0ZGNhOTBlNmMxYTZkOTI1ZmMxMGE5Y2Vj MWU2MGU2MzYwMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI1IEBACiAyMDEyLTExLTEyICBBZGFt IEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKKyAgICAgICAgW1Y4XSBXZSBzaG91bGQgYmUg YWJsZSB0byBnZXQgVjhQZXJDb250ZXh0RGF0YSBmcm9tIGEgdjg6OkNvbnRleHQgbW9yZSBxdWlj a2x5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDIw MDgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlz IHBhdGNoIHVzZXMgdGhlIG5ldyB2ODo6Q29udGV4dDo6R2V0QWxpZ25lZFBvaW50ZXJGcm9tRW1i ZWRkZXJEYXRhCisgICAgICAgIEFQSSB0byBnZXQgdGhlIFY4UGVyQ29udGV4dERhdGEgYXNzb2Np YXRlZCB3aXRoIGEgdjg6OkNvbnRleHQgbXVjaCBtb3JlCisgICAgICAgIHF1aWNrbHkuIFdlIG5v IGxvbmdlciBuZWVkIHRvIHVzZSBhIGhpZGRlbiBwcm9wZXJ0eSBvbiB0aGUgaW5uZXIgZ2xvYmFs CisgICAgICAgIG9iamVjdC4gVGhpcyBwYXRjaCB3aWxsIGVuYWJsZSBmdXR1cmUgb3B0aW1pemF0 aW9ucy4KKworICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4SGlkZGVuUHJvcGVydHlOYW1lLmg6Cisg ICAgICAgIChXZWJDb3JlKToKKyAgICAgICAgKiBiaW5kaW5ncy92OC9WOFBlckNvbnRleHREYXRh LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlY4UGVyQ29udGV4dERhdGE6OmRpc3Bvc2UpOgorICAg ICAgICAoV2ViQ29yZTo6VjhQZXJDb250ZXh0RGF0YTo6aW5pdCk6CisgICAgICAgICogYmluZGlu Z3MvdjgvVjhQZXJDb250ZXh0RGF0YS5oOgorICAgICAgICAoV2ViQ29yZTo6VjhQZXJDb250ZXh0 RGF0YTo6ZnJvbSk6CisKKzIwMTItMTEtMTIgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9y Zz4KKwogICAgICAgICBbVjhdIFVwZGF0ZSBjYWxsZXJzIHRvIHVzZSB0aGUgYWxpZ25lZCBwb2lu dGVyIEFQSSByYXRoZXIgdGhhbiB0aGUgZGVwcmVjYXRlZCB1bmFsaWduZWQgcG9pbnRlciBBUEkK ICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMTUxOQog CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOEhpZGRlblByb3BlcnR5 TmFtZS5oIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhIaWRkZW5Qcm9wZXJ0eU5hbWUu aAppbmRleCBlMWE1NGVhOWEyOWQ1MWQ5ODQ0ZGY4YzA3ZTFlNjg1NWYzMjlmNTEzLi4yZjM3OWQw OWYyMzIwODliNjg0N2Q3ZDVhZTAxZThmNGRmM2YzMjhlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy92OC9WOEhpZGRlblByb3BlcnR5TmFtZS5oCisrKyBiL1NvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL3Y4L1Y4SGlkZGVuUHJvcGVydHlOYW1lLmgKQEAgLTQ0LDcgKzQ0LDYgQEAg bmFtZXNwYWNlIFdlYkNvcmUgewogICAgIFYoZXZlbnQpIFwKICAgICBWKGxpc3RlbmVyKSBcCiAg ICAgVihvd25lck5vZGUpIFwKLSAgICBWKHBlckNvbnRleHREYXRhKSBcCiAgICAgVihzY3JpcHRT dGF0ZSkgXAogICAgIFYoc2xlZXBGdW5jdGlvbikgXAogICAgIFYoc3RhdGUpIFwKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4UGVyQ29udGV4dERhdGEuY3BwIGIvU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhQZXJDb250ZXh0RGF0YS5jcHAKaW5kZXggMmEyNmYw ZTJkNWJmMTE5Zjc0NGE5ZThkMDgzNTQzZTRhYTA2MjRjZi4uNGM1OGZjMDQwYTJkMTBjMmI5MDkx ZjAxOTI1ZTI5NjUzZjQ4ZDhmMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv djgvVjhQZXJDb250ZXh0RGF0YS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvdjgv VjhQZXJDb250ZXh0RGF0YS5jcHAKQEAgLTMyLDIzICszMiwxNCBAQAogI2luY2x1ZGUgIlY4UGVy Q29udGV4dERhdGEuaCIKIAogI2luY2x1ZGUgIlY4QmluZGluZy5oIgotI2luY2x1ZGUgIlY4SGlk ZGVuUHJvcGVydHlOYW1lLmgiCiAjaW5jbHVkZSAiVjhPYmplY3RDb25zdHJ1Y3Rvci5oIgogCiBu YW1lc3BhY2UgV2ViQ29yZSB7CiAKLVY4UGVyQ29udGV4dERhdGEqIFY4UGVyQ29udGV4dERhdGE6 OmZyb20odjg6OkhhbmRsZTx2ODo6Q29udGV4dD4gY29udGV4dCkKLXsKLSAgICB2ODo6SGFuZGxl PHY4OjpWYWx1ZT4gd3JhcHBlZFBlckNvbnRleHREYXRhID0gdG9Jbm5lckdsb2JhbE9iamVjdChj b250ZXh0KS0+R2V0SGlkZGVuVmFsdWUoVjhIaWRkZW5Qcm9wZXJ0eU5hbWU6OnBlckNvbnRleHRE YXRhKCkpOwotICAgIGlmICh3cmFwcGVkUGVyQ29udGV4dERhdGEuSXNFbXB0eSgpKQotICAgICAg ICByZXR1cm4gMDsKLSAgICByZXR1cm4gc3RhdGljX2Nhc3Q8VjhQZXJDb250ZXh0RGF0YSo+KHY4 OjpFeHRlcm5hbDo6VW53cmFwKHdyYXBwZWRQZXJDb250ZXh0RGF0YSkpOwotfQotCiB2b2lkIFY4 UGVyQ29udGV4dERhdGE6OmRpc3Bvc2UoKQogewogICAgIHY4OjpIYW5kbGVTY29wZSBoYW5kbGVT Y29wZTsKLSAgICB0b0lubmVyR2xvYmFsT2JqZWN0KG1fY29udGV4dCktPkRlbGV0ZUhpZGRlblZh bHVlKFY4SGlkZGVuUHJvcGVydHlOYW1lOjpwZXJDb250ZXh0RGF0YSgpKTsKKyAgICBtX2NvbnRl eHQtPlNldEFsaWduZWRQb2ludGVySW5FbWJlZGRlckRhdGEodjhDb250ZXh0UGVyQ29udGV4dERh dGFJbmRleCwgMCk7CiAKICAgICB7CiAgICAgICAgIFdyYXBwZXJCb2lsZXJwbGF0ZU1hcDo6aXRl cmF0b3IgaXQgPSBtX3dyYXBwZXJCb2lsZXJwbGF0ZXMuYmVnaW4oKTsKQEAgLTg4LDcgKzc5LDcg QEAgdm9pZCBWOFBlckNvbnRleHREYXRhOjpkaXNwb3NlKCkKIAogYm9vbCBWOFBlckNvbnRleHRE YXRhOjppbml0KCkKIHsKLSAgICB0b0lubmVyR2xvYmFsT2JqZWN0KG1fY29udGV4dCktPlNldEhp ZGRlblZhbHVlKFY4SGlkZGVuUHJvcGVydHlOYW1lOjpwZXJDb250ZXh0RGF0YSgpLCB2ODo6RXh0 ZXJuYWw6OldyYXAodGhpcykpOworICAgIG1fY29udGV4dC0+U2V0QWxpZ25lZFBvaW50ZXJJbkVt YmVkZGVyRGF0YSh2OENvbnRleHRQZXJDb250ZXh0RGF0YUluZGV4LCB0aGlzKTsKIAogICAgIHY4 OjpIYW5kbGU8djg6OlN0cmluZz4gcHJvdG90eXBlU3RyaW5nID0gdjg6OlN0cmluZzo6TmV3U3lt Ym9sKCJwcm90b3R5cGUiKTsKICAgICBpZiAocHJvdG90eXBlU3RyaW5nLklzRW1wdHkoKSkKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4UGVyQ29udGV4dERhdGEuaCBi L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4UGVyQ29udGV4dERhdGEuaAppbmRleCA4YzNj NDM3ZTI4YzA4MzFkZDAzMTU5MTQ2MDI3NTBmYjY1M2Y1MjA0Li4zOTc5ZjlhMzdkZDY2ZDk0Njlk MjM1MzcwYjg0MjVhYzIyMjE3MTc0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy92OC9WOFBlckNvbnRleHREYXRhLmgKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvdjgv VjhQZXJDb250ZXh0RGF0YS5oCkBAIC00NCw2ICs0NCwxMyBAQCBzdHJ1Y3QgVjhOUE9iamVjdDsK IHR5cGVkZWYgV1RGOjpWZWN0b3I8VjhOUE9iamVjdCo+IFY4TlBPYmplY3RWZWN0b3I7CiB0eXBl ZGVmIFdURjo6SGFzaE1hcDxpbnQsIFY4TlBPYmplY3RWZWN0b3I+IFY4TlBPYmplY3RNYXA7CiAK K2VudW0gVjhDb250ZXh0RW1iZWRkZXJEYXRhRmllbGQgeworICAgIHY4Q29udGV4dERlYnVnSWRJ bmRleCwKKyAgICB2OENvbnRleHRQZXJDb250ZXh0RGF0YUluZGV4CisgICAgLy8gUmF0aGVyIHRo YW4gYWRkaW5nIG1vcmUgZW1iZWRkZXIgZGF0YSBmaWVsZHMgdG8gdjg6OkNvbnRleHQsCisgICAg Ly8gY29uc2lkZXIgYWRkaW5nIHRoZSBkYXRhIHRvIFY4UGVyQ29udGV4dERhdGEgaW5zdGVhZC4K K307CisKIGNsYXNzIFY4UGVyQ29udGV4dERhdGEgewogcHVibGljOgogICAgIHN0YXRpYyBQYXNz T3duUHRyPFY4UGVyQ29udGV4dERhdGE+IGNyZWF0ZSh2ODo6UGVyc2lzdGVudDx2ODo6Q29udGV4 dD4gY29udGV4dCkKQEAgLTU4LDcgKzY1LDEwIEBAIHB1YmxpYzoKIAogICAgIGJvb2wgaW5pdCgp OwogCi0gICAgc3RhdGljIFY4UGVyQ29udGV4dERhdGEqIGZyb20odjg6OkhhbmRsZTx2ODo6Q29u dGV4dD4pOworICAgIHN0YXRpYyBWOFBlckNvbnRleHREYXRhKiBmcm9tKHY4OjpIYW5kbGU8djg6 OkNvbnRleHQ+IGNvbnRleHQpCisgICAgeworICAgICAgICByZXR1cm4gc3RhdGljX2Nhc3Q8VjhQ ZXJDb250ZXh0RGF0YSo+KGNvbnRleHQtPkdldEFsaWduZWRQb2ludGVyRnJvbUVtYmVkZGVyRGF0 YSh2OENvbnRleHRQZXJDb250ZXh0RGF0YUluZGV4KSk7CisgICAgfQogCiAgICAgLy8gVG8gY3Jl YXRlIEpTIFdyYXBwZXIgb2JqZWN0cywgd2UgY3JlYXRlIGEgY2FjaGUgb2YgYSAnYm9pbGVyIHBs YXRlJwogICAgIC8vIG9iamVjdCwgYW5kIHRoZW4gc2ltcGx5IENsb25lIHRoYXQgb2JqZWN0IGVh Y2ggdGltZSB3ZSBuZWVkIGEgbmV3IG9uZS4K