101996 2012-11-12 14:53:25 -0800 IndexedDB: storage/indexeddb/mozilla/add-twice-failure.html is flaky following r134252 2012-11-13 10:46:11 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jsbell jsbell alecflett dgrogan tony webkit.review.bot oldest_to_newest 764855 0 jsbell 2012-11-12 14:53:25 -0800 Flakiness dashboard link: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=storage%2Findexeddb%2Fmozilla%2Fadd-twice-failure.html Flaky diff: PASS request.result is key request = objectStore.add({}, key); PASS event.target.errorCode is IDBDatabaseException.CONSTRAINT_ERR +FAIL Abort function called unexpectedly! +FAIL Error function called unexpectedly: (AbortError) Version change transaction was aborted in upgradeneeded event handler. PASS successfullyParsed is true Cause: This was added to the test: event.target.transaction.onabort = unexpectedAbortCallback The test induces an error but doesn't prevent the default, so it will bubble up and be caught by this. It's flaky because this may or may not occur before the test output is captured. Trivial fix is to prevent the default. 764861 1 173735 jsbell 2012-11-12 14:59:36 -0800 Created attachment 173735 Patch 764862 2 jsbell 2012-11-12 14:59:52 -0800 dgrogan@ - please take a look? 764868 3 173735 dgrogan 2012-11-12 15:05:08 -0800 Comment on attachment 173735 Patch LGTM 764869 4 jsbell 2012-11-12 15:05:45 -0800 tony@ - r? cq? 765137 5 173735 webkit.review.bot 2012-11-12 19:39:12 -0800 Comment on attachment 173735 Patch Rejecting attachment 173735 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: webkit-commit-queue/Source/WebKit/chromium/webkit --revision 167263 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 51>At revision 167263. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/14813601 765653 6 173904 jsbell 2012-11-13 08:49:16 -0800 Created attachment 173904 Patch 765793 7 173904 webkit.review.bot 2012-11-13 10:46:08 -0800 Comment on attachment 173904 Patch Clearing flags on attachment: 173904 Committed r134439: <http://trac.webkit.org/changeset/134439> 765794 8 webkit.review.bot 2012-11-13 10:46:11 -0800 All reviewed patches have been landed. Closing bug. 173735 2012-11-12 14:59:36 -0800 2012-11-13 08:49:15 -0800 Patch bug-101996-20121112145738.patch text/plain 1530 jsbell U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0MzA0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNzQ5ZWUzNTQzYmViYTcxNTc4ODAy MWMzNWYxZGIzYTkxNzc1M2M1ZS4uMDUyZDc0NGFlZmZhNGE2OWZlYzYzMzI4NGZjYzg4M2ZkNDRi MGEwYyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTExLTEyICBKb3NodWEgQmVsbCAgPGpz YmVsbEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgSW5kZXhlZERCOiBzdG9yYWdlL2luZGV4ZWRk Yi9tb3ppbGxhL2FkZC10d2ljZS1mYWlsdXJlLmh0bWwgaXMgZmxha3kgZm9sbG93aW5nIHIxMzQy NTIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMTk5 NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEVycm9y IGJlaW5nIHRlc3RlZCBtYXkgY2F1c2UgdHJhbnNhY3Rpb24gdG8gYWJvcnQsIHdoaWNoIGNvdWxk IGhhcHBlbiBiZWZvcmUgb3IgYWZ0ZXIKKyAgICAgICAgdGVzdCBvdXRwdXQgaXMgY2FwdHVyZWQu IFByZXZlbnQgZGVmYXVsdCBiZWhhdmlvciBvZiB0aGUgZXJyb3Igc28gdGhpcyBkb2Vzbid0IGhh cHBlbi4KKworICAgICAgICAqIHN0b3JhZ2UvaW5kZXhlZGRiL21vemlsbGEvcmVzb3VyY2VzL2Fk ZC10d2ljZS1mYWlsdXJlLmpzOgorICAgICAgICAoYWRkU2Vjb25kRXhwZWN0ZWRFcnJvcik6CisK IDIwMTItMTEtMTIgIERpbWl0cmkgR2xhemtvdiAgPGRnbGF6a292QGNocm9taXVtLm9yZz4KIAog ICAgICAgICBNYXJrZWQgdHJhbnNmb3Jtcy8zZC9wb2ludC1tYXBwaW5nIHRlc3RzIGFzIGZsYWtl eS4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRiL21vemlsbGEvcmVz b3VyY2VzL2FkZC10d2ljZS1mYWlsdXJlLmpzIGIvTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVk ZGIvbW96aWxsYS9yZXNvdXJjZXMvYWRkLXR3aWNlLWZhaWx1cmUuanMKaW5kZXggMDQxMWY0NmNk OWUwYTRhZDg3MDAzZDFhMzgwMDgwNGQ3ZTgyNTNkNi4uMjVmMjZlODJiMTA3NjA0OTU3OWQwMDJl YzRmMDVmMjY1M2UyZTgxMyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVk ZGIvbW96aWxsYS9yZXNvdXJjZXMvYWRkLXR3aWNlLWZhaWx1cmUuanMKKysrIGIvTGF5b3V0VGVz dHMvc3RvcmFnZS9pbmRleGVkZGIvbW96aWxsYS9yZXNvdXJjZXMvYWRkLXR3aWNlLWZhaWx1cmUu anMKQEAgLTM1LDUgKzM1LDYgQEAgZnVuY3Rpb24gYWRkRmlyc3RTdWNjZXNzKCkKIGZ1bmN0aW9u IGFkZFNlY29uZEV4cGVjdGVkRXJyb3IoKQogewogICAgIHNob3VsZEJlKCJldmVudC50YXJnZXQu ZXJyb3JDb2RlIiwgIklEQkRhdGFiYXNlRXhjZXB0aW9uLkNPTlNUUkFJTlRfRVJSIik7CisgICAg ZXZlbnQucHJldmVudERlZmF1bHQoKTsKICAgICBmaW5pc2hKU1Rlc3QoKTsKIH0K 173904 2012-11-13 08:49:16 -0800 2012-11-13 10:46:08 -0800 Patch bug-101996-20121113084717.patch text/plain 1545 jsbell U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0Mzc2CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMWEyZWExZGZiOTdkMDZiZmYwYzky MGMzZDg2ZjY5ZWZhZDJhMmFjYy4uOGU1MWMwZmE5ZGFjODE4M2NmNmJlODFhMTE0NDgzOTViZTFk NmQ5MiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTExLTEyICBKb3NodWEgQmVsbCAgPGpz YmVsbEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgSW5kZXhlZERCOiBzdG9yYWdlL2luZGV4ZWRk Yi9tb3ppbGxhL2FkZC10d2ljZS1mYWlsdXJlLmh0bWwgaXMgZmxha3kgZm9sbG93aW5nIHIxMzQy NTIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMTk5 NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEVycm9y IGJlaW5nIHRlc3RlZCBtYXkgY2F1c2UgdHJhbnNhY3Rpb24gdG8gYWJvcnQsIHdoaWNoIGNvdWxk IGhhcHBlbiBiZWZvcmUgb3IgYWZ0ZXIKKyAgICAgICAgdGVzdCBvdXRwdXQgaXMgY2FwdHVyZWQu IFByZXZlbnQgZGVmYXVsdCBiZWhhdmlvciBvZiB0aGUgZXJyb3Igc28gdGhpcyBkb2Vzbid0IGhh cHBlbi4KKworICAgICAgICAqIHN0b3JhZ2UvaW5kZXhlZGRiL21vemlsbGEvcmVzb3VyY2VzL2Fk ZC10d2ljZS1mYWlsdXJlLmpzOgorICAgICAgICAoYWRkU2Vjb25kRXhwZWN0ZWRFcnJvcik6CisK IDIwMTItMTEtMTIgIFNoaW55YSBLYXdhbmFrYSAgPHNoaW55YWtAY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIENoYW5naW5nIGlkLCBjbGFzc05hbWUsIG9yIGF0dHJpYnV0ZSBzaG91bGQgaW52YWxp ZGF0ZSBkaXN0cmlidXRpb24KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhl ZGRiL21vemlsbGEvcmVzb3VyY2VzL2FkZC10d2ljZS1mYWlsdXJlLmpzIGIvTGF5b3V0VGVzdHMv c3RvcmFnZS9pbmRleGVkZGIvbW96aWxsYS9yZXNvdXJjZXMvYWRkLXR3aWNlLWZhaWx1cmUuanMK aW5kZXggMDQxMWY0NmNkOWUwYTRhZDg3MDAzZDFhMzgwMDgwNGQ3ZTgyNTNkNi4uMjVmMjZlODJi MTA3NjA0OTU3OWQwMDJlYzRmMDVmMjY1M2UyZTgxMyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMv c3RvcmFnZS9pbmRleGVkZGIvbW96aWxsYS9yZXNvdXJjZXMvYWRkLXR3aWNlLWZhaWx1cmUuanMK KysrIGIvTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIvbW96aWxsYS9yZXNvdXJjZXMvYWRk LXR3aWNlLWZhaWx1cmUuanMKQEAgLTM1LDUgKzM1LDYgQEAgZnVuY3Rpb24gYWRkRmlyc3RTdWNj ZXNzKCkKIGZ1bmN0aW9uIGFkZFNlY29uZEV4cGVjdGVkRXJyb3IoKQogewogICAgIHNob3VsZEJl KCJldmVudC50YXJnZXQuZXJyb3JDb2RlIiwgIklEQkRhdGFiYXNlRXhjZXB0aW9uLkNPTlNUUkFJ TlRfRVJSIik7CisgICAgZXZlbnQucHJldmVudERlZmF1bHQoKTsKICAgICBmaW5pc2hKU1Rlc3Qo KTsKIH0K