101995 2012-11-12 14:40:27 -0800 Please reinstate --pixel 2013-01-16 12:29:28 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED NRWT P2 Normal --- 1 simon.fraser zan abarth dpranke eric simon.fraser webkit.review.bot zan oldest_to_newest 764846 0 simon.fraser 2012-11-12 14:40:27 -0800 run-webkit-tests --pixel is hard-wired in my brain, and was in ORWT for years. Please put it back. 764957 1 dpranke 2012-11-12 16:36:06 -0800 ORWT supports --pixel-tests, and NRWT supports -p and --pixel-tests; I think the fact that --pixel worked is a side-effect of the way that Perl supports things (unique prefixes for an arg will work), but Python's standard option parsing doesn't do that. We can add in a --pixel synonym for -p or --pixel-tests, but you're the first person that's complained about this. Are you sure you can't rewire your brain to support the shorter -p ? 764993 2 simon.fraser 2012-11-12 17:06:20 -0800 mitz has also complained about this. I guess i can try getting used to -p. 765001 3 dpranke 2012-11-12 17:12:59 -0800 to be clear: I'm happy to add this (it's one line or less) if there's really a need, but it seems kinda silly. 765015 4 simon.fraser 2012-11-12 17:19:36 -0800 The strongest argument I have is that ORWT had this for years, and as a result some people expect it to work. 765018 5 dpranke 2012-11-12 17:25:18 -0800 My only hesitation is that since perl supported *any* unique prefix, I'm not sure how many different versions to add. Is "--pixel" enough? Are there other switches that need similar shortcuts? 765035 6 simon.fraser 2012-11-12 17:39:32 -0800 This is the only one I habitually type in and have it not work (though I get confused about --new-baseline vs. --new-baselines). 808199 7 182943 zan 2013-01-16 02:19:39 -0800 Created attachment 182943 Patch 808604 8 182943 dpranke 2013-01-16 12:15:28 -0800 Comment on attachment 182943 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182943&action=review > Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:136 > + optparse.make_option("-p", "--pixel", "--pixel-tests", action="store_true", I didn't realize that worked; I always assumed it was one short and one long :) . 808610 9 182943 webkit.review.bot 2013-01-16 12:29:24 -0800 Comment on attachment 182943 Patch Clearing flags on attachment: 182943 Committed r139912: <http://trac.webkit.org/changeset/139912> 808611 10 webkit.review.bot 2013-01-16 12:29:28 -0800 All reviewed patches have been landed. Closing bug. 182943 2013-01-16 02:19:39 -0800 2013-01-16 12:29:24 -0800 Patch bug-101995-20130116111640.patch text/plain 1984 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5ODUzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzU5OGM1MWM4Y2IyMTk4ZmI1M2RjYWMxODVlYWUzMmJh YzQ2YjllMi4uYWQzMWQ0MTRjZDcxNDQxNzA1ZDRkNjBkNTc5ZGI2OGEyYzE3MTc2ZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDEzLTAxLTE2ICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKwor ICAgICAgICBQbGVhc2UgcmVpbnN0YXRlIC0tcGl4ZWwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMTk5NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCB0aGUgJy0tcGl4ZWwnIGFuZCAnLS1uby1waXhl bCcgb3B0aW9ucyBmb3IgTlJXVCBhcyBhbGlhc2VzIGZvcgorICAgICAgICB0aGUgJy0tcGl4ZWwt dGVzdHMnIChvciAnLXAnKSBhbmQgJy0tbm8tcGl4ZWwtdGVzdHMnIG9wdGlvbnMgcmVzcGVjdGl2 ZWx5LgorICAgICAgICBTb21lIGRldmVsb3BlcnMgYXJlIHN0aWxsIHVzZWQgdG8gdGhlc2Ugb3B0 aW9ucyB0aGF0IHdlcmUgYXZhaWxhYmxlIGluIHRoZSBPUldULgorCisgICAgICAgICogU2NyaXB0 cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weToKKyAgICAgICAgKHBh cnNlX2FyZ3MpOgorCiAyMDEzLTAxLTE2ICBKb2NoZW4gRWlzaW5nZXIgIDxqb2NoZW5AY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFtjaHJvbWl1bV0gYWRkIHRpdGxlIHRleHQgZGlyZWN0aW9uIGF0 dHJpYnV0ZSB0byBUZXN0UnVubmVyCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weQppbmRleCA5OWI3OWYxZTQyZmU5ZDlh MjYzMzU2Y2FhZDVkMWJkM2Y0NDY5MjQ4Li40MGY3ZDZjZjA4ZmMxZDA1MDg4Y2RlYjkyNGI0OGY1 OTRhMTJkNzIzIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0 cy9ydW5fd2Via2l0X3Rlc3RzLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0 X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMucHkKQEAgLTEzMyw5ICsxMzMsOSBAQCBkZWYgcGFyc2Vf YXJncyhhcmdzKToKICAgICBdKSkKIAogICAgIG9wdGlvbl9ncm91cF9kZWZpbml0aW9ucy5hcHBl bmQoKCJSZXN1bHRzIE9wdGlvbnMiLCBbCi0gICAgICAgIG9wdHBhcnNlLm1ha2Vfb3B0aW9uKCIt cCIsICItLXBpeGVsLXRlc3RzIiwgYWN0aW9uPSJzdG9yZV90cnVlIiwKKyAgICAgICAgb3B0cGFy c2UubWFrZV9vcHRpb24oIi1wIiwgIi0tcGl4ZWwiLCAiLS1waXhlbC10ZXN0cyIsIGFjdGlvbj0i c3RvcmVfdHJ1ZSIsCiAgICAgICAgICAgICBkZXN0PSJwaXhlbF90ZXN0cyIsIGhlbHA9IkVuYWJs ZSBwaXhlbC10by1waXhlbCBQTkcgY29tcGFyaXNvbnMiKSwKLSAgICAgICAgb3B0cGFyc2UubWFr ZV9vcHRpb24oIi0tbm8tcGl4ZWwtdGVzdHMiLCBhY3Rpb249InN0b3JlX2ZhbHNlIiwKKyAgICAg ICAgb3B0cGFyc2UubWFrZV9vcHRpb24oIi0tbm8tcGl4ZWwiLCAiLS1uby1waXhlbC10ZXN0cyIs IGFjdGlvbj0ic3RvcmVfZmFsc2UiLAogICAgICAgICAgICAgZGVzdD0icGl4ZWxfdGVzdHMiLCBo ZWxwPSJEaXNhYmxlIHBpeGVsLXRvLXBpeGVsIFBORyBjb21wYXJpc29ucyIpLAogICAgICAgICBv cHRwYXJzZS5tYWtlX29wdGlvbigiLS1uby1zYW1wbGUtb24tdGltZW91dCIsIGFjdGlvbj0ic3Rv cmVfZmFsc2UiLAogICAgICAgICAgICAgZGVzdD0ic2FtcGxlX29uX3RpbWVvdXQiLCBoZWxwPSJE b24ndCBydW4gc2FtcGxlIG9uIHRpbWVvdXQgKE1hYyBPUyBYIG9ubHkpIiksCg==