101979 2012-11-12 13:44:50 -0800 nrwt: remove a bunch of broken chromium-specific flags 2012-11-12 15:03:55 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED NRWT P2 Normal --- 1 dpranke dpranke abarth adamk ojan tony oldest_to_newest 764769 0 dpranke 2012-11-12 13:44:50 -0800 nrwt: remove a bunch of broken chromium-specific flags 764774 1 173712 dpranke 2012-11-12 13:46:28 -0800 Created attachment 173712 Patch 764778 2 173712 tony 2012-11-12 13:49:15 -0800 Comment on attachment 173712 Patch Ok, but I thought there was a GPU test lab with real hardware that ran with some of the accelerated code paths. 764781 3 dpranke 2012-11-12 13:51:03 -0800 There might be, but if there is, it's using --additional-drt-flag, because the --accelerated-* flags weren't being honored. So, worst case, a bot breaks because of an unrecognized flag, and we notice the real problem. 764837 4 dpranke 2012-11-12 14:34:08 -0800 Committed r134308: <http://trac.webkit.org/changeset/134308> 764867 5 173712 ojan 2012-11-12 15:03:55 -0800 Comment on attachment 173712 Patch nice! 173712 2012-11-12 13:46:28 -0800 2012-11-12 15:03:52 -0800 Patch bug-101979-20121112134430.patch text/plain 5347 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0Mjk1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzQ2YjJjZGRlNmNlZjJkMWMwY2ExNWVmOTE1OWZmYWU3 NTA1N2EwYy4uMDdiODdjOGVmYWI4MmI0ZTJiNzU3NjU0Yzc5MTdiYTA2ODBhNDdjYSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0 IEBACisyMDEyLTExLTEyICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgorCisg ICAgICAgIG5yd3Q6IHJlbW92ZSBhIGJ1bmNoIG9mIGJyb2tlbiBjaHJvbWl1bS1zcGVjaWZpYyBm bGFncworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAx OTc5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhl cmUgd2VyZSBhIGJ1bmNoIG9mIGNocm9taXVtLXNwZWNpZmljIGZsYWdzIHRoYXQgdXNlZCB0byBi ZQorICAgICAgICBzdXBwb3J0ZWQgYnkgTlJXVCAoYW5kIGhhbmRsZWQgYW5kIHBhc3NlZCBvbiB0 byBEUlQpIGJ1dCBoYXZlCisgICAgICAgIHByb2JhYmx5IGJlZW4gYnJva2VuIGZvciBhIGxvbmcg dGltZSBhbmQgYXJlIGN1cnJlbnRseSBpZ25vcmVkLgorCisgICAgICAgIFRoaXMgcGF0Y2ggcmVt b3ZlcyBhbGwgb2YgdGhvc2UgZmxhZ3M7IHRoZSBydWxlIG9mIHRodW1iIGdvaW5nIGZvcndhcmQK KyAgICAgICAgaXMgdGhhdCB3ZSBzaG91bGQgb25seSBhZGQgZmxhZ3MgdGhhdCBhZmZlY3QgaG93 IHRoZSBweXRob24gY29kZSBmdW5jdGlvbnMuCisgICAgICAgIElmIGEgZmxhZyBpcyBqdXN0IHBh c3NlZCB2ZXJiYXRpbSB0byBEUlQsIHRoZSB1c2VyIGNhbiB1c2UgLS1hZGRpdGlvbmFsLWRydC1m bGFnCisgICAgICAgIGZvciB0aGF0LgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlv dXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weToKKyAgICAgICAgKHBhcnNlX2FyZ3MpOgorICAg ICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHNfaW50 ZWdyYXRpb250ZXN0LnB5OgorICAgICAgICAoTWFpblRlc3Quc2V0VXApOgorCiAyMDEyLTExLTEy ICBNaWtoYWlsIFBvemRueWFrb3YgIDxtaWtoYWlsLnBvemRueWFrb3ZAaW50ZWwuY29tPgogCiAg ICAgICAgIFtFRkxdW1dLMl0gQWRkIC0tZGV2aWNlLXBpeGVsLXJhdGlvIGNvbW1hbmQgbGluZSBv cHRpb24gdG8gRUZMIE1pbmlCcm93c2VyCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weQppbmRleCAxYzhlNzMyMWFkY2Y1 OGE3NjhkY2M3M2IyMDhlYWQ3YzEyMDQ3NmM5Li4yZGY1N2NmNmYyN2JhZDU4ZjU0MmQzYTRlZTZm Zjk2Zjg0YWUyM2MyIDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90 ZXN0cy9ydW5fd2Via2l0X3Rlc3RzLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5 b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMucHkKQEAgLTIwNyw0NSArMjA3LDkgQEAgZGVmIHBh cnNlX2FyZ3MoYXJncz1Ob25lKToKIAogICAgICMgRklYTUU6IFRoZXNlIG9wdGlvbnMgc2hvdWxk IG1vdmUgb250byB0aGUgQ2hyb21pdW1Qb3J0LgogICAgIG9wdGlvbl9ncm91cF9kZWZpbml0aW9u cy5hcHBlbmQoKCJDaHJvbWl1bS1zcGVjaWZpYyBPcHRpb25zIiwgWwotICAgICAgICBvcHRwYXJz ZS5tYWtlX29wdGlvbigiLS1zdGFydHVwLWRpYWxvZyIsIGFjdGlvbj0ic3RvcmVfdHJ1ZSIsCi0g ICAgICAgICAgICBkZWZhdWx0PUZhbHNlLCBoZWxwPSJjcmVhdGUgYSBkaWFsb2cgb24gRHVtcFJl bmRlclRyZWUgc3RhcnR1cCIpLAotICAgICAgICBvcHRwYXJzZS5tYWtlX29wdGlvbigiLS1ncC1m YXVsdC1lcnJvci1ib3giLCBhY3Rpb249InN0b3JlX3RydWUiLAotICAgICAgICAgICAgZGVmYXVs dD1GYWxzZSwgaGVscD0iZW5hYmxlIFdpbmRvd3MgR1AgZmF1bHQgZXJyb3IgYm94IiksCi0gICAg ICAgIG9wdHBhcnNlLm1ha2Vfb3B0aW9uKCItLWpzLWZsYWdzIiwKLSAgICAgICAgICAgIHR5cGU9 InN0cmluZyIsIGhlbHA9IkphdmFTY3JpcHQgZmxhZ3MgdG8gcGFzcyB0byB0ZXN0cyIpLAotICAg ICAgICBvcHRwYXJzZS5tYWtlX29wdGlvbigiLS1zdHJlc3Mtb3B0IiwgYWN0aW9uPSJzdG9yZV90 cnVlIiwKLSAgICAgICAgICAgIGRlZmF1bHQ9RmFsc2UsCi0gICAgICAgICAgICBoZWxwPSJFbmFi bGUgYWRkaXRpb25hbCBzdHJlc3MgdGVzdCB0byBKYXZhU2NyaXB0IG9wdGltaXphdGlvbiIpLAot ICAgICAgICBvcHRwYXJzZS5tYWtlX29wdGlvbigiLS1zdHJlc3MtZGVvcHQiLCBhY3Rpb249InN0 b3JlX3RydWUiLAotICAgICAgICAgICAgZGVmYXVsdD1GYWxzZSwKLSAgICAgICAgICAgIGhlbHA9 IkVuYWJsZSBhZGRpdGlvbmFsIHN0cmVzcyB0ZXN0IHRvIEphdmFTY3JpcHQgb3B0aW1pemF0aW9u IiksCiAgICAgICAgIG9wdHBhcnNlLm1ha2Vfb3B0aW9uKCItLW5vY2hlY2stc3lzLWRlcHMiLCBh Y3Rpb249InN0b3JlX3RydWUiLAogICAgICAgICAgICAgZGVmYXVsdD1GYWxzZSwKICAgICAgICAg ICAgIGhlbHA9IkRvbid0IGNoZWNrIHRoZSBzeXN0ZW0gZGVwZW5kZW5jaWVzICh0aGVtZXMpIiks Ci0gICAgICAgIG9wdHBhcnNlLm1ha2Vfb3B0aW9uKCItLWFjY2VsZXJhdGVkLXZpZGVvIiwKLSAg ICAgICAgICAgIGFjdGlvbj0ic3RvcmVfdHJ1ZSIsCi0gICAgICAgICAgICBoZWxwPSJVc2UgaGFy ZHdhcmUtYWNjZWxlcmF0ZWQgY29tcG9zaXRpbmcgZm9yIHZpZGVvIiksCi0gICAgICAgIG9wdHBh cnNlLm1ha2Vfb3B0aW9uKCItLW5vLWFjY2VsZXJhdGVkLXZpZGVvIiwKLSAgICAgICAgICAgIGFj dGlvbj0ic3RvcmVfZmFsc2UiLAotICAgICAgICAgICAgZGVzdD0iYWNjZWxlcmF0ZWRfdmlkZW8i LAotICAgICAgICAgICAgaGVscD0iRG9uJ3QgdXNlIGhhcmR3YXJlLWFjY2VsZXJhdGVkIGNvbXBv c2l0aW5nIGZvciB2aWRlbyIpLAotICAgICAgICBvcHRwYXJzZS5tYWtlX29wdGlvbigiLS10aHJl YWRlZC1jb21wb3NpdGluZyIsCi0gICAgICAgICAgICBhY3Rpb249InN0b3JlX3RydWUiLAotICAg ICAgICAgICAgaGVscD0iVXNlIHRocmVhZGVkIGNvbXBvc2l0aW5nIGZvciByZW5kZXJpbmciKSwK LSAgICAgICAgb3B0cGFyc2UubWFrZV9vcHRpb24oIi0tYWNjZWxlcmF0ZWQtMmQtY2FudmFzIiwK LSAgICAgICAgICAgIGFjdGlvbj0ic3RvcmVfdHJ1ZSIsCi0gICAgICAgICAgICBoZWxwPSJVc2Ug aGFyZHdhcmUtYWNjZWxlcmF0ZWQgMkQgQ2FudmFzIGNhbGxzIiksCi0gICAgICAgIG9wdHBhcnNl Lm1ha2Vfb3B0aW9uKCItLW5vLWFjY2VsZXJhdGVkLTJkLWNhbnZhcyIsCi0gICAgICAgICAgICBh Y3Rpb249InN0b3JlX2ZhbHNlIiwKLSAgICAgICAgICAgIGRlc3Q9ImFjY2VsZXJhdGVkXzJkX2Nh bnZhcyIsCi0gICAgICAgICAgICBoZWxwPSJEb24ndCB1c2UgaGFyZHdhcmUtYWNjZWxlcmF0ZWQg MkQgQ2FudmFzIGNhbGxzIiksCi0gICAgICAgIG9wdHBhcnNlLm1ha2Vfb3B0aW9uKCItLWFjY2Vs ZXJhdGVkLXBhaW50aW5nIiwKLSAgICAgICAgICAgIGFjdGlvbj0ic3RvcmVfdHJ1ZSIsCi0gICAg ICAgICAgICBkZWZhdWx0PUZhbHNlLAotICAgICAgICAgICAgaGVscD0iVXNlIGhhcmR3YXJlIGFj Y2VsZXJhdGVkIHBhaW50aW5nIG9mIGNvbXBvc2l0ZWQgcGFnZXMiKSwKLSAgICAgICAgb3B0cGFy c2UubWFrZV9vcHRpb24oIi0tcGVyLXRpbGUtcGFpbnRpbmciLAotICAgICAgICAgICAgYWN0aW9u PSJzdG9yZV90cnVlIiwKLSAgICAgICAgICAgIGhlbHA9IlVzZSBwZXItdGlsZSBwYWludGluZyBv ZiBjb21wb3NpdGVkIHBhZ2VzIiksCiAgICAgICAgIG9wdHBhcnNlLm1ha2Vfb3B0aW9uKCItLWFk Yi1kZXZpY2UiLAogICAgICAgICAgICAgYWN0aW9uPSJhcHBlbmQiLCBkZWZhdWx0PVtdLAogICAg ICAgICAgICAgaGVscD0iUnVuIEFuZHJvaWQgbGF5b3V0IHRlc3RzIG9uIHRoZXNlIGRldmljZXMu IiksCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5f d2Via2l0X3Rlc3RzX2ludGVncmF0aW9udGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv bGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHNfaW50ZWdyYXRpb250ZXN0LnB5CmluZGV4IDhl MzU3NDdkMzlhNmZmZDg1NzU2MDk0Nzk3ZjljMTQ1NDg0OTFlMmMuLjZhOTE2MWZlNWU5OTY3ZGFl NjIzM2FkNDMxYjUzNzNjZjZhNjdhZmMgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHNfaW50ZWdyYXRpb250ZXN0LnB5CisrKyBi L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHNfaW50 ZWdyYXRpb250ZXN0LnB5CkBAIC0yODcsMTYgKzI4Nyw2IEBAIGNsYXNzIE1haW5UZXN0KHVuaXR0 ZXN0LlRlc3RDYXNlLCBTdHJlYW1UZXN0aW5nTWl4aW4pOgogICAgICAgICAjIHByb3Blcmx5IG9u IGN5Z3dpbiAoYnVnIDYzODQ2KS4KICAgICAgICAgc2VsZi5zaG91bGRfdGVzdF9wcm9jZXNzZXMg PSBub3Qgc2VsZi5fcGxhdGZvcm0uaXNfd2luKCkKIAotICAgIGRlZiB0ZXN0X2FjY2VsZXJhdGVk X2NvbXBvc2l0aW5nKHNlbGYpOgotICAgICAgICAjIFRoaXMganVzdCB0ZXN0cyB0aGF0IHdlIHJl Y29nbml6ZSB0aGUgY29tbWFuZCBsaW5lIGFyZ3MKLSAgICAgICAgc2VsZi5hc3NlcnRUcnVlKHBh c3NpbmdfcnVuKFsnLS1hY2NlbGVyYXRlZC12aWRlbyddKSkKLSAgICAgICAgc2VsZi5hc3NlcnRU cnVlKHBhc3NpbmdfcnVuKFsnLS1uby1hY2NlbGVyYXRlZC12aWRlbyddKSkKLQotICAgIGRlZiB0 ZXN0X2FjY2VsZXJhdGVkXzJkX2NhbnZhcyhzZWxmKToKLSAgICAgICAgIyBUaGlzIGp1c3QgdGVz dHMgdGhhdCB3ZSByZWNvZ25pemUgdGhlIGNvbW1hbmQgbGluZSBhcmdzCi0gICAgICAgIHNlbGYu YXNzZXJ0VHJ1ZShwYXNzaW5nX3J1bihbJy0tYWNjZWxlcmF0ZWQtMmQtY2FudmFzJ10pKQotICAg ICAgICBzZWxmLmFzc2VydFRydWUocGFzc2luZ19ydW4oWyctLW5vLWFjY2VsZXJhdGVkLTJkLWNh bnZhcyddKSkKLQogICAgIGRlZiB0ZXN0X2FsbChzZWxmKToKICAgICAgICAgcmVzLCBvdXQsIGVy ciwgdXNlciA9IGxvZ2dpbmdfcnVuKFtdLCB0ZXN0c19pbmNsdWRlZD1UcnVlKQogICAgICAgICBz ZWxmLmFzc2VydEVxdWFscyhyZXMsIHVuZXhwZWN0ZWRfdGVzdHNfY291bnQpCg==