101969 2012-11-12 12:54:27 -0800 More work towards packaging layer changes up into a transaction object 2012-11-12 13:17:18 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca simon.fraser oldest_to_newest 764702 0 andersca 2012-11-12 12:54:27 -0800 More work towards packaging layer changes up into a transaction object 764709 1 173697 andersca 2012-11-12 12:58:10 -0800 Created attachment 173697 Patch 764730 2 173697 kling 2012-11-12 13:13:45 -0800 Comment on attachment 173697 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173697&action=review > Source/WebKit2/ChangeLog:8 > + Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!). OOPS 764733 3 andersca 2012-11-12 13:17:18 -0800 Committed r134293: <http://trac.webkit.org/changeset/134293> 173697 2012-11-12 12:58:10 -0800 2012-11-12 13:13:44 -0800 Patch bug-101969-20121112125615.patch text/plain 7352 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0Mjc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggM2I0OGExZDNmZWIzODJk NWNkNTc2NzVjNzk4MmZjYWExZWViYjYwNC4uNmZhMjRiYjBlNWFhMjgwY2RiYTcwYzg5YjBmYjQ0 MTc2OThhYzM4YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDM2IEBACiAyMDEyLTExLTEyICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgTW9yZSB3b3JrIHRv d2FyZHMgcGFja2FnaW5nIGxheWVyIGNoYW5nZXMgdXAgaW50byBhIHRyYW5zYWN0aW9uIG9iamVj dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAxOTY5 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkaXRp b25hbCBpbmZvcm1hdGlvbiBvZiB0aGUgY2hhbmdlIHN1Y2ggYXMgYXBwcm9hY2gsIHJhdGlvbmFs ZS4gUGxlYXNlIGFkZCBwZXItZnVuY3Rpb24gZGVzY3JpcHRpb25zIGJlbG93IChPT1BTISkuCisK KyAgICAgICAgKiBTaGFyZWQvbWFjL1JlbW90ZUxheWVyVHJlZVRyYW5zYWN0aW9uLmg6CisgICAg ICAgICogU2hhcmVkL21hYy9SZW1vdGVMYXllclRyZWVUcmFuc2FjdGlvbi5tbToKKyAgICAgICAg KFdlYktpdDo6UmVtb3RlTGF5ZXJUcmVlVHJhbnNhY3Rpb246OlJlbW90ZUxheWVyVHJlZVRyYW5z YWN0aW9uKToKKyAgICAgICAgKFdlYktpdDo6UmVtb3RlTGF5ZXJUcmVlVHJhbnNhY3Rpb246On5S ZW1vdGVMYXllclRyZWVUcmFuc2FjdGlvbik6CisgICAgICAgIChXZWJLaXQ6OlJlbW90ZUxheWVy VHJlZVRyYW5zYWN0aW9uOjpsYXllclByb3BlcnRpZXNDaGFuZ2VkKToKKyAgICAgICAgQWRkIGVt cHR5IHN0dWJzLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9SZW1vdGVHcmFw aGljc0xheWVyLm1tOgorICAgICAgICAoV2ViS2l0OjpSZW1vdGVHcmFwaGljc0xheWVyOjpmbHVz aENvbXBvc2l0aW5nU3RhdGVGb3JUaGlzTGF5ZXJPbmx5KToKKyAgICAgICAgQ2FsbCBsYXllclBy b3BlcnRpZXNDaGFuZ2VkIG9uIHRoZSBjdXJyZW50IHRyYW5zYWN0aW9uLgorCisgICAgICAgICog V2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9SZW1vdGVMYXllclRyZWVDb250cm9sbGVyLmg6CisgICAg ICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9SZW1vdGVMYXllclRyZWVDb250cm9sbGVyLm1t OgorICAgICAgICAoV2ViS2l0OjpSZW1vdGVMYXllclRyZWVDb250cm9sbGVyOjpSZW1vdGVMYXll clRyZWVDb250cm9sbGVyKToKKyAgICAgICAgSW5pdGlhbGl6ZSBtX2N1cnJlbnRUcmFuc2FjdGlv biB0aWxsIDAuCisKKyAgICAgICAgKFdlYktpdDo6UmVtb3RlTGF5ZXJUcmVlQ29udHJvbGxlcjo6 Y3VycmVudFRyYW5zYWN0aW9uKToKKyAgICAgICAgQWRkIGdldHRlci4gVGhpcyBtYXkgb25seSBi ZSBjYWxsZWQgZnJvbSBiZW5lYXRoIGZsdXNoTGF5ZXJzLgorCisgICAgICAgIChXZWJLaXQ6OlJl bW90ZUxheWVyVHJlZUNvbnRyb2xsZXI6OmZsdXNoTGF5ZXJzKToKKyAgICAgICAgQ3JlYXRlIGEg dHJhbnNhY3Rpb24gYmVmb3JlIGZsdXNpbmcgdGhlIGNvbXBvc2l0aW5nIHN0YXRlLgorCisyMDEy LTExLTEyICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKICAgICAgICAg TW9yZSB3b3JrIG9uIHJlbW90ZSBsYXllciBmbHVzaGluZwogICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAxOTYwCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQyL1NoYXJlZC9tYWMvUmVtb3RlTGF5ZXJUcmVlVHJhbnNhY3Rpb24uaCBiL1NvdXJjZS9X ZWJLaXQyL1NoYXJlZC9tYWMvUmVtb3RlTGF5ZXJUcmVlVHJhbnNhY3Rpb24uaAppbmRleCAxOTkx YjM1ZGU0MDUxMGY2YTEyYjg5N2EyZjYzYmUzODI5OGZmY2M5Li5kMTE1Mjg5M2I0ZDc5NWU1NjAx YWQ1MTMxMjJiY2JiOTA0ZjMzMzBjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQv bWFjL1JlbW90ZUxheWVyVHJlZVRyYW5zYWN0aW9uLmgKKysrIGIvU291cmNlL1dlYktpdDIvU2hh cmVkL21hYy9SZW1vdGVMYXllclRyZWVUcmFuc2FjdGlvbi5oCkBAIC0yOCwxMiArMjgsMTkgQEAK IAogbmFtZXNwYWNlIFdlYktpdCB7CiAKK2NsYXNzIFJlbW90ZUdyYXBoaWNzTGF5ZXI7CisKIGNs YXNzIFJlbW90ZUxheWVyVHJlZVRyYW5zYWN0aW9uIHsKIHB1YmxpYzoKICAgICBlbnVtIExheWVy Q2hhbmdlIHsKICAgICAgICAgTm9DaGFuZ2UgPSAwLAogICAgICAgICBOYW1lQ2hhbmdlZCA9IDEg PDwgMSwKICAgICB9OworCisgICAgUmVtb3RlTGF5ZXJUcmVlVHJhbnNhY3Rpb24oKTsKKyAgICB+ UmVtb3RlTGF5ZXJUcmVlVHJhbnNhY3Rpb24oKTsKKworICAgIHZvaWQgbGF5ZXJQcm9wZXJ0aWVz Q2hhbmdlZChjb25zdCBSZW1vdGVHcmFwaGljc0xheWVyKiwgdW5zaWduZWQgbGF5ZXJDaGFuZ2Vz KTsKIH07CiAKIH0gLy8gbmFtZXNwYWNlIFdlYktpdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dDIvU2hhcmVkL21hYy9SZW1vdGVMYXllclRyZWVUcmFuc2FjdGlvbi5tbSBiL1NvdXJjZS9XZWJL aXQyL1NoYXJlZC9tYWMvUmVtb3RlTGF5ZXJUcmVlVHJhbnNhY3Rpb24ubW0KaW5kZXggZDdlZGIx MjE2MGExNzg5Y2U3MTBhZTI0NWI1ZTJlMGU2NDEzM2UzNS4uNTNkZTM2MWZjZjIxNGE0YTM3M2Uy OWMzYTE0MjBhNWE4NDY4NWNhMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvU2hhcmVkL21h Yy9SZW1vdGVMYXllclRyZWVUcmFuc2FjdGlvbi5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9TaGFy ZWQvbWFjL1JlbW90ZUxheWVyVHJlZVRyYW5zYWN0aW9uLm1tCkBAIC0yNSwzICsyNSwyMCBAQAog CiAjaW5jbHVkZSAiY29uZmlnLmgiCiAjaW5jbHVkZSAiUmVtb3RlTGF5ZXJUcmVlVHJhbnNhY3Rp b24uaCIKKworbmFtZXNwYWNlIFdlYktpdCB7CisKK1JlbW90ZUxheWVyVHJlZVRyYW5zYWN0aW9u OjpSZW1vdGVMYXllclRyZWVUcmFuc2FjdGlvbigpCit7Cit9CisKK1JlbW90ZUxheWVyVHJlZVRy YW5zYWN0aW9uOjp+UmVtb3RlTGF5ZXJUcmVlVHJhbnNhY3Rpb24oKQoreworfQorCit2b2lkIFJl bW90ZUxheWVyVHJlZVRyYW5zYWN0aW9uOjpsYXllclByb3BlcnRpZXNDaGFuZ2VkKGNvbnN0IFJl bW90ZUdyYXBoaWNzTGF5ZXIqLCB1bnNpZ25lZCBsYXllckNoYW5nZXMpCit7CisgICAgLy8gRklY TUU6IEltcGxlbWVudCB0aGlzLgorfQorCit9IC8vIG5hbWVzcGFjZSBXZWJLaXQKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvUmVtb3RlR3JhcGhpY3NM YXllci5tbSBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvUmVtb3RlR3Jh cGhpY3NMYXllci5tbQppbmRleCBlYzgzZTNjNDhkOGYxOGE3NmFhZWJiNmY4NmNlMTM5ZDUyOWU2 MzI5Li4zZWJiMDdiYTg5Njk0M2I5MWMyY2E5Mzg1OGQ3Yzk3ZWFmZjYxZDdlIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1JlbW90ZUdyYXBoaWNzTGF5 ZXIubW0KKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9SZW1vdGVH cmFwaGljc0xheWVyLm1tCkBAIC0yNiw2ICsyNiw3IEBACiAjaW5jbHVkZSAiY29uZmlnLmgiCiAj aW5jbHVkZSAiUmVtb3RlR3JhcGhpY3NMYXllci5oIgogCisjaW5jbHVkZSAiUmVtb3RlTGF5ZXJU cmVlQ29udHJvbGxlci5oIgogI2luY2x1ZGUgIlJlbW90ZUxheWVyVHJlZVRyYW5zYWN0aW9uLmgi CiAKICNpbmNsdWRlIDx3dGYvdGV4dC9DU3RyaW5nLmg+CkBAIC04MCw3ICs4MSwxMiBAQCB2b2lk IFJlbW90ZUdyYXBoaWNzTGF5ZXI6OmZsdXNoQ29tcG9zaXRpbmdTdGF0ZShjb25zdCBGbG9hdFJl Y3QmKQogCiB2b2lkIFJlbW90ZUdyYXBoaWNzTGF5ZXI6OmZsdXNoQ29tcG9zaXRpbmdTdGF0ZUZv clRoaXNMYXllck9ubHkoKQogewotICAgIC8vIEZJWE1FOiBGbHVzaCB0aGUgY2hhbmdlZCBwcm9w ZXJ0aWVzLgorICAgIGlmICghbV91bmNvbW1pdHRlZExheWVyQ2hhbmdlcykKKyAgICAgICAgcmV0 dXJuOworCisgICAgbV9jb250cm9sbGVyLT5jdXJyZW50VHJhbnNhY3Rpb24oKS5sYXllclByb3Bl cnRpZXNDaGFuZ2VkKHRoaXMsIG1fdW5jb21taXR0ZWRMYXllckNoYW5nZXMpOworCisgICAgbV91 bmNvbW1pdHRlZExheWVyQ2hhbmdlcyA9IFJlbW90ZUxheWVyVHJlZVRyYW5zYWN0aW9uOjpOb0No YW5nZTsKIH0KIAogdm9pZCBSZW1vdGVHcmFwaGljc0xheWVyOjpub3RlTGF5ZXJQcm9wZXJ0aWVz Q2hhbmdlZCh1bnNpZ25lZCBsYXllckNoYW5nZXMpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1JlbW90ZUxheWVyVHJlZUNvbnRyb2xsZXIuaCBiL1Nv dXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvUmVtb3RlTGF5ZXJUcmVlQ29udHJv bGxlci5oCmluZGV4IDdlMjIzMjMzZWNkODUyMDVmNzg0YTYyZDcxYjRiZmI3YWM3M2JmODEuLjdl ZDZjYTlhNGZjZWRlNDNiNjQ2Mzc1YmZiYTM3YjJkY2E3ODM1MTkgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvUmVtb3RlTGF5ZXJUcmVlQ29udHJvbGxl ci5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvUmVtb3RlTGF5 ZXJUcmVlQ29udHJvbGxlci5oCkBAIC0zMSw2ICszMSw3IEBACiAKIG5hbWVzcGFjZSBXZWJLaXQg ewogCitjbGFzcyBSZW1vdGVMYXllclRyZWVUcmFuc2FjdGlvbjsKIGNsYXNzIFdlYlBhZ2U7CiAK IGNsYXNzIFJlbW90ZUxheWVyVHJlZUNvbnRyb2xsZXIgOiBwdWJsaWMgV2ViQ29yZTo6R3JhcGhp Y3NMYXllckZhY3RvcnkgewpAQCAtNDEsNiArNDIsOCBAQCBwdWJsaWM6CiAgICAgdm9pZCBzZXRS b290TGF5ZXIoV2ViQ29yZTo6R3JhcGhpY3NMYXllciopOwogICAgIHZvaWQgc2NoZWR1bGVMYXll ckZsdXNoKCk7CiAKKyAgICBSZW1vdGVMYXllclRyZWVUcmFuc2FjdGlvbiYgY3VycmVudFRyYW5z YWN0aW9uKCk7CisKIHByaXZhdGU6CiAgICAgZXhwbGljaXQgUmVtb3RlTGF5ZXJUcmVlQ29udHJv bGxlcihXZWJQYWdlKik7CiAKQEAgLTUyLDYgKzU1LDcgQEAgcHJpdmF0ZToKIAogICAgIFdlYlBh Z2UqIG1fd2ViUGFnZTsKICAgICBXZWJDb3JlOjpUaW1lcjxSZW1vdGVMYXllclRyZWVDb250cm9s bGVyPiBtX2xheWVyRmx1c2hUaW1lcjsKKyAgICBSZW1vdGVMYXllclRyZWVUcmFuc2FjdGlvbiog bV9jdXJyZW50VHJhbnNhY3Rpb247CiB9OwogCiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvUmVtb3RlTGF5ZXJU cmVlQ29udHJvbGxlci5tbSBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMv UmVtb3RlTGF5ZXJUcmVlQ29udHJvbGxlci5tbQppbmRleCA3Y2M5Y2YxNjllZmRlZTgwNjc1YjQ4 Yzg4ZjUyNzY4NjRlYmU3ZDQ5Li40NzYzOGM0MDdkYjQwY2RiODkxNDUwOWU3MDRiZTg2ZjdjZTFh MDNjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1Jl bW90ZUxheWVyVHJlZUNvbnRyb2xsZXIubW0KKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vz cy9XZWJQYWdlL21hYy9SZW1vdGVMYXllclRyZWVDb250cm9sbGVyLm1tCkBAIC0yNywxMSArMjcs MTMgQEAKICNpbXBvcnQgIlJlbW90ZUxheWVyVHJlZUNvbnRyb2xsZXIuaCIKIAogI2ltcG9ydCAi UmVtb3RlR3JhcGhpY3NMYXllci5oIgorI2ltcG9ydCAiUmVtb3RlTGF5ZXJUcmVlVHJhbnNhY3Rp b24uaCIKICNpbXBvcnQgIldlYlBhZ2UuaCIKICNpbXBvcnQgPFdlYkNvcmUvRnJhbWUuaD4KICNp bXBvcnQgPFdlYkNvcmUvRnJhbWVWaWV3Lmg+CiAjaW1wb3J0IDxXZWJDb3JlL1BhZ2UuaD4KICNp bXBvcnQgPHd0Zi9QYXNzT3duUHRyLmg+CisjaW1wb3J0IDx3dGYvVGVtcG9yYXJ5Q2hhbmdlLmg+ CiAKIHVzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOwogCkBAIC00NSw2ICs0Nyw3IEBAIFBhc3NPd25Q dHI8UmVtb3RlTGF5ZXJUcmVlQ29udHJvbGxlcj4gUmVtb3RlTGF5ZXJUcmVlQ29udHJvbGxlcjo6 Y3JlYXRlKFdlYlBhZ2UqCiBSZW1vdGVMYXllclRyZWVDb250cm9sbGVyOjpSZW1vdGVMYXllclRy ZWVDb250cm9sbGVyKFdlYlBhZ2UqIHdlYlBhZ2UpCiAgICAgOiBtX3dlYlBhZ2Uod2ViUGFnZSkK ICAgICAsIG1fbGF5ZXJGbHVzaFRpbWVyKHRoaXMsICZSZW1vdGVMYXllclRyZWVDb250cm9sbGVy OjpsYXllckZsdXNoVGltZXJGaXJlZCkKKyAgICAsIG1fY3VycmVudFRyYW5zYWN0aW9uKDApCiB7 CiB9CiAKQEAgLTY0LDYgKzY3LDEzIEBAIHZvaWQgUmVtb3RlTGF5ZXJUcmVlQ29udHJvbGxlcjo6 c2NoZWR1bGVMYXllckZsdXNoKCkKICAgICBtX2xheWVyRmx1c2hUaW1lci5zdGFydE9uZVNob3Qo MCk7CiB9CiAKK1JlbW90ZUxheWVyVHJlZVRyYW5zYWN0aW9uJiBSZW1vdGVMYXllclRyZWVDb250 cm9sbGVyOjpjdXJyZW50VHJhbnNhY3Rpb24oKQoreworICAgIEFTU0VSVChtX2N1cnJlbnRUcmFu c2FjdGlvbik7CisKKyAgICByZXR1cm4gKm1fY3VycmVudFRyYW5zYWN0aW9uOworfQorCiBQYXNz T3duUHRyPEdyYXBoaWNzTGF5ZXI+IFJlbW90ZUxheWVyVHJlZUNvbnRyb2xsZXI6OmNyZWF0ZUdy YXBoaWNzTGF5ZXIoR3JhcGhpY3NMYXllckNsaWVudCogY2xpZW50KQogewogICAgIHJldHVybiBS ZW1vdGVHcmFwaGljc0xheWVyOjpjcmVhdGUoY2xpZW50LCB0aGlzKTsKQEAgLTc2LDYgKzg2LDEx IEBAIHZvaWQgUmVtb3RlTGF5ZXJUcmVlQ29udHJvbGxlcjo6bGF5ZXJGbHVzaFRpbWVyRmlyZWQo V2ViQ29yZTo6VGltZXI8UmVtb3RlTGF5ZXJUCiAKIHZvaWQgUmVtb3RlTGF5ZXJUcmVlQ29udHJv bGxlcjo6Zmx1c2hMYXllcnMoKQogeworICAgIEFTU0VSVCghbV9jdXJyZW50VHJhbnNhY3Rpb24p OworCisgICAgUmVtb3RlTGF5ZXJUcmVlVHJhbnNhY3Rpb24gdHJhbnNhY3Rpb247CisgICAgVGVt cG9yYXJ5Q2hhbmdlPFJlbW90ZUxheWVyVHJlZVRyYW5zYWN0aW9uKj4gdHJhbnNhY3Rpb25DaGFu Z2UobV9jdXJyZW50VHJhbnNhY3Rpb24sICZ0cmFuc2FjdGlvbik7CisKICAgICBtX3dlYlBhZ2Ut PmxheW91dElmTmVlZGVkKCk7CiAgICAgbV93ZWJQYWdlLT5jb3JlUGFnZSgpLT5tYWluRnJhbWUo KS0+dmlldygpLT5mbHVzaENvbXBvc2l0aW5nU3RhdGVJbmNsdWRpbmdTdWJmcmFtZXMoKTsKIAo=