101957 2012-11-12 11:23:59 -0800 Add the TestRunner public API to the ChromiumPublicApi watchlist, and introduce an entry for ChromiumTestRunner 2012-11-13 03:33:04 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jochen jochen abarth dglazkov dpranke fishd jamesr ojan tkent webkit.review.bot oldest_to_newest 764607 0 jochen 2012-11-12 11:23:59 -0800 Add the TestRunner public API to the ChromiumPublicApi watchlist, and introduce an entry for ChromiumTestRunner 764609 1 173676 jochen 2012-11-12 11:25:34 -0800 Created attachment 173676 Patch 764616 2 jochen 2012-11-12 11:29:42 -0800 Since content_shell links against TestRunner, we should make sure its public API follows similar rules than the rest of our webkit API. Is it ok to just add the TestRunner/public dir to the ChromiumPublicApi list? 764635 3 173676 abarth 2012-11-12 11:57:17 -0800 Comment on attachment 173676 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173676&action=review Yep > Tools/Scripts/webkitpy/common/config/watchlist:302 > + "ChromiumTestRunner": [ "jochen@chromium.org", ], No need for the trailing , 764636 4 173676 abarth 2012-11-12 11:57:35 -0800 Comment on attachment 173676 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173676&action=review > Tools/Scripts/webkitpy/common/config/watchlist:20 > + r"|Source/Platform/chromium/public/" I think you're missing a , at the end of this line. 764801 5 173676 jochen 2012-11-12 14:03:51 -0800 Comment on attachment 173676 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173676&action=review >> Tools/Scripts/webkitpy/common/config/watchlist:20 >> + r"|Source/Platform/chromium/public/" > > I think you're missing a , at the end of this line. no, see e.g. line 19 764805 6 173676 abarth 2012-11-12 14:07:49 -0800 Comment on attachment 173676 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173676&action=review >>> Tools/Scripts/webkitpy/common/config/watchlist:20 >>> + r"|Source/Platform/chromium/public/" >> >> I think you're missing a , at the end of this line. > > no, see e.g. line 19 Ah, you're right. /me forgets that this isn't really JSON. 765446 7 jochen 2012-11-13 03:33:04 -0800 Committed r134394: <http://trac.webkit.org/changeset/134394> 173676 2012-11-12 11:25:34 -0800 2012-11-12 14:07:49 -0800 Patch bug-101957-20121112202336.patch text/plain 2324 jochen U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0MjYyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNDZjZGQ1ZDhiMWVmZDJhM2JhYjE2ODZhOThlZGRiZGNi ZWEzYjBhZC4uODZiYTg3NThhYWVlOWI1NzE4NzQwNzY3NzczNWRiYWUwMWRhODQyYiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDEyLTExLTEyICBKb2NoZW4gRWlzaW5nZXIgIDxqb2NoZW5AY2hyb21pdW0ub3JnPgor CisgICAgICAgIEFkZCB0aGUgVGVzdFJ1bm5lciBwdWJsaWMgQVBJIHRvIHRoZSBDaHJvbWl1bVB1 YmxpY0FwaSB3YXRjaGxpc3QsIGFuZCBpbnRyb2R1Y2UgYW4gZW50cnkgZm9yIENocm9taXVtVGVz dFJ1bm5lcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTAxOTU3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg Q2hyb21pdW0gbm93IGFsc28gZGVwZW5kcyBvbiB0aGUgVGVzdFJ1bm5lciBwdWJsaWMgQVBJLCBh bmQgYXMgc3VjaCwgc2ltaWxhciBydWxlcyBhcyBmb3IgdGhlIENocm9taXVtIFdlYktpdCBBUEkg c2hvdWxkIGFwcGx5LgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9jb21tb24vY29uZmln L3dhdGNobGlzdDoKKwogMjAxMi0xMS0xMiAgUGV0ZXIgQmV2ZXJsb28gIDxwZXRlckBjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgW0Nocm9taXVtLUFuZHJvaWRdIFJlc3RhcnQgdGhlIGRldmljZSdz IHNoZWxsIGluIHJvb3QgYmVmb3JlIHB1c2hpbmcgZGF0YQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9jb21tb24vY29uZmlnL3dhdGNobGlzdCBiL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvY29tbW9uL2NvbmZpZy93YXRjaGxpc3QKaW5kZXggODU0YTgxMjI4MGNiMTU0NjE5OTI2 ODg4MjBhODBhM2FjMWYzMDU1ZC4uNDUwZTQ4ODRkMGM3M2U2ZWQ4ZjIzYmE4ZDM3YmVkMWQ2Yjhl ZDliOCAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY29uZmlnL3dh dGNobGlzdAorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jb25maWcvd2F0Y2hs aXN0CkBAIC0xNyw3ICsxNywxMSBAQAogICAgICAgICB9LAogICAgICAgICAiQ2hyb21pdW1QdWJs aWNBcGkiOiB7CiAgICAgICAgICAgICAiZmlsZW5hbWUiOiByIlNvdXJjZS9XZWJLaXQvY2hyb21p dW0vcHVibGljLyIKLSAgICAgICAgICAgICAgICAgICAgICAgIHIifFNvdXJjZS9QbGF0Zm9ybS9j aHJvbWl1bS9wdWJsaWMvIiwKKyAgICAgICAgICAgICAgICAgICAgICAgIHIifFNvdXJjZS9QbGF0 Zm9ybS9jaHJvbWl1bS9wdWJsaWMvIgorICAgICAgICAgICAgICAgICAgICAgICAgciJ8VG9vbHMv RHVtcFJlbmRlclRyZWUvY2hyb21pdW0vVGVzdFJ1bm5lci9wdWJsaWMiLAorICAgICAgICB9LAor ICAgICAgICAiQ2hyb21pdW1UZXN0UnVubmVyIjogeworICAgICAgICAgICAgImZpbGVuYW1lIjog ciJUb29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9UZXN0UnVubmVyIiwKICAgICAgICAgfSwK ICAgICAgICAgIkFwcGxlTWFjUHVibGljQXBpIjogewogICAgICAgICAgICAgImZpbGVuYW1lIjog ciJTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9vYmpjL1B1YmxpY0RPTUludGVyZmFjZXMuaCIKQEAg LTI5NSw2ICsyOTksNyBAQAogICAgICAgICAiQ1NTIjogWyAiYWxleGlzQHdlYmtpdC5vcmciLCAi bWFjcGhlcnNvbkBjaHJvbWl1bS5vcmciLCAiY21hcmNlbG9Ad2Via2l0Lm9yZyJdLAogICAgICAg ICAiQ2hyb21pdW1HcmFwaGljcyI6IFsgImphbWVzckBjaHJvbWl1bS5vcmciLCAiY2MtYnVnc0Bj aHJvbWl1bS5vcmciIF0sCiAgICAgICAgICJDaHJvbWl1bVB1YmxpY0FwaSI6IFsgImFiYXJ0aEB3 ZWJraXQub3JnIiwgImRnbGF6a292QGNocm9taXVtLm9yZyIsICJmaXNoZEBjaHJvbWl1bS5vcmci LCAiamFtZXNyQGNocm9taXVtLm9yZyIsICJ0a2VudCt3a2FwaUBjaHJvbWl1bS5vcmciIF0sCisg ICAgICAgICJDaHJvbWl1bVRlc3RSdW5uZXIiOiBbICJqb2NoZW5AY2hyb21pdW0ub3JnIiwgXSwK ICAgICAgICAgIkRPTUF0dHJpYnV0ZXMiOiBbICJjbWFyY2Vsb0B3ZWJraXQub3JnIiwgXSwKICAg ICAgICAgIkVGTCI6IFsgInJha3Vjb0B3ZWJraXQub3JnIiwgImd5dXlvdW5nLmtpbUBzYW1zdW5n LmNvbSIgXSwKICAgICAgICAgIkVGTFdlYktpdDJQbGF0Zm9ybVNwZWNpZmljIjogWyAiZ3l1eW91 bmcua2ltQHNhbXN1bmcuY29tIiwgInJha3Vjb0B3ZWJraXQub3JnIiBdLAo=