101954 2012-11-12 11:19:26 -0800 REGRESSION(r126157): This patch caused (untestable) regression of the volume property on Mac, Win, and Blackberry ports. (Requested by jernoble on #webkit). 2012-11-12 11:28:39 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 87304 1 webkit.review.bot webkit.review.bot eric.carlson jer.noble pnormand oldest_to_newest 764599 0 webkit.review.bot 2012-11-12 11:19:26 -0800 http://trac.webkit.org/changeset/126157 broke the build: This patch caused (untestable) regression of the volume property on Mac, Win, and Blackberry ports. (Requested by jernoble on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear 764602 1 173675 webkit.review.bot 2012-11-12 11:20:09 -0800 Created attachment 173675 ROLLOUT of r126157 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 764612 2 jer.noble 2012-11-12 11:26:31 -0800 *** Bug 101824 has been marked as a duplicate of this bug. *** 764613 3 173675 webkit.review.bot 2012-11-12 11:28:36 -0800 Comment on attachment 173675 ROLLOUT of r126157 Clearing flags on attachment: 173675 Committed r134268: <http://trac.webkit.org/changeset/134268> 764614 4 webkit.review.bot 2012-11-12 11:28:39 -0800 All reviewed patches have been landed. Closing bug. 173675 2012-11-12 11:20:09 -0800 2012-11-12 11:28:35 -0800 ROLLOUT of r126157 bug-101954-20121112192629.patch text/plain 3212 webkit.review.bot U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0MjYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTQwZTc0NWVlZjE2OWZj NTY5NzJjZTFkNzkwNGIyNDA1ZjBlMjJkYi4uN2I4MTk4MTU3ZmE0YWYxMmIxZTBiZmJjMWI1NTM5 ZjRjMTNkYzZjZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTExLTEyICBTaGVy aWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KKworICAgICAgICBVbnJldmll d2VkLCByb2xsaW5nIG91dCByMTI2MTU3LgorICAgICAgICBodHRwOi8vdHJhYy53ZWJraXQub3Jn L2NoYW5nZXNldC8xMjYxNTcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEwMTk1NAorCisgICAgICAgIFRoaXMgcGF0Y2ggY2F1c2VkICh1bnRlc3RhYmxl KSByZWdyZXNzaW9uIG9mIHRoZSB2b2x1bWUKKyAgICAgICAgcHJvcGVydHkgb24gTWFjLCBXaW4s IGFuZCBCbGFja2JlcnJ5IHBvcnRzLiAoUmVxdWVzdGVkIGJ5CisgICAgICAgIGplcm5vYmxlIG9u ICN3ZWJraXQpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvTWVkaWFQbGF5ZXIuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXI6OmxvYWRXaXRoTmV4dE1lZGlhRW5naW5l KToKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyOjpzZXRWb2x1bWUpOgorICAgICAgICAo V2ViQ29yZTo6TWVkaWFQbGF5ZXI6OnNldE11dGVkKToKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlh UGxheWVyOjpzZXRQcmVzZXJ2ZXNQaXRjaCk6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXll cjo6c2V0U2l6ZSk6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXllcjo6c2V0VmlzaWJsZSk6 CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXllcjo6c2V0UHJlbG9hZCk6CisKIDIwMTItMTEt MTIgIEFsbGFuIFNhbmRmZWxkIEplbnNlbiAgPGFsbGFuLmplbnNlbkBkaWdpYS5jb20+CiAKICAg ICAgICAgTW92ZSByZXNvbHZpbmcgYmxvYiByZWZlcmVuY2VzIHRvIEZvcm1EYXRhLgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvTWVkaWFQbGF5ZXIuY3BwIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvTWVkaWFQbGF5ZXIuY3BwCmluZGV4IGRh OTM1NzBhMGI3YjE3OGNhZTkyM2E5NWVlZjI1NDc2ZTQzYzFhMjMuLjlmODBmOWIwYWJhN2YxYWZi MzZmMTVmZmVlOWRhNzNiZmEyOTczYzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL01lZGlhUGxheWVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9NZWRpYVBsYXllci5jcHAKQEAgLTQwNyw3ICs0MDcsNiBAQCB2b2lkIE1lZGlh UGxheWVyOjpsb2FkV2l0aE5leHRNZWRpYUVuZ2luZShNZWRpYVBsYXllckZhY3RvcnkqIGN1cnJl bnQpCiAgICAgICAgIG1fcHJpdmF0ZS0+c2V0UHJpdmF0ZUJyb3dzaW5nTW9kZShtX3ByaXZhdGVC cm93c2luZyk7CiAgICAgICAgIG1fcHJpdmF0ZS0+c2V0UHJlbG9hZChtX3ByZWxvYWQpOwogICAg ICAgICBtX3ByaXZhdGUtPnNldFByZXNlcnZlc1BpdGNoKHByZXNlcnZlc1BpdGNoKCkpOwotICAg ICAgICBtX3ByaXZhdGUtPnNldFJhdGUobV9yYXRlKTsKICAgICAgICAgaWYgKG1fc2hvdWxkUHJl cGFyZVRvUmVuZGVyKQogICAgICAgICAgICAgbV9wcml2YXRlLT5wcmVwYXJlRm9yUmVuZGVyaW5n KCk7CiAgICAgfQpAQCAtNjI2LDkgKzYyNSw2IEBAIGZsb2F0IE1lZGlhUGxheWVyOjp2b2x1bWUo KSBjb25zdAogCiB2b2lkIE1lZGlhUGxheWVyOjpzZXRWb2x1bWUoZmxvYXQgdm9sdW1lKQogewot ICAgIGlmICh2b2x1bWUgPT0gbV92b2x1bWUpCi0gICAgICAgIHJldHVybjsKLQogICAgIG1fdm9s dW1lID0gdm9sdW1lOwogCiAgICAgaWYgKG1fcHJpdmF0ZS0+c3VwcG9ydHNNdXRpbmcoKSB8fCAh bV9tdXRlZCkKQEAgLTY0Miw5ICs2MzgsNiBAQCBib29sIE1lZGlhUGxheWVyOjptdXRlZCgpIGNv bnN0CiAKIHZvaWQgTWVkaWFQbGF5ZXI6OnNldE11dGVkKGJvb2wgbXV0ZWQpCiB7Ci0gICAgaWYg KG11dGVkID09IG1fbXV0ZWQpCi0gICAgICAgIHJldHVybjsKLQogICAgIG1fbXV0ZWQgPSBtdXRl ZDsKIAogICAgIGlmIChtX3ByaXZhdGUtPnN1cHBvcnRzTXV0aW5nKCkpCkBAIC02ODEsOSArNjc0 LDYgQEAgYm9vbCBNZWRpYVBsYXllcjo6cHJlc2VydmVzUGl0Y2goKSBjb25zdAogCiB2b2lkIE1l ZGlhUGxheWVyOjpzZXRQcmVzZXJ2ZXNQaXRjaChib29sIHByZXNlcnZlc1BpdGNoKQogewotICAg IGlmIChwcmVzZXJ2ZXNQaXRjaCA9PSBtX3ByZXNlcnZlc1BpdGNoKQotICAgICAgICByZXR1cm47 Ci0KICAgICBtX3ByZXNlcnZlc1BpdGNoID0gcHJlc2VydmVzUGl0Y2g7CiAgICAgbV9wcml2YXRl LT5zZXRQcmVzZXJ2ZXNQaXRjaChwcmVzZXJ2ZXNQaXRjaCk7CiB9CkBAIC03MDksMTAgKzY5OSw3 IEBAIGJvb2wgTWVkaWFQbGF5ZXI6OmRpZExvYWRpbmdQcm9ncmVzcygpCiB9CiAKIHZvaWQgTWVk aWFQbGF5ZXI6OnNldFNpemUoY29uc3QgSW50U2l6ZSYgc2l6ZSkKLXsKLSAgICBpZiAoc2l6ZSA9 PSBtX3NpemUpCi0gICAgICAgIHJldHVybjsKLQoreyAKICAgICBtX3NpemUgPSBzaXplOwogICAg IG1fcHJpdmF0ZS0+c2V0U2l6ZShzaXplKTsKIH0KQEAgLTcyNCw5ICs3MTEsNiBAQCBib29sIE1l ZGlhUGxheWVyOjp2aXNpYmxlKCkgY29uc3QKIAogdm9pZCBNZWRpYVBsYXllcjo6c2V0VmlzaWJs ZShib29sIGIpCiB7Ci0gICAgaWYgKGIgPT0gbV92aXNpYmxlKQotICAgICAgICByZXR1cm47Ci0K ICAgICBtX3Zpc2libGUgPSBiOwogICAgIG1fcHJpdmF0ZS0+c2V0VmlzaWJsZShiKTsKIH0KQEAg LTczOCw5ICs3MjIsNiBAQCBNZWRpYVBsYXllcjo6UHJlbG9hZCBNZWRpYVBsYXllcjo6cHJlbG9h ZCgpIGNvbnN0CiAKIHZvaWQgTWVkaWFQbGF5ZXI6OnNldFByZWxvYWQoTWVkaWFQbGF5ZXI6OlBy ZWxvYWQgcHJlbG9hZCkKIHsKLSAgICBpZiAocHJlbG9hZCA9PSBtX3ByZWxvYWQpCi0gICAgICAg IHJldHVybjsKLQogICAgIG1fcHJlbG9hZCA9IHByZWxvYWQ7CiAgICAgbV9wcml2YXRlLT5zZXRQ cmVsb2FkKHByZWxvYWQpOwogfQo=