101947 2012-11-12 09:42:45 -0800 Don't mark scrolling contents as dirty if RenderLayerBacking is going away 2012-11-13 21:19:52 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 101330 1 skyostil skyostil eric jamesr simon.fraser vollick webkit.review.bot oldest_to_newest 764502 0 skyostil 2012-11-12 09:42:45 -0800 Don't mark scrolling contents as dirty if RenderLayerBacking is going away 764511 1 173663 skyostil 2012-11-12 09:47:34 -0800 Created attachment 173663 Patch 764537 2 173663 simon.fraser 2012-11-12 10:10:48 -0800 Comment on attachment 173663 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173663&action=review > Source/WebCore/ChangeLog:16 > + track repaints or not. If the RenderLayerBacking is being destroyed, the > + compositor is no longer valid and this causes a crash. This seems like the wrong way to fix the crash. Does 'no longer valid' mean null, or garbage? if the latter, we need to null out a pointer somewhere. 764543 3 skyostil 2012-11-12 10:19:07 -0800 (In reply to comment #2) > This seems like the wrong way to fix the crash. Does 'no longer valid' mean null, or garbage? if the latter, we need to null out a pointer somewhere. Specifically, renderer()->view() is null, so we get a crash (and an assertion failure) in RenderLayer::compositor(). An alternative way to fix this would be to make RenderLayerBacking::isTrackingRepaints() check for a valid view before calling compositor(). 765780 4 173923 skyostil 2012-11-13 10:36:55 -0800 Created attachment 173923 Patch Alternative fix. 765788 5 173923 simon.fraser 2012-11-13 10:41:45 -0800 Comment on attachment 173923 Patch I still don't understand. You say compositor is no longer valid. Does this mean that RenderLayerBacking::compositor() returns garbage? Or null? 765811 6 skyostil 2012-11-13 10:57:00 -0800 (In reply to comment #5) > (From update of attachment 173923 [details]) > I still don't understand. You say compositor is no longer valid. Does this mean that RenderLayerBacking::compositor() returns garbage? Or null? It returns garbage, because it tries to get the compositor from a null RenderView. There's a debug assert in RenderLayer::compositor() to guard against this. 765823 7 simon.fraser 2012-11-13 11:06:02 -0800 So let's fix that (returning garbage is a security issue, returning null may crash, but safely). I don't think we want to add null checks to every call to compositor(), so your current patch is still needed. 765884 8 skyostil 2012-11-13 11:54:25 -0800 (In reply to comment #7) > So let's fix that (returning garbage is a security issue, returning null may crash, but safely). I don't think we want to add null checks to every call to compositor(), so your current patch is still needed. Agreed. Actually RenderLayerBacking::isTrackingRepaints() already checks for a null compositor so no changes are needed there. 765889 9 173941 skyostil 2012-11-13 11:56:18 -0800 Created attachment 173941 Patch 766068 10 173941 webkit.review.bot 2012-11-13 14:39:42 -0800 Comment on attachment 173941 Patch Rejecting attachment 173941 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog Failed to merge in the changes. Patch failed at 0001 Clean up the inheritance tree under the MediaControls Class. When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 154. Full output: http://queues.webkit.org/results/14826313 766096 11 174002 skyostil 2012-11-13 15:09:00 -0800 Created attachment 174002 Patch Weird. That merge conflict is from a completely unrelated patch. Here's a rebased version just in case. 766389 12 174002 webkit.review.bot 2012-11-13 21:19:47 -0800 Comment on attachment 174002 Patch Clearing flags on attachment: 174002 Committed r134536: <http://trac.webkit.org/changeset/134536> 766390 13 webkit.review.bot 2012-11-13 21:19:52 -0800 All reviewed patches have been landed. Closing bug. 173663 2012-11-12 09:47:34 -0800 2012-11-13 10:36:50 -0800 Patch bug-101947-20121112174536.patch text/plain 2323 skyostil U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0MTgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODM2ZDk3ZTI0ZGNmZTBj YWEwZWNkOTFiYWUxMTA2ODM0MDc2OGNkYy4uNDc5ODQzYThmYzQzNjNkNzFiYmQyY2VmNDExMTU2 N2I3NjJhMjYxZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDEyLTExLTEyICBTYW1p IEt5b3N0aWxhICA8c2t5b3N0aWxAY2hyb21pdW0ub3JnPgorCisgICAgICAgIERvbid0IG1hcmsg c2Nyb2xsaW5nIGNvbnRlbnRzIGFzIGRpcnR5IGlmIFJlbmRlckxheWVyQmFja2luZyBpcyBnb2lu ZyBhd2F5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MDE5NDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBX aGVuIGEgc2Nyb2xsaW5nIGNvbnRlbnRzIGdyYXBoaWNzIGxheWVyIGlzIGNyZWF0ZWQgb3IgZGVz dHJveWVkLCB0aGUKKyAgICAgICAgYXNzb2NpYXRlZCBncmFwaGljcyBsYXllciBpcyBtYXJrZWQg YXMgbmVlZGluZyBkaXNwbGF5IGJlY2F1c2Ugc29tZSBvZgorICAgICAgICB0aGUgcGFpbnRlZCBj b250ZW50IG1heSBoYXZlIG1pZ3JhdGVkIGJldHdlZW4gdGhlIHByaW1hcnkgZ3JhcGhpY3MgbGF5 ZXIKKyAgICAgICAgYW5kIHRoZSBzY3JvbGxpbmcgbGF5ZXIuCisKKyAgICAgICAgVGhpcyBjYXVz ZXMgYSBwcm9ibGVtIHdoZW4gdGhlIFJlbmRlckxheWVyQmFja2luZyBpcyBiZWluZyBkZXN0cm95 ZWQsCisgICAgICAgIGJlY2F1c2Ugc2V0TmVlZHNEaXNwbGF5KCkgbmVlZHMgdG8gY2hlY2sgZnJv bSB0aGUgY29tcG9zaXRvciB3aGV0aGVyIHRvCisgICAgICAgIHRyYWNrIHJlcGFpbnRzIG9yIG5v dC4gSWYgdGhlIFJlbmRlckxheWVyQmFja2luZyBpcyBiZWluZyBkZXN0cm95ZWQsIHRoZQorICAg ICAgICBjb21wb3NpdG9yIGlzIG5vIGxvbmdlciB2YWxpZCBhbmQgdGhpcyBjYXVzZXMgYSBjcmFz aC4KKworICAgICAgICBUaGlzIHBhdGNoIGZpeGVzIHRoZSBwcm9ibGVtIGJ5IG5vdCBjYWxsaW5n IHNldE5lZWRzRGlzcGxheSgpIGlmIHRoZQorICAgICAgICByZW5kZXJlciBpcyBubyBsb25nZXIg YXR0YWNoZWQgdG8gYSB2aWV3LgorCisgICAgICAgIENvdmVyZWQgYnkgZXhpc3RpbmcgbGF5b3V0 IHRlc3RzIGluIGNvbXBvc2l0aW5nL292ZXJmbG93Ly4KKworICAgICAgICAqIHJlbmRlcmluZy9S ZW5kZXJMYXllckJhY2tpbmcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXJCYWNr aW5nOjp1cGRhdGVTY3JvbGxpbmdMYXllcnMpOgorCiAyMDEyLTExLTExICBTaGVyaWZmIEJvdCAg PHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xs aW5nIG91dCByMTM0MTQ0LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlckxheWVyQmFja2luZy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5 ZXJCYWNraW5nLmNwcAppbmRleCAwMjAyMzJmYzI3YTI4YjUwNDNjNGRjNDI2ZWQ5YmRmMWQ2ZWZh YmUzLi43MDExZTJlZTU4ZDE0ZWIwNzNkZGFhOGEzOWNiMjU3NGEyYzk2MTcwIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJCYWNraW5nLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJCYWNraW5nLmNwcApAQCAtMTAxNSw5 ICsxMDE1LDEwIEBAIGJvb2wgUmVuZGVyTGF5ZXJCYWNraW5nOjp1cGRhdGVTY3JvbGxpbmdMYXll cnMoYm9vbCBuZWVkc1Njcm9sbGluZ0xheWVycykKICAgICBpZiAobGF5ZXJDaGFuZ2VkKSB7CiAg ICAgICAgIHVwZGF0ZUludGVybmFsSGllcmFyY2h5KCk7CiAgICAgICAgIG1fZ3JhcGhpY3NMYXll ci0+c2V0UGFpbnRpbmdQaGFzZShwYWludGluZ1BoYXNlRm9yUHJpbWFyeUxheWVyKCkpOwotICAg ICAgICBtX2dyYXBoaWNzTGF5ZXItPnNldE5lZWRzRGlzcGxheSgpOwotICAgICAgICBpZiAocmVu ZGVyZXIoKS0+dmlldygpKQorICAgICAgICBpZiAocmVuZGVyZXIoKS0+dmlldygpKSB7CisgICAg ICAgICAgICBtX2dyYXBoaWNzTGF5ZXItPnNldE5lZWRzRGlzcGxheSgpOwogICAgICAgICAgICAg Y29tcG9zaXRvcigpLT5zY3JvbGxpbmdMYXllckRpZENoYW5nZShtX293bmluZ0xheWVyKTsKKyAg ICAgICAgfQogICAgIH0KIAogICAgIHJldHVybiBsYXllckNoYW5nZWQ7Cg== 173923 2012-11-13 10:36:55 -0800 2012-11-13 11:56:13 -0800 Patch bug-101947-20121113183455.patch text/plain 2144 skyostil U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0MTgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODM2ZDk3ZTI0ZGNmZTBj YWEwZWNkOTFiYWUxMTA2ODM0MDc2OGNkYy4uZGFlMjY4MDBlNzkwMzY3YjhlYzlmNjU1MjI2YmM5 MWViZmY3MzhkOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDEyLTExLTEyICBTYW1p IEt5b3N0aWxhICA8c2t5b3N0aWxAY2hyb21pdW0ub3JnPgorCisgICAgICAgIERvbid0IG1hcmsg c2Nyb2xsaW5nIGNvbnRlbnRzIGFzIGRpcnR5IGlmIFJlbmRlckxheWVyQmFja2luZyBpcyBnb2lu ZyBhd2F5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MDE5NDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBX aGVuIGEgc2Nyb2xsaW5nIGNvbnRlbnRzIGdyYXBoaWNzIGxheWVyIGlzIGNyZWF0ZWQgb3IgZGVz dHJveWVkLCB0aGUKKyAgICAgICAgYXNzb2NpYXRlZCBncmFwaGljcyBsYXllciBpcyBtYXJrZWQg YXMgbmVlZGluZyBkaXNwbGF5IGJlY2F1c2Ugc29tZSBvZgorICAgICAgICB0aGUgcGFpbnRlZCBj b250ZW50IG1heSBoYXZlIG1pZ3JhdGVkIGJldHdlZW4gdGhlIHByaW1hcnkgZ3JhcGhpY3MgbGF5 ZXIKKyAgICAgICAgYW5kIHRoZSBzY3JvbGxpbmcgbGF5ZXIuCisKKyAgICAgICAgVGhpcyBjYXVz ZXMgYSBwcm9ibGVtIHdoZW4gdGhlIFJlbmRlckxheWVyQmFja2luZyBpcyBiZWluZyBkZXN0cm95 ZWQsCisgICAgICAgIGJlY2F1c2Ugc2V0TmVlZHNEaXNwbGF5KCkgbmVlZHMgdG8gY2hlY2sgZnJv bSB0aGUgY29tcG9zaXRvciB3aGV0aGVyIHRvCisgICAgICAgIHRyYWNrIHJlcGFpbnRzIG9yIG5v dC4gSWYgdGhlIFJlbmRlckxheWVyQmFja2luZyBpcyBiZWluZyBkZXN0cm95ZWQsIHRoZQorICAg ICAgICBjb21wb3NpdG9yIGlzIG5vIGxvbmdlciB2YWxpZCBhbmQgdGhpcyBjYXVzZXMgYSBjcmFz aC4KKworICAgICAgICBUaGlzIHBhdGNoIGZpeGVzIHRoZSBwcm9ibGVtIGJ5IG1ha2luZyBpc1Ry YWNraW5nUmVwYWludHMoKSBlYXJseS1vdXQgaWYgdGhlCisgICAgICAgIHJlbmRlcmVyIGlzIG5v IGxvbmdlciBhdHRhY2hlZCB0byBhIHZpZXcuCisKKyAgICAgICAgQ292ZXJlZCBieSBleGlzdGlu ZyBsYXlvdXQgdGVzdHMgaW4gY29tcG9zaXRpbmcvb3ZlcmZsb3cvLgorCisgICAgICAgICogcmVu ZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJM YXllckJhY2tpbmc6OmlzVHJhY2tpbmdSZXBhaW50cyk6CisKIDIwMTItMTEtMTEgIFNoZXJpZmYg Qm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQs IHJvbGxpbmcgb3V0IHIxMzQxNDQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyTGF5ZXJCYWNraW5nLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJMYXllckJhY2tpbmcuY3BwCmluZGV4IDAyMDIzMmZjMjdhMjhiNTA0M2M0ZGM0MjZlZDliZGYx ZDZlZmFiZTMuLmNhYmI4MjYxNTkyZDkzNjE5ZTlhOGZlNjM2MDc0NjNlNTlmMTRhN2UgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckJhY2tpbmcuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckJhY2tpbmcuY3BwCkBAIC0x NjI2LDYgKzE2MjYsOCBAQCBib29sIFJlbmRlckxheWVyQmFja2luZzo6Z2V0Q3VycmVudFRyYW5z Zm9ybShjb25zdCBHcmFwaGljc0xheWVyKiBncmFwaGljc0xheWVyLAogCiBib29sIFJlbmRlckxh eWVyQmFja2luZzo6aXNUcmFja2luZ1JlcGFpbnRzKCkgY29uc3QKIHsKKyAgICBpZiAoIXJlbmRl cmVyKCktPnZpZXcoKSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIEdyYXBoaWNzTGF5ZXJD bGllbnQqIGNsaWVudCA9IGNvbXBvc2l0b3IoKTsKICAgICByZXR1cm4gY2xpZW50ID8gY2xpZW50 LT5pc1RyYWNraW5nUmVwYWludHMoKSA6IGZhbHNlOwogfQo= 173941 2012-11-13 11:56:18 -0800 2012-11-13 15:08:52 -0800 Patch bug-101947-20121113195418.patch text/plain 2063 skyostil U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0MTgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODM2ZDk3ZTI0ZGNmZTBj YWEwZWNkOTFiYWUxMTA2ODM0MDc2OGNkYy4uNTNkYTQxZWZkNzkyMmM0MTE0M2YwM2ExNWJiNWQy NmNlMWRmYjY3YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDEyLTExLTEyICBTYW1p IEt5b3N0aWxhICA8c2t5b3N0aWxAY2hyb21pdW0ub3JnPgorCisgICAgICAgIERvbid0IG1hcmsg c2Nyb2xsaW5nIGNvbnRlbnRzIGFzIGRpcnR5IGlmIFJlbmRlckxheWVyQmFja2luZyBpcyBnb2lu ZyBhd2F5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MDE5NDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBX aGVuIGEgc2Nyb2xsaW5nIGNvbnRlbnRzIGdyYXBoaWNzIGxheWVyIGlzIGNyZWF0ZWQgb3IgZGVz dHJveWVkLCB0aGUKKyAgICAgICAgYXNzb2NpYXRlZCBncmFwaGljcyBsYXllciBpcyBtYXJrZWQg YXMgbmVlZGluZyBkaXNwbGF5IGJlY2F1c2Ugc29tZSBvZgorICAgICAgICB0aGUgcGFpbnRlZCBj b250ZW50IG1heSBoYXZlIG1pZ3JhdGVkIGJldHdlZW4gdGhlIHByaW1hcnkgZ3JhcGhpY3MgbGF5 ZXIKKyAgICAgICAgYW5kIHRoZSBzY3JvbGxpbmcgbGF5ZXIuCisKKyAgICAgICAgVGhpcyBjYXVz ZXMgYSBwcm9ibGVtIHdoZW4gdGhlIFJlbmRlckxheWVyQmFja2luZyBpcyBiZWluZyBkZXN0cm95 ZWQsCisgICAgICAgIGJlY2F1c2Ugc2V0TmVlZHNEaXNwbGF5KCkgbmVlZHMgdG8gY2hlY2sgZnJv bSB0aGUgY29tcG9zaXRvciB3aGV0aGVyIHRvCisgICAgICAgIHRyYWNrIHJlcGFpbnRzIG9yIG5v dC4gSWYgdGhlIFJlbmRlckxheWVyQmFja2luZyBpcyBiZWluZyBkZXN0cm95ZWQsIHRoZQorICAg ICAgICB2YWx1ZSByZXR1cm5lZCBieSBjb21wb3NpdG9yKCkgaXMgZ2FyYmFnZSBhbmQgdGhpcyBj YXVzZXMgYSBjcmFzaC4KKworICAgICAgICBUaGlzIHBhdGNoIGZpeGVzIHRoZSBwcm9ibGVtIGJ5 IG1ha2luZyBSZW5kZXJMYXllcjo6Y29tcG9zaXRvcigpIHJldHVybiBhIG51bGwKKyAgICAgICAg cG9pbnRlciB3aGVuIHRoZSByZW5kZXJlciBubyBsb25nZXIgaGFzIGEgdmlldy4KKworICAgICAg ICBDb3ZlcmVkIGJ5IGV4aXN0aW5nIGxheW91dCB0ZXN0cyBpbiBjb21wb3NpdGluZy9vdmVyZmxv dy8uCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6UmVuZGVyTGF5ZXI6OmNvbXBvc2l0b3IpOgorCiAyMDEyLTExLTExICBTaGVyaWZmIEJv dCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCBy b2xsaW5nIG91dCByMTM0MTQ0LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckxheWVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5j cHAKaW5kZXggN2JhNGZlOGJiNjgxYWU0ZjlmODY4Nzc3YTBjYjY3OTI2NDk2NmM0OC4uODlkNzNj Mzg5NWY3NjhlYWRlMjU1ODU5YWZiNjE4ZDYzMzJmYmZhYyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCkBAIC0yNjEsNyArMjYxLDggQEAgUmVuZGVyTGF5ZXI6On5S ZW5kZXJMYXllcigpCiAjaWYgVVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKQogUmVuZGVyTGF5 ZXJDb21wb3NpdG9yKiBSZW5kZXJMYXllcjo6Y29tcG9zaXRvcigpIGNvbnN0CiB7Ci0gICAgQVNT RVJUKHJlbmRlcmVyKCktPnZpZXcoKSk7CisgICAgaWYgKCFyZW5kZXJlcigpLT52aWV3KCkpCisg ICAgICAgIHJldHVybiAwOwogICAgIHJldHVybiByZW5kZXJlcigpLT52aWV3KCktPmNvbXBvc2l0 b3IoKTsKIH0KIAo= 174002 2012-11-13 15:09:00 -0800 2012-11-13 21:19:47 -0800 Patch bug-101947-20121113230700.patch text/plain 2083 skyostil U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0MzgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDcxMjM3NDMzYmI1NDYz Njc0OWMyODBlNjM1MDJmNmFkMWM2MGEzMS4uOGQ5NjU2ZjQ5ZTNjNmM1MmFjOTFhMjgzYzlkYzNl YjdkZmQzYmQ1YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDEyLTExLTEyICBTYW1p IEt5b3N0aWxhICA8c2t5b3N0aWxAY2hyb21pdW0ub3JnPgorCisgICAgICAgIERvbid0IG1hcmsg c2Nyb2xsaW5nIGNvbnRlbnRzIGFzIGRpcnR5IGlmIFJlbmRlckxheWVyQmFja2luZyBpcyBnb2lu ZyBhd2F5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MDE5NDcKKworICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBGcmFzZXIuCisKKyAgICAgICAgV2hl biBhIHNjcm9sbGluZyBjb250ZW50cyBncmFwaGljcyBsYXllciBpcyBjcmVhdGVkIG9yIGRlc3Ry b3llZCwgdGhlCisgICAgICAgIGFzc29jaWF0ZWQgZ3JhcGhpY3MgbGF5ZXIgaXMgbWFya2VkIGFz IG5lZWRpbmcgZGlzcGxheSBiZWNhdXNlIHNvbWUgb2YKKyAgICAgICAgdGhlIHBhaW50ZWQgY29u dGVudCBtYXkgaGF2ZSBtaWdyYXRlZCBiZXR3ZWVuIHRoZSBwcmltYXJ5IGdyYXBoaWNzIGxheWVy CisgICAgICAgIGFuZCB0aGUgc2Nyb2xsaW5nIGxheWVyLgorCisgICAgICAgIFRoaXMgY2F1c2Vz IGEgcHJvYmxlbSB3aGVuIHRoZSBSZW5kZXJMYXllckJhY2tpbmcgaXMgYmVpbmcgZGVzdHJveWVk LAorICAgICAgICBiZWNhdXNlIHNldE5lZWRzRGlzcGxheSgpIG5lZWRzIHRvIGNoZWNrIGZyb20g dGhlIGNvbXBvc2l0b3Igd2hldGhlciB0bworICAgICAgICB0cmFjayByZXBhaW50cyBvciBub3Qu IElmIHRoZSBSZW5kZXJMYXllckJhY2tpbmcgaXMgYmVpbmcgZGVzdHJveWVkLCB0aGUKKyAgICAg ICAgdmFsdWUgcmV0dXJuZWQgYnkgY29tcG9zaXRvcigpIGlzIGdhcmJhZ2UgYW5kIHRoaXMgY2F1 c2VzIGEgY3Jhc2guCisKKyAgICAgICAgVGhpcyBwYXRjaCBmaXhlcyB0aGUgcHJvYmxlbSBieSBt YWtpbmcgUmVuZGVyTGF5ZXI6OmNvbXBvc2l0b3IoKSByZXR1cm4gYSBudWxsCisgICAgICAgIHBv aW50ZXIgd2hlbiB0aGUgcmVuZGVyZXIgbm8gbG9uZ2VyIGhhcyBhIHZpZXcuCisKKyAgICAgICAg Q292ZXJlZCBieSBleGlzdGluZyBsYXlvdXQgdGVzdHMgaW4gY29tcG9zaXRpbmcvb3ZlcmZsb3cv LgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OlJlbmRlckxheWVyOjpjb21wb3NpdG9yKToKKwogMjAxMi0xMS0xMyAgSGF5YXRvIEl0byAg PGhheWF0b0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCBhdHRlbXB0IHRvIGZp eCB0aGUgY2hyb21pdW0gbWFjLWJ1aWxkIGFmdGVyIHIxMzQzNDguCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlckxheWVyLmNwcAppbmRleCBmZTNlZDgyN2Y0YWNlNzlmZDRmYmU3MGVmNzFm NDhlOWUzNjJmZThkLi5mODBkOTYxYjI4MmE1ZmU3NTk5ZmVlMzVkNmYyMmZiZDdlM2FmZWY2IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAKQEAgLTI2Miw3ICsyNjIs OCBAQCBSZW5kZXJMYXllcjo6flJlbmRlckxheWVyKCkKICNpZiBVU0UoQUNDRUxFUkFURURfQ09N UE9TSVRJTkcpCiBSZW5kZXJMYXllckNvbXBvc2l0b3IqIFJlbmRlckxheWVyOjpjb21wb3NpdG9y KCkgY29uc3QKIHsKLSAgICBBU1NFUlQocmVuZGVyZXIoKS0+dmlldygpKTsKKyAgICBpZiAoIXJl bmRlcmVyKCktPnZpZXcoKSkKKyAgICAgICAgcmV0dXJuIDA7CiAgICAgcmV0dXJuIHJlbmRlcmVy KCktPnZpZXcoKS0+Y29tcG9zaXRvcigpOwogfQogCg==