101930 2012-11-12 05:07:58 -0800 [EFL][WK2] Add --device-pixel-ratio command line option to EFL MiniBrowser 2012-11-12 13:37:02 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mikhail.pozdnyakov mikhail.pozdnyakov gyuyoung.kim kenneth lucas.de.marchi webkit.review.bot oldest_to_newest 764287 0 mikhail.pozdnyakov 2012-11-12 05:07:58 -0800 Add --device-pixel-ratio command line option to EFL MiniBrowser 764468 1 173655 mikhail.pozdnyakov 2012-11-12 09:02:06 -0800 Created attachment 173655 patch 764588 2 173655 kenneth 2012-11-12 11:08:14 -0800 Comment on attachment 173655 patch View in context: https://bugs.webkit.org/attachment.cgi?id=173655&action=review > Tools/MiniBrowser/efl/main.c:46 > +static double device_pixel_ratio = 0; why not just use 1? > Tools/MiniBrowser/efl/main.c:1038 > ewk_view_theme_set(app_data->webview, THEME_DIR "/default.edj"); > + if (device_pixel_ratio) > + ewk_view_device_pixel_ratio_set(app_data->webview, (float)device_pixel_ratio); > Ah so this works for newly created windows as well, great 764615 3 mikhail.pozdnyakov 2012-11-12 11:29:38 -0800 (In reply to comment #2) > (From update of attachment 173655 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=173655&action=review > > > Tools/MiniBrowser/efl/main.c:46 > > +static double device_pixel_ratio = 0; > > why not just use 1? It's already has default value in Webkit. Don't want to set customDeviceScaleFactor if it's not required by the User. 764620 4 173655 kenneth 2012-11-12 11:33:48 -0800 Comment on attachment 173655 patch View in context: https://bugs.webkit.org/attachment.cgi?id=173655&action=review >>> Tools/MiniBrowser/efl/main.c:46 >>> +static double device_pixel_ratio = 0; >> >> why not just use 1? > > It's already has default value in Webkit. Don't want to set customDeviceScaleFactor if it's not required by the User. Such a comment might be good? 764646 5 173684 mikhail.pozdnyakov 2012-11-12 12:04:27 -0800 Created attachment 173684 to be landed 764757 6 173684 webkit.review.bot 2012-11-12 13:36:56 -0800 Comment on attachment 173684 to be landed Clearing flags on attachment: 173684 Committed r134295: <http://trac.webkit.org/changeset/134295> 764758 7 webkit.review.bot 2012-11-12 13:37:02 -0800 All reviewed patches have been landed. Closing bug. 173655 2012-11-12 09:02:06 -0800 2012-11-12 12:04:27 -0800 patch bug101930 text/plain 2967 mikhail.pozdnyakov Y29tbWl0IDU4Y2I3YzBiMDFiN2MwOTNjOWZjZDYwYzBlNzRkZjM2YmIwNWY4OTYKQXV0aG9yOiBN aWtoYWlsIFBvemRueWFrb3YgPG1pa2hhaWwucG96ZG55YWtvdkBpbnRlbC5jb20+CkRhdGU6ICAg TW9uIE5vdiAxMiAxODo1Nzo0NCAyMDEyICswMjAwCgogICAgMTAxOTMwCgpkaWZmIC0tZ2l0IGEv VG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IDBkYTU3NjAuLmQwNjAyYjMg MTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxMi0xMS0xMiAgTWlraGFpbCBQb3pkbnlha292ICA8bWlraGFpbC5wb3pk bnlha292QGludGVsLmNvbT4KKworICAgICAgICBbRUZMXVtXSzJdIEFkZCAtLWRldmljZS1waXhl bC1yYXRpbyBjb21tYW5kIGxpbmUgb3B0aW9uIHRvIEVGTCBNaW5pQnJvd3NlcgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAxOTMwCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkZWQgLS1kZXZpY2UtcGl4 ZWwtcmF0aW8gY29tbWFuZCBsaW5lIG9wdGlvbiB0byBFRkwgTWluaUJyb3dzZXIgd2hpY2ggc2V0 cworICAgICAgICB0aGUgcmF0aW8gYmV0d2VlbiB0aGUgQ1NTIHVuaXRzIGFuZCBkZXZpY2UgcGl4 ZWxzIHdoZW4gdGhlIGNvbnRlbnQgaXMgdW5zY2FsZWQuCisgICAgICAgIE9wdGlvbiBpcyBhcHBs aWVkIGZvciBhbGwgdGhlIHZpZXdzIGNyZWF0ZWQgYnkgbWluaSBicm93c2VyLgorCisgICAgICAg ICogTWluaUJyb3dzZXIvZWZsL21haW4uYzoKKyAgICAgICAgKHdpbmRvd19jcmVhdGUpOgorICAg ICAgICAoZWxtX21haW4pOgorCiAyMDEyLTExLTExICBLYW5naWwgSGFuICA8a2FuZ2lsLmhhbkBz YW1zdW5nLmNvbT4KIAogICAgICAgICBDaGFuZ2UgYnVpbGQgY29uZ3JhdHVsYXRpb24gbWVzc2Fn ZSBpbiBFRkwKZGlmZiAtLWdpdCBhL1Rvb2xzL01pbmlCcm93c2VyL2VmbC9tYWluLmMgYi9Ub29s cy9NaW5pQnJvd3Nlci9lZmwvbWFpbi5jCmluZGV4IGU5ODJhNzEuLjg3MWIzNmQgMTAwNjQ0Ci0t LSBhL1Rvb2xzL01pbmlCcm93c2VyL2VmbC9tYWluLmMKKysrIGIvVG9vbHMvTWluaUJyb3dzZXIv ZWZsL21haW4uYwpAQCAtNDMsNiArNDMsNyBAQCBzdGF0aWMgRWluYV9Cb29sIGVuY29kaW5nX2Rl dGVjdG9yX2VuYWJsZWQgPSBFSU5BX0ZBTFNFOwogc3RhdGljIEVpbmFfQm9vbCBmcmFtZV9mbGF0 dGVuaW5nX2VuYWJsZWQgPSBFSU5BX0ZBTFNFOwogc3RhdGljIGludCB3aW5kb3dfd2lkdGggPSA4 MDA7CiBzdGF0aWMgaW50IHdpbmRvd19oZWlnaHQgPSA2MDA7CitzdGF0aWMgZG91YmxlIGRldmlj ZV9waXhlbF9yYXRpbyA9IDA7CiAKIHN0YXRpYyBFd2tfVmlld19TbWFydF9DbGFzcyogbWluaUJy b3dzZXJWaWV3U21hcnRDbGFzcygpCiB7CkBAIC03MCw2ICs3MSw4IEBAIHN0YXRpYyBjb25zdCBF Y29yZV9HZXRvcHQgb3B0aW9ucyA9IHsKICAgICAgICAgICAgICgnZScsICJlbmdpbmUiLCAiZWNv cmUtZXZhcyBlbmdpbmUgdG8gdXNlLiIpLAogICAgICAgICBFQ09SRV9HRVRPUFRfU1RPUkVfU1RS CiAgICAgICAgICAgICAoJ3MnLCAid2luZG93LXNpemUiLCAid2luZG93IHNpemUgaW4gZm9sbG93 aW5nIGZvcm1hdCAod2lkdGgpeChoZWlnaHQpLiIpLAorICAgICAgICBFQ09SRV9HRVRPUFRfU1RP UkVfRE9VQkxFCisgICAgICAgICAgICAoJ3InLCAiZGV2aWNlLXBpeGVsLXJhdGlvIiwgIlJhdGlv IGJldHdlZW4gdGhlIENTUyB1bml0cyBhbmQgZGV2aWNlIHBpeGVscy4iKSwKICAgICAgICAgRUNP UkVfR0VUT1BUX0NBTExCQUNLX05PQVJHUwogICAgICAgICAgICAgKCdFJywgImxpc3QtZW5naW5l cyIsICJsaXN0IGVjb3JlLWV2YXMgZW5naW5lcy4iLAogICAgICAgICAgICAgIGVjb3JlX2dldG9w dF9jYWxsYmFja19lY29yZV9ldmFzX2xpc3RfZW5naW5lcywgTlVMTCksCkBAIC0xMDMwLDYgKzEw MzMsOCBAQCBzdGF0aWMgQnJvd3Nlcl9XaW5kb3cgKndpbmRvd19jcmVhdGUoY29uc3QgY2hhciAq dXJsKQogICAgIEV2YXNfU21hcnQgKnNtYXJ0ID0gZXZhc19zbWFydF9jbGFzc19uZXcoJmV3a1Zp ZXdDbGFzcy0+c2MpOwogICAgIGFwcF9kYXRhLT53ZWJ2aWV3ID0gZXdrX3ZpZXdfc21hcnRfYWRk KGV2YXMsIHNtYXJ0LCBld2tfY29udGV4dF9kZWZhdWx0X2dldCgpKTsKICAgICBld2tfdmlld190 aGVtZV9zZXQoYXBwX2RhdGEtPndlYnZpZXcsIFRIRU1FX0RJUiAiL2RlZmF1bHQuZWRqIik7Cisg ICAgaWYgKGRldmljZV9waXhlbF9yYXRpbykKKyAgICAgICAgZXdrX3ZpZXdfZGV2aWNlX3BpeGVs X3JhdGlvX3NldChhcHBfZGF0YS0+d2VidmlldywgKGZsb2F0KWRldmljZV9waXhlbF9yYXRpbyk7 CiAKICAgICBFd2tfU2V0dGluZ3MgKnNldHRpbmdzID0gZXdrX3ZpZXdfc2V0dGluZ3NfZ2V0KGFw cF9kYXRhLT53ZWJ2aWV3KTsKICAgICBld2tfc2V0dGluZ3NfZmlsZV9hY2Nlc3NfZnJvbV9maWxl X3VybHNfYWxsb3dlZF9zZXQoc2V0dGluZ3MsIEVJTkFfVFJVRSk7CkBAIC0xMTA5LDYgKzExMTQs NyBAQCBlbG1fbWFpbihpbnQgYXJnYywgY2hhciAqYXJndltdKQogICAgIEVjb3JlX0dldG9wdF9W YWx1ZSB2YWx1ZXNbXSA9IHsKICAgICAgICAgRUNPUkVfR0VUT1BUX1ZBTFVFX1NUUihldmFzX2Vu Z2luZV9uYW1lKSwKICAgICAgICAgRUNPUkVfR0VUT1BUX1ZBTFVFX1NUUih3aW5kb3dfc2l6ZV9z dHJpbmcpLAorICAgICAgICBFQ09SRV9HRVRPUFRfVkFMVUVfRE9VQkxFKGRldmljZV9waXhlbF9y YXRpbyksCiAgICAgICAgIEVDT1JFX0dFVE9QVF9WQUxVRV9CT09MKHF1aXRPcHRpb24pLAogICAg ICAgICBFQ09SRV9HRVRPUFRfVkFMVUVfQk9PTChlbmNvZGluZ19kZXRlY3Rvcl9lbmFibGVkKSwK ICAgICAgICAgRUNPUkVfR0VUT1BUX1ZBTFVFX0JPT0woZnJhbWVfZmxhdHRlbmluZ19lbmFibGVk KSwK 173684 2012-11-12 12:04:27 -0800 2012-11-12 13:36:56 -0800 to be landed bug101930_v2 text/plain 3149 mikhail.pozdnyakov Y29tbWl0IGRlMDMxMThhZTM1MjA0YzExOTc1YjQxOTQzNWQwYTNjNGNiYTNjYmQKQXV0aG9yOiBN aWtoYWlsIFBvemRueWFrb3YgPG1pa2hhaWwucG96ZG55YWtvdkBpbnRlbC5jb20+CkRhdGU6ICAg TW9uIE5vdiAxMiAyMjowMDo0NyAyMDEyICswMjAwCgogICAgYnVnMTAxOTMwCgpkaWZmIC0tZ2l0 IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IDQ2Y2RkNWQuLjQ1ZWZm ZDQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxOCBAQAorMjAxMi0xMS0xMiAgTWlraGFpbCBQb3pkbnlha292ICA8bWlraGFpbC5w b3pkbnlha292QGludGVsLmNvbT4KKworICAgICAgICBbRUZMXVtXSzJdIEFkZCAtLWRldmljZS1w aXhlbC1yYXRpbyBjb21tYW5kIGxpbmUgb3B0aW9uIHRvIEVGTCBNaW5pQnJvd3NlcgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAxOTMwCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4uCisKKyAgICAgICAgQWRk ZWQgLS1kZXZpY2UtcGl4ZWwtcmF0aW8gY29tbWFuZCBsaW5lIG9wdGlvbiB0byBFRkwgTWluaUJy b3dzZXIgd2hpY2ggc2V0cworICAgICAgICB0aGUgcmF0aW8gYmV0d2VlbiB0aGUgQ1NTIHVuaXRz IGFuZCBkZXZpY2UgcGl4ZWxzIHdoZW4gdGhlIGNvbnRlbnQgaXMgdW5zY2FsZWQuCisgICAgICAg IE9wdGlvbiBpcyBhcHBsaWVkIGZvciBhbGwgdGhlIHZpZXdzIGNyZWF0ZWQgYnkgbWluaSBicm93 c2VyLgorCisgICAgICAgICogTWluaUJyb3dzZXIvZWZsL21haW4uYzoKKyAgICAgICAgKHdpbmRv d19jcmVhdGUpOgorICAgICAgICAoZWxtX21haW4pOgorCiAyMDEyLTExLTEyICBQZXRlciBCZXZl cmxvbyAgPHBldGVyQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbQ2hyb21pdW0tQW5kcm9pZF0g UmVzdGFydCB0aGUgZGV2aWNlJ3Mgc2hlbGwgaW4gcm9vdCBiZWZvcmUgcHVzaGluZyBkYXRhCmRp ZmYgLS1naXQgYS9Ub29scy9NaW5pQnJvd3Nlci9lZmwvbWFpbi5jIGIvVG9vbHMvTWluaUJyb3dz ZXIvZWZsL21haW4uYwppbmRleCBlOTgyYTcxLi5iZjQ2MGNlIDEwMDY0NAotLS0gYS9Ub29scy9N aW5pQnJvd3Nlci9lZmwvbWFpbi5jCisrKyBiL1Rvb2xzL01pbmlCcm93c2VyL2VmbC9tYWluLmMK QEAgLTQzLDYgKzQzLDkgQEAgc3RhdGljIEVpbmFfQm9vbCBlbmNvZGluZ19kZXRlY3Rvcl9lbmFi bGVkID0gRUlOQV9GQUxTRTsKIHN0YXRpYyBFaW5hX0Jvb2wgZnJhbWVfZmxhdHRlbmluZ19lbmFi bGVkID0gRUlOQV9GQUxTRTsKIHN0YXRpYyBpbnQgd2luZG93X3dpZHRoID0gODAwOwogc3RhdGlj IGludCB3aW5kb3dfaGVpZ2h0ID0gNjAwOworLyogRGVmYXVsdCB2YWx1ZSBvZiBkZXZpY2VfcGl4 ZWxfcmF0aW8gaXMgJzAnIHNvIHRoYXQgd2UgZG9uJ3Qgc2V0IGN1c3RvbSBkZXZpY2UKKyAqIHNj YWxlIGZhY3RvciB1bmxlc3MgaXQncyByZXF1aXJlZCBieSB0aGUgVXNlci4gKi8KK3N0YXRpYyBk b3VibGUgZGV2aWNlX3BpeGVsX3JhdGlvID0gMDsKIAogc3RhdGljIEV3a19WaWV3X1NtYXJ0X0Ns YXNzKiBtaW5pQnJvd3NlclZpZXdTbWFydENsYXNzKCkKIHsKQEAgLTcwLDYgKzczLDggQEAgc3Rh dGljIGNvbnN0IEVjb3JlX0dldG9wdCBvcHRpb25zID0gewogICAgICAgICAgICAgKCdlJywgImVu Z2luZSIsICJlY29yZS1ldmFzIGVuZ2luZSB0byB1c2UuIiksCiAgICAgICAgIEVDT1JFX0dFVE9Q VF9TVE9SRV9TVFIKICAgICAgICAgICAgICgncycsICJ3aW5kb3ctc2l6ZSIsICJ3aW5kb3cgc2l6 ZSBpbiBmb2xsb3dpbmcgZm9ybWF0ICh3aWR0aCl4KGhlaWdodCkuIiksCisgICAgICAgIEVDT1JF X0dFVE9QVF9TVE9SRV9ET1VCTEUKKyAgICAgICAgICAgICgncicsICJkZXZpY2UtcGl4ZWwtcmF0 aW8iLCAiUmF0aW8gYmV0d2VlbiB0aGUgQ1NTIHVuaXRzIGFuZCBkZXZpY2UgcGl4ZWxzLiIpLAog ICAgICAgICBFQ09SRV9HRVRPUFRfQ0FMTEJBQ0tfTk9BUkdTCiAgICAgICAgICAgICAoJ0UnLCAi bGlzdC1lbmdpbmVzIiwgImxpc3QgZWNvcmUtZXZhcyBlbmdpbmVzLiIsCiAgICAgICAgICAgICAg ZWNvcmVfZ2V0b3B0X2NhbGxiYWNrX2Vjb3JlX2V2YXNfbGlzdF9lbmdpbmVzLCBOVUxMKSwKQEAg LTEwMzAsNiArMTAzNSw4IEBAIHN0YXRpYyBCcm93c2VyX1dpbmRvdyAqd2luZG93X2NyZWF0ZShj b25zdCBjaGFyICp1cmwpCiAgICAgRXZhc19TbWFydCAqc21hcnQgPSBldmFzX3NtYXJ0X2NsYXNz X25ldygmZXdrVmlld0NsYXNzLT5zYyk7CiAgICAgYXBwX2RhdGEtPndlYnZpZXcgPSBld2tfdmll d19zbWFydF9hZGQoZXZhcywgc21hcnQsIGV3a19jb250ZXh0X2RlZmF1bHRfZ2V0KCkpOwogICAg IGV3a192aWV3X3RoZW1lX3NldChhcHBfZGF0YS0+d2VidmlldywgVEhFTUVfRElSICIvZGVmYXVs dC5lZGoiKTsKKyAgICBpZiAoZGV2aWNlX3BpeGVsX3JhdGlvKQorICAgICAgICBld2tfdmlld19k ZXZpY2VfcGl4ZWxfcmF0aW9fc2V0KGFwcF9kYXRhLT53ZWJ2aWV3LCAoZmxvYXQpZGV2aWNlX3Bp eGVsX3JhdGlvKTsKIAogICAgIEV3a19TZXR0aW5ncyAqc2V0dGluZ3MgPSBld2tfdmlld19zZXR0 aW5nc19nZXQoYXBwX2RhdGEtPndlYnZpZXcpOwogICAgIGV3a19zZXR0aW5nc19maWxlX2FjY2Vz c19mcm9tX2ZpbGVfdXJsc19hbGxvd2VkX3NldChzZXR0aW5ncywgRUlOQV9UUlVFKTsKQEAgLTEx MDksNiArMTExNiw3IEBAIGVsbV9tYWluKGludCBhcmdjLCBjaGFyICphcmd2W10pCiAgICAgRWNv cmVfR2V0b3B0X1ZhbHVlIHZhbHVlc1tdID0gewogICAgICAgICBFQ09SRV9HRVRPUFRfVkFMVUVf U1RSKGV2YXNfZW5naW5lX25hbWUpLAogICAgICAgICBFQ09SRV9HRVRPUFRfVkFMVUVfU1RSKHdp bmRvd19zaXplX3N0cmluZyksCisgICAgICAgIEVDT1JFX0dFVE9QVF9WQUxVRV9ET1VCTEUoZGV2 aWNlX3BpeGVsX3JhdGlvKSwKICAgICAgICAgRUNPUkVfR0VUT1BUX1ZBTFVFX0JPT0wocXVpdE9w dGlvbiksCiAgICAgICAgIEVDT1JFX0dFVE9QVF9WQUxVRV9CT09MKGVuY29kaW5nX2RldGVjdG9y X2VuYWJsZWQpLAogICAgICAgICBFQ09SRV9HRVRPUFRfVkFMVUVfQk9PTChmcmFtZV9mbGF0dGVu aW5nX2VuYWJsZWQpLAo=