101924 2012-11-12 04:17:43 -0800 [BlackBerry] Avoid using gradient in RenderThemeBlackBerry when drawing media controls 2013-05-21 19:05:27 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 100760 P2 Normal --- 1 jonathan.dong.webkit jonathan.dong.webkit charles.wei jrogers mifenton robin.webkit rwlbuis staikos tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 764245 0 jonathan.dong.webkit 2012-11-12 04:17:43 -0800 Gradient is not fully supported since we've enabled GL, which causes the media controls are not drawn. We'd temporarily remove the gradient codes when drawing media controls. 764252 1 173615 jonathan.dong.webkit 2012-11-12 04:26:34 -0800 Created attachment 173615 Patch 764253 2 jonathan.dong.webkit 2012-11-12 04:30:18 -0800 RIM PR: 240586 768515 3 173615 rwlbuis 2012-11-15 14:45:12 -0800 Comment on attachment 173615 Patch This has already been done as part of bug 100760. 892083 4 jrogers 2013-05-21 19:05:27 -0700 *** This bug has been marked as a duplicate of bug 100760 *** 173615 2012-11-12 04:26:34 -0800 2012-11-15 14:45:12 -0800 Patch bug-101924-20121112202435.patch text/plain 7149 jonathan.dong.webkit U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0MjA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjQ1M2EyZjBkMWI4M2Ri NTYyNjhmNTg3NmJmNWI0Yzc4NmI0Y2VjOS4uMjcwZGY2MGZiMWM3YmQ1N2U2NGFmNTg5ODMxYWQy ZTI3MGVlN2Q1ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEyLTExLTEyICBKb25h dGhhbiBEb25nICA8am9uYXRoYW4uZG9uZ0B0b3JjaG1vYmlsZS5jb20uY24+CisKKyAgICAgICAg W0JsYWNrQmVycnldIEF2b2lkIHVzaW5nIGdyYWRpZW50IGluIFJlbmRlclRoZW1lQmxhY2tCZXJy eSB3aGVuIGRyYXdpbmcgbWVkaWEgY29udHJvbHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMTkyNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSBncmFkaWVudCBkcmF3aW5nIGNvZGVzIHdoZW4g ZHJhd2luZyBtZWRpYSBjb250cm9scyBzaW5jZSBpdCBpcworICAgICAgICBub3QgZnVsbHkgc3Vw cG9ydGVkIGFmdGVyIEdMIGdldHMgZW5hYmxlZC4KKyAgICAgICAgTk9USUNFOiBUaGlzIGlzIHRo ZSB0ZW1wb3Jhcnkgc29sdXRpb24gYW5kIHdpbGwgYmUgcmVwbGFjZWQgd2l0aCB0aGUgbmV3Cisg ICAgICAgIG1lZGlhIGNvbnRyb2xzIGJhc2VkIG9uIHRoZSBuZXcgVVggc3BlYy4KKyAgICAgICAg SW50ZXJuYWxseSByZXZpZXdlZCBieSBSb2JpbiBDYW8gPHJvYmluLmNhb0B0b3JjaG1vYmlsZS5j b20uY24+CisKKyAgICAgICAgTm8gbmV3IHRlc3RzIHNpbmNlIHRoZXJlJ3Mgbm8gZnVuY3Rpb25h bCBjaGFuZ2UuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ibGFja2JlcnJ5L1JlbmRlclRoZW1lQmxh Y2tCZXJyeS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJUaGVtZUJsYWNrQmVycnk6OnBh aW50U2xpZGVyVHJhY2tSZWN0KToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRoZW1lQmxhY2tC ZXJyeTo6cGFpbnRTbGlkZXJUaHVtYik6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJUaGVtZUJs YWNrQmVycnk6OnBhaW50TWVkaWFTbGlkZXJUaHVtYik6CisgICAgICAgIChXZWJDb3JlOjpSZW5k ZXJUaGVtZUJsYWNrQmVycnk6OnBhaW50UHJvZ3Jlc3NCYXIpOgorCiAyMDEyLTExLTEyICBTaGVy aWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmll d2VkLCByb2xsaW5nIG91dCByMTM0MTU0LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vYmxhY2tiZXJyeS9SZW5kZXJUaGVtZUJsYWNrQmVycnkuY3BwIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vYmxhY2tiZXJyeS9SZW5kZXJUaGVtZUJsYWNrQmVycnkuY3BwCmluZGV4IDRj NTYzYTBlODRiZjZhN2NkM2ZlYjIxNDE2NzliZDQzYjQ4OGNlNGQuLmE5MTJiYzExMjhiYjFiMTRl ZTE4MjlhYTQyMjQ1NjhjMzdiNWU0NjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2JsYWNrYmVycnkvUmVuZGVyVGhlbWVCbGFja0JlcnJ5LmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ibGFja2JlcnJ5L1JlbmRlclRoZW1lQmxhY2tCZXJyeS5jcHAKQEAgLTcx Nyw4ICs3MTcsOCBAQCBib29sIFJlbmRlclRoZW1lQmxhY2tCZXJyeTo6cGFpbnRTbGlkZXJUcmFj a1JlY3QoUmVuZGVyT2JqZWN0KiBvYmplY3QsIGNvbnN0IFBhaQogICAgIGluZm8uY29udGV4dC0+ c2V0U3Ryb2tlU3R5bGUoU29saWRTdHJva2UpOwogICAgIGluZm8uY29udGV4dC0+c2V0U3Ryb2tl VGhpY2tuZXNzKGxpbmVXaWR0aCk7CiAKLSAgICBpbmZvLmNvbnRleHQtPnNldFN0cm9rZUdyYWRp ZW50KGNyZWF0ZUxpbmVhckdyYWRpZW50KHN0cm9rZUNvbG9yU3RhcnQsIHN0cm9rZUNvbG9yRW5k LCByZWN0Lm1heFhNaW5ZQ29ybmVyKCksIHJlY3QuIG1heFhNYXhZQ29ybmVyKCkpKTsKLSAgICBp bmZvLmNvbnRleHQtPnNldEZpbGxHcmFkaWVudChjcmVhdGVMaW5lYXJHcmFkaWVudChmaWxsQ29s b3JTdGFydCwgZmlsbENvbG9yRW5kLCByZWN0Lm1heFhNaW5ZQ29ybmVyKCksIHJlY3QubWF4WE1h eFlDb3JuZXIoKSkpOworICAgIGluZm8uY29udGV4dC0+c2V0U3Ryb2tlQ29sb3Ioc3Ryb2tlQ29s b3JFbmQsIENvbG9yU3BhY2VEZXZpY2VSR0IpOworICAgIGluZm8uY29udGV4dC0+c2V0RmlsbENv bG9yKGZpbGxDb2xvckVuZCwgQ29sb3JTcGFjZURldmljZVJHQik7CiAKICAgICBQYXRoIHBhdGg7 CiAgICAgcGF0aC5hZGRSb3VuZGVkUmVjdChyZWN0LCBzbWFsbENvcm5lcik7CkBAIC03MzUsMTEg KzczNSwxMSBAQCBib29sIFJlbmRlclRoZW1lQmxhY2tCZXJyeTo6cGFpbnRTbGlkZXJUaHVtYihS ZW5kZXJPYmplY3QqIG9iamVjdCwgY29uc3QgUGFpbnRJbgogICAgIGluZm8uY29udGV4dC0+c2V0 U3Ryb2tlU3R5bGUoU29saWRTdHJva2UpOwogICAgIGluZm8uY29udGV4dC0+c2V0U3Ryb2tlVGhp Y2tuZXNzKGxpbmVXaWR0aCk7CiAgICAgaWYgKGlzUHJlc3NlZChvYmplY3QpIHx8IGlzSG92ZXJl ZChvYmplY3QpKSB7Ci0gICAgICAgIGluZm8uY29udGV4dC0+c2V0U3Ryb2tlR3JhZGllbnQoY3Jl YXRlTGluZWFyR3JhZGllbnQoaG92ZXJUb3BPdXRsaW5lLCBob3ZlckJvdHRvbU91dGxpbmUsIHJl Y3QubWF4WE1pbllDb3JuZXIoKSwgcmVjdC4gbWF4WE1heFlDb3JuZXIoKSkpOwotICAgICAgICBp bmZvLmNvbnRleHQtPnNldEZpbGxHcmFkaWVudChjcmVhdGVMaW5lYXJHcmFkaWVudChob3ZlclRv cCwgaG92ZXJCb3R0b20sIHJlY3QubWF4WE1pbllDb3JuZXIoKSwgcmVjdC5tYXhYTWF4WUNvcm5l cigpKSk7CisgICAgICAgIGluZm8uY29udGV4dC0+c2V0U3Ryb2tlQ29sb3IoaG92ZXJCb3R0b21P dXRsaW5lLCBDb2xvclNwYWNlRGV2aWNlUkdCKTsKKyAgICAgICAgaW5mby5jb250ZXh0LT5zZXRG aWxsQ29sb3IoaG92ZXJCb3R0b20sIENvbG9yU3BhY2VEZXZpY2VSR0IpOwogICAgIH0gZWxzZSB7 Ci0gICAgICAgIGluZm8uY29udGV4dC0+c2V0U3Ryb2tlR3JhZGllbnQoY3JlYXRlTGluZWFyR3Jh ZGllbnQocmVndWxhclRvcE91dGxpbmUsIHJlZ3VsYXJCb3R0b21PdXRsaW5lLCByZWN0Lm1heFhN aW5ZQ29ybmVyKCksIHJlY3QuIG1heFhNYXhZQ29ybmVyKCkpKTsKLSAgICAgICAgaW5mby5jb250 ZXh0LT5zZXRGaWxsR3JhZGllbnQoY3JlYXRlTGluZWFyR3JhZGllbnQocmVndWxhclRvcCwgcmVn dWxhckJvdHRvbSwgcmVjdC5tYXhYTWluWUNvcm5lcigpLCByZWN0Lm1heFhNYXhZQ29ybmVyKCkp KTsKKyAgICAgICAgaW5mby5jb250ZXh0LT5zZXRTdHJva2VDb2xvcihyZWd1bGFyQm90dG9tT3V0 bGluZSwgQ29sb3JTcGFjZURldmljZVJHQik7CisgICAgICAgIGluZm8uY29udGV4dC0+c2V0Rmls bENvbG9yKHJlZ3VsYXJCb3R0b20sIENvbG9yU3BhY2VEZXZpY2VSR0IpOwogICAgIH0KICAgICBQ YXRoIHBhdGg7CiAgICAgcGF0aC5hZGRSb3VuZGVkUmVjdChyZWN0LCBsYXJnZUNvcm5lcik7CkBA IC05ODIsMjYgKzk4MiwxMiBAQCBib29sIFJlbmRlclRoZW1lQmxhY2tCZXJyeTo6cGFpbnRNZWRp YVNsaWRlclRodW1iKFJlbmRlck9iamVjdCogb2JqZWN0LCBjb25zdCBQYQogICAgIGlmICghc2xp ZGVyKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKLSAgICBmbG9hdCBmdWxsU2NyZWVuTXVsdGlw bGllciA9IGRldGVybWluZUZ1bGxTY3JlZW5NdWx0aXBsaWVyKHRvRWxlbWVudChzbGlkZXItPm5v ZGUoKSkpOworICAgIHN0YXRpYyBJbWFnZSogbWVkaWFUaHVtYiA9IEltYWdlOjpsb2FkUGxhdGZv cm1SZXNvdXJjZSgibWVkaWFfdGh1bWIiKS5sZWFrUmVmKCk7CisgICAgc3RhdGljIEltYWdlKiBt ZWRpYVRodW1iUHJlc3NlZCA9IEltYWdlOjpsb2FkUGxhdGZvcm1SZXNvdXJjZSgibWVkaWFfdGh1 bWJfcHJlc3NlZCIpLmxlYWtSZWYoKTsKIAotICAgIHBhaW50SW5mby5jb250ZXh0LT5zYXZlKCk7 Ci0gICAgUGF0aCBtZWRpYVRodW1iUm91bmRlZFJlY3RhbmdsZTsKLSAgICBtZWRpYVRodW1iUm91 bmRlZFJlY3RhbmdsZS5hZGRSb3VuZGVkUmVjdChyZWN0LCBGbG9hdFNpemUobWVkaWFTbGlkZXJU aHVtYlJhZGl1cyAqIGZ1bGxTY3JlZW5NdWx0aXBsaWVyLCBtZWRpYVNsaWRlclRodW1iUmFkaXVz ICogZnVsbFNjcmVlbk11bHRpcGxpZXIpKTsKLSAgICBwYWludEluZm8uY29udGV4dC0+c2V0U3Ry b2tlU3R5bGUoU29saWRTdHJva2UpOwotICAgIHBhaW50SW5mby5jb250ZXh0LT5zZXRTdHJva2VU aGlja25lc3MoMC41KTsKLSAgICBwYWludEluZm8uY29udGV4dC0+c2V0U3Ryb2tlQ29sb3IoQ29s b3I6OmJsYWNrLCBDb2xvclNwYWNlRGV2aWNlUkdCKTsKLQotICAgIGlmIChpc1ByZXNzZWQob2Jq ZWN0KSB8fCBpc0hvdmVyZWQob2JqZWN0KSB8fCBzbGlkZXItPmluRHJhZ01vZGUoKSkgewotICAg ICAgICBwYWludEluZm8uY29udGV4dC0+c2V0RmlsbEdyYWRpZW50KGNyZWF0ZUxpbmVhckdyYWRp ZW50KHNlbGVjdGlvbiwgQ29sb3Ioc2VsZWN0aW9uKS5kYXJrKCkucmdiKCksCi0gICAgICAgICAg ICAgICAgcmVjdC5tYXhYTWluWUNvcm5lcigpLCByZWN0Lm1heFhNYXhZQ29ybmVyKCkpKTsKLSAg ICB9IGVsc2UgewotICAgICAgICBwYWludEluZm8uY29udGV4dC0+c2V0RmlsbEdyYWRpZW50KGNy ZWF0ZUxpbmVhckdyYWRpZW50KENvbG9yOjp3aGl0ZSwgQ29sb3IoQ29sb3I6OndoaXRlKS5kYXJr KCkucmdiKCksCi0gICAgICAgICAgICAgICAgcmVjdC5tYXhYTWluWUNvcm5lcigpLCByZWN0Lm1h eFhNYXhZQ29ybmVyKCkpKTsKLSAgICB9Ci0gICAgcGFpbnRJbmZvLmNvbnRleHQtPmZpbGxQYXRo KG1lZGlhVGh1bWJSb3VuZGVkUmVjdGFuZ2xlKTsKLSAgICBwYWludEluZm8uY29udGV4dC0+cmVz dG9yZSgpOwotCi0gICAgcmV0dXJuIHRydWU7CisgICAgaWYgKGlzUHJlc3NlZChvYmplY3QpIHx8 IGlzSG92ZXJlZChvYmplY3QpIHx8IHNsaWRlci0+aW5EcmFnTW9kZSgpKQorICAgICAgICByZXR1 cm4gcGFpbnRNZWRpYUJ1dHRvbihwYWludEluZm8uY29udGV4dCwgcmVjdCwgbWVkaWFUaHVtYlBy ZXNzZWQpOworICAgIHJldHVybiBwYWludE1lZGlhQnV0dG9uKHBhaW50SW5mby5jb250ZXh0LCBy ZWN0LCBtZWRpYVRodW1iKTsKICNlbHNlCiAgICAgVU5VU0VEX1BBUkFNKG9iamVjdCk7CiAgICAg VU5VU0VEX1BBUkFNKHBhaW50SW5mbyk7CkBAIC0xMDg0LDggKzEwNzAsOCBAQCBib29sIFJlbmRl clRoZW1lQmxhY2tCZXJyeTo6cGFpbnRQcm9ncmVzc0JhcihSZW5kZXJPYmplY3QqIG9iamVjdCwg Y29uc3QgUGFpbnRJbgogICAgIGluZm8uY29udGV4dC0+c2V0U3Ryb2tlU3R5bGUoU29saWRTdHJv a2UpOwogICAgIGluZm8uY29udGV4dC0+c2V0U3Ryb2tlVGhpY2tuZXNzKGxpbmVXaWR0aCk7CiAK LSAgICBpbmZvLmNvbnRleHQtPnNldFN0cm9rZUdyYWRpZW50KGNyZWF0ZUxpbmVhckdyYWRpZW50 KHJhbmdlU2xpZGVyUmVndWxhclRvcE91dGxpbmUsIHJhbmdlU2xpZGVyUmVndWxhckJvdHRvbU91 dGxpbmUsIHJlY3QubWF4WE1pbllDb3JuZXIoKSwgcmVjdC5tYXhYTWF4WUNvcm5lcigpKSk7Ci0g ICAgaW5mby5jb250ZXh0LT5zZXRGaWxsR3JhZGllbnQoY3JlYXRlTGluZWFyR3JhZGllbnQocmFu Z2VTbGlkZXJSZWd1bGFyVG9wLCByYW5nZVNsaWRlclJlZ3VsYXJCb3R0b20sIHJlY3QubWF4WE1p bllDb3JuZXIoKSwgcmVjdC5tYXhYTWF4WUNvcm5lcigpKSk7CisgICAgaW5mby5jb250ZXh0LT5z ZXRTdHJva2VDb2xvcihyYW5nZVNsaWRlclJlZ3VsYXJCb3R0b21PdXRsaW5lLCBDb2xvclNwYWNl RGV2aWNlUkdCKTsKKyAgICBpbmZvLmNvbnRleHQtPnNldEZpbGxDb2xvcihyYW5nZVNsaWRlclJl Z3VsYXJCb3R0b20sIENvbG9yU3BhY2VEZXZpY2VSR0IpOwogCiAgICAgUGF0aCBwYXRoOwogICAg IHBhdGguYWRkUm91bmRlZFJlY3QocmVjdCwgc21hbGxDb3JuZXIpOwpAQCAtMTA5OSwxNSArMTA4 NSwxMSBAQCBib29sIFJlbmRlclRoZW1lQmxhY2tCZXJyeTo6cGFpbnRQcm9ncmVzc0JhcihSZW5k ZXJPYmplY3QqIG9iamVjdCwgY29uc3QgUGFpbnRJbgogICAgIGluZm8uY29udGV4dC0+c2V0U3Ry b2tlVGhpY2tuZXNzKDApOwogICAgIGlmIChyZW5kZXJQcm9ncmVzcy0+aXNEZXRlcm1pbmF0ZSgp KSB7CiAgICAgICAgIHJlY3QyLnNldFdpZHRoKHJlY3QyLndpZHRoKCkgKiByZW5kZXJQcm9ncmVz cy0+cG9zaXRpb24oKSAtIDIpOwotICAgICAgICBpbmZvLmNvbnRleHQtPnNldEZpbGxHcmFkaWVu dChjcmVhdGVMaW5lYXJHcmFkaWVudChwcm9ncmVzc1JlZ3VsYXJUb3AsIHByb2dyZXNzUmVndWxh ckJvdHRvbSwgcmVjdDIubWF4WE1pbllDb3JuZXIoKSwgcmVjdDIubWF4WE1heFlDb3JuZXIoKSkp OworICAgICAgICBpbmZvLmNvbnRleHQtPnNldEZpbGxDb2xvcihwcm9ncmVzc1JlZ3VsYXJCb3R0 b20sIENvbG9yU3BhY2VEZXZpY2VSR0IpOwogICAgIH0gZWxzZSB7CiAgICAgICAgIC8vIEFuaW1h dGluZwogICAgICAgICByZWN0Mi5zZXRXaWR0aChyZWN0Mi53aWR0aCgpIC0gMik7Ci0gICAgICAg IFJlZlB0cjxHcmFkaWVudD4gZ3JhZGllbnQgPSBHcmFkaWVudDo6Y3JlYXRlKHJlY3QyLm1pblhN YXhZQ29ybmVyKCksIHJlY3QyLm1heFhNYXhZQ29ybmVyKCkpOwotICAgICAgICBncmFkaWVudC0+ YWRkQ29sb3JTdG9wKDAuMCwgQ29sb3IocHJvZ3Jlc3NSZWd1bGFyQm90dG9tKSk7Ci0gICAgICAg IGdyYWRpZW50LT5hZGRDb2xvclN0b3AocmVuZGVyUHJvZ3Jlc3MtPmFuaW1hdGlvblByb2dyZXNz KCksIENvbG9yKHByb2dyZXNzUmVndWxhclRvcCkpOwotICAgICAgICBncmFkaWVudC0+YWRkQ29s b3JTdG9wKDEuMCwgQ29sb3IocHJvZ3Jlc3NSZWd1bGFyQm90dG9tKSk7Ci0gICAgICAgIGluZm8u Y29udGV4dC0+c2V0RmlsbEdyYWRpZW50KGdyYWRpZW50KTsKKyAgICAgICAgaW5mby5jb250ZXh0 LT5zZXRGaWxsQ29sb3IoQ29sb3IocHJvZ3Jlc3NSZWd1bGFyQm90dG9tKSwgQ29sb3JTcGFjZURl dmljZVJHQik7CiAgICAgfQogICAgIFBhdGggcGF0aDI7CiAgICAgcGF0aDIuYWRkUm91bmRlZFJl Y3QocmVjdDIsIHNtYWxsQ29ybmVyKTsK