101914 2012-11-12 02:26:54 -0800 [V8] Make isValidDOMObject() static 2012-11-13 03:45:35 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 haraken haraken abarth japhet webkit.review.bot oldest_to_newest 764170 0 haraken 2012-11-12 02:26:54 -0800 isValidDOMObject() is used by DOMWrapper.cpp only. 764172 1 173593 haraken 2012-11-12 02:28:54 -0800 Created attachment 173593 Patch 764497 2 173593 abarth 2012-11-12 09:36:50 -0800 Comment on attachment 173593 Patch isValidDOMObject is kind of a misnomer. Many things can have an InternalFieldCount but not be DOM objects. 765374 3 173846 haraken 2012-11-13 01:04:11 -0800 Created attachment 173846 Patch 765376 4 haraken 2012-11-13 01:06:01 -0800 (In reply to comment #2) > isValidDOMObject is kind of a misnomer. Renamed it to hasInternalField(). 765450 5 173846 webkit.review.bot 2012-11-13 03:45:32 -0800 Comment on attachment 173846 Patch Clearing flags on attachment: 173846 Committed r134396: <http://trac.webkit.org/changeset/134396> 765451 6 webkit.review.bot 2012-11-13 03:45:35 -0800 All reviewed patches have been landed. Closing bug. 173593 2012-11-12 02:28:54 -0800 2012-11-13 01:04:06 -0800 Patch bug-101914-20121112192657.patch text/plain 3119 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0MTc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2IzZDBmMGRiOWNmYTE5 N2M1NzU4MWRlZjQ0ZDI5ODRlMmRjOWFkOC4uNzkzZjA1NDhjZjMxNTU0NWI5MWJmY2YxYmFlNmJh ZDkzNWYxZTY0NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTExLTEyICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIE1ha2UgaXNW YWxpZERPTU9iamVjdCgpIHN0YXRpYworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTAxOTE0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgaXNWYWxpZERPTU9iamVjdCgpIGlzIHVzZWQgYnkgRE9NV3JhcHBlci5j cHAgb25seS4KKworICAgICAgICBObyB0ZXN0cy4gTm8gY2hhbmdlIGluIGJlaGF2aW9yLgorCisg ICAgICAgICogYmluZGluZ3MvdjgvVjhET01XcmFwcGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OmlzVmFsaWRET01PYmplY3QpOgorICAgICAgICAoV2ViQ29yZSk6CisgICAgICAgIChXZWJDb3Jl OjpWOERPTVdyYXBwZXI6Om1heWJlRE9NV3JhcHBlcik6CisgICAgICAgICogYmluZGluZ3Mvdjgv VjhET01XcmFwcGVyLmg6CisgICAgICAgIChWOERPTVdyYXBwZXIpOgorCiAyMDEyLTExLTEwICBT aW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFNhdmUgb25l IGNhbGwgdG8gY29udGFpbmVyRm9yUmVwYWludCgpIHdoZW4gdXBkYXRpbmcgbGF5ZXIgcG9zaXRp b25zCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTVdyYXBwZXIu Y3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhET01XcmFwcGVyLmNwcAppbmRleCBh YWM5NWRiZWUyYTNjMjA1YmUxYzAzMTUyNDA5MmQ5YzFmMzViYjQ2Li44MjE4Y2U1OGNlNDI5Nzk2 MzRkMzIxNDVkYzU3ZmQ5NWEwNWNkMmM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy92OC9WOERPTVdyYXBwZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4 L1Y4RE9NV3JhcHBlci5jcHAKQEAgLTExOSwxNCArMTE5LDE3IEBAIHY4OjpMb2NhbDx2ODo6T2Jq ZWN0PiBWOERPTVdyYXBwZXI6Omluc3RhbnRpYXRlVjhPYmplY3QoRG9jdW1lbnQqIGRlcHJlY2F0 ZWREb2N1CiAgICAgcmV0dXJuIGluc3RhbmNlOwogfQogCi0jaWZuZGVmIE5ERUJVRwotYm9vbCBW OERPTVdyYXBwZXI6Om1heWJlRE9NV3JhcHBlcih2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gdmFsdWUp CitzdGF0aWMgYm9vbCBpc1ZhbGlkRE9NT2JqZWN0KHY4OjpIYW5kbGU8djg6OlZhbHVlPiB2YWx1 ZSkKIHsKICAgICBpZiAodmFsdWUuSXNFbXB0eSgpIHx8ICF2YWx1ZS0+SXNPYmplY3QoKSkKICAg ICAgICAgcmV0dXJuIGZhbHNlOworICAgIHJldHVybiB2ODo6SGFuZGxlPHY4OjpPYmplY3Q+OjpD YXN0KHZhbHVlKS0+SW50ZXJuYWxGaWVsZENvdW50KCk7Cit9CiAKLSAgICB2ODo6SGFuZGxlPHY4 OjpPYmplY3Q+IG9iamVjdCA9IHY4OjpIYW5kbGU8djg6Ok9iamVjdD46OkNhc3QodmFsdWUpOwot ICAgIGlmICghb2JqZWN0LT5JbnRlcm5hbEZpZWxkQ291bnQoKSkKKyNpZm5kZWYgTkRFQlVHCiti b29sIFY4RE9NV3JhcHBlcjo6bWF5YmVET01XcmFwcGVyKHY4OjpIYW5kbGU8djg6OlZhbHVlPiB2 YWx1ZSkKK3sKKyAgICBpZiAoIWlzVmFsaWRET01PYmplY3QodmFsdWUpKQogICAgICAgICByZXR1 cm4gZmFsc2U7CiAKICAgICBBU1NFUlQob2JqZWN0LT5JbnRlcm5hbEZpZWxkQ291bnQoKSA+PSB2 OERlZmF1bHRXcmFwcGVySW50ZXJuYWxGaWVsZENvdW50KTsKQEAgLTEzOSwxMyArMTQyLDYgQEAg Ym9vbCBWOERPTVdyYXBwZXI6Om1heWJlRE9NV3JhcHBlcih2ODo6SGFuZGxlPHY4OjpWYWx1ZT4g dmFsdWUpCiB9CiAjZW5kaWYKIAotYm9vbCBWOERPTVdyYXBwZXI6OmlzVmFsaWRET01PYmplY3Qo djg6OkhhbmRsZTx2ODo6VmFsdWU+IHZhbHVlKQotewotICAgIGlmICh2YWx1ZS5Jc0VtcHR5KCkg fHwgIXZhbHVlLT5Jc09iamVjdCgpKQotICAgICAgICByZXR1cm4gZmFsc2U7Ci0gICAgcmV0dXJu IHY4OjpIYW5kbGU8djg6Ok9iamVjdD46OkNhc3QodmFsdWUpLT5JbnRlcm5hbEZpZWxkQ291bnQo KTsKLX0KLQogYm9vbCBWOERPTVdyYXBwZXI6OmlzV3JhcHBlck9mVHlwZSh2ODo6SGFuZGxlPHY4 OjpWYWx1ZT4gdmFsdWUsIFdyYXBwZXJUeXBlSW5mbyogdHlwZSkKIHsKICAgICBpZiAoIWlzVmFs aWRET01PYmplY3QodmFsdWUpKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv djgvVjhET01XcmFwcGVyLmggYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTVdyYXBw ZXIuaAppbmRleCBlMDQyNGU4MTczZjY2YWY2Y2UzMTY4Mzk1M2RmYTBlYjViNzE0Njg3Li5hY2Fh NDEyNjQ3NDZkYTcyMTdmMDA2Njc4NmUwOWQxNTM0ZDc2MTc2IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTVdyYXBwZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy92OC9WOERPTVdyYXBwZXIuaApAQCAtMTAzLDggKzEwMyw2IEBAIG5hbWVzcGFjZSBX ZWJDb3JlIHsKICAgICAgICAgdGVtcGxhdGU8dHlwZW5hbWUgVD4KICAgICAgICAgc3RhdGljIHY4 OjpQZXJzaXN0ZW50PHY4OjpPYmplY3Q+IHNldEpTV3JhcHBlckZvckRPTU9iamVjdChQYXNzUmVm UHRyPFQ+LCB2ODo6SGFuZGxlPHY4OjpPYmplY3Q+LCB2ODo6SXNvbGF0ZSogPSAwKTsKIAotICAg ICAgICBzdGF0aWMgYm9vbCBpc1ZhbGlkRE9NT2JqZWN0KHY4OjpIYW5kbGU8djg6OlZhbHVlPik7 Ci0KICAgICAgICAgLy8gQ2hlY2sgd2hldGhlciBhIFY4IHZhbHVlIGlzIGEgd3JhcHBlciBvZiB0 eXBlIHxjbGFzc1R5cGV8LgogICAgICAgICBzdGF0aWMgYm9vbCBpc1dyYXBwZXJPZlR5cGUodjg6 OkhhbmRsZTx2ODo6VmFsdWU+LCBXcmFwcGVyVHlwZUluZm8qKTsKIAo= 173846 2012-11-13 01:04:11 -0800 2012-11-13 03:45:31 -0800 Patch bug-101914-20121113180211.patch text/plain 3249 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0MTc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2IzZDBmMGRiOWNmYTE5 N2M1NzU4MWRlZjQ0ZDI5ODRlMmRjOWFkOC4uN2UwMzAxOTcxMzdhOGRlY2M2MmRkN2NlNmFhMWMz ODdiYzNhMDhlMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTExLTEyICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIE1ha2UgaXNW YWxpZERPTU9iamVjdCgpIHN0YXRpYworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTAxOTE0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4K KworICAgICAgICBpc1ZhbGlkRE9NT2JqZWN0KCkgaXMgdXNlZCBieSBET01XcmFwcGVyLmNwcCBv bmx5LgorCisgICAgICAgIE5vIHRlc3RzLiBObyBjaGFuZ2UgaW4gYmVoYXZpb3IuCisKKyAgICAg ICAgKiBiaW5kaW5ncy92OC9WOERPTVdyYXBwZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6aXNW YWxpZERPTU9iamVjdCk6CisgICAgICAgIChXZWJDb3JlKToKKyAgICAgICAgKFdlYkNvcmU6OlY4 RE9NV3JhcHBlcjo6bWF5YmVET01XcmFwcGVyKToKKyAgICAgICAgKiBiaW5kaW5ncy92OC9WOERP TVdyYXBwZXIuaDoKKyAgICAgICAgKFY4RE9NV3JhcHBlcik6CisKIDIwMTItMTEtMTAgIFNpbW9u IEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgU2F2ZSBvbmUgY2Fs bCB0byBjb250YWluZXJGb3JSZXBhaW50KCkgd2hlbiB1cGRhdGluZyBsYXllciBwb3NpdGlvbnMK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9NV3JhcHBlci5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTVdyYXBwZXIuY3BwCmluZGV4IGFhYzk1 ZGJlZTJhM2MyMDViZTFjMDMxNTI0MDkyZDljMWYzNWJiNDYuLmEyNmFjNGYxN2VkNDI1NmI2NWQ5 ZmY1ZWU0YjYyMWM5NDY3ZDBmZGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L3Y4L1Y4RE9NV3JhcHBlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhE T01XcmFwcGVyLmNwcApAQCAtMTE5LDE0ICsxMTksMTcgQEAgdjg6OkxvY2FsPHY4OjpPYmplY3Q+ IFY4RE9NV3JhcHBlcjo6aW5zdGFudGlhdGVWOE9iamVjdChEb2N1bWVudCogZGVwcmVjYXRlZERv Y3UKICAgICByZXR1cm4gaW5zdGFuY2U7CiB9CiAKLSNpZm5kZWYgTkRFQlVHCi1ib29sIFY4RE9N V3JhcHBlcjo6bWF5YmVET01XcmFwcGVyKHY4OjpIYW5kbGU8djg6OlZhbHVlPiB2YWx1ZSkKK3N0 YXRpYyBib29sIGhhc0ludGVybmFsRmllbGQodjg6OkhhbmRsZTx2ODo6VmFsdWU+IHZhbHVlKQog ewogICAgIGlmICh2YWx1ZS5Jc0VtcHR5KCkgfHwgIXZhbHVlLT5Jc09iamVjdCgpKQogICAgICAg ICByZXR1cm4gZmFsc2U7CisgICAgcmV0dXJuIHY4OjpIYW5kbGU8djg6Ok9iamVjdD46OkNhc3Qo dmFsdWUpLT5JbnRlcm5hbEZpZWxkQ291bnQoKTsKK30KIAotICAgIHY4OjpIYW5kbGU8djg6Ok9i amVjdD4gb2JqZWN0ID0gdjg6OkhhbmRsZTx2ODo6T2JqZWN0Pjo6Q2FzdCh2YWx1ZSk7Ci0gICAg aWYgKCFvYmplY3QtPkludGVybmFsRmllbGRDb3VudCgpKQorI2lmbmRlZiBOREVCVUcKK2Jvb2wg VjhET01XcmFwcGVyOjptYXliZURPTVdyYXBwZXIodjg6OkhhbmRsZTx2ODo6VmFsdWU+IHZhbHVl KQoreworICAgIGlmICghaGFzSW50ZXJuYWxGaWVsZCh2YWx1ZSkpCiAgICAgICAgIHJldHVybiBm YWxzZTsKIAogICAgIEFTU0VSVChvYmplY3QtPkludGVybmFsRmllbGRDb3VudCgpID49IHY4RGVm YXVsdFdyYXBwZXJJbnRlcm5hbEZpZWxkQ291bnQpOwpAQCAtMTM5LDE2ICsxNDIsOSBAQCBib29s IFY4RE9NV3JhcHBlcjo6bWF5YmVET01XcmFwcGVyKHY4OjpIYW5kbGU8djg6OlZhbHVlPiB2YWx1 ZSkKIH0KICNlbmRpZgogCi1ib29sIFY4RE9NV3JhcHBlcjo6aXNWYWxpZERPTU9iamVjdCh2ODo6 SGFuZGxlPHY4OjpWYWx1ZT4gdmFsdWUpCi17Ci0gICAgaWYgKHZhbHVlLklzRW1wdHkoKSB8fCAh dmFsdWUtPklzT2JqZWN0KCkpCi0gICAgICAgIHJldHVybiBmYWxzZTsKLSAgICByZXR1cm4gdjg6 OkhhbmRsZTx2ODo6T2JqZWN0Pjo6Q2FzdCh2YWx1ZSktPkludGVybmFsRmllbGRDb3VudCgpOwot fQotCiBib29sIFY4RE9NV3JhcHBlcjo6aXNXcmFwcGVyT2ZUeXBlKHY4OjpIYW5kbGU8djg6OlZh bHVlPiB2YWx1ZSwgV3JhcHBlclR5cGVJbmZvKiB0eXBlKQogewotICAgIGlmICghaXNWYWxpZERP TU9iamVjdCh2YWx1ZSkpCisgICAgaWYgKCFoYXNJbnRlcm5hbEZpZWxkKHZhbHVlKSkKICAgICAg ICAgcmV0dXJuIGZhbHNlOwogCiAgICAgdjg6OkhhbmRsZTx2ODo6T2JqZWN0PiBvYmplY3QgPSB2 ODo6SGFuZGxlPHY4OjpPYmplY3Q+OjpDYXN0KHZhbHVlKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9NV3JhcHBlci5oIGIvU291cmNlL1dlYkNvcmUvYmluZGlu Z3MvdjgvVjhET01XcmFwcGVyLmgKaW5kZXggZTA0MjRlODE3M2Y2NmFmNmNlMzE2ODM5NTNkZmEw ZWI1YjcxNDY4Ny4uYWNhYTQxMjY0NzQ2ZGE3MjE3ZjAwNjY3ODZlMDlkMTUzNGQ3NjE3NiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhET01XcmFwcGVyLmgKKysrIGIv U291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhET01XcmFwcGVyLmgKQEAgLTEwMyw4ICsxMDMs NiBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIHRlbXBsYXRlPHR5cGVuYW1lIFQ+CiAg ICAgICAgIHN0YXRpYyB2ODo6UGVyc2lzdGVudDx2ODo6T2JqZWN0PiBzZXRKU1dyYXBwZXJGb3JE T01PYmplY3QoUGFzc1JlZlB0cjxUPiwgdjg6OkhhbmRsZTx2ODo6T2JqZWN0Piwgdjg6Oklzb2xh dGUqID0gMCk7CiAKLSAgICAgICAgc3RhdGljIGJvb2wgaXNWYWxpZERPTU9iamVjdCh2ODo6SGFu ZGxlPHY4OjpWYWx1ZT4pOwotCiAgICAgICAgIC8vIENoZWNrIHdoZXRoZXIgYSBWOCB2YWx1ZSBp cyBhIHdyYXBwZXIgb2YgdHlwZSB8Y2xhc3NUeXBlfC4KICAgICAgICAgc3RhdGljIGJvb2wgaXNX cmFwcGVyT2ZUeXBlKHY4OjpIYW5kbGU8djg6OlZhbHVlPiwgV3JhcHBlclR5cGVJbmZvKik7CiAK