101893 2012-11-11 22:26:36 -0800 [V8] V8Event::valueAccessorGetter() in custom binding is not used 2012-11-12 17:05:26 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 haraken haraken abarth japhet tommyw webkit.review.bot oldest_to_newest 764045 0 haraken 2012-11-11 22:26:36 -0800 We can remove it. 764046 1 173557 haraken 2012-11-11 22:28:28 -0800 Created attachment 173557 Patch 764489 2 173557 abarth 2012-11-12 09:31:40 -0800 Comment on attachment 173557 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173557&action=review > Source/WebCore/ChangeLog:4 > + [V8] V8Event::valueAccessorGetter() in custom binding is not used > + https://bugs.webkit.org/show_bug.cgi?id=101893 I'm not sure what you mean by "not used". Why doesn't it cause a compile error? It must be declared in the header... 764490 3 173557 abarth 2012-11-12 09:32:25 -0800 Comment on attachment 173557 Patch It seems to compile without this code, so I guess you're right. I'm not sure why the function is declared in the header though... 764916 4 haraken 2012-11-12 16:03:24 -0800 (In reply to comment #3) > (From update of attachment 173557 [details]) > It seems to compile without this code, so I guess you're right. I'm not sure why the function is declared in the header though... That's my question too. 764989 5 173557 webkit.review.bot 2012-11-12 17:05:21 -0800 Comment on attachment 173557 Patch Clearing flags on attachment: 173557 Committed r134329: <http://trac.webkit.org/changeset/134329> 764990 6 webkit.review.bot 2012-11-12 17:05:26 -0800 All reviewed patches have been landed. Closing bug. 173557 2012-11-11 22:28:28 -0800 2012-11-12 17:05:21 -0800 Patch bug-101893-20121112152631.patch text/plain 1508 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0MTc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2IzZDBmMGRiOWNmYTE5 N2M1NzU4MWRlZjQ0ZDI5ODRlMmRjOWFkOC4uYTcxMDg3YjZjYzBkMDE4ZGE1Mzg5ZWVjOWJjZDRj NWEwMjY0OTk1ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTExLTExICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIFY4RXZlbnQ6 OnZhbHVlQWNjZXNzb3JHZXR0ZXIoKSBpbiBjdXN0b20gYmluZGluZyBpcyBub3QgdXNlZAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAxODkzCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gdGVzdHMuIE5v IGNoYW5nZSBpbiBiZWhhdmlvci4KKworICAgICAgICAqIGJpbmRpbmdzL3Y4L2N1c3RvbS9WOEV2 ZW50Q3VzdG9tLmNwcDoKKwogMjAxMi0xMS0xMCAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2Vy QGFwcGxlLmNvbT4KIAogICAgICAgICBTYXZlIG9uZSBjYWxsIHRvIGNvbnRhaW5lckZvclJlcGFp bnQoKSB3aGVuIHVwZGF0aW5nIGxheWVyIHBvc2l0aW9ucwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4RXZlbnRDdXN0b20uY3BwIGIvU291cmNlL1dlYkNv cmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4RXZlbnRDdXN0b20uY3BwCmluZGV4IDc1ZTZiYmNiZWIx OGM0MmQ3YTIyYjFkNjZkNDdjY2Q3OGJmODU1MjUuLjM4MWU4MmJlM2VhMjBjOTJhNjViOTJlY2E1 ZTAyZjI4NTczMmNiMjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1 c3RvbS9WOEV2ZW50Q3VzdG9tLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9j dXN0b20vVjhFdmVudEN1c3RvbS5jcHAKQEAgLTQyLDEyICs0Miw2IEBACiAKIG5hbWVzcGFjZSBX ZWJDb3JlIHsKIAotdm9pZCBWOEV2ZW50Ojp2YWx1ZUFjY2Vzc29yU2V0dGVyKHY4OjpMb2NhbDx2 ODo6U3RyaW5nPiBuYW1lLCB2ODo6TG9jYWw8djg6OlZhbHVlPiB2YWx1ZSwgY29uc3Qgdjg6OkFj Y2Vzc29ySW5mbyYgaW5mbykKLXsKLSAgICBFdmVudCogZXZlbnQgPSBWOEV2ZW50Ojp0b05hdGl2 ZShpbmZvLkhvbGRlcigpKTsKLSAgICBldmVudC0+c2V0RGVmYXVsdFByZXZlbnRlZCghdmFsdWUt PkJvb2xlYW5WYWx1ZSgpKTsKLX0KLQogdjg6OkhhbmRsZTx2ODo6VmFsdWU+IFY4RXZlbnQ6OmRh dGFUcmFuc2ZlckFjY2Vzc29yR2V0dGVyKHY4OjpMb2NhbDx2ODo6U3RyaW5nPiBuYW1lLCBjb25z dCB2ODo6QWNjZXNzb3JJbmZvJiBpbmZvKQogewogICAgIEV2ZW50KiBldmVudCA9IFY4RXZlbnQ6 OnRvTmF0aXZlKGluZm8uSG9sZGVyKCkpOwo=