101887 2012-11-11 21:03:23 -0800 Many DOMWindowProperties would benefit from being ScriptWrappable 2012-11-11 21:31:31 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth eric haraken webkit.review.bot oldest_to_newest 764012 0 abarth 2012-11-11 21:03:23 -0800 Many DOMWindowProperties would benefit from being ScriptWrappable 764014 1 173548 abarth 2012-11-11 21:04:45 -0800 Created attachment 173548 Patch 764019 2 173548 haraken 2012-11-11 21:22:05 -0800 Comment on attachment 173548 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173548&action=review > Source/WebCore/ChangeLog:9 > + These object are only ever created at the behest of script, which means > + making them ScriptWrappable is a win. Agreed. 764021 3 173548 webkit.review.bot 2012-11-11 21:31:27 -0800 Comment on attachment 173548 Patch Clearing flags on attachment: 173548 Committed r134188: <http://trac.webkit.org/changeset/134188> 764022 4 webkit.review.bot 2012-11-11 21:31:31 -0800 All reviewed patches have been landed. Closing bug. 173548 2012-11-11 21:04:45 -0800 2012-11-11 21:31:27 -0800 Patch bug-101887-20121111210248.patch text/plain 6689 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0MTExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWFiNTZmZjE5NzYyOWU3 NmQyM2FmN2VlNTAzYjYyY2IwZWI0YTg5Ni4uYTUwMjQ0N2RhNDMyYjdlZWZjM2U0NmU2MTBhZGM4 MTA5NGNhNWZlZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTExLTExICBBZGFt IEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAgICAgICAgTWFueSBET01XaW5kb3dQcm9w ZXJ0aWVzIHdvdWxkIGJlbmVmaXQgZnJvbSBiZWluZyBTY3JpcHRXcmFwcGFibGUKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMTg4NworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZXNlIG9iamVjdCBhcmUg b25seSBldmVyIGNyZWF0ZWQgYXQgdGhlIGJlaGVzdCBvZiBzY3JpcHQsIHdoaWNoIG1lYW5zCisg ICAgICAgIG1ha2luZyB0aGVtIFNjcmlwdFdyYXBwYWJsZSBpcyBhIHdpbi4KKworICAgICAgICAq IHBhZ2UvQmFySW5mby5oOgorICAgICAgICAqIHBhZ2UvQ29uc29sZS5oOgorICAgICAgICAqIHBh Z2UvQ3J5cHRvLmg6CisgICAgICAgICogcGFnZS9IaXN0b3J5Lmg6CisgICAgICAgICogcGFnZS9M b2NhdGlvbi5oOgorICAgICAgICAqIHBhZ2UvTmF2aWdhdG9yLmg6CisgICAgICAgICogcGFnZS9Q ZXJmb3JtYW5jZS5oOgorCiAyMDEyLTExLTA5ICBEYW5hIEphbnNlbnMgIDxkYW5ha2pAY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFtjaHJvbWl1bV0gRGVmaW5lIFdFQktJVF9JTVBMRU1FTlRBVElP TiBldmVyeXdoZXJlIGluc2lkZSBXZWJDb3JlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w YWdlL0JhckluZm8uaCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvQmFySW5mby5oCmluZGV4IGIzNjli NmU0Y2I3YmU1YzE5N2ZkOTFhMjI5OGEyNmU1ZTc4M2ZmMzAuLjRmMDlhNDViMjE5ZTZmZWQ2MTBk YTE0OGNmZDk0NDhmYjkxYTE0ZWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvQmFy SW5mby5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvQmFySW5mby5oCkBAIC0zMCw2ICszMCw3 IEBACiAjZGVmaW5lIEJhckluZm9faAogCiAjaW5jbHVkZSAiRE9NV2luZG93UHJvcGVydHkuaCIK KyNpbmNsdWRlICJTY3JpcHRXcmFwcGFibGUuaCIKICNpbmNsdWRlIDx3dGYvUGFzc1JlZlB0ci5o PgogI2luY2x1ZGUgPHd0Zi9SZWZDb3VudGVkLmg+CiAKQEAgLTM3LDcgKzM4LDcgQEAgbmFtZXNw YWNlIFdlYkNvcmUgewogCiAgICAgY2xhc3MgRnJhbWU7CiAKLSAgICBjbGFzcyBCYXJJbmZvIDog cHVibGljIFJlZkNvdW50ZWQ8QmFySW5mbz4sIHB1YmxpYyBET01XaW5kb3dQcm9wZXJ0eSB7Cisg ICAgY2xhc3MgQmFySW5mbyA6IHB1YmxpYyBTY3JpcHRXcmFwcGFibGUsIHB1YmxpYyBSZWZDb3Vu dGVkPEJhckluZm8+LCBwdWJsaWMgRE9NV2luZG93UHJvcGVydHkgewogICAgIHB1YmxpYzoKICAg ICAgICAgZW51bSBUeXBlIHsgTG9jYXRpb25iYXIsIE1lbnViYXIsIFBlcnNvbmFsYmFyLCBTY3Jv bGxiYXJzLCBTdGF0dXNiYXIsIFRvb2xiYXIgfTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGFnZS9Db25zb2xlLmggYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0NvbnNvbGUuaAppbmRleCA3 YWY1NzFlYjc4NjVmNjYwODIzZDYzODdhOGY0YTljYmU4NzNjYzMyLi5iNjAzNDY4OWY0MmQzMTgx ZjIzZWVhYmJlYWVkNDc2OTMwMzNiYTQ1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdl L0NvbnNvbGUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0NvbnNvbGUuaApAQCAtMzQsNiAr MzQsNyBAQAogI2luY2x1ZGUgIlNjcmlwdENhbGxTdGFjay5oIgogI2luY2x1ZGUgIlNjcmlwdFBy b2ZpbGUuaCIKICNpbmNsdWRlICJTY3JpcHRTdGF0ZS5oIgorI2luY2x1ZGUgIlNjcmlwdFdyYXBw YWJsZS5oIgogI2luY2x1ZGUgPHd0Zi9Gb3J3YXJkLmg+CiAjaW5jbHVkZSA8d3RmL1Bhc3NSZWZQ dHIuaD4KICNpbmNsdWRlIDx3dGYvUmVmQ291bnRlZC5oPgpAQCAtNTAsNyArNTEsNyBAQCBjbGFz cyBTY3JpcHRDYWxsU3RhY2s7CiB0eXBlZGVmIFZlY3RvcjxSZWZQdHI8U2NyaXB0UHJvZmlsZT4g PiBQcm9maWxlc0FycmF5OwogI2VuZGlmCiAKLWNsYXNzIENvbnNvbGUgOiBwdWJsaWMgUmVmQ291 bnRlZDxDb25zb2xlPiwgcHVibGljIERPTVdpbmRvd1Byb3BlcnR5IHsKK2NsYXNzIENvbnNvbGUg OiBwdWJsaWMgU2NyaXB0V3JhcHBhYmxlLCBwdWJsaWMgUmVmQ291bnRlZDxDb25zb2xlPiwgcHVi bGljIERPTVdpbmRvd1Byb3BlcnR5IHsKIHB1YmxpYzoKICAgICBzdGF0aWMgUGFzc1JlZlB0cjxD b25zb2xlPiBjcmVhdGUoRnJhbWUqIGZyYW1lKSB7IHJldHVybiBhZG9wdFJlZihuZXcgQ29uc29s ZShmcmFtZSkpOyB9CiAgICAgdmlydHVhbCB+Q29uc29sZSgpOwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGFnZS9DcnlwdG8uaCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvQ3J5cHRvLmgKaW5k ZXggYTUzYjA2NDZmNGQwOTczNzRmYjk1YjdlNmZkYmFlMjJhYmRkZDI0Mi4uMTcyNWFmODZlYjIx YTQ4MTY0ZDcwZDhhZmUyYmFiNjFmY2MzMDIzMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGFnZS9DcnlwdG8uaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0NyeXB0by5oCkBAIC0yOSw2 ICsyOSw3IEBACiAjaWZuZGVmIENyeXB0b19oCiAjZGVmaW5lIENyeXB0b19oCiAKKyNpbmNsdWRl ICJTY3JpcHRXcmFwcGFibGUuaCIKICNpbmNsdWRlIDx3dGYvRm9yd2FyZC5oPgogI2luY2x1ZGUg PHd0Zi9QYXNzUmVmUHRyLmg+CiAjaW5jbHVkZSA8d3RmL1JlZkNvdW50ZWQuaD4KQEAgLTM3LDcg KzM4LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogCiB0eXBlZGVmIGludCBFeGNlcHRpb25Db2Rl OwogCi1jbGFzcyBDcnlwdG8gOiBwdWJsaWMgUmVmQ291bnRlZDxDcnlwdG8+IHsKK2NsYXNzIENy eXB0byA6IHB1YmxpYyBTY3JpcHRXcmFwcGFibGUsIHB1YmxpYyBSZWZDb3VudGVkPENyeXB0bz4g ewogcHVibGljOgogICAgIHN0YXRpYyBQYXNzUmVmUHRyPENyeXB0bz4gY3JlYXRlKCkgeyByZXR1 cm4gYWRvcHRSZWYobmV3IENyeXB0bygpKTsgfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wYWdlL0hpc3RvcnkuaCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvSGlzdG9yeS5oCmluZGV4IDg4 OWMzNzQxMGM2YjdjYTk0MTg0ZDM2MTVhMmY4N2RjYzdiMTRlY2IuLmQ3YzdhMjhiYTAyZThiOTAx NWYxNTk4ZTgwNmIyYTI1NzZhYmUxMDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uv SGlzdG9yeS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvSGlzdG9yeS5oCkBAIC0yOCw2ICsy OCw3IEBACiAKICNpbmNsdWRlICJET01XaW5kb3dQcm9wZXJ0eS5oIgogI2luY2x1ZGUgIktVUkwu aCIKKyNpbmNsdWRlICJTY3JpcHRXcmFwcGFibGUuaCIKICNpbmNsdWRlIDx3dGYvRm9yd2FyZC5o PgogI2luY2x1ZGUgPHd0Zi9QYXNzUmVmUHRyLmg+CiAjaW5jbHVkZSA8d3RmL1JlZkNvdW50ZWQu aD4KQEAgLTM5LDcgKzQwLDcgQEAgY2xhc3MgU2NyaXB0RXhlY3V0aW9uQ29udGV4dDsKIGNsYXNz IFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZTsKIHR5cGVkZWYgaW50IEV4Y2VwdGlvbkNvZGU7CiAKLWNs YXNzIEhpc3RvcnkgOiBwdWJsaWMgUmVmQ291bnRlZDxIaXN0b3J5PiwgcHVibGljIERPTVdpbmRv d1Byb3BlcnR5IHsKK2NsYXNzIEhpc3RvcnkgOiBwdWJsaWMgU2NyaXB0V3JhcHBhYmxlLCBwdWJs aWMgUmVmQ291bnRlZDxIaXN0b3J5PiwgcHVibGljIERPTVdpbmRvd1Byb3BlcnR5IHsKIHB1Ymxp YzoKICAgICBzdGF0aWMgUGFzc1JlZlB0cjxIaXN0b3J5PiBjcmVhdGUoRnJhbWUqIGZyYW1lKSB7 IHJldHVybiBhZG9wdFJlZihuZXcgSGlzdG9yeShmcmFtZSkpOyB9CiAKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3BhZ2UvTG9jYXRpb24uaCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvTG9jYXRp b24uaAppbmRleCAyMmYzYzVhNGEyYzhiNDU4M2U2ZWQ3MTczNDIzY2Y5N2I2MTQ5MGE5Li5iNGY5 YTRjMTc5MGNkM2UzY2ViMzdiZDA1NTZkZDNhNWUyNWIwYjM1IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wYWdlL0xvY2F0aW9uLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9Mb2NhdGlv bi5oCkBAIC0zMSw2ICszMSw3IEBACiAKICNpbmNsdWRlICJET01TdHJpbmdMaXN0LmgiCiAjaW5j bHVkZSAiRE9NV2luZG93UHJvcGVydHkuaCIKKyNpbmNsdWRlICJTY3JpcHRXcmFwcGFibGUuaCIK ICNpbmNsdWRlIDx3dGYvUGFzc1JlZlB0ci5oPgogI2luY2x1ZGUgPHd0Zi9SZWZDb3VudGVkLmg+ CiAjaW5jbHVkZSA8d3RmL3RleHQvV1RGU3RyaW5nLmg+CkBAIC00Myw3ICs0NCw3IEBAIGNsYXNz IEtVUkw7CiAKIHR5cGVkZWYgaW50IEV4Y2VwdGlvbkNvZGU7CiAKLWNsYXNzIExvY2F0aW9uIDog cHVibGljIFJlZkNvdW50ZWQ8TG9jYXRpb24+LCBwdWJsaWMgRE9NV2luZG93UHJvcGVydHkgewor Y2xhc3MgTG9jYXRpb24gOiBwdWJsaWMgU2NyaXB0V3JhcHBhYmxlLCBwdWJsaWMgUmVmQ291bnRl ZDxMb2NhdGlvbj4sIHB1YmxpYyBET01XaW5kb3dQcm9wZXJ0eSB7CiBwdWJsaWM6CiAgICAgc3Rh dGljIFBhc3NSZWZQdHI8TG9jYXRpb24+IGNyZWF0ZShGcmFtZSogZnJhbWUpIHsgcmV0dXJuIGFk b3B0UmVmKG5ldyBMb2NhdGlvbihmcmFtZSkpOyB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BhZ2UvTmF2aWdhdG9yLmggYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL05hdmlnYXRvci5oCmlu ZGV4IDgxZTQ1OGE5NzkwZjZjZjllYjE1NjExNmU2YmQyNWQ1YTRlNTZhNTcuLjkzMTUyMTNjMDcz NmFhMWZiYWQxYTg1NDlhN2Q5MzZlMWExOGI4NGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BhZ2UvTmF2aWdhdG9yLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9OYXZpZ2F0b3IuaApA QCAtMjIsNiArMjIsNyBAQAogCiAjaW5jbHVkZSAiRE9NV2luZG93UHJvcGVydHkuaCIKICNpbmNs dWRlICJOYXZpZ2F0b3JCYXNlLmgiCisjaW5jbHVkZSAiU2NyaXB0V3JhcHBhYmxlLmgiCiAjaW5j bHVkZSAiU3VwcGxlbWVudGFibGUuaCIKICNpbmNsdWRlIDx3dGYvRm9yd2FyZC5oPgogI2luY2x1 ZGUgPHd0Zi9IYXNoTWFwLmg+CkBAIC0zOCw3ICszOSw3IEBAIGNsYXNzIFBsdWdpbkRhdGE7CiAK IHR5cGVkZWYgaW50IEV4Y2VwdGlvbkNvZGU7CiAKLWNsYXNzIE5hdmlnYXRvciA6IHB1YmxpYyBO YXZpZ2F0b3JCYXNlLCBwdWJsaWMgUmVmQ291bnRlZDxOYXZpZ2F0b3I+LCBwdWJsaWMgRE9NV2lu ZG93UHJvcGVydHksIHB1YmxpYyBTdXBwbGVtZW50YWJsZTxOYXZpZ2F0b3I+IHsKK2NsYXNzIE5h dmlnYXRvciA6IHB1YmxpYyBOYXZpZ2F0b3JCYXNlLCBwdWJsaWMgU2NyaXB0V3JhcHBhYmxlLCBw dWJsaWMgUmVmQ291bnRlZDxOYXZpZ2F0b3I+LCBwdWJsaWMgRE9NV2luZG93UHJvcGVydHksIHB1 YmxpYyBTdXBwbGVtZW50YWJsZTxOYXZpZ2F0b3I+IHsKIHB1YmxpYzoKICAgICBzdGF0aWMgUGFz c1JlZlB0cjxOYXZpZ2F0b3I+IGNyZWF0ZShGcmFtZSogZnJhbWUpIHsgcmV0dXJuIGFkb3B0UmVm KG5ldyBOYXZpZ2F0b3IoZnJhbWUpKTsgfQogICAgIHZpcnR1YWwgfk5hdmlnYXRvcigpOwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9QZXJmb3JtYW5jZS5oIGIvU291cmNlL1dlYkNv cmUvcGFnZS9QZXJmb3JtYW5jZS5oCmluZGV4IDhkOTQ5ZjI0YzQzNjEzNTUxZWFmODAwZDdiMWM3 ZThhMTZkNmEzZWMuLjIwMWNkN2EwODU3NDVkNWM0ZWM5YmVmYTE0OGY5ZTgxMGVkMDM4OGIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGVyZm9ybWFuY2UuaAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wYWdlL1BlcmZvcm1hbmNlLmgKQEAgLTQwLDYgKzQwLDcgQEAKICNpbmNsdWRlICJQ ZXJmb3JtYW5jZUVudHJ5TGlzdC5oIgogI2luY2x1ZGUgIlBlcmZvcm1hbmNlTmF2aWdhdGlvbi5o IgogI2luY2x1ZGUgIlBlcmZvcm1hbmNlVGltaW5nLmgiCisjaW5jbHVkZSAiU2NyaXB0V3JhcHBh YmxlLmgiCiAjaW5jbHVkZSA8d3RmL1Bhc3NSZWZQdHIuaD4KICNpbmNsdWRlIDx3dGYvUmVmQ291 bnRlZC5oPgogI2luY2x1ZGUgPHd0Zi9SZWZQdHIuaD4KQEAgLTU0LDcgKzU1LDcgQEAgY2xhc3Mg UmVzb3VyY2VSZXF1ZXN0OwogY2xhc3MgUmVzb3VyY2VSZXNwb25zZTsKIGNsYXNzIFVzZXJUaW1p bmc7CiAKLWNsYXNzIFBlcmZvcm1hbmNlIDogcHVibGljIFJlZkNvdW50ZWQ8UGVyZm9ybWFuY2U+ LCBwdWJsaWMgRE9NV2luZG93UHJvcGVydHksIHB1YmxpYyBFdmVudFRhcmdldCB7CitjbGFzcyBQ ZXJmb3JtYW5jZSA6IHB1YmxpYyBTY3JpcHRXcmFwcGFibGUsIHB1YmxpYyBSZWZDb3VudGVkPFBl cmZvcm1hbmNlPiwgcHVibGljIERPTVdpbmRvd1Byb3BlcnR5LCBwdWJsaWMgRXZlbnRUYXJnZXQg ewogcHVibGljOgogICAgIHN0YXRpYyBQYXNzUmVmUHRyPFBlcmZvcm1hbmNlPiBjcmVhdGUoRnJh bWUqIGZyYW1lKSB7IHJldHVybiBhZG9wdFJlZihuZXcgUGVyZm9ybWFuY2UoZnJhbWUpKTsgfQog ICAgIH5QZXJmb3JtYW5jZSgpOwo=