101885 2012-11-11 19:35:27 -0800 DFG should not emit function checks if we've already proved that the operand is that exact function 2012-11-12 14:53:08 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo barraclough ggaren mark.lam mhahnenberg msaboff oliver sam oldest_to_newest 763984 0 fpizlo 2012-11-11 19:35:27 -0800 Patch forthcoming. 763986 1 173541 fpizlo 2012-11-11 19:38:29 -0800 Created attachment 173541 the patch 764854 2 fpizlo 2012-11-12 14:53:08 -0800 Landed in http://trac.webkit.org/changeset/134313 173541 2012-11-11 19:38:29 -0800 2012-11-12 14:14:34 -0800 the patch checkfunc.patch text/plain 3500 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTM0MTgzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDEyLTExLTExICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg REZHIHNob3VsZCBub3QgZW1pdCBmdW5jdGlvbiBjaGVja3MgaWYgd2UndmUgYWxyZWFkeSBwcm92 ZWQgdGhhdCB0aGUgb3BlcmFuZCBpcyB0aGF0IGV4YWN0IGZ1bmN0aW9uCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDE4ODUKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGRmZy9ERkdBYnN0cmFjdFN0YXRl LmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpBYnN0cmFjdFN0YXRlOjpleGVjdXRlKToKKyAgICAg ICAgKiBkZmcvREZHQWJzdHJhY3RWYWx1ZS5oOgorICAgICAgICAoSlNDOjpERkc6OkFic3RyYWN0 VmFsdWU6OmZpbHRlckJ5VmFsdWUpOgorICAgICAgICAoQWJzdHJhY3RWYWx1ZSk6CisgICAgICAg ICogZGZnL0RGR0NvbnN0YW50Rm9sZGluZ1BoYXNlLmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpD b25zdGFudEZvbGRpbmdQaGFzZTo6Zm9sZENvbnN0YW50cyk6CisKIDIwMTItMTEtMTEgIEZpbGlw IFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAgICAgICBERkcgcmVnaXN0ZXIgYWxsb2Nh dGlvbiBzaG91bGQgYmUgZ3JlZWR5IHJhdGhlciB0aGFuIHJvdW5kLXJvYmluCkluZGV4OiBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0Fic3RyYWN0U3RhdGUuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQWJzdHJhY3RTdGF0ZS5jcHAJKHJldmlzaW9u IDEzNDE2OCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQWJzdHJhY3RTdGF0ZS5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTE1NzIsMTEgKzE1NzIsMjIgQEAgYm9vbCBBYnN0cmFjdFN0 YXRlOjpleGVjdXRlKHVuc2lnbmVkIGluZAogICAgICAgICBmb3JOb2RlKG5vZGUuY2hpbGQxKCkp LmZpbHRlcihTcGVjQ2VsbCk7CiAgICAgICAgIGJyZWFrOwogICAgICAgICAgICAgCi0gICAgY2Fz ZSBDaGVja0Z1bmN0aW9uOgorICAgIGNhc2UgQ2hlY2tGdW5jdGlvbjogeworICAgICAgICBKU1Zh bHVlIHZhbHVlID0gZm9yTm9kZShub2RlLmNoaWxkMSgpKS52YWx1ZSgpOworICAgICAgICBpZiAo dmFsdWUgPT0gbm9kZS5mdW5jdGlvbigpKSB7CisgICAgICAgICAgICBtX2ZvdW5kQ29uc3RhbnRz ID0gdHJ1ZTsKKyAgICAgICAgICAgIEFTU0VSVCh2YWx1ZSk7CisgICAgICAgICAgICBub2RlLnNl dENhbkV4aXQoZmFsc2UpOworICAgICAgICAgICAgYnJlYWs7CisgICAgICAgIH0KKyAgICAgICAg CiAgICAgICAgIG5vZGUuc2V0Q2FuRXhpdCh0cnVlKTsgLy8gTGllcyEgV2UgY2FuIGRvIGJldHRl ci4KLSAgICAgICAgZm9yTm9kZShub2RlLmNoaWxkMSgpKS5maWx0ZXIoU3BlY0Z1bmN0aW9uKTsK LSAgICAgICAgLy8gRklYTUU6IFNob3VsZCBiZSBhYmxlIHRvIHByb3BhZ2F0ZSB0aGUgZmFjdCB0 aGF0IHdlIGtub3cgd2hhdCB0aGUgZnVuY3Rpb24gaXMuCisgICAgICAgIGlmICghZm9yTm9kZShu b2RlLmNoaWxkMSgpKS5maWx0ZXJCeVZhbHVlKG5vZGUuZnVuY3Rpb24oKSkpIHsKKyAgICAgICAg ICAgIG1faXNWYWxpZCA9IGZhbHNlOworICAgICAgICAgICAgYnJlYWs7CisgICAgICAgIH0KICAg ICAgICAgYnJlYWs7CisgICAgfQogICAgICAgICAKICAgICBjYXNlIFB1dEJ5SWQ6CiAgICAgY2Fz ZSBQdXRCeUlkRGlyZWN0OgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdBYnN0 cmFjdFZhbHVlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdB YnN0cmFjdFZhbHVlLmgJKHJldmlzaW9uIDEzNDE2OCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9kZmcvREZHQWJzdHJhY3RWYWx1ZS5oCSh3b3JraW5nIGNvcHkpCkBAIC0yODQsNiArMjg0LDIx IEBAIHN0cnVjdCBBYnN0cmFjdFZhbHVlIHsKICAgICAgICAgY2hlY2tDb25zaXN0ZW5jeSgpOwog ICAgIH0KICAgICAKKyAgICBib29sIGZpbHRlckJ5VmFsdWUoSlNWYWx1ZSB2YWx1ZSkKKyAgICB7 CisgICAgICAgIGlmICghdmFsaWRhdGUodmFsdWUpKQorICAgICAgICAgICAgcmV0dXJuIGZhbHNl OworICAgICAgICAKKyAgICAgICAgaWYgKCEhdmFsdWUgJiYgdmFsdWUuaXNDZWxsKCkpCisgICAg ICAgICAgICBmaWx0ZXIoU3RydWN0dXJlU2V0KHZhbHVlLmFzQ2VsbCgpLT5zdHJ1Y3R1cmUoKSkp OworICAgICAgICBlbHNlCisgICAgICAgICAgICBmaWx0ZXIoc3BlY3VsYXRpb25Gcm9tVmFsdWUo dmFsdWUpKTsKKyAgICAgICAgCisgICAgICAgIG1fdmFsdWUgPSB2YWx1ZTsKKyAgICAgICAgCisg ICAgICAgIHJldHVybiB0cnVlOworICAgIH0KKyAgICAKICAgICBib29sIHZhbGlkYXRlVHlwZShK U1ZhbHVlIHZhbHVlKSBjb25zdAogICAgIHsKICAgICAgICAgaWYgKGlzVG9wKCkpCkluZGV4OiBT b3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0NvbnN0YW50Rm9sZGluZ1BoYXNlLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0NvbnN0YW50Rm9sZGluZ1Bo YXNlLmNwcAkocmV2aXNpb24gMTM0MTY4KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9E RkdDb25zdGFudEZvbGRpbmdQaGFzZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEyNCw2ICsxMjQs MTQgQEAgcHJpdmF0ZToKICAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgICAgIH0KICAg ICAgICAgICAgICAgICAKKyAgICAgICAgICAgIGNhc2UgQ2hlY2tGdW5jdGlvbjogeworICAgICAg ICAgICAgICAgIGlmIChtX3N0YXRlLmZvck5vZGUobm9kZS5jaGlsZDEoKSkudmFsdWUoKSAhPSBu b2RlLmZ1bmN0aW9uKCkpCisgICAgICAgICAgICAgICAgICAgIGJyZWFrOworICAgICAgICAgICAg ICAgIG5vZGUuc2V0T3BBbmREZWZhdWx0RmxhZ3MoUGhhbnRvbSk7CisgICAgICAgICAgICAgICAg ZWxpbWluYXRlZCA9IHRydWU7CisgICAgICAgICAgICAgICAgYnJlYWs7CisgICAgICAgICAgICB9 CisgICAgICAgICAgICAgICAgCiAgICAgICAgICAgICBkZWZhdWx0OgogICAgICAgICAgICAgICAg IGJyZWFrOwogICAgICAgICAgICAgfQo=