101881 2012-11-11 18:42:02 -0800 [Refactoring] Remove shadowPseudoId() and use setPseudo() in HTMLKeygenElement 2012-11-11 22:35:56 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 101171 1 shinyak shinyak mifenton tkent webcomponents-bugzilla webkit.review.bot oldest_to_newest 763967 0 shinyak 2012-11-11 18:42:02 -0800 We would like to remove shadowPseudoId, and use pseudo() instead. 764011 1 173547 shinyak 2012-11-11 21:02:09 -0800 Created attachment 173547 Patch 764016 2 173547 tkent 2012-11-11 21:07:33 -0800 Comment on attachment 173547 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173547&action=review > Source/WebCore/html/HTMLKeygenElement.cpp:68 > + DEFINE_STATIC_LOCAL(AtomicString, pseudoId, ("-webkit-keygen-select", AtomicString::ConstructFromLiteral)); Why don't you just put this into the constructor? 764035 3 shinyak 2012-11-11 22:07:45 -0800 (In reply to comment #2) > (From update of attachment 173547 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=173547&action=review > > > Source/WebCore/html/HTMLKeygenElement.cpp:68 > > + DEFINE_STATIC_LOCAL(AtomicString, pseudoId, ("-webkit-keygen-select", AtomicString::ConstructFromLiteral)); > > Why don't you just put this into the constructor? Ah, I'll do so. 764036 4 173554 shinyak 2012-11-11 22:09:17 -0800 Created attachment 173554 Patch 764038 5 173554 tkent 2012-11-11 22:10:56 -0800 Comment on attachment 173554 Patch Looks good 764052 6 173554 webkit.review.bot 2012-11-11 22:35:53 -0800 Comment on attachment 173554 Patch Clearing flags on attachment: 173554 Committed r134189: <http://trac.webkit.org/changeset/134189> 764053 7 webkit.review.bot 2012-11-11 22:35:56 -0800 All reviewed patches have been landed. Closing bug. 173547 2012-11-11 21:02:09 -0800 2012-11-11 22:09:13 -0800 Patch bug-101881-20121112140012.patch text/plain 2225 shinyak U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0MTgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTZlNDNjM2ViOTFlM2M3 OWJjMzMwMTk5YjMxMWM0OWFjZGRhYTAyOS4uZmI3YWUxMGFlZGVmN2UyYzY2NzgzMGQ2ZDY2NDRi ZjljMmUyMjE5ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTExLTExICBTaGlu eWEgS2F3YW5ha2EgIDxzaGlueWFrQGNocm9taXVtLm9yZz4KKworICAgICAgICBbUmVmYWN0b3Jp bmddIFJlbW92ZSBzaGFkb3dQc2V1ZG9JZCgpIGFuZCB1c2Ugc2V0UHNldWRvKCkgaW4gSFRNTEtl eWdlbkVsZW1lbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEwMTg4MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFdlJ3JlIG1pZ3JhdGluZyBzaGFkb3dQc2V1ZG9JZCgpIHRvIHBzZXVkbygpLiBXZSByZW1v dmUgc2hhZG93UHNldWRvSWQoKSBmcm9tIEhUTUxLZXlnZW5FbGVtZW50IGFuZCB1c2UKKyAgICAg ICAgc2V0UHNldWRvKCkvcHNldWRvKCkgaW5zdGVhZC4KKworICAgICAgICBObyBuZXcgdGVzdHMs IHNpbXBsZSByZWZhY290cmluZy4KKworICAgICAgICAqIGh0bWwvSFRNTEtleWdlbkVsZW1lbnQu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6S2V5Z2VuU2VsZWN0RWxlbWVudDo6S2V5Z2VuU2VsZWN0 RWxlbWVudCk6CisgICAgICAgIChLZXlnZW5TZWxlY3RFbGVtZW50KToKKyAgICAgICAgKFdlYkNv cmU6OktleWdlblNlbGVjdEVsZW1lbnQ6OmtleWdlblBzZXVkb0lkKToKKwogMjAxMi0xMS0xMSAg S2VudCBUYW11cmEgIDx0a2VudEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgSW50ZXJuYWxzOiBN b2NrUGFnZVBvcHVwIHNob3VsZCBub3QgdXBkYXRlIERPTSBzdHJ1Y3R1cmUgZHVyaW5nIGRldGFj aCgpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxLZXlnZW5FbGVtZW50LmNw cCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEtleWdlbkVsZW1lbnQuY3BwCmluZGV4IDc0MzY0 OTZhMjdmNWNkZTA1MDAxYjc0ZWZmYzA1ODk3N2Q3NTc1ODEuLmNlZGZiZTM4ZjA5ODRjNDUzNWIy MGUyM2JmMDNkNDM2NDIyM2ZhY2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRN TEtleWdlbkVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEtleWdlbkVs ZW1lbnQuY3BwCkBAIC01MCwxNiArNTAsMTEgQEAgcHVibGljOgogICAgICAgICByZXR1cm4gYWRv cHRSZWYobmV3IEtleWdlblNlbGVjdEVsZW1lbnQoZG9jdW1lbnQpKTsKICAgICB9CiAKLSAgICB2 aXJ0dWFsIGNvbnN0IEF0b21pY1N0cmluZyYgc2hhZG93UHNldWRvSWQoKSBjb25zdAotICAgIHsK LSAgICAgICAgREVGSU5FX1NUQVRJQ19MT0NBTChBdG9taWNTdHJpbmcsIHBzZXVkb0lkLCAoIi13 ZWJraXQta2V5Z2VuLXNlbGVjdCIsIEF0b21pY1N0cmluZzo6Q29uc3RydWN0RnJvbUxpdGVyYWwp KTsKLSAgICAgICAgcmV0dXJuIHBzZXVkb0lkOwotICAgIH0KLQogcHJvdGVjdGVkOgogICAgIEtl eWdlblNlbGVjdEVsZW1lbnQoRG9jdW1lbnQqIGRvY3VtZW50KQogICAgICAgICA6IEhUTUxTZWxl Y3RFbGVtZW50KHNlbGVjdFRhZywgZG9jdW1lbnQsIDApCiAgICAgeworICAgICAgICBzZXRQc2V1 ZG8oa2V5Z2VuUHNldWRvSWQoKSk7CiAgICAgfQogCiBwcml2YXRlOgpAQCAtNjcsNiArNjIsMTIg QEAgcHJpdmF0ZToKICAgICB7CiAgICAgICAgIHJldHVybiBjcmVhdGUoZG9jdW1lbnQoKSk7CiAg ICAgfQorCisgICAgc3RhdGljIGlubGluZSBjb25zdCBBdG9taWNTdHJpbmcmIGtleWdlblBzZXVk b0lkKCkKKyAgICB7CisgICAgICAgIERFRklORV9TVEFUSUNfTE9DQUwoQXRvbWljU3RyaW5nLCBw c2V1ZG9JZCwgKCItd2Via2l0LWtleWdlbi1zZWxlY3QiLCBBdG9taWNTdHJpbmc6OkNvbnN0cnVj dEZyb21MaXRlcmFsKSk7CisgICAgICAgIHJldHVybiBwc2V1ZG9JZDsKKyAgICB9CiB9OwogCiBp bmxpbmUgSFRNTEtleWdlbkVsZW1lbnQ6OkhUTUxLZXlnZW5FbGVtZW50KGNvbnN0IFF1YWxpZmll ZE5hbWUmIHRhZ05hbWUsIERvY3VtZW50KiBkb2N1bWVudCwgSFRNTEZvcm1FbGVtZW50KiBmb3Jt KQo= 173554 2012-11-11 22:09:17 -0800 2012-11-11 22:35:52 -0800 Patch bug-101881-20121112150720.patch text/plain 1838 shinyak U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0MTg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTcxN2MyNjlhNWRjMTQ1 MTU0NmRmNTg0YzlhMTFlZmQ5OTgxMGE5Yi4uNmE5N2JhMWQwYmZlZjJjODlmNGIwMjMyZjJmN2Mz ZGI4NjJhY2IxYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTExLTExICBTaGlu eWEgS2F3YW5ha2EgIDxzaGlueWFrQGNocm9taXVtLm9yZz4KKworICAgICAgICBbUmVmYWN0b3Jp bmddIFJlbW92ZSBzaGFkb3dQc2V1ZG9JZCgpIGFuZCB1c2Ugc2V0UHNldWRvKCkgaW4gSFRNTEtl eWdlbkVsZW1lbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEwMTg4MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFdlJ3JlIG1pZ3JhdGluZyBzaGFkb3dQc2V1ZG9JZCgpIHRvIHBzZXVkbygpLiBXZSByZW1v dmUgc2hhZG93UHNldWRvSWQoKSBmcm9tIEhUTUxLZXlnZW5FbGVtZW50IGFuZCB1c2UKKyAgICAg ICAgc2V0UHNldWRvKCkvcHNldWRvKCkgaW5zdGVhZC4KKworICAgICAgICBObyBuZXcgdGVzdHMs IHNpbXBsZSByZWZhY290cmluZy4KKworICAgICAgICAqIGh0bWwvSFRNTEtleWdlbkVsZW1lbnQu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6S2V5Z2VuU2VsZWN0RWxlbWVudDo6S2V5Z2VuU2VsZWN0 RWxlbWVudCk6CisgICAgICAgIChLZXlnZW5TZWxlY3RFbGVtZW50KToKKwogMjAxMi0xMS0xMSAg S2VudGFybyBIYXJhICA8aGFyYWtlbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW1Y4XSBIVE1M RG9jdW1lbnQ6OmFsbCgpIG5lZWRzIG5vdCB0byBiZSBjdXN0b20KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2h0bWwvSFRNTEtleWdlbkVsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRt bC9IVE1MS2V5Z2VuRWxlbWVudC5jcHAKaW5kZXggNzQzNjQ5NmEyN2Y1Y2RlMDUwMDFiNzRlZmZj MDU4OTc3ZDc1NzU4MS4uYzcyNjI1ZTNhMmI3NDEyNzA1MTU5YWZhZTdkNGMzZDkyMmRiZDYyMyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MS2V5Z2VuRWxlbWVudC5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MS2V5Z2VuRWxlbWVudC5jcHAKQEAgLTUwLDE2ICs1 MCwxMiBAQCBwdWJsaWM6CiAgICAgICAgIHJldHVybiBhZG9wdFJlZihuZXcgS2V5Z2VuU2VsZWN0 RWxlbWVudChkb2N1bWVudCkpOwogICAgIH0KIAotICAgIHZpcnR1YWwgY29uc3QgQXRvbWljU3Ry aW5nJiBzaGFkb3dQc2V1ZG9JZCgpIGNvbnN0Ci0gICAgewotICAgICAgICBERUZJTkVfU1RBVElD X0xPQ0FMKEF0b21pY1N0cmluZywgcHNldWRvSWQsICgiLXdlYmtpdC1rZXlnZW4tc2VsZWN0Iiwg QXRvbWljU3RyaW5nOjpDb25zdHJ1Y3RGcm9tTGl0ZXJhbCkpOwotICAgICAgICByZXR1cm4gcHNl dWRvSWQ7Ci0gICAgfQotCiBwcm90ZWN0ZWQ6CiAgICAgS2V5Z2VuU2VsZWN0RWxlbWVudChEb2N1 bWVudCogZG9jdW1lbnQpCiAgICAgICAgIDogSFRNTFNlbGVjdEVsZW1lbnQoc2VsZWN0VGFnLCBk b2N1bWVudCwgMCkKICAgICB7CisgICAgICAgIERFRklORV9TVEFUSUNfTE9DQUwoQXRvbWljU3Ry aW5nLCBwc2V1ZG9JZCwgKCItd2Via2l0LWtleWdlbi1zZWxlY3QiLCBBdG9taWNTdHJpbmc6OkNv bnN0cnVjdEZyb21MaXRlcmFsKSk7CisgICAgICAgIHNldFBzZXVkbyhwc2V1ZG9JZCk7CiAgICAg fQogCiBwcml2YXRlOgo=